52616 2011-01-18 02:40:44 -0800 [Qt][WK2] Not implemented warnings should not break layout tests 2011-01-18 04:31:55 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 1 kbalazs webkit-unassigned oldest_to_newest 335729 0 kbalazs 2011-01-18 02:40:44 -0800 The WebKit2 logging system always enables logging. There is a more sophistic mechanism in WebCore that actually disables logging if the QT_WEBKIT_LOG environment variable is not set. Maybe we should fix this in the future but I am dubious about that because the most of the qt codes does not use the wtf logging channels but qDebug and friends instead. Currently I just want to fix the issue to not break the tests by disabling logging unconditionally. 335741 1 79260 kbalazs 2011-01-18 04:02:11 -0800 Created attachment 79260 Patch 335742 2 kbalazs 2011-01-18 04:04:26 -0800 After the change the u-szeged wk2 bot will need a full rebuild because the dependencies from the prefix header is not handled by the build system. 335745 3 79260 ossy 2011-01-18 04:10:16 -0800 Comment on attachment 79260 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79260&action=review LGTM, r=me. > Source/WebKit2/WebKit2Prefix.h:61 > +// Disable notImplemented() warnings to not break layout tests. // Disable notImplemented() warnings not to break layout tests. 335751 4 79260 kbalazs 2011-01-18 04:31:22 -0800 Comment on attachment 79260 Patch Clearing flags. 335752 5 kbalazs 2011-01-18 04:31:55 -0800 Committed in http://trac.webkit.org/changeset/76014. 79260 2011-01-18 04:02:11 -0800 2011-01-18 04:31:22 -0800 Patch bug-52616-20110118130209.patch text/plain 1257 kbalazs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMzgyZTJlMTY0N2JjZTU1OTMwZTdmOGM0ZTc5MmNlNzYxNDk0YjZhLi42 MzNiZWM4ZWVjZGYyZjZjNWRhZGYwMDhlOThhN2U1ZWE2NDQ4N2IzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTEtMDEtMTggIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtR dF1bV0syXSBOb3QgaW1wbGVtZW50ZWQgd2FybmluZ3Mgc2hvdWxkIG5vdCBicmVhayBsYXlvdXQg dGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUy NjE2CisKKyAgICAgICAgKiBXZWJLaXQyUHJlZml4Lmg6IERlZmluZSBESVNBQkxFX05PVF9JTVBM RU1FTlRFRF9XQVJOSU5HUyBvbiBRdC4KKwogMjAxMS0wMS0xNyAgSm9uIEhvbmV5Y3V0dCAgPGpo b25leWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIFdpbmRvd3MgYnVpbGQgZml4LiBVbnJldmll d2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViS2l0MlByZWZpeC5oIGIvU291cmNl L1dlYktpdDIvV2ViS2l0MlByZWZpeC5oCmluZGV4IDE5YmVlN2ZkYjg5MjJlYjYxZjY3ZWI2MjM5 NzU4NDI0MzRjODkyZmEuLjA3OWM3ZjcwYTQ4NjUwM2ExMTZmODliNDM0ZDg5NTA0MWY5N2U4YWIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYktpdDJQcmVmaXguaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJLaXQyUHJlZml4LmgKQEAgLTU4LDYgKzU4LDEwIEBAIHN0YXRpYyBjb25zdCB0 eXBlJiBuYW1lKCkgXAogI2RlZmluZSBKU19FWFBPUlREQVRBCiAjZGVmaW5lIEpTX0VYUE9SVENM QVNTCiAKKy8vIERpc2FibGUgbm90SW1wbGVtZW50ZWQoKSB3YXJuaW5ncyB0byBub3QgYnJlYWsg bGF5b3V0IHRlc3RzLgorLy8gRklYTUU6IFdlYktpdDIgbG9nZ2luZyBzeXN0ZW0gc2hvdWxkIGJl aGF2ZSBpZGVudGljYWwgdG8gV2ViS2l0MS4KKyNkZWZpbmUgRElTQUJMRV9OT1RfSU1QTEVNRU5U RURfV0FSTklOR1MgMQorCiAjZWxpZiBkZWZpbmVkKF9fQVBQTEVfXykKIAogI2lmICFkZWZpbmVk KEJVSUxESU5HX09OX0xFT1BBUkQpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFS RCkK