52607 2011-01-17 19:30:41 -0800 Some WebKit2 layout tests crash due to focus being on a frame in the page cache 2011-01-17 19:49:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 335640 0 mjs 2011-01-17 19:30:41 -0800 Some WebKit2 layout tests crash due to focus being on a frame in the page cache 335641 1 79239 mjs 2011-01-17 19:33:25 -0800 Created attachment 79239 Patch 335643 2 79239 mitz 2011-01-17 19:41:09 -0800 Comment on attachment 79239 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79239&action=review I know that in single-frame pages we try to maintain the focused element upon navigation back to a cached page. Does this change affect this behavior? Does it already not work for pages with subframes? > Source/WebCore/ChangeLog:15 > + goes in the page cache, rest focus to the main frame. Typo: rest. 335646 3 79239 mitz 2011-01-17 19:47:49 -0800 Comment on attachment 79239 Patch WebKit is already failing to maintain focus in a subframe across navigation through the page cache, which is arguably a bug, but not something this patch changes, so r+ 335648 4 mjs 2011-01-17 19:49:26 -0800 Committed r75994: <http://trac.webkit.org/changeset/75994> 79239 2011-01-17 19:33:25 -0800 2011-01-17 19:47:49 -0800 Patch bug-52607-20110117193321.patch text/plain 1890 mjs SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1OTkzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDEtMTcgIE1hY2llaiBT dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTb21lIFdlYktpdDIgbGF5b3V0IHRlc3RzIGNyYXNoIGR1ZSB0 byBmb2N1cyBiZWluZyBvbiBhIGZyYW1lIGluIHRoZSBwYWdlIGNhY2hlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjYwNworCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gRXhpc3RpbmcgdGVzdHMgY3Jhc2ggaW4gV2ViS2l0MiB3aXRob3V0IHRoaXMgZml4 LgorICAgICAgICAKKyAgICAgICAgSSBzdXNwZWN0IHRoZXJlIGFyZSBvdGhlciBjb25zZXF1ZW5j ZXMgYmVzaWRlcyB0aGUgV2ViS2l0MiBjcmFzaCwgYnV0IEkKKyAgICAgICAgd2FzIHVuYWJsZSB0 byBpZGVudGlmeSBhbnkgZm9yIGNlcnRhaW4uCisKKyAgICAgICAgKiBoaXN0b3J5L0NhY2hlZEZy YW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZEZyYW1lOjpDYWNoZWRGcmFtZSk6IElm IGEgZnJhbWUgc3RpbGwgaGFzIGZvY3VzIHdoZW4gaXRzIHBhZ2UKKyAgICAgICAgZ29lcyBpbiB0 aGUgcGFnZSBjYWNoZSwgcmVzdCBmb2N1cyB0byB0aGUgbWFpbiBmcmFtZS4KKwogMjAxMS0wMS0x NyAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2ltcGxpZnkgV0tD QUNGTGF5ZXJSZW5kZXJlcidzIEFQSQpJbmRleDogU291cmNlL1dlYkNvcmUvaGlzdG9yeS9DYWNo ZWRGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaGlzdG9yeS9DYWNoZWRG cmFtZS5jcHAJKHJldmlzaW9uIDc1OTE2KQorKysgU291cmNlL1dlYkNvcmUvaGlzdG9yeS9DYWNo ZWRGcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJE b2N1bWVudExvYWRlci5oIgogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRlICJF dmVudE5hbWVzLmgiCisjaW5jbHVkZSAiRm9jdXNDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiRnJh bWUuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudC5oIgogI2luY2x1ZGUgIkZyYW1lVmll dy5oIgpAQCAtMTMxLDYgKzEzMiw5IEBAIENhY2hlZEZyYW1lOjpDYWNoZWRGcmFtZShGcmFtZSog ZnJhbWUpCiAgICAgQVNTRVJUKG1fZG9jdW1lbnRMb2FkZXIpOwogICAgIEFTU0VSVChtX3ZpZXcp OwogCisgICAgaWYgKGZyYW1lLT5wYWdlKCktPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkRnJh bWUoKSA9PSBmcmFtZSkKKyAgICAgICAgZnJhbWUtPnBhZ2UoKS0+Zm9jdXNDb250cm9sbGVyKCkt PnNldEZvY3VzZWRGcmFtZShmcmFtZS0+cGFnZSgpLT5tYWluRnJhbWUoKSk7CisKICAgICAvLyBB Y3RpdmUgRE9NIG9iamVjdHMgbXVzdCBiZSBzdXNwZW5kZWQgYmVmb3JlIHdlIGNhY2hlZCB0aGUg ZnJhbWUgc2NyaXB0IGRhdGEKICAgICBtX2RvY3VtZW50LT5zdXNwZW5kQWN0aXZlRE9NT2JqZWN0 cyhBY3RpdmVET01PYmplY3Q6OkRvY3VtZW50V2lsbEJlY29tZUluYWN0aXZlKTsKICAgICBtX2Nh Y2hlZEZyYW1lU2NyaXB0RGF0YSA9IGFkb3B0UHRyKG5ldyBTY3JpcHRDYWNoZWRGcmFtZURhdGEo ZnJhbWUpKTsK