52591 2011-01-17 11:46:51 -0800 JavaScriptCore fails to link on FreeBSD/amd64 2011-01-18 13:46:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 dim webkit-unassigned commit-queue rakuco oldest_to_newest 335423 0 79197 dim 2011-01-17 11:46:51 -0800 Created attachment 79197 Fix JavaScriptCore linking on FreeBSD/amd64 On FreeBSD/amd64, JavaScriptCore fails to link with a similar error as in bug 28422: /usr/bin/ld: ../JavaScriptCore/release/libjscore.a(JITStubs.o): relocation R_X86_64_PC32 against `cti_vm_throw' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value This is the same type of issue as under Linux: the symbol name in question needs to have a @plt suffix. Patch attached. 335458 1 79207 dim 2011-01-17 12:44:26 -0800 Created attachment 79207 Fix JavaScriptCore linking on FreeBSD/amd64 Updated patch to include ChangeLog entry. 335585 2 ap 2011-01-17 17:03:26 -0800 + * jit/JITStubs.cpp: use @plt suffix on x86_64 platforms, for both Linux + and FreeBSD. There's a tab remaining in the ChangeLog, sorry. Please mark a patch for review once it's ready, so that it doesn't get overlooked. 335680 3 79245 dim 2011-01-17 23:56:08 -0800 Created attachment 79245 Fix JavaScriptCore linking on FreeBSD/amd64 Update to r76001, and untabify ChangeLog entry. 336065 4 79245 commit-queue 2011-01-18 13:46:36 -0800 Comment on attachment 79245 Fix JavaScriptCore linking on FreeBSD/amd64 Clearing flags on attachment: 79245 Committed r76060: <http://trac.webkit.org/changeset/76060> 336067 5 commit-queue 2011-01-18 13:46:41 -0800 All reviewed patches have been landed. Closing bug. 79197 2011-01-17 11:46:51 -0800 2011-01-17 12:44:26 -0800 Fix JavaScriptCore linking on FreeBSD/amd64 fbsd-plt.diff text/plain 490 dim SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCShyZXZpc2lvbiA3NTk1 MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC03OSw3ICs3OSw3IEBACiAjZGVmaW5lIFRIVU1CX0ZVTkNfUEFSQU0obmFtZSkKICNl bmRpZgogCi0jaWYgT1MoTElOVVgpICYmIENQVShYODZfNjQpCisjaWYgKE9TKExJTlVYKSB8fCBP UyhGUkVFQlNEKSkgJiYgQ1BVKFg4Nl82NCkKICNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FU SU9OKG5hbWUpICNuYW1lICJAcGx0IgogI2VsaWYgT1MoREFSV0lOKQogI2RlZmluZSBTWU1CT0xf U1RSSU5HX1JFTE9DQVRJT04obmFtZSkgIl8iICNuYW1lCg== 79207 2011-01-17 12:44:26 -0800 2011-01-17 23:56:08 -0800 Fix JavaScriptCore linking on FreeBSD/amd64 fbsd-plt-2.diff text/plain 1325 dim SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzU5NjUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDEtMTcgIERpbWl0cnkgQW5kcmljICA8ZGltQGZyZWVic2Qub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBsaW5raW5nIEphdmFT Y3JpcHRDb3JlIG9uIEZyZWVCU0QvYW1kNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUyNTkxCisKKyAgICAgICAgTGlua2luZyBvZiBKYXZhU2NyaXB0 Q29yZSBvbiBGcmVlQlNEL2FtZDY0IGZhaWxzLCBmb3IgdGhlIHNhbWUgcmVhc29uIGFzCisgICAg ICAgIGluIGJ1ZyAyODQyMjogY3RpX3ZtX3Rocm93IG5lZWRzIGEgIkBwbHQiIHN1ZmZpeCwgb3Ro ZXJ3aXNlIHRoZSBsaW5rZXIKKyAgICAgICAgY29tcGxhaW5zIGFib3V0IHRoZSByZWxvY2F0aW9u IHR5cGUuCisKKyAgICAgICAgKiBqaXQvSklUU3R1YnMuY3BwOiB1c2UgQHBsdCBzdWZmaXggb24g eDg2XzY0IHBsYXRmb3JtcywgZm9yIGJvdGggTGludXgKKwlhbmQgRnJlZUJTRC4KKwogMjAxMS0w MS0xNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1z dGFtcGVkIGJ5IE1hcmsgUm93ZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU U3R1YnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1 YnMuY3BwCShyZXZpc2lvbiA3NTk1MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU U3R1YnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OSw3ICs3OSw3IEBAIG5hbWVzcGFjZSBKU0Mg ewogI2RlZmluZSBUSFVNQl9GVU5DX1BBUkFNKG5hbWUpCiAjZW5kaWYKIAotI2lmIE9TKExJTlVY KSAmJiBDUFUoWDg2XzY0KQorI2lmIChPUyhMSU5VWCkgfHwgT1MoRlJFRUJTRCkpICYmIENQVShY ODZfNjQpCiAjZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihuYW1lKSAjbmFtZSAiQHBs dCIKICNlbGlmIE9TKERBUldJTikKICNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5h bWUpICJfIiAjbmFtZQo= 79245 2011-01-17 23:56:08 -0800 2011-01-18 13:46:36 -0800 Fix JavaScriptCore linking on FreeBSD/amd64 fbsd-plt-3.diff text/plain 1340 dim SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzYwMDEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDEtMTggIERpbWl0cnkgQW5kcmljICA8ZGltQGZyZWVic2Qub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBsaW5raW5nIEphdmFT Y3JpcHRDb3JlIG9uIEZyZWVCU0QvYW1kNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUyNTkxCisKKyAgICAgICAgTGlua2luZyBvZiBKYXZhU2NyaXB0 Q29yZSBvbiBGcmVlQlNEL2FtZDY0IGZhaWxzLCBmb3IgdGhlIHNhbWUgcmVhc29uIGFzCisgICAg ICAgIGluIGJ1ZyAyODQyMjogY3RpX3ZtX3Rocm93IG5lZWRzIGEgIkBwbHQiIHN1ZmZpeCwgb3Ro ZXJ3aXNlIHRoZSBsaW5rZXIKKyAgICAgICAgY29tcGxhaW5zIGFib3V0IHRoZSByZWxvY2F0aW9u IHR5cGUuCisKKyAgICAgICAgKiBqaXQvSklUU3R1YnMuY3BwOiB1c2UgQHBsdCBzdWZmaXggb24g eDg2XzY0IHBsYXRmb3JtcywgZm9yIGJvdGggTGludXgKKyAgICAgICAgYW5kIEZyZWVCU0QuCisK IDIwMTEtMDEtMTcgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZEBzZW5jaGEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUU3R1YnMuY3BwCShyZXZpc2lvbiA3NjAwMSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OSw3ICs3OSw3IEBA IG5hbWVzcGFjZSBKU0MgewogI2RlZmluZSBUSFVNQl9GVU5DX1BBUkFNKG5hbWUpCiAjZW5kaWYK IAotI2lmIE9TKExJTlVYKSAmJiBDUFUoWDg2XzY0KQorI2lmIChPUyhMSU5VWCkgfHwgT1MoRlJF RUJTRCkpICYmIENQVShYODZfNjQpCiAjZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihu YW1lKSAjbmFtZSAiQHBsdCIKICNlbGlmIE9TKERBUldJTikKICNkZWZpbmUgU1lNQk9MX1NUUklO R19SRUxPQ0FUSU9OKG5hbWUpICJfIiAjbmFtZQo=