52585 2011-01-17 09:44:22 -0800 REGRESSION(r75709): Return value of fscanf() shouldn't be ignored. 2011-01-17 19:10:56 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P1 Blocker --- 45384 1 jarred webkit-unassigned barraclough commit-queue ossy xan.lopez oldest_to_newest 335365 0 jarred 2011-01-17 09:44:22 -0800 We have a broken build w/ gcc 4.4.5 and libc 2.12.1 on Ubuntu 10.10 due to a warn_unused_result attribute applied on fscanf, and a misuse in change set 75709 (http://trac.webkit.org/changeset/75709/trunk/Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp) where the return value is not checked/used. Patch to come shortly. 335370 1 79183 jarred 2011-01-17 10:02:13 -0800 Created attachment 79183 Proposed patch Added another compiler flag to ignore unused return values, and to not treat those warnings as errors. Also removed duplicate -Wreturn-type entry. 335450 2 ossy 2011-01-17 12:35:50 -0800 It isn't Qt specific bug, but the return value of fscanf() should be always checked to avoid strange bugs. I prefer check the return value of fscanf() to paper over the problem with -Wreturn-type compiler option. 335453 3 79183 ossy 2011-01-17 12:38:29 -0800 Comment on attachment 79183 Proposed patch r- due to my last comment. And rs=me to remove the redundant -Wreturn-type. 335462 4 jarred 2011-01-17 12:48:02 -0800 (In reply to comment #2) > It isn't Qt specific bug, but the return value of fscanf() should be always checked to avoid strange bugs. I prefer check the return value of fscanf() to paper over the problem with -Wreturn-type compiler option. That was my original patch :) I know it's not Qt specific regression, but it is (at least) effecting the Qt Linux build. It got past the build bots somehow ;) I'll revise the patch. 335463 5 ossy 2011-01-17 12:49:19 -0800 452 static void maybeModifyVMPoolSize() 453 { 454 FILE* fp = fopen("/proc/sys/vm/overcommit_memory", "r"); 455 if (!fp) 456 return; 457 458 unsigned overcommit = 0; 459 fscanf(fp, "%u", &overcommit); Here the return value of fscanf must be true, so we can ignore it here, but we shouldn't do it in general. I think the similar "check" to http://trac.webkit.org/changeset/66984 would be good: + // We have to use the return value of fwrite to avoid "ignoring return value" gcc warning + // See https://bugs.webkit.org/show_bug.cgi?id=45384 for details. - fscanf(fp, "%u", &overcommit); + if (fscanf(fp, "%u", &overcommit)) {} 335465 6 ossy 2011-01-17 12:51:09 -0800 Once we should find a general solution for https://bugs.webkit.org/show_bug.cgi?id=45384 ... Any volunteer? :) 335480 7 79209 jarred 2011-01-17 13:13:42 -0800 Created attachment 79209 Proposed patch Check the return value instead of disabling a gcc warning flag, to benefit all ports. 335481 8 79209 ossy 2011-01-17 13:14:48 -0800 Comment on attachment 79209 Proposed patch LGTM, r=me. 335485 9 79209 darin 2011-01-17 13:17:33 -0800 Comment on attachment 79209 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=79209&action=review > Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:466 > + // We have to use the return value of fscanf to avoid "ignoring return value" gcc warning > + // See https://bugs.webkit.org/show_bug.cgi?id=45384 for details. This comment isn’t needed. We need to check the return value of fscanf because that’s how you use fscanf! I don’t think we need a reference to this bug. > Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:467 > + if (fscanf(fp, "%u", &overcommit)) { This is not right. We need to check if the value is 1 rather than checking for 0. This function can return EOF, for example. Since we’re going to the trouble to check here, I suggest doing the check correctly. 335486 10 jarred 2011-01-17 13:19:54 -0800 Spot on Darin, will revise. 335489 11 79210 jarred 2011-01-17 13:24:16 -0800 Created attachment 79210 Proposed patch explicitly check for 1, as checking for "anything but zero" is incorrect as EOF could be returned. 335492 12 79211 jarred 2011-01-17 13:26:28 -0800 Created attachment 79211 Proposed patch broken patch 335502 13 79211 ossy 2011-01-17 13:44:22 -0800 Comment on attachment 79211 Proposed patch r=me, based on Darin's comment. Thanks for the advice, this patch is better. 335504 14 ossy 2011-01-17 13:46:46 -0800 Jarred, if you realized that you upload a bad patch next time, just remove r? flag and set obsolete flag instead of giving a "self-r-" . 335505 15 jarred 2011-01-17 13:48:29 -0800 (In reply to comment #14) > Jarred, if you realized that you upload a bad patch next time, just > remove r? flag and set obsolete flag instead of giving a "self-r-" . Will do, I just like criticizing myself :) 335631 16 79211 commit-queue 2011-01-17 19:10:50 -0800 Comment on attachment 79211 Proposed patch Clearing flags on attachment: 79211 Committed r75992: <http://trac.webkit.org/changeset/75992> 335632 17 commit-queue 2011-01-17 19:10:56 -0800 All reviewed patches have been landed. Closing bug. 79183 2011-01-17 10:02:13 -0800 2011-01-17 13:13:42 -0800 Proposed patch fscanf_break.patch text/plain 1349 jarred ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwZDRhN2Y5Li42MmI3NTFl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDEtMTcgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZEBzZW5jaGEuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRXhlY3V0YWJs ZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcCAtIEJ1aWxkIGJyb2tlbiBvbiBMaW51eAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI1ODUKKyAgICAgICAg CisgICAgICAgIGFkZGVkIC1Xbm8tdW51c2VkLXJlc3VsdCB0byBjb21waWxlciBmbGFncworCisg ICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAg ICAgICAgKiBXZWJLaXQucHJpOgorCiAyMDExLTAxLTE2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYg LS1naXQgYS9XZWJLaXQucHJpIGIvV2ViS2l0LnByaQppbmRleCBkODU2ODYzLi5jYzZiZDQ2IDEw MDY0NAotLS0gYS9XZWJLaXQucHJpCisrKyBiL1dlYktpdC5wcmkKQEAgLTU4LDcgKzU4LDcgQEAg Q09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpIHsKIElOQ0xVREVQQVRIICs9ICQkT1VUUFVU X0RJUi9Tb3VyY2UvaW5jbHVkZS9RdFdlYktpdAogCiBDT05GSUcgLT0gd2Fybl9vbgotKi1nKysq OlFNQUtFX0NYWEZMQUdTICs9IC1XYWxsIC1XZXh0cmEgLVdyZXR1cm4tdHlwZSAtZm5vLXN0cmlj dC1hbGlhc2luZyAtV2Nhc3QtYWxpZ24gLVdjaGFyLXN1YnNjcmlwdHMgLVdmb3JtYXQtc2VjdXJp dHkgLVdyZXR1cm4tdHlwZSAtV25vLXVudXNlZC1wYXJhbWV0ZXIgLVduby1zaWduLWNvbXBhcmUg LVduby1zd2l0Y2ggLVduby1zd2l0Y2gtZW51bSAtV3VuZGVmIC1XbWlzc2luZy1ub3JldHVybiAt V2luaXQtc2VsZgorKi1nKysqOlFNQUtFX0NYWEZMQUdTICs9IC1XYWxsIC1XZXh0cmEgLVdyZXR1 cm4tdHlwZSAtZm5vLXN0cmljdC1hbGlhc2luZyAtV2Nhc3QtYWxpZ24gLVdjaGFyLXN1YnNjcmlw dHMgLVdmb3JtYXQtc2VjdXJpdHkgLVduby11bnVzZWQtcGFyYW1ldGVyIC1Xbm8tdW51c2VkLXJl c3VsdCAtV25vLXNpZ24tY29tcGFyZSAtV25vLXN3aXRjaCAtV25vLXN3aXRjaC1lbnVtIC1XdW5k ZWYgLVdtaXNzaW5nLW5vcmV0dXJuIC1XaW5pdC1zZWxmCiAKICMgVHJlYXQgd2FybmluZ3MgYXMg ZXJyb3JzIG9uIHg4Ni9MaW51eC9HQ0MKIGxpbnV4LWcrKyogewo= 79209 2011-01-17 13:13:42 -0800 2011-01-17 13:24:16 -0800 Proposed patch fscanf_break.patch text/plain 1698 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGM3YjM1ODkuLjM0YzdlNzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAxLTE3ICBKYXJyZWQgTmljaG9s bHMgIDxqYXJyZWRAc2VuY2hhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKHI3NTcwOSk6IFJldHVybiB2YWx1ZSBvZiBmc2Nh bmYoKSBzaG91bGRuJ3QgYmUgaWdub3JlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUyNTg1CisgICAgICAgIAorICAgICAgICBnY2MgNC40LjQrIGhh cyB3YXJuX3VudXNlZF92YWx1ZSBhdHRyaWJ1dGUgb24gZnNjYW5mLCBzbyB3ZSBzaG91bGQgY2hl Y2sKKyAgICAgICAgdGhlIHJldHVybiB2YWx1ZSB0byBnZXQgYXJvdW5kIHRoZSBnY2Mgd2Fybmlu ZworCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHA6Cisg ICAgICAgIChKU0M6Om1heWJlTW9kaWZ5Vk1Qb29sU2l6ZSk6CisKIDIwMTEtMDEtMTcgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBN YXJrIFJvd2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFi bGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4 ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAKaW5kZXggZGQ3MTFkNC4uZmFiOTFkMiAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9y Rml4ZWRWTVBvb2wuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJs ZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcApAQCAtNDYxLDEwICs0NjEsMTQgQEAgc3RhdGljIHZv aWQgbWF5YmVNb2RpZnlWTVBvb2xTaXplKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgdW5zaWdu ZWQgb3ZlcmNvbW1pdCA9IDA7Ci0gICAgZnNjYW5mKGZwLCAiJXUiLCAmb3ZlcmNvbW1pdCk7Ci0g ICAgaWYgKG92ZXJjb21taXQgPT0gMSkgewotICAgICAgICB2bVBvb2xTaXplID0gdm1Qb29sU2l6 ZU92ZXJjb21taXQ7Ci0gICAgICAgIGNvYWxlc2NlTGltaXQgPSBjb2FsZXNjZUxpbWl0T3ZlcmNv bW1pdDsKKworICAgIC8vIFdlIGhhdmUgdG8gdXNlIHRoZSByZXR1cm4gdmFsdWUgb2YgZnNjYW5m IHRvIGF2b2lkICJpZ25vcmluZyByZXR1cm4gdmFsdWUiIGdjYyB3YXJuaW5nCisgICAgLy8gU2Vl IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM4NCBmb3IgZGV0YWls cy4KKyAgICBpZiAoZnNjYW5mKGZwLCAiJXUiLCAmb3ZlcmNvbW1pdCkpIHsKKyAgICAgICAgaWYg KG92ZXJjb21taXQgPT0gMSkgeworICAgICAgICAgICAgdm1Qb29sU2l6ZSA9IHZtUG9vbFNpemVP dmVyY29tbWl0OworICAgICAgICAgICAgY29hbGVzY2VMaW1pdCA9IGNvYWxlc2NlTGltaXRPdmVy Y29tbWl0OworICAgICAgICB9CiAgICAgfQogCiAgICAgZmNsb3NlKGZwKTsK 79210 2011-01-17 13:24:16 -0800 2011-01-17 13:26:28 -0800 Proposed patch fscanf_break.patch text/plain 1533 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGM3YjM1ODkuLjM0YzdlNzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAxLTE3ICBKYXJyZWQgTmljaG9s bHMgIDxqYXJyZWRAc2VuY2hhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKHI3NTcwOSk6IFJldHVybiB2YWx1ZSBvZiBmc2Nh bmYoKSBzaG91bGRuJ3QgYmUgaWdub3JlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUyNTg1CisgICAgICAgIAorICAgICAgICBnY2MgNC40LjQrIGhh cyB3YXJuX3VudXNlZF92YWx1ZSBhdHRyaWJ1dGUgb24gZnNjYW5mLCBzbyB3ZSBzaG91bGQgY2hl Y2sKKyAgICAgICAgdGhlIHJldHVybiB2YWx1ZSB0byBnZXQgYXJvdW5kIHRoZSBnY2Mgd2Fybmlu ZworCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHA6Cisg ICAgICAgIChKU0M6Om1heWJlTW9kaWZ5Vk1Qb29sU2l6ZSk6CisKIDIwMTEtMDEtMTcgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBN YXJrIFJvd2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFi bGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4 ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAKaW5kZXggZGQ3MTFkNC4uOTdhNWVjNCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9y Rml4ZWRWTVBvb2wuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJs ZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcApAQCAtNDYxLDEwICs0NjEsMTEgQEAgc3RhdGljIHZv aWQgbWF5YmVNb2RpZnlWTVBvb2xTaXplKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgdW5zaWdu ZWQgb3ZlcmNvbW1pdCA9IDA7Ci0gICAgZnNjYW5mKGZwLCAiJXUiLCAmb3ZlcmNvbW1pdCk7Ci0g ICAgaWYgKG92ZXJjb21taXQgPT0gMSkgewotICAgICAgICB2bVBvb2xTaXplID0gdm1Qb29sU2l6 ZU92ZXJjb21taXQ7Ci0gICAgICAgIGNvYWxlc2NlTGltaXQgPSBjb2FsZXNjZUxpbWl0T3ZlcmNv bW1pdDsKKyAgICBpZiAoZnNjYW5mKGZwLCAiJXUiLCAmb3ZlcmNvbW1pdCkgPT0gMSkKKyAgICAg ICAgaWYgKG92ZXJjb21taXQgPT0gMSkgeworICAgICAgICAgICAgdm1Qb29sU2l6ZSA9IHZtUG9v bFNpemVPdmVyY29tbWl0OworICAgICAgICAgICAgY29hbGVzY2VMaW1pdCA9IGNvYWxlc2NlTGlt aXRPdmVyY29tbWl0OworICAgICAgICB9CiAgICAgfQogCiAgICAgZmNsb3NlKGZwKTsK 79211 2011-01-17 13:26:28 -0800 2011-01-17 19:10:50 -0800 Proposed patch fscanf_break.patch text/plain 1535 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGM3YjM1ODkuLjM0YzdlNzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAxLTE3ICBKYXJyZWQgTmljaG9s bHMgIDxqYXJyZWRAc2VuY2hhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKHI3NTcwOSk6IFJldHVybiB2YWx1ZSBvZiBmc2Nh bmYoKSBzaG91bGRuJ3QgYmUgaWdub3JlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUyNTg1CisgICAgICAgIAorICAgICAgICBnY2MgNC40LjQrIGhh cyB3YXJuX3VudXNlZF92YWx1ZSBhdHRyaWJ1dGUgb24gZnNjYW5mLCBzbyB3ZSBzaG91bGQgY2hl Y2sKKyAgICAgICAgdGhlIHJldHVybiB2YWx1ZSB0byBnZXQgYXJvdW5kIHRoZSBnY2Mgd2Fybmlu ZworCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHA6Cisg ICAgICAgIChKU0M6Om1heWJlTW9kaWZ5Vk1Qb29sU2l6ZSk6CisKIDIwMTEtMDEtMTcgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBN YXJrIFJvd2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFi bGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4 ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAKaW5kZXggZGQ3MTFkNC4uOWZjODg5ZSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9y Rml4ZWRWTVBvb2wuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJs ZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcApAQCAtNDYxLDEwICs0NjEsMTEgQEAgc3RhdGljIHZv aWQgbWF5YmVNb2RpZnlWTVBvb2xTaXplKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgdW5zaWdu ZWQgb3ZlcmNvbW1pdCA9IDA7Ci0gICAgZnNjYW5mKGZwLCAiJXUiLCAmb3ZlcmNvbW1pdCk7Ci0g ICAgaWYgKG92ZXJjb21taXQgPT0gMSkgewotICAgICAgICB2bVBvb2xTaXplID0gdm1Qb29sU2l6 ZU92ZXJjb21taXQ7Ci0gICAgICAgIGNvYWxlc2NlTGltaXQgPSBjb2FsZXNjZUxpbWl0T3ZlcmNv bW1pdDsKKyAgICBpZiAoZnNjYW5mKGZwLCAiJXUiLCAmb3ZlcmNvbW1pdCkgPT0gMSkgeworICAg ICAgICBpZiAob3ZlcmNvbW1pdCA9PSAxKSB7CisgICAgICAgICAgICB2bVBvb2xTaXplID0gdm1Q b29sU2l6ZU92ZXJjb21taXQ7CisgICAgICAgICAgICBjb2FsZXNjZUxpbWl0ID0gY29hbGVzY2VM aW1pdE92ZXJjb21taXQ7CisgICAgICAgIH0KICAgICB9CiAKICAgICBmY2xvc2UoZnApOwo=