52584 2011-01-17 09:40:12 -0800 Web Inspector: unify image data source assignment, add image url to the image view properties list. 2011-01-17 12:17:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 335362 0 pfeldman 2011-01-17 09:40:12 -0800 Patch to follow. 335363 1 79182 pfeldman 2011-01-17 09:42:51 -0800 Created attachment 79182 [PATCH] Proposed change. 335367 2 pfeldman 2011-01-17 09:51:56 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/English.lproj/localizedStrings.js M Source/WebCore/inspector/front-end/ImageView.js M Source/WebCore/inspector/front-end/NetworkPanel.js M Source/WebCore/inspector/front-end/Resource.js M Source/WebCore/inspector/front-end/ResourcesPanel.js Committed r75952 335421 3 79182 caseq 2011-01-17 11:41:38 -0800 Comment on attachment 79182 [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=79182&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1422 > + this._resource.populateImageSource(imagePreviewElement); imagePreviewElement is not defined here. Was this change ever tested? 335445 4 pfeldman 2011-01-17 12:17:32 -0800 (In reply to comment #3) > (From update of attachment 79182 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79182&action=review > > > Source/WebCore/inspector/front-end/NetworkPanel.js:1422 > > + this._resource.populateImageSource(imagePreviewElement); > > imagePreviewElement is not defined here. Was this change ever tested? Sorry about that - too many changes today. Fixed in r75964. 79182 2011-01-17 09:42:51 -0800 2011-01-17 11:41:38 -0800 [PATCH] Proposed change. image_src text/plain 5712 pfeldman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMjlmZTQ4Li5hMDQyOWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTEtMDEtMTcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogdW5pZnkgaW1hZ2UgZGF0YSBzb3VyY2UgYXNzaWdubWVudCwgYWRkIGltYWdlIHVybAor ICAgICAgICB0byB0aGUgaW1hZ2UgdmlldyBwcm9wZXJ0aWVzIGxpc3QuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjU4NAorCisgICAgICAgICogRW5n bGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvSW1hZ2VWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkltYWdlVmlldy5wcm90 b3R5cGUuX2NyZWF0ZUNvbnRlbnRJZk5lZWRlZC5vbkltYWdlTG9hZCk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuSW1hZ2VWaWV3LnByb3RvdHlwZS5fY3JlYXRlQ29udGVudElmTmVlZGVkKToKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5OZXR3b3JrRGF0YUdyaWROb2RlLnByb3RvdHlwZS5fcmVmcmVzaE5hbWVDZWxs KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlJlc291cmNlLnByb3RvdHlwZS5wb3B1bGF0ZUltYWdlU291cmNlKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5wcm90b3R5cGUuX2NvbnRlbnRVUkwpOgorICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuRnJhbWVSZXNvdXJjZVRyZWVFbGVtZW50LnByb3RvdHlwZS5vbmF0dGFjaCk6 CisKKzIwMTEtMDEtMTcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisK ICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiByZXN0b3JlIGRvbSBhbmQgbmV0d29yayBzdGF0ZSB1cG9uIGZyb250ZW5kIHJldXNl LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJp bmdzLmpzIGIvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpz CmluZGV4IDcyYjU3ZGUuLjBkOGVkYzIgMTAwNjQ0CkJpbmFyeSBmaWxlcyBhL1NvdXJjZS9XZWJD b3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBhbmQgYi9Tb3VyY2UvV2ViQ29y ZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgZGlmZmVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ltYWdlVmlldy5qcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VWaWV3LmpzCmluZGV4IGM1NzcyYzguLjkx N2E5ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW1h Z2VWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VW aWV3LmpzCkBAIC03MCwxMiArNzAsNyBAQCBXZWJJbnNwZWN0b3IuSW1hZ2VWaWV3LnByb3RvdHlw ZSA9IHsKICAgICAgICAgdmFyIGluZm9MaXN0RWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoImRsIik7CiAgICAgICAgIGluZm9MaXN0RWxlbWVudC5jbGFzc05hbWUgPSAiaW5mb0xpc3Qi OwogCi0gICAgICAgIGZ1bmN0aW9uIG9uUmVzb3VyY2VDb250ZW50KGVsZW1lbnQsIGNvbnRlbnQp Ci0gICAgICAgIHsKLSAgICAgICAgICAgIGltYWdlUHJldmlld0VsZW1lbnQuc2V0QXR0cmlidXRl KCJzcmMiLCB0aGlzLnJlc291cmNlLmNvbnRlbnRVUkwpOwotICAgICAgICB9Ci0gICAgICAgIHRo aXMucmVzb3VyY2UucmVxdWVzdENvbnRlbnQob25SZXNvdXJjZUNvbnRlbnQuYmluZCh0aGlzKSk7 Ci0KKyAgICAgICAgdGhpcy5yZXNvdXJjZS5wb3B1bGF0ZUltYWdlU291cmNlKGltYWdlUHJldmll d0VsZW1lbnQpOwogCiAgICAgICAgIGZ1bmN0aW9uIG9uSW1hZ2VMb2FkKCkKICAgICAgICAgewpA QCAtMTAwLDYgKzk1LDEzIEBAIFdlYkluc3BlY3Rvci5JbWFnZVZpZXcucHJvdG90eXBlID0gewog ICAgICAgICAgICAgICAgIGRkLnRleHRDb250ZW50ID0gaW1hZ2VQcm9wZXJ0aWVzW2ldLnZhbHVl OwogICAgICAgICAgICAgICAgIGluZm9MaXN0RWxlbWVudC5hcHBlbmRDaGlsZChkZCk7CiAgICAg ICAgICAgICB9CisgICAgICAgICAgICB2YXIgZHQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJk dCIpOworICAgICAgICAgICAgZHQudGV4dENvbnRlbnQgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmco IlVSTCIpOworICAgICAgICAgICAgaW5mb0xpc3RFbGVtZW50LmFwcGVuZENoaWxkKGR0KTsKKyAg ICAgICAgICAgIHZhciBkZCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRkIik7CisgICAgICAg ICAgICBkZC5hcHBlbmRDaGlsZChXZWJJbnNwZWN0b3IubGlua2lmeVVSTEFzTm9kZSh0aGlzLnJl c291cmNlLnVybCkpOworICAgICAgICAgICAgaW5mb0xpc3RFbGVtZW50LmFwcGVuZENoaWxkKGRk KTsKKwogICAgICAgICAgICAgdGhpcy5fY29udGFpbmVyLmFwcGVuZENoaWxkKGluZm9MaXN0RWxl bWVudCk7CiAgICAgICAgIH0KICAgICAgICAgaW1hZ2VQcmV2aWV3RWxlbWVudC5hZGRFdmVudExp c3RlbmVyKCJsb2FkIiwgb25JbWFnZUxvYWQuYmluZCh0aGlzKSwgZmFsc2UpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qcwppbmRleCBh YTg2OGZlLi5lOWUwZGNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL05ldHdvcmtQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL05ldHdvcmtQYW5lbC5qcwpAQCAtMTQxOSwxNSArMTQxOSw3IEBAIFdlYkluc3BlY3Rv ci5OZXR3b3JrRGF0YUdyaWROb2RlLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKHRoaXMuX3Jl c291cmNlLmNhdGVnb3J5ID09PSBXZWJJbnNwZWN0b3IucmVzb3VyY2VDYXRlZ29yaWVzLmltYWdl cykgewogICAgICAgICAgICAgdmFyIHByZXZpZXdJbWFnZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoImltZyIpOwogICAgICAgICAgICAgcHJldmlld0ltYWdlLmNsYXNzTmFtZSA9ICJpbWFnZS1u ZXR3b3JrLWljb24tcHJldmlldyI7Ci0KLSAgICAgICAgICAgIGZ1bmN0aW9uIG9uUmVzb3VyY2VD b250ZW50KCkKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBwcmV2aWV3SW1hZ2Uuc3Jj ID0gdGhpcy5fcmVzb3VyY2UuY29udGVudFVSTDsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAg IGlmIChQcmVmZXJlbmNlcy51c2VEYXRhVVJMRm9yUmVzb3VyY2VJbWFnZUljb25zKQotICAgICAg ICAgICAgICAgIHRoaXMuX3Jlc291cmNlLnJlcXVlc3RDb250ZW50KG9uUmVzb3VyY2VDb250ZW50 LmJpbmQodGhpcykpOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIHByZXZpZXdJ bWFnZS5zcmMgPSB0aGlzLl9yZXNvdXJjZS51cmw7CisgICAgICAgICAgICB0aGlzLl9yZXNvdXJj ZS5wb3B1bGF0ZUltYWdlU291cmNlKGltYWdlUHJldmlld0VsZW1lbnQpOwogCiAgICAgICAgICAg ICB2YXIgaWNvbkVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAg ICAgICAgIGljb25FbGVtZW50LmNsYXNzTmFtZSA9ICJpY29uIjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2UuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlLmpzCmluZGV4IDk4OGM0ZTYuLjczNDA2NDUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2Uu anMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZS5qcwpA QCAtNjc4LDcgKzY3OCwyMCBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2UucHJvdG90eXBlID0gewog ICAgICAgICAgICAgdGhpcy5faW5uZXJSZXF1ZXN0Q29udGVudCgpOwogICAgIH0sCiAKLSAgICBn ZXQgY29udGVudFVSTCgpCisgICAgcG9wdWxhdGVJbWFnZVNvdXJjZTogZnVuY3Rpb24oaW1hZ2Up CisgICAgeworICAgICAgICBmdW5jdGlvbiBvblJlc291cmNlQ29udGVudCgpCisgICAgICAgIHsK KyAgICAgICAgICAgIGltYWdlLnNyYyA9IHRoaXMuX2NvbnRlbnRVUkwoKTsKKyAgICAgICAgfQor CisgICAgICAgIGlmIChQcmVmZXJlbmNlcy51c2VEYXRhVVJMRm9yUmVzb3VyY2VJbWFnZUljb25z KQorICAgICAgICAgICAgdGhpcy5yZXF1ZXN0Q29udGVudChvblJlc291cmNlQ29udGVudC5iaW5k KHRoaXMpKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgaW1hZ2Uuc3JjID0gdGhpcy51cmw7 CisgICAgfSwKKworICAgIF9jb250ZW50VVJMOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICBj b25zdCBtYXhEYXRhVXJsU2l6ZSA9IDEwMjQgKiAxMDI0OwogICAgICAgICAvLyBJZiByZXNvdXJj ZSBjb250ZW50IGlzIG5vdCBhdmFpbGFibGUgb3Igd29uJ3QgZml0IGEgZGF0YSBVUkwsIGZhbGwg YmFjayB0byB1c2luZyBvcmlnaW5hbCBVUkwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwppbmRleCA5ZWY4ZjViLi5kOTY5ODli IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNl c1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3Vy Y2VzUGFuZWwuanMKQEAgLTEwMTEsNyArMTAxMSw3IEBAIFdlYkluc3BlY3Rvci5GcmFtZVJlc291 cmNlVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fcmVzb3VyY2Uu Y2F0ZWdvcnkgPT09IFdlYkluc3BlY3Rvci5yZXNvdXJjZUNhdGVnb3JpZXMuaW1hZ2VzKSB7CiAg ICAgICAgICAgICB2YXIgcHJldmlld0ltYWdlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaW1n Iik7CiAgICAgICAgICAgICBwcmV2aWV3SW1hZ2UuY2xhc3NOYW1lID0gImltYWdlLXJlc291cmNl LWljb24tcHJldmlldyI7Ci0gICAgICAgICAgICBwcmV2aWV3SW1hZ2Uuc3JjID0gdGhpcy5fcmVz b3VyY2UudXJsOworICAgICAgICAgICAgdGhpcy5fcmVzb3VyY2UucG9wdWxhdGVJbWFnZVNvdXJj ZShwcmV2aWV3SW1hZ2UpOwogCiAgICAgICAgICAgICB2YXIgaWNvbkVsZW1lbnQgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAgICAgIGljb25FbGVtZW50LmNsYXNzTmFt ZSA9ICJpY29uIjsK