52580 2011-01-17 08:06:44 -0800 Web Inspector: script column offset is incorrect 2011-01-19 01:18:02 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov webkit-unassigned apavlov bweinstein joepeck keishi loislo peter.rybin pfeldman pmuellr rik timothy yurys oldest_to_newest 335334 0 79178 podivilov 2011-01-17 08:06:44 -0800 Created attachment 79178 snippet For attached document, script column offset is 10 (one-based) while it should be 9. 335795 1 79272 peter.rybin 2011-01-18 06:03:06 -0800 Created attachment 79272 Patch 335814 2 79272 yurys 2011-01-18 07:28:18 -0800 Comment on attachment 79272 Patch Can we have a test for this change? 336387 3 79272 yurys 2011-01-19 01:17:51 -0800 Comment on attachment 79272 Patch Clearing flags on attachment: 79272 Committed r76106: <http://trac.webkit.org/changeset/76106> 336388 4 yurys 2011-01-19 01:18:02 -0800 All reviewed patches have been landed. Closing bug. 79178 2011-01-17 08:06:44 -0800 2011-01-17 08:06:44 -0800 snippet test.html text/html 68 podivilov PGh0bWw+PGJvZHk+DQo8c2NyaXB0PnZhciBkID0gbmV3IERhdGUoKTs8L3NjcmlwdD4NCjwvYm9k eT48L2h0bWw+DQo= 79272 2011-01-18 06:03:06 -0800 2011-01-19 01:17:51 -0800 Patch bug-52580-20110118170304.patch text/plain 2569 peter.rybin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODAzNDZmOTc4YWU5YmNjN2IxMjJkY2ExNjM0ZDYzOWZkNGJiN2U5Li40 OWQyZDNiNThhZDg3Mzg0MzEyNmE5NGJmNWNmNTkxN2M3MDA0M2UzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTEtMDEtMTggIFBldGVyIFJ5YmluICA8cGV0ZXIucnliaW5AZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IHNjcmlwdCBjb2x1bW4gb2Zmc2V0IGlzIGluY29ycmVjdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI1ODAKKworICAgICAgICBD b2x1bW4gaXMgdXBkYXRlZCBpbiAzIHBsYWNlcywgMiBsZXNzIHByb2JhYmxlIHBsYWNlcyBjb250 YWluZWQgZXJyb3IuCisgICAgICAgIEZpeGVkIG5vdy4KKworICAgICAgICAqIHBsYXRmb3JtL3Rl eHQvU2VnbWVudGVkU3RyaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlZ21lbnRlZFN0cmlu Zzo6YWR2YW5jZVNsb3dDYXNlKToKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L1NlZ21lbnRlZFN0 cmluZy5oOgorICAgICAgICAoV2ViQ29yZTo6U2VnbWVudGVkU3RyaW5nOjphZHZhbmNlUGFzdE5l d2xpbmUpOgorCiAyMDExLTAxLTE3ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1NlZ21lbnRlZFN0cmluZy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1NlZ21lbnRlZFN0cmluZy5jcHAKaW5kZXggYTM3 MTU4MmUxZTIwYjRlYzYyYjBkYWNjMWQ5YTM2MTljZTNkMGZkOS4uNWU5NzU1YjJjMzVjMGFlNjQw YWVkOGNjYzNkMTU2ZDE2ZjEyNzdmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9TZWdtZW50ZWRTdHJpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3RleHQvU2VnbWVudGVkU3RyaW5nLmNwcApAQCAtMjQ2LDcgKzI0Niw4IEBAIHZvaWQgU2VnbWVu dGVkU3RyaW5nOjphZHZhbmNlU2xvd0Nhc2UoaW50JiBsaW5lTnVtYmVyKQogICAgICAgICBpZiAo Km1fY3VycmVudFN0cmluZy5tX2N1cnJlbnQrKyA9PSAnXG4nICYmIG1fY3VycmVudFN0cmluZy5k b05vdEV4Y2x1ZGVMaW5lTnVtYmVycygpKSB7CiAgICAgICAgICAgICArK2xpbmVOdW1iZXI7CiAg ICAgICAgICAgICArK21fY3VycmVudExpbmU7Ci0gICAgICAgICAgICBtX251bWJlck9mQ2hhcmFj dGVyc0NvbnN1bWVkUHJpb3JUb0N1cnJlbnRMaW5lID0gbnVtYmVyT2ZDaGFyYWN0ZXJzQ29uc3Vt ZWQoKTsKKyAgICAgICAgICAgIC8vIFBsdXMgMSBiZWNhdXNlIG51bWJlck9mQ2hhcmFjdGVyc0Nv bnN1bWVkIHZhbHVlIGhhc24ndCBpbmNyZW1lbnRlZCB5ZXQ7IGl0IGRvZXMgd2l0aCBtX2xlbmd0 aCBkZWNyZW1lbnQgYmVsb3cuCisgICAgICAgICAgICBtX251bWJlck9mQ2hhcmFjdGVyc0NvbnN1 bWVkUHJpb3JUb0N1cnJlbnRMaW5lID0gbnVtYmVyT2ZDaGFyYWN0ZXJzQ29uc3VtZWQoKSArIDE7 CiAgICAgICAgIH0KICAgICAgICAgaWYgKC0tbV9jdXJyZW50U3RyaW5nLm1fbGVuZ3RoID09IDAp CiAgICAgICAgICAgICBhZHZhbmNlU3Vic3RyaW5nKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS90ZXh0L1NlZ21lbnRlZFN0cmluZy5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9TZWdtZW50ZWRTdHJpbmcuaAppbmRleCA1ZjU0OGM3M2YxZjU4NjQwOTU5YjVh YTQyMGY4OGEyNTMxMTAxYTk5Li4zMGM4OTlkNzdhMzgwZDkxMGM4ZmY4NDkxNGUzMTA4MmRkY2U2 ZWViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1NlZ21lbnRlZFN0 cmluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvU2VnbWVudGVkU3RyaW5n LmgKQEAgLTE2NCw3ICsxNjQsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBsaW5lTnVtYmVyICs9 IG5ld0xpbmVGbGFnOwogICAgICAgICAgICAgbV9jdXJyZW50TGluZSArPSBuZXdMaW5lRmxhZzsK ICAgICAgICAgICAgIGlmIChuZXdMaW5lRmxhZykKLSAgICAgICAgICAgICAgICBtX251bWJlck9m Q2hhcmFjdGVyc0NvbnN1bWVkUHJpb3JUb0N1cnJlbnRMaW5lID0gbnVtYmVyT2ZDaGFyYWN0ZXJz Q29uc3VtZWQoKTsKKyAgICAgICAgICAgICAgICBtX251bWJlck9mQ2hhcmFjdGVyc0NvbnN1bWVk UHJpb3JUb0N1cnJlbnRMaW5lID0gbnVtYmVyT2ZDaGFyYWN0ZXJzQ29uc3VtZWQoKSArIDE7CiAg ICAgICAgICAgICAtLW1fY3VycmVudFN0cmluZy5tX2xlbmd0aDsKICAgICAgICAgICAgIG1fY3Vy cmVudENoYXIgPSArK21fY3VycmVudFN0cmluZy5tX2N1cnJlbnQ7CiAgICAgICAgICAgICByZXR1 cm47Cg==