52570 2011-01-17 05:48:31 -0800 [Gtk] No need to content sniff 304 Not Modified responses 2011-01-17 15:32:27 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 svillar svillar mrobinson oldest_to_newest 335274 0 svillar 2011-01-17 05:48:31 -0800 [Gtk] No need to content sniff 304 Not Modified responses 335275 1 79159 svillar 2011-01-17 05:53:49 -0800 Created attachment 79159 Patch 335277 2 svillar 2011-01-17 05:59:59 -0800 Something like this is also done in the Mac port: https://bugs.webkit.org/show_bug.cgi?id=38032 335361 3 79159 mrobinson 2011-01-17 09:35:18 -0800 Comment on attachment 79159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79159&action=review Looks good! If this doesn't change functionality, you should put a note in the ChangeLog where the tests line normally is. If it does change functionality, it might need a test. > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:249 > + if (handle->shouldContentSniff()) > + // Avoid MIME type sniffing if the response comes back as 304 Not Modified. > + if (msg->status_code == SOUP_STATUS_NOT_MODIFIED) { > + soup_message_disable_feature(msg, SOUP_TYPE_CONTENT_SNIFFER); > + g_signal_handlers_disconnect_by_func(msg, reinterpret_cast<gpointer>(contentSniffedCallback), handle.get()); > + } else > + return; You should use curly braces with the outer loop since its body is more than one line. 335461 4 svillar 2011-01-17 12:47:49 -0800 Committed r75967: <http://trac.webkit.org/changeset/75967> 335534 5 mrobinson 2011-01-17 14:46:57 -0800 I think this caused a failure in http/tests/inspector/extensions-resources-redirect.html . It doesn't look too worrying, but it might be nice to understand why. Here's the diff: --- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/inspector/extensions-resources-redirect-expected.txt 2011-01-17 14:34:29.877532178 -0800 +++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/inspector/extensions-resources-redirect-actual.txt 2011-01-17 14:34:29.869142149 -0800 @@ -8,8 +8,8 @@ content: undefined, encoding: undefined RUNNING TEST: extension_testRedirectResourceFinished -Finished resource: http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?redirected=true Finished resource: http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?status=302 +Finished resource: http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?redirected=true RUNNING TEST: extension_testRedirectResourcesInHAR Resources in HAR: http://127.0.0.1:8000/inspector/extensions-resources-redirect.html 335557 6 mrobinson 2011-01-17 15:32:27 -0800 (In reply to comment #5) > I think this caused a failure in http/tests/inspector/extensions-resources-redirect.html . It doesn't look too worrying, but it might be nice to understand why. Here's the diff: Update: This test may just be flaky. 79159 2011-01-17 05:53:49 -0800 2011-01-17 09:35:18 -0800 Patch bug-52570-20110117145347.patch text/plain 2466 svillar ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYzQwZmRhZjE1YzgwNmYyYTAwODAwYWNmNDc4MzczYjIyYTQyMzA3Li41 MjIxN2E3Y2JjMDJkMmQ1ODBjYzhkOTRkYTE0MWUwMWI4MzM0YmRhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTEtMDEtMTcgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0d0a10gTm8gbmVlZCB0byBjb250ZW50IHNuaWZmIDMwNCBOb3QgTW9kaWZpZWQgcmVzcG9u c2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjU3 MAorCisgICAgICAgIE1ha2VzIG5vIHNlbnNlIHRvIHdhaXQgZm9yIHRoZSBvdXRjb21lIG9mIGNv bnRlbnQgc25pZmZpbmcgd2hlbiBXZWJDb3JlCisgICAgICAgIGlzIHZhbGlkYXRpbmcgcmVzb3Vy Y2VzLiBJZiB3ZSBnZXQgYSAzMDQgTm90IE1vZGlmaWVkIGl0IG1lYW5zIHRoYXQgd2UgY2FuCisg ICAgICAgIHNhZmVseSB1c2UgdGhlIGNhY2hlZCB2ZXJzaW9uIG9mIHRoZSByZXNvdXJjZSB3ZSdy ZSBhc2tpbmcgZm9yLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl SGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnb3RIZWFkZXJzQ2FsbGJhY2spOgor CiAyMDExLTAxLTE3ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIE5vdCByZXZpZXdlZDogUXQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApp bmRleCA4OTAwYjE4MDQ3ZDdhYTRhNWQ4MjcxOTE3NTkwYmI3M2ZlNGZkODI5Li4zNjg3NjJjNTZj NzhmM2U0MDcyYzA4NzczMmJkZGQ2NjlkMTAyMDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApA QCAtMjE1LDYgKzIxNSw4IEBAIHN0YXRpYyB2b2lkIHJlc3RhcnRlZENhbGxiYWNrKFNvdXBNZXNz YWdlKiBtc2csIGdwb2ludGVyIGRhdGEpCiAjZW5kaWYKIH0KIAorc3RhdGljIHZvaWQgY29udGVu dFNuaWZmZWRDYWxsYmFjayhTb3VwTWVzc2FnZSosIGNvbnN0IGNoYXIqLCBHSGFzaFRhYmxlKiwg Z3BvaW50ZXIpOworCiBzdGF0aWMgdm9pZCBnb3RIZWFkZXJzQ2FsbGJhY2soU291cE1lc3NhZ2Uq IG1zZywgZ3BvaW50ZXIgZGF0YSkKIHsKICAgICAvLyBGb3IgNDAxLCB3ZSB3aWxsIGFjY3VtdWxh dGUgdGhlIHJlc291cmNlIGJvZHksIGFuZCBvbmx5IHVzZSBpdApAQCAtMjM1LDkgKzIzNywxNyBA QCBzdGF0aWMgdm9pZCBnb3RIZWFkZXJzQ2FsbGJhY2soU291cE1lc3NhZ2UqIG1zZywgZ3BvaW50 ZXIgZGF0YSkKIAogICAgIC8vIFRoZSBjb250ZW50LXNuaWZmZWQgY2FsbGJhY2sgd2lsbCBoYW5k bGUgdGhlIHJlc3BvbnNlIGlmIFdlYkNvcmUKICAgICAvLyByZXF1aXJlIHVzIHRvIHNuaWZmLgot ICAgIGlmICghaGFuZGxlIHx8IHN0YXR1c1dpbGxCZUhhbmRsZWRCeVNvdXAobXNnLT5zdGF0dXNf Y29kZSkgfHwgaGFuZGxlLT5zaG91bGRDb250ZW50U25pZmYoKSkKKyAgICBpZiAoIWhhbmRsZSB8 fCBzdGF0dXNXaWxsQmVIYW5kbGVkQnlTb3VwKG1zZy0+c3RhdHVzX2NvZGUpKQogICAgICAgICBy ZXR1cm47CiAKKyAgICBpZiAoaGFuZGxlLT5zaG91bGRDb250ZW50U25pZmYoKSkKKyAgICAgICAg Ly8gQXZvaWQgTUlNRSB0eXBlIHNuaWZmaW5nIGlmIHRoZSByZXNwb25zZSBjb21lcyBiYWNrIGFz IDMwNCBOb3QgTW9kaWZpZWQuCisgICAgICAgIGlmIChtc2ctPnN0YXR1c19jb2RlID09IFNPVVBf U1RBVFVTX05PVF9NT0RJRklFRCkgeworICAgICAgICAgICAgc291cF9tZXNzYWdlX2Rpc2FibGVf ZmVhdHVyZShtc2csIFNPVVBfVFlQRV9DT05URU5UX1NOSUZGRVIpOworICAgICAgICAgICAgZ19z aWduYWxfaGFuZGxlcnNfZGlzY29ubmVjdF9ieV9mdW5jKG1zZywgcmVpbnRlcnByZXRfY2FzdDxn cG9pbnRlcj4oY29udGVudFNuaWZmZWRDYWxsYmFjayksIGhhbmRsZS5nZXQoKSk7CisgICAgICAg IH0gZWxzZQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5h bCogZCA9IGhhbmRsZS0+Z2V0SW50ZXJuYWwoKTsKICAgICBpZiAoZC0+bV9jYW5jZWxsZWQpCiAg ICAgICAgIHJldHVybjsK