52564 2011-01-17 03:41:37 -0800 Build fails when Inspector is disabled 2011-01-19 01:42:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 annulen webkit-unassigned commit-queue pfeldman oldest_to_newest 335234 0 annulen 2011-01-17 03:41:37 -0800 Attached patch fixes this problem 335236 1 79149 annulen 2011-01-17 03:43:51 -0800 Created attachment 79149 Fixed compilation when Inspector is disabled 335608 2 79149 tkent 2011-01-17 17:49:57 -0800 Comment on attachment 79149 Fixed compilation when Inspector is disabled Looks good. 335761 3 79149 commit-queue 2011-01-18 04:45:11 -0800 Comment on attachment 79149 Fixed compilation when Inspector is disabled Clearing flags on attachment: 79149 Committed r76017: <http://trac.webkit.org/changeset/76017> 335762 4 commit-queue 2011-01-18 04:45:16 -0800 All reviewed patches have been landed. Closing bug. 335777 5 79149 pfeldman 2011-01-18 05:33:01 -0800 Comment on attachment 79149 Fixed compilation when Inspector is disabled This patch is wrong, InspectorInstrumentation:: can be called with no guard. Please roll it out. 335779 6 annulen 2011-01-18 05:35:56 -0800 > This patch is wrong, InspectorInstrumentation:: can be called with no guard. Compilation fails without guard 335789 7 pfeldman 2011-01-18 05:51:00 -0800 (In reply to comment #6) > > This patch is wrong, InspectorInstrumentation:: can be called with no guard. > > Compilation fails without guard I can see Qt Linux minimal bots doing fine before this change and after I rolled it out in the r76018: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/16270. 336396 8 annulen 2011-01-19 01:42:28 -0800 (In reply to comment #7) > (In reply to comment #6) > > > This patch is wrong, InspectorInstrumentation:: can be called with no guard. > > > > Compilation fails without guard > > I can see Qt Linux minimal bots doing fine before this change and after I rolled it out in the r76018: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/16270. You're right, sorry 79149 2011-01-17 03:43:51 -0800 2011-01-18 05:33:01 -0800 Fixed compilation when Inspector is disabled 0001-Fixed-compilation-when-Inspector-is-disabled.patch text/plain 1597 annulen RnJvbSAxNDBmYmI0YzdhOWYwNmJkMGFlNWE5MmRhMTdjN2E4YWJkZTBhYzExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25zdGFudGluIFRva2FyZXYgPGFubnVsZW5AeWFuZGV4LnJ1 PgpEYXRlOiBNb24sIDE3IEphbiAyMDExIDE0OjQyOjU1ICswMzAwClN1YmplY3Q6IFtQQVRDSF0g Rml4ZWQgY29tcGlsYXRpb24gd2hlbiBJbnNwZWN0b3IgaXMgZGlzYWJsZWQKCi0tLQogU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nICAgICB8ICAgMTAgKysrKysrKysrKwogU291cmNlL1dlYkNvcmUv cGFnZS9QYWdlLmNwcCB8ICAgIDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygr KSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjExZjc4NC4uYjAyZjJkYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAxLTE3ICBLb25zdGFudGluIFRva2FyZXYgIDxh bm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXhlZCBjb21waWxhdGlvbiB3aGVuIEluc3BlY3RvciBpcyBkaXNhYmxlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI1NjQKKwor ICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpuZXR3b3JrU3RhdGVD aGFuZ2VkKTogQWRkZWQgRU5BQkxFKElOU1BFQ1RPUikgZ3VhcmQKKwogMjAxMS0wMS0xNiAgUGF2 ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggMDEyYTliZS4uNjA5N2M1 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0xMTIsNyArMTEyLDkgQEAgc3RhdGljIHZvaWQgbmV0 d29ya1N0YXRlQ2hhbmdlZCgpCiAgICAgZm9yIChIYXNoU2V0PFBhZ2UqPjo6aXRlcmF0b3IgaXQg PSBhbGxQYWdlcy0+YmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7CiAgICAgICAgIGZvciAoRnJh bWUqIGZyYW1lID0gKCppdCktPm1haW5GcmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJl ZSgpLT50cmF2ZXJzZU5leHQoKSkKICAgICAgICAgICAgIGZyYW1lcy5hcHBlbmQoZnJhbWUpOwor I2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6 bmV0d29ya1N0YXRlQ2hhbmdlZCgqaXQpOworI2VuZGlmCiAgICAgfQogCiAgICAgQXRvbWljU3Ry aW5nIGV2ZW50TmFtZSA9IG5ldHdvcmtTdGF0ZU5vdGlmaWVyKCkub25MaW5lKCkgPyBldmVudE5h bWVzKCkub25saW5lRXZlbnQgOiBldmVudE5hbWVzKCkub2ZmbGluZUV2ZW50OwotLSAKMS43LjMK Cg==