5256 2005-10-04 05:06:37 -0700 Relayout during load causes duplicate plugin part 2005-12-26 14:08:35 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 VERIFIED FIXED http://www.itpolicy.gov.il/wbt/new/lesson1-7.htm P2 Normal --- 1 mitz hyatt oldest_to_newest 21323 0 mitz 2005-10-04 05:06:37 -0700 It seems that under certain conditions, a relayout operation during the loading of a page that contains plugin content results in a duplicate plugin part being created. To reproduce: open the URL in Safari. Wait for everything to load. Then choose File > Open Location and press the Return key to load the same address. Expected: a single instance of the Flash content. Actual: sometimes, (depending on network/server speed?) I get two instances of the Flash content, one at the correct position, and another one partially occluding the table to the right. Looks like during relayout the object needs to move, but for some reason it is recreated in its new position and the old instance isn't deleted. 21511 1 mjs 2005-10-05 21:31:10 -0700 Could this be due to the fallback content bugs (recently fixed)? 21512 2 mitz 2005-10-05 22:30:38 -0700 (In reply to comment #1) > Could this be due to the fallback content bugs (recently fixed)? > FWIW, it happens with TOT as well as with WebKit-416.9. 21587 3 4259 mitz 2005-10-08 11:45:03 -0700 Created attachment 4259 testcase 21588 4 mitz 2005-10-08 11:49:26 -0700 This is a problem with <OBJECT>s that contain an <EMBED>, if layout is forced in the middle of the OBJECT but before the EMBED. In the testcase, this is done by displaying the JavaScript alert. The result is that both the OBJECT and the EMBED end up being shown. 21614 5 4267 mitz 2005-10-09 11:15:53 -0700 Created attachment 4267 don't update widget until OBJECT tag is closed 21615 6 4267 mitz 2005-10-09 11:19:26 -0700 Comment on attachment 4267 don't update widget until OBJECT tag is closed This patch will be necessary even when bug 5306 is fixed, since it makes no sense to request plugin content before all parameters are known. 21622 7 4267 darin 2005-10-09 13:41:13 -0700 Comment on attachment 4267 don't update widget until OBJECT tag is closed Looks pretty good. I suggest that allParamsAvailable() be a const member function. Also, I think it should be inline since it's just getting the value of a boolean field. Also, I see no reason for it to be virtual. How does this work in the case where you dynamically create an object element and add parameter elements one by one? Or does that not need to work? 21624 8 mitz 2005-10-09 13:59:07 -0700 (In reply to comment #7) > How does this work in the case where you dynamically create an object element > and add parameter elements one by one? Or does that not need to work? Hm... I'm not sure. I don't think there is (or there should be) a way to say "I'm not done with this" (the same questions apply to applet elements, on which this patch is based). Anyway, when bug 5306 is fixed, it will be less of an issue. 21748 9 4301 mitz 2005-10-10 15:21:48 -0700 Created attachment 4301 don't update widget until OBJECT tag is closed 21749 10 4301 mitz 2005-10-10 15:25:59 -0700 Comment on attachment 4301 don't update widget until OBJECT tag is closed Made allParamsAvailable() non-virtual, const and inline. I think the other questions are beyond the scope of this bug/patch. Currently, adding or removing a PARAM triggers an update, but changing the value of a PARAM doesn't. I don't think it makes sense. 22066 11 4356 mitz 2005-10-14 03:43:13 -0700 Created attachment 4356 don't update widget until OBJECT tag is closed Maciej pointed out that the previous patch would break object elements not created by the parser. This fixes it. 22193 12 4356 hyatt 2005-10-17 20:43:25 -0700 Comment on attachment 4356 don't update widget until OBJECT tag is closed r=me 22864 13 bdakin 2005-10-24 17:47:37 -0700 This patch no longer applies cleanly. 22881 14 4470 mitz 2005-10-25 00:04:54 -0700 Created attachment 4470 up-to-date diff The exact same changes, diffed wrt current versions. 23444 15 timothy 2005-11-01 10:35:36 -0800 Landed. Checking in khtml/html/html_objectimpl.cpp; /cvs/root/WebCore/khtml/html/html_objectimpl.cpp,v <-- html_objectimpl.cpp new revision: 1.87; previous revision: 1.86 Checking in khtml/html/html_objectimpl.h; /cvs/root/WebCore/khtml/html/html_objectimpl.h,v <-- html_objectimpl.h new revision: 1.38; previous revision: 1.37 Checking in khtml/html/htmlfactory.cpp; /cvs/root/WebCore/khtml/html/htmlfactory.cpp,v <-- htmlfactory.cpp new revision: 1.9; previous revision: 1.8 Checking in khtml/rendering/render_frames.cpp; /cvs/root/WebCore/khtml/rendering/render_frames.cpp,v <-- render_frames.cpp new revision: 1.83; previous revision: 1.82 4259 2005-10-08 11:45:03 -0700 2005-10-08 11:45:03 -0700 testcase doubleObject.html text/html 731 mitz PGh0bWw+DQo8aGVhZD4KPFRJVExFPkVNQkVEIGluc2lkZSBPQkpFQ1Q8L1RJVExFPg0KPC9oZWFk Pg0KPGJvZHk+CjxvYmplY3QgY2xhc3NpZD0iY2xzaWQ6RDI3Q0RCNkUtQUU2RC0xMWNmLTk2Qjgt NDQ0NTUzNTQwMDAwIiBjb2RlYmFzZT0iaHR0cDovL2Rvd25sb2FkLm1hY3JvbWVkaWEuY29tL3B1 Yi9zaG9ja3dhdmUvY2Ficy9mbGFzaC9zd2ZsYXNoLmNhYiN2ZXJzaW9uPTUsMCwwLDAiIHdpZHRo PSIyMDAiIGhlaWdodD0iMTAwIj4NCiAgICA8cGFyYW0gbmFtZT1tb3ZpZSB2YWx1ZT0iaHR0cDov L2ljZS5jby5pbC9CYW5uZXJzL2ltYWdlcy9CYW5uZXJzL0VVMjAweDU1U2xvdy5zd2YiPg0KICAg IDxwYXJhbSBuYW1lPXF1YWxpdHkgdmFsdWU9aGlnaD4KICAgIDxzY3JpcHQgdHlwZT0idGV4dC9q YXZhc2NyaXB0Ij5hbGVydCgnSXQgaXMgbm93IHNhZmUgdG8gY2xpY2sgdGhlIE9LIGJ1dHRvbicp Ozwvc2NyaXB0Pg0KICAgIDxlbWJlZCBzcmM9Imh0dHA6Ly93d3cuaWNlLmNvLmlsL2ltZy9mbGFz aC9iYW5uZXI1LnN3ZiIgcXVhbGl0eT1oaWdoIHBsdWdpbnNwYWdlPSJodHRwOi8vd3d3Lm1hY3Jv bWVkaWEuY29tL3Nob2Nrd2F2ZS9kb3dubG9hZC9pbmRleC5jZ2k/UDFfUHJvZF9WZXJzaW9uPVNo b2Nrd2F2ZUZsYXNoIiB0eXBlPSJhcHBsaWNhdGlvbi94LXNob2Nrd2F2ZS1mbGFzaCIgd2lkdGg9 IjEwMCIgaGVpZ2h0PSIyMDAiPg0KPC9vYmplY3Q+CjwvYm9keT4NCjwvaHRtbD4= 4267 2005-10-09 11:15:53 -0700 2005-10-10 15:21:48 -0700 don't update widget until OBJECT tag is closed 5256_r1.patch text/plain 2973 mitz SW5kZXg6IGh0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz L3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuODEKZGlmZiAtcCAtdSAtcjEuODEgaHRtbF9vYmplY3RpbXBsLmNwcAotLS0g aHRtbC9odG1sX29iamVjdGltcGwuY3BwCTUgT2N0IDIwMDUgMDg6MTg6MjYgLTAwMDAJMS44MQor KysgaHRtbC9odG1sX29iamVjdGltcGwuY3BwCTkgT2N0IDIwMDUgMTg6MTc6MDQgLTAwMDAKQEAg LTU2MSw2ICs1NjEsNyBAQCBIVE1MT2JqZWN0RWxlbWVudEltcGw6OkhUTUxPYmplY3RFbGVtZW50 CiB7CiAgICAgbmVlZFdpZGdldFVwZGF0ZSA9IGZhbHNlOwogICAgIG1fdXNlRmFsbGJhY2tDb250 ZW50ID0gZmFsc2U7CisgICAgbV9hbGxQYXJhbXNBdmFpbGFibGUgPSBmYWxzZTsKIH0KIAogSFRN TE9iamVjdEVsZW1lbnRJbXBsOjp+SFRNTE9iamVjdEVsZW1lbnRJbXBsKCkKQEAgLTc2Myw2ICs3 NjQsMjMgQEAgdm9pZCBIVE1MT2JqZWN0RWxlbWVudEltcGw6OmF0dGFjaCgpCiAgICAgfQogfQog Cit2b2lkIEhUTUxPYmplY3RFbGVtZW50SW1wbDo6Y2xvc2VSZW5kZXJlcigpCit7CisgICAgLy8g VGhlIHBhcnNlciBqdXN0IHJlYWNoZWQgPC9vYmplY3Q+LCBzbyBhbGwgdGhlIHBhcmFtcyBhcmUg YXZhaWxhYmxlIG5vdy4KKyAgICBtX2FsbFBhcmFtc0F2YWlsYWJsZSA9IHRydWU7CisgICAgaWYg KGluRG9jdW1lbnQoKSAmJiAhbV91c2VGYWxsYmFja0NvbnRlbnQpIHsKKyAgICAgICAgbmVlZFdp ZGdldFVwZGF0ZSA9IHRydWU7CisgICAgICAgIHNldENoYW5nZWQoKTsKKyAgICB9CisgICAgCisg ICAgSFRNTEVsZW1lbnRJbXBsOjpjbG9zZVJlbmRlcmVyKCk7Cit9CisKK2Jvb2wgSFRNTE9iamVj dEVsZW1lbnRJbXBsOjphbGxQYXJhbXNBdmFpbGFibGUoKQoreworICAgIHJldHVybiBtX2FsbFBh cmFtc0F2YWlsYWJsZTsKK30KKwogdm9pZCBIVE1MT2JqZWN0RWxlbWVudEltcGw6OmRldGFjaCgp CiB7CiAgICAgLy8gT25seSBib3RoZXIgd2l0aCBhbiB1bmxvYWQgZXZlbnQgaWYgd2UgaGFkIGEg cmVuZGVyIG9iamVjdC4gIC0gZHdoCkluZGV4OiBodG1sL2h0bWxfb2JqZWN0aW1wbC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL2h0bWwvaHRtbF9vYmplY3Rp bXBsLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzYKZGlmZiAtcCAtdSAtcjEuMzYgaHRtbF9v YmplY3RpbXBsLmgKLS0tIGh0bWwvaHRtbF9vYmplY3RpbXBsLmgJMTYgU2VwIDIwMDUgMjI6NDI6 MTIgLTAwMDAJMS4zNgorKysgaHRtbC9odG1sX29iamVjdGltcGwuaAk5IE9jdCAyMDA1IDE4OjE3 OjA0IC0wMDAwCkBAIC0xNzAsNiArMTcwLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBh dHRhY2goKTsKICAgICB2aXJ0dWFsIGJvb2wgcmVuZGVyZXJJc05lZWRlZChraHRtbDo6UmVuZGVy U3R5bGUgKik7CiAgICAgdmlydHVhbCBraHRtbDo6UmVuZGVyT2JqZWN0ICpjcmVhdGVSZW5kZXJl cihSZW5kZXJBcmVuYSAqLCBraHRtbDo6UmVuZGVyU3R5bGUgKik7CisgICAgdmlydHVhbCB2b2lk IGNsb3NlUmVuZGVyZXIoKTsKICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCk7CiAgICAgdmlydHVh bCB2b2lkIGluc2VydGVkSW50b0RvY3VtZW50KCk7CiAgICAgdmlydHVhbCB2b2lkIHJlbW92ZWRG cm9tRG9jdW1lbnQoKTsKQEAgLTIzNiw2ICsyMzcsNyBAQCBwdWJsaWM6CiAgICAgRE9NU3RyaW5n IHdpZHRoKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRXaWR0aChjb25zdCBET01TdHJpbmcgJik7CiAK KyAgICB2aXJ0dWFsIGJvb2wgYWxsUGFyYW1zQXZhaWxhYmxlKCk7CiAjaWYgQVBQTEVfQ0hBTkdF UwogICAgIEtKUzo6QmluZGluZ3M6Okluc3RhbmNlICpnZXRPYmplY3RJbnN0YW5jZSgpIGNvbnN0 OwogI2VuZGlmCkBAIC0yNTMsNiArMjU1LDcgQEAgcHJpdmF0ZToKICNpZiBBUFBMRV9DSEFOR0VT CiAgICAgbXV0YWJsZSBLSlM6OkJpbmRpbmdzOjpJbnN0YW5jZSAqb2JqZWN0SW5zdGFuY2U7CiAj ZW5kaWYKKyAgICBib29sIG1fYWxsUGFyYW1zQXZhaWxhYmxlOwogfTsKIAogLy8gLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQpJbmRleDogcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNw cCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43OApkaWZmIC1wIC11IC1yMS43OCByZW5kZXJfZnJh bWVzLmNwcAotLS0gcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCTMgT2N0IDIwMDUgMjE6MTI6 MzkgLTAwMDAJMS43OAorKysgcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCTkgT2N0IDIwMDUg MTg6MTc6MDQgLTAwMDAKQEAgLTY3NSw2ICs2NzUsOCBAQCB2b2lkIFJlbmRlclBhcnRPYmplY3Q6 OnVwZGF0ZVdpZGdldCgpCiAKICAgICAgIEhUTUxPYmplY3RFbGVtZW50SW1wbCAqbyA9IHN0YXRp Y19jYXN0PEhUTUxPYmplY3RFbGVtZW50SW1wbCAqPihlbGVtZW50KCkpOwogCisgICAgICBpZiAo IW8tPmFsbFBhcmFtc0F2YWlsYWJsZSgpKQorICAgICAgICByZXR1cm47CiAgICAgICAvLyBDaGVj ayBmb3IgYSBjaGlsZCBFTUJFRCB0YWcuCiAgICAgICBIVE1MRW1iZWRFbGVtZW50SW1wbCAqZW1i ZWQgPSAwOwogICAgICAgZm9yIChOb2RlSW1wbCAqY2hpbGQgPSBvLT5maXJzdENoaWxkKCk7IGNo aWxkOyApIHsK 4301 2005-10-10 15:21:48 -0700 2005-10-14 03:44:15 -0700 don't update widget until OBJECT tag is closed 5256_r2.patch text/plain 2914 mitz SW5kZXg6IGh0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz L3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuODEKZGlmZiAtcCAtdSAtcjEuODEgaHRtbF9vYmplY3RpbXBsLmNwcAotLS0g aHRtbC9odG1sX29iamVjdGltcGwuY3BwCTUgT2N0IDIwMDUgMDg6MTg6MjYgLTAwMDAJMS44MQor KysgaHRtbC9odG1sX29iamVjdGltcGwuY3BwCTEwIE9jdCAyMDA1IDIyOjA3OjQ1IC0wMDAwCkBA IC01NjEsNiArNTYxLDcgQEAgSFRNTE9iamVjdEVsZW1lbnRJbXBsOjpIVE1MT2JqZWN0RWxlbWVu dAogewogICAgIG5lZWRXaWRnZXRVcGRhdGUgPSBmYWxzZTsKICAgICBtX3VzZUZhbGxiYWNrQ29u dGVudCA9IGZhbHNlOworICAgIG1fYWxsUGFyYW1zQXZhaWxhYmxlID0gZmFsc2U7CiB9CiAKIEhU TUxPYmplY3RFbGVtZW50SW1wbDo6fkhUTUxPYmplY3RFbGVtZW50SW1wbCgpCkBAIC03NjMsNiAr NzY0LDE4IEBAIHZvaWQgSFRNTE9iamVjdEVsZW1lbnRJbXBsOjphdHRhY2goKQogICAgIH0KIH0K IAordm9pZCBIVE1MT2JqZWN0RWxlbWVudEltcGw6OmNsb3NlUmVuZGVyZXIoKQoreworICAgIC8v IFRoZSBwYXJzZXIganVzdCByZWFjaGVkIDwvb2JqZWN0Piwgc28gYWxsIHRoZSBwYXJhbXMgYXJl IGF2YWlsYWJsZSBub3cuCisgICAgbV9hbGxQYXJhbXNBdmFpbGFibGUgPSB0cnVlOworICAgIGlm IChpbkRvY3VtZW50KCkgJiYgIW1fdXNlRmFsbGJhY2tDb250ZW50KSB7CisgICAgICAgIG5lZWRX aWRnZXRVcGRhdGUgPSB0cnVlOworICAgICAgICBzZXRDaGFuZ2VkKCk7CisgICAgfQorICAgIAor ICAgIEhUTUxFbGVtZW50SW1wbDo6Y2xvc2VSZW5kZXJlcigpOworfQorCiB2b2lkIEhUTUxPYmpl Y3RFbGVtZW50SW1wbDo6ZGV0YWNoKCkKIHsKICAgICAvLyBPbmx5IGJvdGhlciB3aXRoIGFuIHVu bG9hZCBldmVudCBpZiB3ZSBoYWQgYSByZW5kZXIgb2JqZWN0LiAgLSBkd2gKSW5kZXg6IGh0bWwv aHRtbF9vYmplY3RpbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUv a2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zNgpk aWZmIC1wIC11IC1yMS4zNiBodG1sX29iamVjdGltcGwuaAotLS0gaHRtbC9odG1sX29iamVjdGlt cGwuaAkxNiBTZXAgMjAwNSAyMjo0MjoxMiAtMDAwMAkxLjM2CisrKyBodG1sL2h0bWxfb2JqZWN0 aW1wbC5oCTEwIE9jdCAyMDA1IDIyOjA3OjQ1IC0wMDAwCkBAIC0xNzAsNiArMTcwLDcgQEAgcHVi bGljOgogICAgIHZpcnR1YWwgdm9pZCBhdHRhY2goKTsKICAgICB2aXJ0dWFsIGJvb2wgcmVuZGVy ZXJJc05lZWRlZChraHRtbDo6UmVuZGVyU3R5bGUgKik7CiAgICAgdmlydHVhbCBraHRtbDo6UmVu ZGVyT2JqZWN0ICpjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSAqLCBraHRtbDo6UmVuZGVyU3R5 bGUgKik7CisgICAgdmlydHVhbCB2b2lkIGNsb3NlUmVuZGVyZXIoKTsKICAgICB2aXJ0dWFsIHZv aWQgZGV0YWNoKCk7CiAgICAgdmlydHVhbCB2b2lkIGluc2VydGVkSW50b0RvY3VtZW50KCk7CiAg ICAgdmlydHVhbCB2b2lkIHJlbW92ZWRGcm9tRG9jdW1lbnQoKTsKQEAgLTIzNiw2ICsyMzcsNyBA QCBwdWJsaWM6CiAgICAgRE9NU3RyaW5nIHdpZHRoKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRXaWR0 aChjb25zdCBET01TdHJpbmcgJik7CiAKKyAgICBib29sIGFsbFBhcmFtc0F2YWlsYWJsZSgpIGNv bnN0IHsgcmV0dXJuIG1fYWxsUGFyYW1zQXZhaWxhYmxlOyB9CiAjaWYgQVBQTEVfQ0hBTkdFUwog ICAgIEtKUzo6QmluZGluZ3M6Okluc3RhbmNlICpnZXRPYmplY3RJbnN0YW5jZSgpIGNvbnN0Owog I2VuZGlmCkBAIC0yNTMsNiArMjU1LDcgQEAgcHJpdmF0ZToKICNpZiBBUFBMRV9DSEFOR0VTCiAg ICAgbXV0YWJsZSBLSlM6OkJpbmRpbmdzOjpJbnN0YW5jZSAqb2JqZWN0SW5zdGFuY2U7CiAjZW5k aWYKKyAgICBib29sIG1fYWxsUGFyYW1zQXZhaWxhYmxlOwogfTsKIAogLy8gLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQpJbmRleDogcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNwcCx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS43OApkaWZmIC1wIC11IC1yMS43OCByZW5kZXJfZnJhbWVz LmNwcAotLS0gcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCTMgT2N0IDIwMDUgMjE6MTI6Mzkg LTAwMDAJMS43OAorKysgcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCTEwIE9jdCAyMDA1IDIy OjA3OjQ2IC0wMDAwCkBAIC02NzUsNiArNjc1LDggQEAgdm9pZCBSZW5kZXJQYXJ0T2JqZWN0Ojp1 cGRhdGVXaWRnZXQoKQogCiAgICAgICBIVE1MT2JqZWN0RWxlbWVudEltcGwgKm8gPSBzdGF0aWNf Y2FzdDxIVE1MT2JqZWN0RWxlbWVudEltcGwgKj4oZWxlbWVudCgpKTsKIAorICAgICAgaWYgKCFv LT5hbGxQYXJhbXNBdmFpbGFibGUoKSkKKyAgICAgICAgcmV0dXJuOwogICAgICAgLy8gQ2hlY2sg Zm9yIGEgY2hpbGQgRU1CRUQgdGFnLgogICAgICAgSFRNTEVtYmVkRWxlbWVudEltcGwgKmVtYmVk ID0gMDsKICAgICAgIGZvciAoTm9kZUltcGwgKmNoaWxkID0gby0+Zmlyc3RDaGlsZCgpOyBjaGls ZDsgKSB7Cg== 4356 2005-10-14 03:43:13 -0700 2005-10-17 20:43:25 -0700 don't update widget until OBJECT tag is closed 5256_r3.patch text/plain 3938 mitz SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuODEKZGlmZiAtcCAtdSAtcjEuODEgaHRtbF9vYmplY3RpbXBsLmNw cAotLS0ga2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuY3BwCTUgT2N0IDIwMDUgMDg6MTg6MjYg LTAwMDAJMS44MQorKysga2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuY3BwCTE0IE9jdCAyMDA1 IDEwOjQxOjEzIC0wMDAwCkBAIC01NjEsNiArNTYxLDcgQEAgSFRNTE9iamVjdEVsZW1lbnRJbXBs OjpIVE1MT2JqZWN0RWxlbWVudAogewogICAgIG5lZWRXaWRnZXRVcGRhdGUgPSBmYWxzZTsKICAg ICBtX3VzZUZhbGxiYWNrQ29udGVudCA9IGZhbHNlOworICAgIG1fY29tcGxldGUgPSBmYWxzZTsK IH0KIAogSFRNTE9iamVjdEVsZW1lbnRJbXBsOjp+SFRNTE9iamVjdEVsZW1lbnRJbXBsKCkKQEAg LTc2Myw2ICs3NjQsMjUgQEAgdm9pZCBIVE1MT2JqZWN0RWxlbWVudEltcGw6OmF0dGFjaCgpCiAg ICAgfQogfQogCit2b2lkIEhUTUxPYmplY3RFbGVtZW50SW1wbDo6Y2xvc2VSZW5kZXJlcigpCit7 CisgICAgLy8gVGhlIHBhcnNlciBqdXN0IHJlYWNoZWQgPC9vYmplY3Q+LgorICAgIHNldENvbXBs ZXRlKHRydWUpOworICAgIAorICAgIEhUTUxFbGVtZW50SW1wbDo6Y2xvc2VSZW5kZXJlcigpOwor fQorCit2b2lkIEhUTUxPYmplY3RFbGVtZW50SW1wbDo6c2V0Q29tcGxldGUoYm9vbCBjb21wbGV0 ZSkKK3sKKyAgICBpZiAoY29tcGxldGUgIT0gbV9jb21wbGV0ZSkgeworICAgICAgICBtX2NvbXBs ZXRlID0gY29tcGxldGU7CisgICAgICAgIGlmIChjb21wbGV0ZSAmJiBpbkRvY3VtZW50KCkgJiYg IW1fdXNlRmFsbGJhY2tDb250ZW50KSB7CisgICAgICAgICAgICBuZWVkV2lkZ2V0VXBkYXRlID0g dHJ1ZTsKKyAgICAgICAgICAgIHNldENoYW5nZWQoKTsKKyAgICAgICAgfQorICAgIH0KK30KKwog dm9pZCBIVE1MT2JqZWN0RWxlbWVudEltcGw6OmRldGFjaCgpCiB7CiAgICAgLy8gT25seSBib3Ro ZXIgd2l0aCBhbiB1bmxvYWQgZXZlbnQgaWYgd2UgaGFkIGEgcmVuZGVyIG9iamVjdC4gIC0gZHdo CkluZGV4OiBraHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmgsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMzYKZGlmZiAtcCAtdSAtcjEuMzYgaHRtbF9vYmplY3RpbXBsLmgKLS0t IGtodG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmgJMTYgU2VwIDIwMDUgMjI6NDI6MTIgLTAwMDAJ MS4zNgorKysga2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuaAkxNCBPY3QgMjAwNSAxMDo0MTox MyAtMDAwMApAQCAtMTcwLDYgKzE3MCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgYXR0 YWNoKCk7CiAgICAgdmlydHVhbCBib29sIHJlbmRlcmVySXNOZWVkZWQoa2h0bWw6OlJlbmRlclN0 eWxlICopOwogICAgIHZpcnR1YWwga2h0bWw6OlJlbmRlck9iamVjdCAqY3JlYXRlUmVuZGVyZXIo UmVuZGVyQXJlbmEgKiwga2h0bWw6OlJlbmRlclN0eWxlICopOworICAgIHZpcnR1YWwgdm9pZCBj bG9zZVJlbmRlcmVyKCk7CiAgICAgdmlydHVhbCB2b2lkIGRldGFjaCgpOwogICAgIHZpcnR1YWwg dm9pZCBpbnNlcnRlZEludG9Eb2N1bWVudCgpOwogICAgIHZpcnR1YWwgdm9pZCByZW1vdmVkRnJv bURvY3VtZW50KCk7CkBAIC0yMzYsNiArMjM3LDggQEAgcHVibGljOgogICAgIERPTVN0cmluZyB3 aWR0aCgpIGNvbnN0OwogICAgIHZvaWQgc2V0V2lkdGgoY29uc3QgRE9NU3RyaW5nICYpOwogCisg ICAgYm9vbCBpc0NvbXBsZXRlKCkgY29uc3QgeyByZXR1cm4gbV9jb21wbGV0ZTsgfQorICAgIHZv aWQgc2V0Q29tcGxldGUoYm9vbCBjb21wbGV0ZSk7CiAjaWYgQVBQTEVfQ0hBTkdFUwogICAgIEtK Uzo6QmluZGluZ3M6Okluc3RhbmNlICpnZXRPYmplY3RJbnN0YW5jZSgpIGNvbnN0OwogI2VuZGlm CkBAIC0yNTMsNiArMjU2LDcgQEAgcHJpdmF0ZToKICNpZiBBUFBMRV9DSEFOR0VTCiAgICAgbXV0 YWJsZSBLSlM6OkJpbmRpbmdzOjpJbnN0YW5jZSAqb2JqZWN0SW5zdGFuY2U7CiAjZW5kaWYKKyAg ICBib29sIG1fY29tcGxldGU7CiB9OwogCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkluZGV4OiBraHRt bC9odG1sL2h0bWxmYWN0b3J5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2Vi Q29yZS9raHRtbC9odG1sL2h0bWxmYWN0b3J5LmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44 CmRpZmYgLXAgLXUgLXIxLjggaHRtbGZhY3RvcnkuY3BwCi0tLSBraHRtbC9odG1sL2h0bWxmYWN0 b3J5LmNwcAkzIE9jdCAyMDA1IDIxOjEyOjMwIC0wMDAwCTEuOAorKysga2h0bWwvaHRtbC9odG1s ZmFjdG9yeS5jcHAJMTQgT2N0IDIwMDUgMTA6NDE6MTQgLTAwMDAKQEAgLTI2OSw3ICsyNjksOSBA QCBIVE1MRWxlbWVudEltcGwqIGVtYmVkQ29uc3RydWN0b3IoY29uc3QgCiAKIEhUTUxFbGVtZW50 SW1wbCogb2JqZWN0Q29uc3RydWN0b3IoY29uc3QgQXRvbWljU3RyaW5nJiB0YWdOYW1lLCBEb2N1 bWVudFB0ciogZG9jUHRyLCBIVE1MRm9ybUVsZW1lbnRJbXBsKiBmb3JtLCBib29sIGNyZWF0ZWRC eVBhcnNlcikKIHsKLSAgICByZXR1cm4gbmV3IEhUTUxPYmplY3RFbGVtZW50SW1wbChkb2NQdHIp OworICAgIEhUTUxPYmplY3RFbGVtZW50SW1wbCAqIG9iamVjdCA9IG5ldyBIVE1MT2JqZWN0RWxl bWVudEltcGwoZG9jUHRyKTsKKyAgICBvYmplY3QtPnNldENvbXBsZXRlKCFjcmVhdGVkQnlQYXJz ZXIpOworICAgIHJldHVybiBvYmplY3Q7CiB9CiAKIEhUTUxFbGVtZW50SW1wbCogcGFyYW1Db25z dHJ1Y3Rvcihjb25zdCBBdG9taWNTdHJpbmcmIHRhZ05hbWUsIERvY3VtZW50UHRyKiBkb2NQdHIs IEhUTUxGb3JtRWxlbWVudEltcGwqIGZvcm0sIGJvb2wgY3JlYXRlZEJ5UGFyc2VyKQpJbmRleDog a2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNwcCx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS43OApkaWZmIC1wIC11IC1yMS43OCByZW5kZXJfZnJhbWVzLmNwcAot LS0ga2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCTMgT2N0IDIwMDUgMjE6MTI6Mzkg LTAwMDAJMS43OAorKysga2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCTE0IE9jdCAy MDA1IDEwOjQxOjE0IC0wMDAwCkBAIC02NzUsNiArNjc1LDggQEAgdm9pZCBSZW5kZXJQYXJ0T2Jq ZWN0Ojp1cGRhdGVXaWRnZXQoKQogCiAgICAgICBIVE1MT2JqZWN0RWxlbWVudEltcGwgKm8gPSBz dGF0aWNfY2FzdDxIVE1MT2JqZWN0RWxlbWVudEltcGwgKj4oZWxlbWVudCgpKTsKIAorICAgICAg aWYgKCFvLT5pc0NvbXBsZXRlKCkpCisgICAgICAgIHJldHVybjsKICAgICAgIC8vIENoZWNrIGZv ciBhIGNoaWxkIEVNQkVEIHRhZy4KICAgICAgIEhUTUxFbWJlZEVsZW1lbnRJbXBsICplbWJlZCA9 IDA7CiAgICAgICBmb3IgKE5vZGVJbXBsICpjaGlsZCA9IG8tPmZpcnN0Q2hpbGQoKTsgY2hpbGQ7 ICkgewo= 4470 2005-10-25 00:04:54 -0700 2005-10-25 00:04:54 -0700 up-to-date diff 5256_r4.patch text/plain 3925 mitz SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuODQKZGlmZiAtcCAtdSAtcjEuODQgaHRtbF9vYmplY3RpbXBsLmNw cAotLS0ga2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuY3BwCTI0IE9jdCAyMDA1IDIxOjQyOjE0 IC0wMDAwCTEuODQKKysrIGtodG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAkyNSBPY3QgMjAw NSAwNzowMzoyNyAtMDAwMApAQCAtNTYyLDYgKzU2Miw3IEBAIEhUTUxPYmplY3RFbGVtZW50SW1w bDo6SFRNTE9iamVjdEVsZW1lbnQKIHsKICAgICBuZWVkV2lkZ2V0VXBkYXRlID0gZmFsc2U7CiAg ICAgbV91c2VGYWxsYmFja0NvbnRlbnQgPSBmYWxzZTsKKyAgICBtX2NvbXBsZXRlID0gZmFsc2U7 CiAgICAgbV9kb2NOYW1lZEl0ZW0gPSB0cnVlOwogfQogCkBAIC03NjUsNiArNzY2LDI1IEBAIHZv aWQgSFRNTE9iamVjdEVsZW1lbnRJbXBsOjphdHRhY2goKQogICAgIH0KIH0KIAordm9pZCBIVE1M T2JqZWN0RWxlbWVudEltcGw6OmNsb3NlUmVuZGVyZXIoKQoreworICAgIC8vIFRoZSBwYXJzZXIg anVzdCByZWFjaGVkIDwvb2JqZWN0Pi4KKyAgICBzZXRDb21wbGV0ZSh0cnVlKTsKKyAgICAKKyAg ICBIVE1MRWxlbWVudEltcGw6OmNsb3NlUmVuZGVyZXIoKTsKK30KKwordm9pZCBIVE1MT2JqZWN0 RWxlbWVudEltcGw6OnNldENvbXBsZXRlKGJvb2wgY29tcGxldGUpCit7CisgICAgaWYgKGNvbXBs ZXRlICE9IG1fY29tcGxldGUpIHsKKyAgICAgICAgbV9jb21wbGV0ZSA9IGNvbXBsZXRlOworICAg ICAgICBpZiAoY29tcGxldGUgJiYgaW5Eb2N1bWVudCgpICYmICFtX3VzZUZhbGxiYWNrQ29udGVu dCkgeworICAgICAgICAgICAgbmVlZFdpZGdldFVwZGF0ZSA9IHRydWU7CisgICAgICAgICAgICBz ZXRDaGFuZ2VkKCk7CisgICAgICAgIH0KKyAgICB9Cit9CisKIHZvaWQgSFRNTE9iamVjdEVsZW1l bnRJbXBsOjpkZXRhY2goKQogewogICAgIC8vIE9ubHkgYm90aGVyIHdpdGggYW4gdW5sb2FkIGV2 ZW50IGlmIHdlIGhhZCBhIHJlbmRlciBvYmplY3QuICAtIGR3aApJbmRleDoga2h0bWwvaHRtbC9o dG1sX29iamVjdGltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9r aHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjM3CmRp ZmYgLXAgLXUgLXIxLjM3IGh0bWxfb2JqZWN0aW1wbC5oCi0tLSBraHRtbC9odG1sL2h0bWxfb2Jq ZWN0aW1wbC5oCTI0IE9jdCAyMDA1IDIxOjQyOjE0IC0wMDAwCTEuMzcKKysrIGtodG1sL2h0bWwv aHRtbF9vYmplY3RpbXBsLmgJMjUgT2N0IDIwMDUgMDc6MDM6MjcgLTAwMDAKQEAgLTE3MCw2ICsx NzAsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGF0dGFjaCgpOwogICAgIHZpcnR1YWwg Ym9vbCByZW5kZXJlcklzTmVlZGVkKGtodG1sOjpSZW5kZXJTdHlsZSAqKTsKICAgICB2aXJ0dWFs IGtodG1sOjpSZW5kZXJPYmplY3QgKmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hICosIGtodG1s OjpSZW5kZXJTdHlsZSAqKTsKKyAgICB2aXJ0dWFsIHZvaWQgY2xvc2VSZW5kZXJlcigpOwogICAg IHZpcnR1YWwgdm9pZCBkZXRhY2goKTsKICAgICB2aXJ0dWFsIHZvaWQgaW5zZXJ0ZWRJbnRvRG9j dW1lbnQoKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlZEZyb21Eb2N1bWVudCgpOwpAQCAtMjM2 LDYgKzIzNyw5IEBAIHB1YmxpYzoKICAgICBET01TdHJpbmcgd2lkdGgoKSBjb25zdDsKICAgICB2 b2lkIHNldFdpZHRoKGNvbnN0IERPTVN0cmluZyAmKTsKIAorICAgIGJvb2wgaXNDb21wbGV0ZSgp IGNvbnN0IHsgcmV0dXJuIG1fY29tcGxldGU7IH0KKyAgICB2b2lkIHNldENvbXBsZXRlKGJvb2wg Y29tcGxldGUpOworICAgIAogICAgIGJvb2wgaXNEb2NOYW1lZEl0ZW0oKSBjb25zdCB7IHJldHVy biBtX2RvY05hbWVkSXRlbTsgfQogI2lmIEFQUExFX0NIQU5HRVMKICAgICBLSlM6OkJpbmRpbmdz OjpJbnN0YW5jZSAqZ2V0T2JqZWN0SW5zdGFuY2UoKSBjb25zdDsKQEAgLTI1NSw2ICsyNTksNyBA QCBwcml2YXRlOgogI2lmIEFQUExFX0NIQU5HRVMKICAgICBtdXRhYmxlIEtKUzo6QmluZGluZ3M6 Okluc3RhbmNlICpvYmplY3RJbnN0YW5jZTsKICNlbmRpZgorICAgIGJvb2wgbV9jb21wbGV0ZTsK ICAgICBib29sIG1fZG9jTmFtZWRJdGVtOwogfTsKIApJbmRleDoga2h0bWwvaHRtbC9odG1sZmFj dG9yeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRt bC9odG1sZmFjdG9yeS5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOApkaWZmIC1wIC11IC1y MS44IGh0bWxmYWN0b3J5LmNwcAotLS0ga2h0bWwvaHRtbC9odG1sZmFjdG9yeS5jcHAJMyBPY3Qg MjAwNSAyMToxMjozMCAtMDAwMAkxLjgKKysrIGtodG1sL2h0bWwvaHRtbGZhY3RvcnkuY3BwCTI1 IE9jdCAyMDA1IDA3OjAzOjI3IC0wMDAwCkBAIC0yNjksNyArMjY5LDkgQEAgSFRNTEVsZW1lbnRJ bXBsKiBlbWJlZENvbnN0cnVjdG9yKGNvbnN0IAogCiBIVE1MRWxlbWVudEltcGwqIG9iamVjdENv bnN0cnVjdG9yKGNvbnN0IEF0b21pY1N0cmluZyYgdGFnTmFtZSwgRG9jdW1lbnRQdHIqIGRvY1B0 ciwgSFRNTEZvcm1FbGVtZW50SW1wbCogZm9ybSwgYm9vbCBjcmVhdGVkQnlQYXJzZXIpCiB7Ci0g ICAgcmV0dXJuIG5ldyBIVE1MT2JqZWN0RWxlbWVudEltcGwoZG9jUHRyKTsKKyAgICBIVE1MT2Jq ZWN0RWxlbWVudEltcGwgKiBvYmplY3QgPSBuZXcgSFRNTE9iamVjdEVsZW1lbnRJbXBsKGRvY1B0 cik7CisgICAgb2JqZWN0LT5zZXRDb21wbGV0ZSghY3JlYXRlZEJ5UGFyc2VyKTsKKyAgICByZXR1 cm4gb2JqZWN0OwogfQogCiBIVE1MRWxlbWVudEltcGwqIHBhcmFtQ29uc3RydWN0b3IoY29uc3Qg QXRvbWljU3RyaW5nJiB0YWdOYW1lLCBEb2N1bWVudFB0ciogZG9jUHRyLCBIVE1MRm9ybUVsZW1l bnRJbXBsKiBmb3JtLCBib29sIGNyZWF0ZWRCeVBhcnNlcikKSW5kZXg6IGtodG1sL3JlbmRlcmlu Zy9yZW5kZXJfZnJhbWVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29y ZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuODEKZGlmZiAtcCAtdSAtcjEuODEgcmVuZGVyX2ZyYW1lcy5jcHAKLS0tIGtodG1sL3JlbmRl cmluZy9yZW5kZXJfZnJhbWVzLmNwcAkxOSBPY3QgMjAwNSAwOToxNToxNCAtMDAwMAkxLjgxCisr KyBraHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMjUgT2N0IDIwMDUgMDc6MDM6Mjgg LTAwMDAKQEAgLTY3NSw2ICs2NzUsOCBAQCB2b2lkIFJlbmRlclBhcnRPYmplY3Q6OnVwZGF0ZVdp ZGdldCgpCiAKICAgICAgIEhUTUxPYmplY3RFbGVtZW50SW1wbCAqbyA9IHN0YXRpY19jYXN0PEhU TUxPYmplY3RFbGVtZW50SW1wbCAqPihlbGVtZW50KCkpOwogCisgICAgICBpZiAoIW8tPmlzQ29t cGxldGUoKSkKKyAgICAgICAgcmV0dXJuOwogICAgICAgLy8gQ2hlY2sgZm9yIGEgY2hpbGQgRU1C RUQgdGFnLgogICAgICAgSFRNTEVtYmVkRWxlbWVudEltcGwgKmVtYmVkID0gMDsKICAgICAgIGZv ciAoTm9kZUltcGwgKmNoaWxkID0gby0+Zmlyc3RDaGlsZCgpOyBjaGlsZDsgKSB7Cg==