52556 2011-01-17 00:03:35 -0800 [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass 2011-01-17 01:26:10 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 52559 0 helder webkit-unassigned commit-queue kling mdelaney7 oldest_to_newest 335173 0 helder 2011-01-17 00:03:35 -0800 The shadow color opacity needs to be set on the shadow painter. Additionally, the gradient brush should be transformed. 335176 1 79133 helder 2011-01-17 00:06:21 -0800 Created attachment 79133 Patch 335203 2 79133 commit-queue 2011-01-17 01:26:05 -0800 Comment on attachment 79133 Patch Clearing flags on attachment: 79133 Committed r75927: <http://trac.webkit.org/changeset/75927> 335204 3 commit-queue 2011-01-17 01:26:10 -0800 All reviewed patches have been landed. Closing bug. 79133 2011-01-17 00:06:21 -0800 2011-01-17 01:26:05 -0800 Patch bug-52556-20110117000619.patch text/plain 3467 helder ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMjEwZGM0YzYzNTlkODY1NWJlY2VmY2YzYmUyMmVjZjc1NWFmMjc0Li45OTMwZTRl ZjliM2ZjOTE5MDQyNDFhYjc1YTkxMDViZDRkMDg1NThiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDEtMTcgIEhlbGRlciBDb3JyZWlhICA8aGVsZGVyQHNlbmNoYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBmYXN0L2NhbnZh cy9jYW52YXMtZmlsbFBhdGgtZ3JhZGllbnQtc2hhZG93Lmh0bWwgZG9lcyBub3QgcGFzcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI1NTYKKworICAg ICAgICBUaGUgc2hhZG93IGNvbG9yIG9wYWNpdHkgbmVlZHMgdG8gYmUgc2V0IG9uIHRoZSBzaGFk b3cgcGFpbnRlci4KKyAgICAgICAgQWRkaXRpb25hbGx5LCB0aGUgZ3JhZGllbnQgYnJ1c2ggc2hv dWxkIGJlIHRyYW5zZm9ybWVkLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDogUmVt b3ZlIHRlc3QgZnJvbSBza2lwcGVkIGxpc3QuCisKIDIwMTEtMDEtMTYgIE9saXZlciBIdW50ICA8 b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IDUwNThhMTU4MmUzNjVmOGNhZGE4ZTA4MDNkODhh NDdmNThkNTRhYTYuLjkzOGE1Yzc3YzY5MjRkMjY5NTc5Njc1MzQ3MDY3ZTI2ZDc2NGJlYzQgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtMjM3Miw3ICsyMzcyLDYgQEAgZmFzdC90ZXh0L2xh cmdlLXRleHQtY29tcG9zZWQtY2hhci1kb3MuaHRtbAogZmFzdC90ZXh0L2ludGVybmF0aW9uYWwv MDAyLmh0bWwKIGZhc3QvYmxvY2svcG9zaXRpb25pbmcvYWJzb2x1dGUtaW4taW5saW5lLXJ0bC00 Lmh0bWwKIGZhc3QvY2FudmFzL2NhbnZhcy1ncmFkaWVudC1hZGRTdG9wLWVycm9yLmh0bWwKLWZh c3QvY2FudmFzL2NhbnZhcy1maWxsUGF0aC1ncmFkaWVudC1zaGFkb3cuaHRtbAogZmFzdC9jc3Mv em9vbS1ib2R5LXNjcm9sbC5odG1sCiBmYXN0L2RvbS9FbGVtZW50L2dldEJvdW5kaW5nQ2xpZW50 UmVjdC5odG1sCiBmYXN0L2RvbS9FbGVtZW50L2dldENsaWVudFJlY3RzLmh0bWwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCAxYTZjODA0NTdjOGYzMzFmNmE1OGYwNTRiYmI1YWZlZjFhZDFlY2Q2Li4wYTJhZDdhY2Fl ODY4ZjA0NmM4MTIyMTgxYTEzM2IyZGNjMjI2MTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDEtMTcgIEhlbGRlciBDb3JyZWlhICA8aGVsZGVyQHNlbmNoYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBmYXN0L2Nh bnZhcy9jYW52YXMtZmlsbFBhdGgtZ3JhZGllbnQtc2hhZG93Lmh0bWwgZG9lcyBub3QgcGFzcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI1NTYKKwor ICAgICAgICBUaGUgc2hhZG93IGNvbG9yIG9wYWNpdHkgbmVlZHMgdG8gYmUgc2V0IG9uIHRoZSBz aGFkb3cgcGFpbnRlci4KKyAgICAgICAgQWRkaXRpb25hbGx5LCB0aGUgZ3JhZGllbnQgYnJ1c2gg c2hvdWxkIGJlIHRyYW5zZm9ybWVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQv R3JhcGhpY3NDb250ZXh0UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0 OjpmaWxsUGF0aCk6CisKIDIwMTEtMDEtMTYgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5j cHAKaW5kZXggZTIzN2ZjMGE4YmNmMWJmMmEwNDM0ODU5MDc1ZmI4ZjE5NjRhYTllYS4uNTkwMjJj YjdlYjE1ZGZmZWVlMjM3MmYxNzVjODVkMTBlNzM3NzUyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcApA QCAtNDk2LDggKzQ5NiwxMyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFBhdGgoY29uc3Qg UGF0aCYgcGF0aCkKICAgICAgICAgewogICAgICAgICAgICAgUVBhaW50ZXIqIHNoYWRvd1BhaW50 ZXIgPSBzaGFkb3ctPmJlZ2luU2hhZG93TGF5ZXIodGhpcywgcGxhdGZvcm1QYXRoLmNvbnRyb2xQ b2ludFJlY3QoKSk7CiAgICAgICAgICAgICBpZiAoc2hhZG93UGFpbnRlcikgewotICAgICAgICAg ICAgICAgIHNoYWRvd1BhaW50ZXItPnNldENvbXBvc2l0aW9uTW9kZShRUGFpbnRlcjo6Q29tcG9z aXRpb25Nb2RlX1NvdXJjZSk7Ci0gICAgICAgICAgICAgICAgc2hhZG93UGFpbnRlci0+ZmlsbFBh dGgocGxhdGZvcm1QYXRoLCBRQ29sb3IobV9kYXRhLT5zaGFkb3cubV9jb2xvcikpOworICAgICAg ICAgICAgICAgIGlmIChtX3N0YXRlLmZpbGxHcmFkaWVudCkgeworICAgICAgICAgICAgICAgICAg ICBRQnJ1c2ggYnJ1c2goKm1fc3RhdGUuZmlsbEdyYWRpZW50LT5wbGF0Zm9ybUdyYWRpZW50KCkp OworICAgICAgICAgICAgICAgICAgICBicnVzaC5zZXRUcmFuc2Zvcm0obV9zdGF0ZS5maWxsR3Jh ZGllbnQtPmdyYWRpZW50U3BhY2VUcmFuc2Zvcm0oKSk7CisgICAgICAgICAgICAgICAgICAgIHNo YWRvd1BhaW50ZXItPnNldE9wYWNpdHkoc3RhdGljX2Nhc3Q8cXJlYWw+KHNoYWRvdy0+bV9jb2xv ci5hbHBoYSgpKSAvIDI1NSk7CisgICAgICAgICAgICAgICAgICAgIHNoYWRvd1BhaW50ZXItPmZp bGxQYXRoKHBsYXRmb3JtUGF0aCwgYnJ1c2gpOworICAgICAgICAgICAgICAgIH0gZWxzZQorICAg ICAgICAgICAgICAgICAgICBzaGFkb3dQYWludGVyLT5maWxsUGF0aChwbGF0Zm9ybVBhdGgsIFFD b2xvcihzaGFkb3ctPm1fY29sb3IpKTsKICAgICAgICAgICAgICAgICBzaGFkb3ctPmVuZFNoYWRv d0xheWVyKHRoaXMpOwogICAgICAgICAgICAgfQogICAgICAgICB9IGVsc2Ugewo=