52553 2011-01-16 23:08:04 -0800 [GTK] Many DOM XHTML tests time out 2011-01-24 17:30:51 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned abarth eric svillar webkit.review.bot xan.lopez oldest_to_newest 335151 0 mrobinson 2011-01-16 23:08:04 -0800 Many tests in the dom/xhtml/level3/core/ directory seem to time out. From initial examination, the issue seems to be that the soup backend does not handle the failure of a synchronous load before the inner event loop has started. 335155 1 79129 mrobinson 2011-01-16 23:17:06 -0800 Created attachment 79129 Patch 339324 2 79129 eric 2011-01-24 15:44:39 -0800 Comment on attachment 79129 Patch Can't we run the loop with a timeout? Or schedule a timeout event on the loop before we run it? That seems like a more general fix for this problem than this specific exclusion. 339338 3 mrobinson 2011-01-24 16:01:31 -0800 (In reply to comment #2) > (From update of attachment 79129 [details]) > Can't we run the loop with a timeout? Or schedule a timeout event on the loop before we run it? That seems like a more general fix for this problem than this specific exclusion. I had considered a solution like this, but the details of the operation of the WebCoreSynchronousLoader are hidden from ResourceHandle::loadResourceSynchronously. Meanwhile, the handle itself "owns" the WebCoreSynchronousLoader (it's the client), so it didn't seem clean to add another relationship. I finally chose this approach because it matches the CF network code. 339339 4 mrobinson 2011-01-24 16:02:18 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 79129 [details] [details]) > > Can't we run the loop with a timeout? Or schedule a timeout event on the loop before we run it? That seems like a more general fix for this problem than this specific exclusion. > > I had considered a solution like this, but the details of the operation of the WebCoreSynchronousLoader are hidden from ResourceHandle::loadResourceSynchronously. Meanwhile, the handle itself "owns" the WebCoreSynchronousLoader (it's the client), so it didn't seem clean to add another relationship. I finally chose this approach because it matches the CF network code. By the way, thanks for the review! 339371 5 79129 mrobinson 2011-01-24 16:47:24 -0800 Comment on attachment 79129 Patch Clearing flags on attachment: 79129 Committed r76555: <http://trac.webkit.org/changeset/76555> 339372 6 mrobinson 2011-01-24 16:47:29 -0800 All reviewed patches have been landed. Closing bug. 339393 7 webkit.review.bot 2011-01-24 17:30:51 -0800 http://trac.webkit.org/changeset/76555 might have broken GTK Linux 32-bit Release The following tests are not passing: http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html media/unsupported-rtsp.html 79129 2011-01-16 23:17:06 -0800 2011-01-24 16:47:24 -0800 Patch bug-52553-20110116231705.patch text/plain 3952 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMWJmYWFlOWQ5ZWQ4MjljMmI1NmEzODIxMTcyMjM4NmFiZGEzZjI4Li5mYmFiOTQy NmZjNWMwM2ZiZjg3MjI5NmYyNDAzNzFiZjM0MzIzYjk2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTEtMDEtMTYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIE1hbnkg RE9NIFhIVE1MIHRlc3RzIHRpbWUgb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MjU1MworCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6 IFVuc2tpcCB0ZXN0cyB3aGljaCBhcmUgbm8gbG9uZ2VyIHRpbWluZyBvdXQuCisKKzIwMTEtMDEt MTYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJl dmlld2VkIGJ5IFhhbiBMb3Blei4KIAogICAgICAgICBbR1RLXSBmYXN0L2V2ZW50cy9zY3JvbGwt YWZ0ZXItY2xpY2stb24tdGFiLWluZGV4IGhhcyBiZWVuIGZhaWxpbmcgb24gdGhlIGJvdHMKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggMGY3NjRkN2E2NjUxYTUyZGNkYTFiNGQ0N2Q5NGUy YWMzY2I2ODFjMS4uYTg4NjljOTgyMTdlMjhlMWE4MjFjZWIzMmNhYjc3YzVlOWJmYWVmZiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTMwLDIzICszMCw3IEBACiAKICMgVGhlIGdyb3Vw IG9mIHRlc3RzIGJlbG93IGFyZSB0aW1pbmcgb3V0LiBBcyB3ZSBnbyB0aHJvdWdoIHRoZW0KICMg YW5kIGdldCBtb3JlIGRldGFpbGVkIGluZm9ybWF0aW9uLCB3ZSBzaG91bGQgYXR0YWNoIGJ1Z3Mg dG8gdGhlbS4KLWRvbS94aHRtbC9sZXZlbDMvY29yZS9lbnRpdHlnZXRpbnB1dGVuY29kaW5nMDMu eGh0bWwKLWRvbS94aHRtbC9sZXZlbDMvY29yZS9lbnRpdHlnZXRpbnB1dGVuY29kaW5nMDQueGh0 bWwKLWRvbS94aHRtbC9sZXZlbDMvY29yZS9lbnRpdHlnZXR4bWxlbmNvZGluZzAyLnhodG1sCi1k b20veGh0bWwvbGV2ZWwzL2NvcmUvZW50aXR5Z2V0eG1sZW5jb2RpbmcwMy54aHRtbAotZG9tL3ho dG1sL2xldmVsMy9jb3JlL2VudGl0eWdldHhtbGVuY29kaW5nMDQueGh0bWwKLWRvbS94aHRtbC9s ZXZlbDMvY29yZS9lbnRpdHlnZXR4bWx2ZXJzaW9uMDMueGh0bWwKLWRvbS94aHRtbC9sZXZlbDMv Y29yZS9lbnRpdHlnZXR4bWx2ZXJzaW9uMDQueGh0bWwKLWRvbS94aHRtbC9sZXZlbDMvY29yZS9u b2RlZ2V0YmFzZXVyaTE2LnhodG1sCi1kb20veGh0bWwvbGV2ZWwzL2NvcmUvbm9kZWdldGJhc2V1 cmkxOS54aHRtbAotZG9tL3hodG1sL2xldmVsMy9jb3JlL25vZGVnZXRiYXNldXJpMjAueGh0bWwK LWh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvWE1MSHR0cFJlcXVlc3RFeGNlcHRpb24uaHRtbAot aHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9jb25uZWN0aW9uLWVycm9yLXN5bmMuaHRtbAogZmFz dC94bWxodHRwcmVxdWVzdC9udWxsLWRvY3VtZW50LXhtbGh0dHByZXF1ZXN0LW9wZW4uaHRtbAot aHR0cC90ZXN0cy9taXNjL2Zhdmljb24tYXMtaW1hZ2UuaHRtbAotbWVkaWEvdW5zdXBwb3J0ZWQt cnRzcC5odG1sCi1zZWN1cml0eS9hdXRvY29tcGxldGUtY2xlYXJlZC1vbi1iYWNrLmh0bWwKLWh0 dHAvdGVzdHMvc2VjdXJpdHkvZnJhbWVOYXZpZ2F0aW9uL2Nyb3NzLW9yaWdpbi1vcGVuZXIuaHRt bAogCiAjIEludGVybWl0dGVudGx5IHRpbWluZyBvdXQgb24gR3RrIERlYnVnIEJvdDoKICMgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDQ1CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mjk0MGViMGUzZmNiMjY3Njc3YjZhOGE3MmVkY2FmNjNkODExNjE3Zi4uOWFkZjRiYzVmN2JkMjJj ZDg4MjljYzI0ZjQ4MGU4OTI4NjI5YTg1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAy MDExLTAxLTE2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBNYW55IERP TSBYSFRNTCB0ZXN0cyB0aW1lIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTI1NTMKKworICAgICAgICBQcm9wZXJseSBoYW5kbGUgdGhlIHNpdHVh dGlvbiB3aGVyZSBhIHN5bmNocm9ub3VzIGxvYWQgZmFpbHMgYmVmb3JlIHRoZSBpbm5lcgorICAg ICAgICBldmVudCBsb29wIGhhcyBzdGFydGVkLiBJbiB0aGlzIGNhc2UsIHdlIHNpbXBseSBkbyBu b3QgcnVuIHRoZSBpbm5lciBldmVudCBsb29wLAorICAgICAgICBvciBlbHNlIGl0IHdpbGwgYmxv Y2sgaW5kZWZpbml0ZWx5IChzaW5jZSBubyBHSU8gb3IgbGlic291cCBjYWxsYmFja3Mgd2lsbCBm aXJlKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmxvYWRSZXNvdXJjZVN5 bmNocm9ub3VzbHkpOiBCYWlsIG91dCBvZiBhIHN5bmNocm9ub3VzCisgICAgICAgIGxvYWQgaWYg aXQgZmFpbHMgdXAgZnJvbnQuCisKKzIwMTEtMDEtMTYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2Jp bnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KIAogICAg ICAgICBbR1RLXSBmYXN0L2V2ZW50cy9zY3JvbGwtYWZ0ZXItY2xpY2stb24tdGFiLWluZGV4IGhh cyBiZWVuIGZhaWxpbmcgb24gdGhlIGJvdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggODkw MGIxODA0N2Q3YWE0YTVkODI3MTkxNzU5MGJiNzNmZTRmZDgyOS4uMzE5ZTViY2ZjNWQzY2M2NWY1 ZWFiYWIzNmZiYmZlNTgzNGU4MzE3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKQEAgLTc4OSw2 ICs3ODksMTAgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6bG9hZFJlc291cmNlU3luY2hyb25vdXNs eShOZXR3b3JraW5nQ29udGV4dCogY29udGV4dCwgY29uc3QKICAgICBSZWZQdHI8UmVzb3VyY2VI YW5kbGU+IGhhbmRsZSA9IGFkb3B0UmVmKG5ldyBSZXNvdXJjZUhhbmRsZShyZXF1ZXN0LCAmc3lu Y0xvYWRlciwgZmFsc2UgLypkZWZlcnNMb2FkaW5nKi8sIGZhbHNlIC8qc2hvdWxkQ29udGVudFNu aWZmKi8pKTsKICAgICBoYW5kbGUtPnN0YXJ0KGNvbnRleHQpOwogCisgICAgLy8gSWYgdGhlIHJl cXVlc3QgaGFzIGFscmVhZHkgZmFpbGVkLCBkbyBub3QgcnVuIHRoZSBtYWluIGxvb3AsIG9yIGVs c2Ugd2UnbGwgYmxvY2sgaW5kZWZpbml0ZWx5LgorICAgIGlmIChoYW5kbGUtPmQtPm1fc2NoZWR1 bGVkRmFpbHVyZVR5cGUgIT0gTm9GYWlsdXJlKQorICAgICAgICByZXR1cm47CisKICAgICBzeW5j TG9hZGVyLnJ1bigpOwogfQogCg==