52524 2011-01-15 18:07:22 -0800 fast/dom/Range/range-clone-contents.html fails only on Windows 2011-01-17 14:05:58 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Windows XP CLOSED FIXED InRadar, LayoutTestFailure P1 Normal --- 52512 1 ddkilzer webkit-unassigned adele ap aroben bweinstein commit-queue enrica jberlin oldest_to_newest 334980 0 ddkilzer 2011-01-15 18:07:22 -0800 LayoutTests/fast/dom/Range/range-clone-contents.html only fails on Windows bots. It would be interesting to know if disabling optimization on WebCore/dom/Range.cpp affects the results of the test. The Range::processContents() method reuses a lot of variables, also shadows many variables, and uses multiple variables within for() loop conditions. 334982 1 ddkilzer 2011-01-15 18:15:44 -0800 Added the test to the Windows skip list: Committed r75889. <http://trac.webkit.org/changeset/75889> 334984 2 ddkilzer 2011-01-15 18:17:48 -0800 <rdar://problem/8870569> 335044 3 ddkilzer 2011-01-16 06:45:04 -0800 Brian/Adam: Are there any known issues where DOMAllInOne.cpp isn't always rebuilt properly for Windows if one of its constituent files is changed? 335066 4 adele 2011-01-16 11:55:10 -0800 Does anyone on Windows see this failure in their local build? 335089 5 79114 ddkilzer 2011-01-16 14:48:30 -0800 Created attachment 79114 Patch to try Patch to try if there is a codegen issue with MSVC compiler. 335269 6 aroben 2011-01-17 05:36:41 -0800 (In reply to comment #3) > Brian/Adam: Are there any known issues where DOMAllInOne.cpp isn't always rebuilt properly for Windows if one of its constituent files is changed? I don't know of any such issues. 335270 7 aroben 2011-01-17 05:37:04 -0800 A link to the failure diff would be handy. 335325 8 ddkilzer 2011-01-17 07:53:52 -0800 (In reply to comment #7) > A link to the failure diff would be handy. Here are links to the failure diffs from Bug 52512 Comment #7: Windows 7 Release bot: <http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r75882%20(8257)/fast/dom/Range/range-clone-contents-pretty-diff.html> Windows XP Debug bot: <http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r75882%20(24216)/fast/dom/Range/range-clone-contents-pretty-diff.html> 335339 9 aroben 2011-01-17 08:11:37 -0800 (In reply to comment #8) > (In reply to comment #7) > > A link to the failure diff would be handy. > > Here are links to the failure diffs from Bug 52512 Comment #7: Thanks! FYI, our standard procedure in cases like this (where the test is just failing, as opposed to crashing or timing out) is to check in platform-specific results that reflect the current behavior, rather than skipping the test. 335372 10 ddkilzer 2011-01-17 10:15:43 -0800 (In reply to comment #8) > (In reply to comment #7) > > A link to the failure diff would be handy. > > Here are links to the failure diffs from Bug 52512 Comment #7: > > Windows 7 Release bot: <http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r75882%20(8257)/fast/dom/Range/range-clone-contents-pretty-diff.html> Here's the Windows 7 Release build of r75882: <http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/10555> > Windows XP Debug bot: <http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r75882%20(24216)/fast/dom/Range/range-clone-contents-pretty-diff.html> And Windows XP Debug build of r75882: <http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/29578> 335405 11 ddkilzer 2011-01-17 11:04:33 -0800 A local Release build of WebKit r75949 on Windows XP shows that fast/dom/Range/range-clone-contents.html passes. This appears to be an issue with needing a clean build on the Windows buildbots. However, I'll wait for independent verification from another source before removing the test from the Skipped list. 335411 12 79192 ddkilzer 2011-01-17 11:29:40 -0800 Created attachment 79192 Unskip the test 335483 13 79192 commit-queue 2011-01-17 13:17:04 -0800 Comment on attachment 79192 Unskip the test Clearing flags on attachment: 79192 Committed r75970: <http://trac.webkit.org/changeset/75970> 335484 14 commit-queue 2011-01-17 13:17:09 -0800 All reviewed patches have been landed. Closing bug. 335511 15 ddkilzer 2011-01-17 14:05:50 -0800 (In reply to comment #13) > (From update of attachment 79192 [details]) > Clearing flags on attachment: 79192 > > Committed r75970: <http://trac.webkit.org/changeset/75970> Windows 7 Release tests for r75970: <http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/8298> Windows XP Debug tests for r75970: <http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/24245> The new test now passes. 79114 2011-01-16 14:48:30 -0800 2011-01-17 11:29:37 -0800 Patch to try bug-52524-try-v1.diff text/plain 4706 ddkilzer ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MzI2ZmY2Li4wNzEyYzFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTEtMDEt MTYgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICA8aHR0cDov L3dlYmtpdC5vcmcvYi81MjUyND4gZmFzdC9kb20vUmFuZ2UvcmFuZ2UtY2xvbmUtY29udGVudHMu aHRtbCBmYWlscyBvbmx5IG9uIFdpbmRvd3MKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOiBSZW1vdmUgdGVzdCBm cm9tIHNraXAgbGlzdC4KKwogMjAxMS0wMS0xNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFNraXAgZmFzdC9kb20vUmFuZ2UvcmFuZ2UtY2xvbmUtY29udGVu dHMuaHRtbCBvbiBXaW5kb3dzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4v U2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCmluZGV4IDhlNDU1ZjIu LmE3NDU2Y2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCkBAIC0xMTE3LDYgKzExMTcsMyBA QCBlZGl0aW5nL3NlbGVjdGlvbi9jYXJldC1tb2RlLXBhcmFncmFwaC1rZXlzLW5hdmlnYXRpb24u aHRtbAogCiAjIERSVCBkb2VzIG5vdCBvYmV5IGFkZFVSTFRvUmVkaXJlY3QKIGh0dHAvdGVzdHMv bG9hZGluZy9jcm9zcy1vcmlnaW4tWEhSLXdpbGxMb2FkUmVxdWVzdC5odG1sCi0KLSMgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNTI0Ci1mYXN0L2RvbS9SYW5nZS9y YW5nZS1jbG9uZS1jb250ZW50cy5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA0MjhhNC4uYzdhN2QxZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAxLTE2ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvNTI1MjQ+ IGZhc3QvZG9tL1JhbmdlL3JhbmdlLWNsb25lLWNvbnRlbnRzLmh0bWwgZmFpbHMgb25seSBvbiBX aW5kb3dzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBkb20vUmFuZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmFuZ2U6OnByb2Nlc3NDb250ZW50 cyk6IFRyeSByZW5hbWluZyBhIGxvY2FsIHZhcmlhYmxlCisgICAgICAgIHRvIHByZXZlbnQgc2hh ZG93aW5nLCBleHRyYWN0IGEgbWV0aG9kIGNhbGwgaW50byBhIGxvY2FsCisgICAgICAgIHZhcmlh YmxlIChlbmRPZmZzZXQpLCBhbmQgdXNlIFZlY3Rvcjo6cHJlcGVuZCgpIGluc3RlYWQgb2YKKyAg ICAgICAgVmVjdG9yOjphcHBlbmQoKSBzbyB0aGF0IGEgTm9kZXNWZWN0b3I6OmNvbnN0X2l0ZXJh dG9yIG1heSBiZQorICAgICAgICB1c2VkIGluc3RlYWQgb2YgYW4gaW50LgorCiAyMDExLTAxLTE1 ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByNzU3MDguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vUmFuZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmNwcAppbmRleCBhNDFm YzQ5Li5jNzJiMjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vUmFuZ2UuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9SYW5nZS5jcHAKQEAgLTcyNywxMyArNzI3LDEzIEBAIFBh c3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4gUmFuZ2U6OnByb2Nlc3NDb250ZW50cyhBY3Rpb25U eXBlIGFjdGlvbiwgRXhjZXB0aW9uCiAgICAgICAgICAgICAgICAgbm9kZXMuYXBwZW5kKG4pOwog ICAgICAgICAgICAgfQogICAgICAgICAgICAgZm9yIChOb2RlVmVjdG9yOjpjb25zdF9pdGVyYXRv ciBpdCA9IG5vZGVzLmJlZ2luKCk7IGl0ICE9IG5vZGVzLmVuZCgpOyBpdCsrKSB7Ci0gICAgICAg ICAgICAgICAgTm9kZSogbiA9IGl0LT5nZXQoKTsKKyAgICAgICAgICAgICAgICBOb2RlKiBub2Rl ID0gaXQtPmdldCgpOwogICAgICAgICAgICAgICAgIGlmIChhY3Rpb24gPT0gRVhUUkFDVF9DT05U RU5UUykKLSAgICAgICAgICAgICAgICAgICAgbGVmdENvbnRlbnRzLT5hcHBlbmRDaGlsZChuLCBl Yyk7IC8vIFdpbGwgcmVtb3ZlIG4gZnJvbSBzdGFydCBjb250YWluZXIuCisgICAgICAgICAgICAg ICAgICAgIGxlZnRDb250ZW50cy0+YXBwZW5kQ2hpbGQobm9kZSwgZWMpOyAvLyBXaWxsIHJlbW92 ZSBub2RlIGZyb20gc3RhcnQgY29udGFpbmVyLgogICAgICAgICAgICAgICAgIGVsc2UgaWYgKGFj dGlvbiA9PSBDTE9ORV9DT05URU5UUykKLSAgICAgICAgICAgICAgICAgICAgbGVmdENvbnRlbnRz LT5hcHBlbmRDaGlsZChuLT5jbG9uZU5vZGUodHJ1ZSksIGVjKTsKKyAgICAgICAgICAgICAgICAg ICAgbGVmdENvbnRlbnRzLT5hcHBlbmRDaGlsZChub2RlLT5jbG9uZU5vZGUodHJ1ZSksIGVjKTsK ICAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAgIHRvQ29udGFpbmVyTm9k ZShtX3N0YXJ0LmNvbnRhaW5lcigpKS0+cmVtb3ZlQ2hpbGQobiwgZWMpOworICAgICAgICAgICAg ICAgICAgICB0b0NvbnRhaW5lck5vZGUobV9zdGFydC5jb250YWluZXIoKSktPnJlbW92ZUNoaWxk KG5vZGUsIGVjKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCkBAIC03OTIsMTggKzc5Miwx OSBAQCBQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IFJhbmdlOjpwcm9jZXNzQ29udGVudHMo QWN0aW9uVHlwZSBhY3Rpb24sIEV4Y2VwdGlvbgogICAgICAgICAgICAgaWYgKGFjdGlvbiA9PSBF WFRSQUNUX0NPTlRFTlRTIHx8IGFjdGlvbiA9PSBDTE9ORV9DT05URU5UUykKICAgICAgICAgICAg ICAgICByaWdodENvbnRlbnRzID0gbV9lbmQuY29udGFpbmVyKCktPmNsb25lTm9kZShmYWxzZSk7 CiAgICAgICAgICAgICBOb2RlKiBuID0gbV9lbmQuY29udGFpbmVyKCktPmZpcnN0Q2hpbGQoKTsK LSAgICAgICAgICAgIGlmIChuICYmIG1fZW5kLm9mZnNldCgpKSB7CisgICAgICAgICAgICBpbnQg ZW5kT2Zmc2V0ID0gbV9lbmQub2Zmc2V0KCk7CisgICAgICAgICAgICBpZiAobiAmJiBlbmRPZmZz ZXQpIHsKICAgICAgICAgICAgICAgICBOb2RlVmVjdG9yIG5vZGVzOwotICAgICAgICAgICAgICAg IGZvciAoaW50IGkgPSAwOyBpIDwgbV9lbmQub2Zmc2V0KCkgJiYgbjsgaSsrLCBuID0gbi0+bmV4 dFNpYmxpbmcoKSkKLSAgICAgICAgICAgICAgICAgICAgbm9kZXMuYXBwZW5kKG4pOwotICAgICAg ICAgICAgICAgIGZvciAoaW50IGkgPSBub2Rlcy5zaXplKCkgLSAxOyBpID49IDA7IGktLSkgewot ICAgICAgICAgICAgICAgICAgICBuID0gbm9kZXNbaV0uZ2V0KCk7CisgICAgICAgICAgICAgICAg Zm9yIChpbnQgaSA9IDA7IG4gJiYgaSA8IGVuZE9mZnNldDsgbiA9IG4tPm5leHRTaWJsaW5nKCks IGkrKykKKyAgICAgICAgICAgICAgICAgICAgbm9kZXMucHJlcGVuZChuKTsKKyAgICAgICAgICAg ICAgICBmb3IgKE5vZGVWZWN0b3I6OmNvbnN0X2l0ZXJhdG9yIGl0ID0gbm9kZXMuYmVnaW4oKTsg aXQgIT0gbm9kZXMuZW5kKCk7IGl0KyspIHsKKyAgICAgICAgICAgICAgICAgICAgTm9kZSogbm9k ZSA9IGl0LT5nZXQoKTsKICAgICAgICAgICAgICAgICAgICAgaWYgKGFjdGlvbiA9PSBFWFRSQUNU X0NPTlRFTlRTKQotICAgICAgICAgICAgICAgICAgICAgICAgcmlnaHRDb250ZW50cy0+aW5zZXJ0 QmVmb3JlKG4sIHJpZ2h0Q29udGVudHMtPmZpcnN0Q2hpbGQoKSwgZWMpOyAvLyB3aWxsIHJlbW92 ZSBuIGZyb20gaXRzIHBhcmVudAorICAgICAgICAgICAgICAgICAgICAgICAgcmlnaHRDb250ZW50 cy0+aW5zZXJ0QmVmb3JlKG5vZGUsIHJpZ2h0Q29udGVudHMtPmZpcnN0Q2hpbGQoKSwgZWMpOyAv LyBXaWxsIHJlbW92ZSBub2RlIGZyb20gaXRzIHBhcmVudC4KICAgICAgICAgICAgICAgICAgICAg ZWxzZSBpZiAoYWN0aW9uID09IENMT05FX0NPTlRFTlRTKQotICAgICAgICAgICAgICAgICAgICAg ICAgcmlnaHRDb250ZW50cy0+aW5zZXJ0QmVmb3JlKG4tPmNsb25lTm9kZSh0cnVlKSwgcmlnaHRD b250ZW50cy0+Zmlyc3RDaGlsZCgpLCBlYyk7CisgICAgICAgICAgICAgICAgICAgICAgICByaWdo dENvbnRlbnRzLT5pbnNlcnRCZWZvcmUobm9kZS0+Y2xvbmVOb2RlKHRydWUpLCByaWdodENvbnRl bnRzLT5maXJzdENoaWxkKCksIGVjKTsKICAgICAgICAgICAgICAgICAgICAgZWxzZQotICAgICAg ICAgICAgICAgICAgICAgICAgdG9Db250YWluZXJOb2RlKG1fZW5kLmNvbnRhaW5lcigpKS0+cmVt b3ZlQ2hpbGQobiwgZWMpOworICAgICAgICAgICAgICAgICAgICAgICAgdG9Db250YWluZXJOb2Rl KG1fZW5kLmNvbnRhaW5lcigpKS0+cmVtb3ZlQ2hpbGQobm9kZSwgZWMpOwogICAgICAgICAgICAg ICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgfQo= 79192 2011-01-17 11:29:40 -0800 2011-01-17 13:17:04 -0800 Unskip the test bug-52524-20110117112939.patch text/plain 1235 ddkilzer ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3ZDU2Y2Y0NzMxNGJhODEyNGNhYzJlMTEyZDcyZmNjZWQ4MDI3NDgyLi44MjYxYzBm YWNmNzVjYWY2MGIyMmQ5NWE2MmUyOTMxYWMwYzc3MWEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDEtMTcgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAg ICA8aHR0cDovL3dlYmtpdC5vcmcvYi81MjUyND4gZmFzdC9kb20vUmFuZ2UvcmFuZ2UtY2xvbmUt Y29udGVudHMuaHRtbCBmYWlscyBvbmx5IG9uIFdpbmRvd3MKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOiBSZW1v dmVkCisgICAgICAgIGZhc3QvZG9tL1JhbmdlL3JhbmdlLWNsb25lLWNvbnRlbnRzLmh0bWwuICBJ dCBhcHBlYXJzIHRoZQorICAgICAgICBXaW5kb3dzIGJ1aWxkYm90cyBuZWVkIGEgY2xlYW4gYnVp bGQuCisKIDIwMTEtMDEtMTcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgTm90IHJldmlld2VkOiBza2lwIGZsYWt5IGluc3BlY3RvciB0ZXN0ICh3aWxs IGxvb2sgYXQgaXQgdG9tb3Jyb3cpLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v d2luL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAppbmRleCA4ZTQ1 NWYyYThlNGNhMmE4MDNkYWQ4MWE3ZGY1Y2UyZGJhOWE4OGQ2Li5hNzQ1NmNiZWRlZmY5ZmI3NzBh YWQ2ZTU4N2VhZTk3ODA5NTU5ZDgwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93 aW4vU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZApAQCAtMTEx Nyw2ICsxMTE3LDMgQEAgZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtbW9kZS1wYXJhZ3JhcGgta2V5 cy1uYXZpZ2F0aW9uLmh0bWwKIAogIyBEUlQgZG9lcyBub3Qgb2JleSBhZGRVUkxUb1JlZGlyZWN0 CiBodHRwL3Rlc3RzL2xvYWRpbmcvY3Jvc3Mtb3JpZ2luLVhIUi13aWxsTG9hZFJlcXVlc3QuaHRt bAotCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjUyNAotZmFz dC9kb20vUmFuZ2UvcmFuZ2UtY2xvbmUtY29udGVudHMuaHRtbAo=