52517 2011-01-15 12:24:55 -0800 Only use moving memory model assumption in ExecutableAllocator::intializePageSize() for Symbian OS 2011-01-18 14:54:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 dbates dbates barraclough dave+webkit oliver oldest_to_newest 334920 0 dbates 2011-01-15 12:24:55 -0800 We should strengthen the constraint in ExecutableAllocator::initializePageSize() such that we only use the moving memory model when compiling for Symbian OS on ARMv5 or lower architectures. Currently, we compile code that assumes the moving memory model for all ARMv5 or lower architectures. As per section Chunk in <http://library.forum.nokia.com/index.jsp?topic=/S60_5th_Edition_Cpp_Developers_Library/GUID-35228542-8C95-4849-A73F-2B4F082F0C44/sdk/doc_source/guide/Base-subsystem-guide/e32/MemoryManagement/MemoryAllocationOverview.guide.html>: [[ On ARM processors up to and including those that support the ARMv5 architecture, the memory model used by Symbian OS is the moving memory model. To guarantee real-time behaviour using this model, each process is limited to a maximum of 16 chunks.... On ARM processors that support the ARMv6 architecture, the memory model used by Symbian OS is the multiple memory model. Using this model, there is no limit on the number of chunks per process. ]] 334923 1 79072 dbates 2011-01-15 12:37:28 -0800 Created attachment 79072 Patch 334925 2 dbates 2011-01-15 12:44:34 -0800 Additional remarks: Prior to changeset 64105 <http://trac.webkit.org/changeset/64105> (bug #43009), the moving memory model code in ExecutableAllocator::initializePageSize() was behind an OS(SYMBIAN) guard when the code was in the file ExecutableAllocatorSymbian.cpp <http://trac.webkit.org/browser/trunk/JavaScriptCore/jit/ExecutableAllocatorSymbian.cpp?rev=64104#L25>. This file was removed in changeset 64105. 336113 3 dbates 2011-01-18 14:54:17 -0800 Committed r76068: <http://trac.webkit.org/changeset/76068> 79072 2011-01-15 12:37:28 -0800 2011-01-15 23:47:02 -0800 Patch bug52517.patch text/plain 1627 dbates SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzU4ODEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK KzIwMTEtMDEtMTUgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgdXNlIG1vdmluZyBtZW1v cnkgbW9kZWwgYXNzdW1wdGlvbiBpbiBFeGVjdXRhYmxlQWxsb2NhdG9yOjppbnRpYWxpemVQYWdl U2l6ZSgpIGZvciBTeW1iaWFuIE9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MjUxNworCisgICAgICAgIEN1cnJlbnRseSwgd2UgY29tcGlsZSBjb2Rl IHdpdGggcmVzcGVjdCB0byB0aGUgU3ltYmlhbi1zcGVjaWZpYyBtb3ZpbmcgbWVtb3J5IG1vZGVs CisgICAgICAgIGFzc3VtcHRpb24gZm9yIGFsbCBBUk12NSBvciBsb3dlciBhcmNoaXRlY3R1cmVz LiBJbnN0ZWFkLCB3ZSBzaG91bGQgb25seSBjb21waWxlCisgICAgICAgIHN1Y2ggY29kZSB3aGVu IGJ1aWxkaW5nIGZvciBTeW1iaWFuIE9TIG9uIHRob3NlIGFyY2hpdGVjdHVyZXMgYmVjYXVzZSB0 aGlzIG1vZGVsCisgICAgICAgIGlzIFN5bWJpYW4tc3BlY2lmaWMuCisKKyAgICAgICAgKiBqaXQv RXhlY3V0YWJsZUFsbG9jYXRvci5jcHA6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVBbGxvY2F0 b3I6OmludGlhbGl6ZVBhZ2VTaXplKToKKwogMjAxMS0wMS0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0 b3IuY3BwCShyZXZpc2lvbiA3NTg3OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhl Y3V0YWJsZUFsbG9jYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3LDcgQEAgc2l6 ZV90IEV4ZWN1dGFibGVBbGxvY2F0b3I6OnBhZ2VTaXplID0gMAogCiB2b2lkIEV4ZWN1dGFibGVB bGxvY2F0b3I6OmludGlhbGl6ZVBhZ2VTaXplKCkKIHsKLSNpZiBDUFUoQVJNVjVfT1JfTE9XRVIp CisjaWYgT1MoU1lNQklBTikgJiYgQ1BVKEFSTVY1X09SX0xPV0VSKQogICAgIC8vIFRoZSBtb3Zp bmcgbWVtb3J5IG1vZGVsIChhcyB1c2VkIGluIEFSTXY1IGFuZCBlYXJsaWVyIHBsYXRmb3JtcykK ICAgICAvLyBvbiBTeW1iaWFuIE9TIGxpbWl0cyB0aGUgbnVtYmVyIG9mIGNodW5rcyBmb3IgZWFj aCBwcm9jZXNzIHRvIDE2LiAKICAgICAvLyBUbyBtaXRpZ2F0ZSB0aGlzIGxpbWl0YXRpb24gaW5j cmVhc2UgdGhlIHBhZ2VzaXplIHRvIGFsbG9jYXRlCg==