52508 2011-01-15 00:53:33 -0800 [gtk] strip NUL characters when copying text/html on GTK+ 2011-01-26 15:51:00 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned abarth eric rniwa webkit.review.bot oldest_to_newest 334871 0 tony 2011-01-15 00:53:33 -0800 This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=52236. The test editing/pasteboard/copy-null-characters.html tries to copy a text node with a null character and paste it into a content editable field. On the GTK+ port, the pasted text is truncated at the null character. I'm going to skip the test for now and investigate next week. 340383 1 80218 tony 2011-01-26 12:05:11 -0800 Created attachment 80218 Patch 340463 2 80218 rniwa 2011-01-26 14:14:27 -0800 Comment on attachment 80218 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80218&action=review > Source/WebCore/ChangeLog:7 > + Please elaborate on what caused the bug and what fix you're doing. > Source/WebCore/editing/markup.cpp:188 > - return String::adopt(result); > + // We remove '\0' characters because they are not visibly rendered to the user. > + return String::adopt(result).replace(0, ""); I don't think this is an efficient way of removing nulls but I don't have an alternative offer. Also, replace doesn't replicate the string when there's no match so this doesn't regress the performance when there are no null characters. In addition, any algorithm to strip null characters will require traversing through the entire string so I'd say r+. 340491 3 tony 2011-01-26 14:52:38 -0800 Committed r76723: <http://trac.webkit.org/changeset/76723> 340534 4 webkit.review.bot 2011-01-26 15:51:00 -0800 http://trac.webkit.org/changeset/76723 might have broken Leopard Intel Release (Tests) 80218 2011-01-26 12:05:11 -0800 2011-01-26 14:14:27 -0800 Patch bug-52508-20110126120633.patch text/plain 5369 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NjdjMjUzNDU0MjVkOTllNGNjZWVlZWY2ZjhkNTc3ZjI5ZTI3YTUwLi5jMTcxODhl NjJmOGRmNDVhZTY3ZTI3YWY0OGU1NjAyNGQxY2VlZDJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDEtMjYgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbZ3RrXSBzdHJpcCBOVUwgY2hh cmFjdGVycyB3aGVuIGNvcHlpbmcgdGV4dC9odG1sIG9uIEdUSysKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNTA4CisKKyAgICAgICAgKiBlZGl0aW5n L3Bhc3RlYm9hcmQvY29weS1udWxsLWNoYXJhY3RlcnMuaHRtbDogTWFrZSBzdXJlIHdlIGRpZG4n dAorICAgICAgICAgICAgY2hhbmdlIGlubmVySFRNTCAoaXQgc2hvdWxkIHN0aWxsIGNvbnRhaW4g dGhlIG51bGwpCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IFJlLWVuYWJsZSB0aGUg dGVzdAorCiAyMDExLTAxLTI1ICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieUFudHRpIEtvaXZpc3RvLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktbnVsbC1jaGFyYWN0ZXJzLmh0bWwgYi9M YXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvY29weS1udWxsLWNoYXJhY3RlcnMuaHRtbApp bmRleCBiOTA4ZGMxMDVlNDc1NjY4YTlmNGFiNTBjZTFiNWQ3MjM3OWI5ZDFkLi4zOTZhN2IzODNh NmYyNWQ4MzM0MmEwZDhhNTE5NDhjN2JjZTc4MzZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9l ZGl0aW5nL3Bhc3RlYm9hcmQvY29weS1udWxsLWNoYXJhY3RlcnMuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvY29weS1udWxsLWNoYXJhY3RlcnMuaHRtbApAQCAtMTEs NiArMTEsMTggQEAgZnVuY3Rpb24gcnVuVGVzdCgpCiAgICAgdmFyIHNvdXJjZSA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJzb3VyY2UiKTsKICAgICB2YXIgdGV4dFdpdGhOdWxsID0gIkNvcHlc MCBwYXN0ZSBtZSI7CiAgICAgc291cmNlLnRleHRDb250ZW50ID0gdGV4dFdpdGhOdWxsOworCisg ICAgdmFyIHJlc3VsdHMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0cyIpOworICAg IC8vIE1ha2Ugc3VyZSBpbm5lckhUTUwgc3RpbGwgaGFzIHRoZSBOVUxMLgorICAgIGlmIChzb3Vy Y2UuaW5uZXJIVE1MICE9IHRleHRXaXRoTnVsbCkgeworICAgICAgICByZXN1bHRzLmlubmVyVGV4 dCA9ICJzb3VyY2UuaW5uZXJIVE1MIGhhcyB0aGUgd3JvbmcgdmFsdWUgKGV4cGVjdGVkICIgKwor ICAgICAgICAgICAgSlNPTi5zdHJpbmdpZnkodGV4dFdpdGhOdWxsKSArICIgYnV0IGZvdW5kICIg KworICAgICAgICAgICAgSlNPTi5zdHJpbmdpZnkoc291cmNlLmlubmVySFRNTCkgKyAiKS4iOwor ICAgICAgICBNYXJrdXAuZHVtcChkb2N1bWVudC5ib2R5KTsKKyAgICAgICAgTWFya3VwLm5vdGlm eURvbmUoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIHNlbC5zZXRQb3NpdGlvbihz b3VyY2UsIDApOwogICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiKTsKICAgICBk b2N1bWVudC5leGVjQ29tbWFuZCgiQ29weSIpOwpAQCAtMjMsNyArMzUsNiBAQCBmdW5jdGlvbiBy dW5UZXN0KCkKICAgICBkZXN0aW5hdGlvblBsYWluVGV4dC5mb2N1cygpOwogICAgIGRvY3VtZW50 LmV4ZWNDb21tYW5kKCJQYXN0ZSIpOwogCi0gICAgdmFyIHJlc3VsdHMgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgicmVzdWx0cyIpOwogICAgIHZhciBleHBlY3RlZFBsYWluVGV4dFZhbHVlID0g IkNvcHkgcGFzdGUgbWUiOwogICAgIGlmIChleHBlY3RlZFBsYWluVGV4dFZhbHVlICE9IGRlc3Rp bmF0aW9uUGxhaW5UZXh0LnZhbHVlKSB7CiAgICAgICAgIHJlc3VsdHMuaW5uZXJUZXh0ID0gIlBs YWluIHRleHQgZmllbGQgaGFzIHRoZSB3cm9uZyB2YWx1ZSAoZXhwZWN0ZWQgIiArCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9Ta2lwcGVkCmluZGV4IDNjMTVjOTFjN2ViMTY0ZGZkOTlkZjViYzYxMWZjOGU2MmYx YjY0MzguLmRkZjUxOTc2MDFkNTJjNzlmZWZjZmNjYTMzOTQ5MjY3ZDYzOTFmZWYgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9Ta2lwcGVkCkBAIC01NTcxLDkgKzU1NzEsNiBAQCBlZGl0aW5nL2lucHV0L3Bh Z2UtdXAtZG93bi1zY3JvbGxzLmh0bWwKICMgRFJUIGRvZXMgbm90IG9iZXkgbGF5b3V0VGVzdENv bnRyb2xsZXIuYWRkVVJMVG9SZWRpcmVjdCgpCiBodHRwL3Rlc3RzL2xvYWRpbmcvY3Jvc3Mtb3Jp Z2luLVhIUi13aWxsTG9hZFJlcXVlc3QuaHRtbAogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MjUwOAotZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktbnVsbC1jaGFy YWN0ZXJzLmh0bWwKLQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTI3OTgKIGh0dHAvdGVzdHMvc2VjdXJpdHkvbG9jYWwtQ1NTLWZyb20tcmVtb3RlLmh0bWwKIGh0 dHAvdGVzdHMvc2VjdXJpdHkvbG9jYWwtSmF2YVNjcmlwdC1mcm9tLXJlbW90ZS5odG1sCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggOTNlMDQ5MTZlYjUwZTJmZDE3ZWI2Y2FjZmIzNGNlZDc0NzIxNDBiMy4uMjk4ZDZh N2MyYzQ4Y2E0MmZkMDNhMmRmNmM5YTJlNGNhMWVmODQ4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDExLTAxLTI2ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2d0a10gc3RyaXAg TlVMIGNoYXJhY3RlcnMgd2hlbiBjb3B5aW5nIHRleHQvaHRtbCBvbiBHVEsrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjUwOAorCisgICAgICAgICog ZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRvci5oOiBtYXJrIGZ1bmN0aW9uIGFzIHZpcnR1YWwKKyAg ICAgICAgKiBlZGl0aW5nL21hcmt1cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZWRNYXJr dXBBY2N1bXVsYXRvcjo6YXBwZW5kU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlZE1h cmt1cEFjY3VtdWxhdG9yOjp0YWtlUmVzdWx0cyk6IHN0cmlwIG51bGxzCisKIDIwMTEtMDEtMjUg IEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFudHRpIEtvaXZpc3RvLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9NYXJrdXBBY2N1bXVsYXRvci5oIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9NYXJrdXBBY2N1 bXVsYXRvci5oCmluZGV4IDVhOWM4ODRjNzliMDVkMGE1MTAyN2NlYjc3MjhkZTlkZTI2OThhMDIu LjBiZmM2ZTYwMDViYmY0NGIzMGFlM2FmNzZmMzQ2Yjg3MGFhNDZmYzkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvTWFya3VwQWNjdW11bGF0b3IuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmgKQEAgLTcyLDcgKzcyLDcgQEAgcHVibGlj OgogICAgIFN0cmluZyBzZXJpYWxpemVOb2RlcyhOb2RlKiBub2RlLCBOb2RlKiBub2RlVG9Ta2lw LCBFQ2hpbGRyZW5Pbmx5IGNoaWxkcmVuT25seSk7CiAKIHByb3RlY3RlZDoKLSAgICB2b2lkIGFw cGVuZFN0cmluZyhjb25zdCBTdHJpbmcmKTsKKyAgICB2aXJ0dWFsIHZvaWQgYXBwZW5kU3RyaW5n KGNvbnN0IFN0cmluZyYpOwogICAgIHZvaWQgYXBwZW5kU3RhcnRUYWcoTm9kZSosIE5hbWVzcGFj ZXMqID0gMCk7CiAgICAgdm9pZCBhcHBlbmRFbmRUYWcoTm9kZSopOwogICAgIHN0YXRpYyBzaXpl X3QgdG90YWxMZW5ndGgoY29uc3QgVmVjdG9yPFN0cmluZz4mKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFy a3VwLmNwcAppbmRleCA1NDljODE2ZTMyODhiZWExMjVjNTNjNjEyNmMwM2I2ZGQ0YjUyYTUzLi5i YWY0ZTA0ZjA0OTk2MmE1YTMwOGM4M2MzZWE4NDhhNjMyNmExYjkxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9tYXJrdXAuY3BwCkBAIC0xMjQsNyArMTI0LDcgQEAgcHVibGljOgogICAgIH0KIAogICAgIE5v ZGUqIHNlcmlhbGl6ZU5vZGVzKE5vZGUqIHN0YXJ0Tm9kZSwgTm9kZSogcGFzdEVuZCk7Ci0gICAg dm9pZCBhcHBlbmRTdHJpbmcoY29uc3QgU3RyaW5nJiBzKSB7IHJldHVybiBNYXJrdXBBY2N1bXVs YXRvcjo6YXBwZW5kU3RyaW5nKHMpOyB9CisgICAgdmlydHVhbCB2b2lkIGFwcGVuZFN0cmluZyhj b25zdCBTdHJpbmcmIHMpIHsgcmV0dXJuIE1hcmt1cEFjY3VtdWxhdG9yOjphcHBlbmRTdHJpbmco cyk7IH0KICAgICB2b2lkIHdyYXBXaXRoTm9kZShOb2RlKiwgYm9vbCBjb252ZXJ0QmxvY2tzVG9J bmxpbmVzID0gZmFsc2UsIFJhbmdlRnVsbHlTZWxlY3RzTm9kZSA9IERvZXNGdWxseVNlbGVjdE5v ZGUpOwogICAgIHZvaWQgd3JhcFdpdGhTdHlsZU5vZGUoQ1NTU3R5bGVEZWNsYXJhdGlvbiosIERv Y3VtZW50KiwgYm9vbCBpc0Jsb2NrID0gZmFsc2UpOwogICAgIFN0cmluZyB0YWtlUmVzdWx0cygp OwpAQCAtMTg0LDcgKzE4NCw4IEBAIFN0cmluZyBTdHlsZWRNYXJrdXBBY2N1bXVsYXRvcjo6dGFr ZVJlc3VsdHMoKQogCiAgICAgY29uY2F0ZW5hdGVNYXJrdXAocmVzdWx0KTsKIAotICAgIHJldHVy biBTdHJpbmc6OmFkb3B0KHJlc3VsdCk7CisgICAgLy8gV2UgcmVtb3ZlICdcMCcgY2hhcmFjdGVy cyBiZWNhdXNlIHRoZXkgYXJlIG5vdCB2aXNpYmx5IHJlbmRlcmVkIHRvIHRoZSB1c2VyLgorICAg IHJldHVybiBTdHJpbmc6OmFkb3B0KHJlc3VsdCkucmVwbGFjZSgwLCAiIik7CiB9CiAKIHZvaWQg U3R5bGVkTWFya3VwQWNjdW11bGF0b3I6OmFwcGVuZFRleHQoVmVjdG9yPFVDaGFyPiYgb3V0LCBU ZXh0KiB0ZXh0KQo=