52499 2011-01-14 17:05:41 -0800 Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1 2011-01-14 17:19:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 334753 0 andersca 2011-01-14 17:05:41 -0800 Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1 334755 1 79034 andersca 2011-01-14 17:07:32 -0800 Created attachment 79034 Patch 334760 2 79034 sam 2011-01-14 17:13:01 -0800 Comment on attachment 79034 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79034&action=review > WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:184 > + const float wastedSpaceThreshold = 0.75f; You should use a double here and remove the f. 334765 3 andersca 2011-01-14 17:19:06 -0800 Committed r75849: <http://trac.webkit.org/changeset/75849> 79034 2011-01-14 17:07:32 -0800 2011-01-14 17:13:01 -0800 Patch bug-52499-20110114170730.patch text/plain 2601 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTg0NSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbXBsZW1lbnQgdGhlICJzaG91bGQgcGFpbnQgYm91bmRzIGluc3RlYWQgb2YgaW5kaXZpdWFs IHJlY3RzIiBhbGdvcml0aG0gZnJvbSBXZWJLaXQxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjQ5OQorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL0RyYXdpbmdBcmVhSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OnNob3VsZFBhaW50Qm91 bmRzUmVjdCk6CisgICAgICAgIFBvcnQgY29kZSBmcm9tIC1bV2ViVmlldyBfbXVzdERyYXdVbmlv bmVkUmVjdDpzaW5nbGVSZWN0czpjb3VudDpdLgorCisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdB cmVhSW1wbDo6ZGlzcGxheSk6CisgICAgICAgIElmIHNob3VsZFBhaW50Qm91bmRzUmVjdCByZXR1 cm5zIHRydWUsIGNsZWFyIHRoZSByZWN0cyB2ZWN0b3IgYW5kIGFwcGVuZCB0aGUgYm91bmRzIHJl Y3QuCisKIDIwMTEtMDEtMTQgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmIEdhcmVuLgpJbmRleDogV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwCShyZXZpc2lvbiA3NTgzMSkK KysrIFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE3OCw2ICsxNzgsMjcgQEAgdm9pZCBEcmF3aW5nQXJlYUltcGw6OmRpc3Bs YXkoKQogICAgIG1faXNXYWl0aW5nRm9yRGlkVXBkYXRlID0gdHJ1ZTsKIH0KIAorc3RhdGljIGJv b2wgc2hvdWxkUGFpbnRCb3VuZHNSZWN0KGNvbnN0IEludFJlY3QmIGJvdW5kcywgY29uc3QgVmVj dG9yPEludFJlY3Q+JiByZWN0cykKK3sKKyAgICBjb25zdCBzaXplX3QgcmVjdFRocmVzaG9sZCA9 IDEwOworICAgIGNvbnN0IGZsb2F0IHdhc3RlZFNwYWNlVGhyZXNob2xkID0gMC43NWY7CisKKyAg ICBpZiAocmVjdHMuc2l6ZSgpIDw9IDEgfHwgcmVjdHMuc2l6ZSgpID4gcmVjdFRocmVzaG9sZCkK KyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICAvLyBBdHRlbXB0IHRvIGd1ZXNzIHdoZXRoZXIg b3Igbm90IHdlIHNob3VsZCB1c2UgdGhlIHJlZ2lvbiBib3VuZHMgcmVjdCBvciB0aGUgaW5kaXZp ZHVhbCByZWN0cy4KKyAgICAvLyBXZSBkbyB0aGlzIGJ5IGNvbXB1dGluZyB0aGUgcGVyY2VudGFn ZSBvZiAid2FzdGVkIHNwYWNlIiBpbiB0aGUgYm91bmRzLiAgSWYgdGhhdCB3YXN0ZWQgc3BhY2UK KyAgICAvLyBpcyB0b28gbGFyZ2UsIHRoZW4gd2Ugd2lsbCBkbyBpbmRpdmlkdWFsIHJlY3QgcGFp bnRpbmcgaW5zdGVhZC4KKyAgICB1bnNpZ25lZCBsb25nIGxvbmcgYm91bmRzQXJlYSA9IGJvdW5k cy53aWR0aCgpICogYm91bmRzLmhlaWdodCgpOworICAgIHVuc2lnbmVkIGxvbmcgbG9uZyByZWN0 c0FyZWEgPSAwOworICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcmVjdHMuc2l6ZSgpOyArK2kp CisgICAgICAgIHJlY3RzQXJlYSArPSByZWN0c1tpXS53aWR0aCgpICogcmVjdHNbaV0uaGVpZ2h0 KCk7CisKKyAgICBmbG9hdCB3YXN0ZWRTcGFjZSA9IDEgLSAocmVjdHNBcmVhIC8gYm91bmRzQXJl YSk7CisKKyAgICByZXR1cm4gd2FzdGVkU3BhY2UgPD0gd2FzdGVkU3BhY2VUaHJlc2hvbGQ7Cit9 CisKIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjpkaXNwbGF5KFVwZGF0ZUluZm8mIHVwZGF0ZUluZm8p CiB7CiAgICAgLy8gRklYTUU6IEl0IHdvdWxkIGJlIGJldHRlciBpZiB3ZSBjb3VsZCBhdm9pZCBw YWludGluZyBhbHRvZ2V0aGVyIHdoZW4gdGhlcmUgaXMgYSBjdXN0b20gcmVwcmVzZW50YXRpb24u CkBAIC0xODcsNiArMjA4LDExIEBAIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjpkaXNwbGF5KFVwZGF0 ZUluZm8KICAgICBJbnRSZWN0IGJvdW5kcyA9IG1fZGlydHlSZWdpb24uYm91bmRzKCk7CiAgICAg VmVjdG9yPEludFJlY3Q+IHJlY3RzID0gbV9kaXJ0eVJlZ2lvbi5yZWN0cygpOwogCisgICAgaWYg KHNob3VsZFBhaW50Qm91bmRzUmVjdChib3VuZHMsIHJlY3RzKSkgeworICAgICAgICByZWN0cy5j bGVhcigpOworICAgICAgICByZWN0cy5hcHBlbmQoYm91bmRzKTsKKyAgICB9CisgICAgICAgIAog ICAgIG1fZGlydHlSZWdpb24gPSBSZWdpb24oKTsKICAgICBtX3Njcm9sbFJlY3QgPSBJbnRSZWN0 KCk7CiAgICAgbV9zY3JvbGxEZWx0YSA9IEludFNpemUoKTsK