52486 2011-01-14 15:28:54 -0800 Layer syncing should go through the compositor 2011-01-17 19:18:08 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser webkit-unassigned simon.fraser oldest_to_newest 334665 0 simon.fraser 2011-01-14 15:28:54 -0800 Currenly FrameView calls syncCompositingState() on the root GraphicsLayer. I think this should go via the compositor instead. 334677 1 79015 simon.fraser 2011-01-14 15:35:24 -0800 Created attachment 79015 Patch 335634 2 simon.fraser 2011-01-17 19:18:08 -0800 http://trac.webkit.org/changeset/75832 79015 2011-01-14 15:35:24 -0800 2011-01-14 15:42:49 -0800 Patch bug-52486-20110114153523.patch text/plain 5671 simon.fraser ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmODYxNTU1Njk5MDA3N2UzYTI3OGE4MTYzOTE1NTY0NDU1NDE5OTE1Li4y MWI0M2VkNGNhZDZjOTkwNWU4MmI0NjM0NTljNjQwNmU5NmRkYzc1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjcgQEAKKzIwMTEtMDEtMTQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TGF5ZXIgc3luY2luZyBzaG91bGQgZ28gdGhyb3VnaCB0aGUgY29tcG9zaXRvcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI0ODYKKworICAgICAgICBS YXRoZXIgdGhhbiBoYXZlIEZyYW1lVmlldyBnbyBkaXJlY3RseSB0byBHcmFwaGljc0xheWVyIHRv CisgICAgICAgIHN5bmMgcGVuZGluZyBjaGFuZ2VzLCByb3V0ZSB0aGUgY2FsbCB0aHJvdWdoIFJl bmRlckxheWVyQ29tcG9zaXRvci4KKyAgICAgICAgCisgICAgICAgIEFkZCBhIEZJWE1FIGFib3V0 IGFuIGV4aXN0aW5nIGlzc3VlIHdpdGggZmx1c2hpbmcgYW5kIHN1YmZyYW1lcy4KKyAgICAgICAg CisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZSwgc28gbm8gdGVzdHMuCisKKyAgICAgICAgKiBw YWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnN5bmNDb21w b3NpdGluZ1N0YXRlRm9yVGhpc0ZyYW1lKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5 ZXJCYWNraW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6bm90 aWZ5U3luY1JlcXVpcmVkKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2NoZWR1 bGVMYXllckZsdXNoKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6 Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6 Om5vdGlmeVN5bmNSZXF1aXJlZCk6CisKIDIwMTEtMDEtMTQgIEFiaGlzaGVrIEFyeWEgIDxpbmZl cm5vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIeWF0dC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCAyYzQyYWI0ZTFhZjI3ZDZmN2Q5NzRiNTI4MTUw ZWRjZWFiMDM2MzIwLi4xMTg3MzE4ZmMwMjgwYTUzMzc3ODRlYWZiYTMzOTA2OGNjMTRhYTRiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC01NTYsMTIgKzU1Niw4IEBAIHZvaWQgRnJh bWVWaWV3Ojp1cGRhdGVDb21wb3NpdGluZ0xheWVycygpCiAKIHZvaWQgRnJhbWVWaWV3OjpzeW5j Q29tcG9zaXRpbmdTdGF0ZUZvclRoaXNGcmFtZSgpCiB7Ci0gICAgUmVuZGVyVmlldyogdmlldyA9 IG1fZnJhbWUtPmNvbnRlbnRSZW5kZXJlcigpOwotICAgIEdyYXBoaWNzTGF5ZXIqIHJvb3RMYXll ciA9IHZpZXcgPyB2aWV3LT5jb21wb3NpdG9yKCktPnJvb3RQbGF0Zm9ybUxheWVyKCkgOiAwOwot ICAgIGlmICghcm9vdExheWVyKQotICAgICAgICByZXR1cm47Ci0KLSAgICByb290TGF5ZXItPnN5 bmNDb21wb3NpdGluZ1N0YXRlKCk7CisgICAgaWYgKFJlbmRlclZpZXcqIHZpZXcgPSBtX2ZyYW1l LT5jb250ZW50UmVuZGVyZXIoKSkKKyAgICAgICAgdmlldy0+Y29tcG9zaXRvcigpLT5mbHVzaFBl bmRpbmdMYXllckNoYW5nZXMoKTsKIAogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICAv LyBUaGUgZnVsbFNjcmVlblJlbmRlcmVyJ3MgZ3JhcGhpY3NMYXllciAgaGFzIGJlZW4gcmUtcGFy ZW50ZWQsIGFuZCB0aGUgYWJvdmUgcmVjdXJzaXZlIHN5bmNDb21wb3NpdGluZ1N0YXRlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IGU0 YjJmNDUwNzkzMzY4OGI3ODUxMzNkMjUyYWU4NzZiZDZkNDQzNzUuLmE2ZWQyMGYxMjQ3ODNhZDc5 MDIyODUxNTcwYmE4Y2I1YzJjZWQ1NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC0xMjY0LDcgKzEyNjQsNyBAQCB2b2lkIFJlbmRl ckxheWVyQmFja2luZzo6bm90aWZ5QW5pbWF0aW9uU3RhcnRlZChjb25zdCBHcmFwaGljc0xheWVy KiwgZG91YmxlIHRpbQogdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6Om5vdGlmeVN5bmNSZXF1aXJl ZChjb25zdCBHcmFwaGljc0xheWVyKikKIHsKICAgICBpZiAoIXJlbmRlcmVyKCktPmRvY3VtZW50 QmVpbmdEZXN0cm95ZWQoKSkKLSAgICAgICAgY29tcG9zaXRvcigpLT5zY2hlZHVsZVN5bmMoKTsK KyAgICAgICAgY29tcG9zaXRvcigpLT5zY2hlZHVsZUxheWVyRmx1c2goKTsKIH0KIAogLy8gVGhp cyBpcyB1c2VkIGZvciB0aGUgJ2ZyZWV6ZScgQVBJLCBmb3IgdGVzdGluZyBvbmx5LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRl eCA5MzEwMDhkMDRjY2M4ZjRiNzhiMmI3MjkzOWVjYzllM2JiYjZmZDFiLi4yMTU1YjM1MTlhYjlh OWNiZDhjN2Q2NDQxOTY3ZjU1YWJjODI0Mjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMTcwLDcgKzE3MCw3IEBAIHZv aWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpzZXRDb21wb3NpdGluZ0xheWVyc05lZWRSZWJ1aWxk KGJvb2wgbmVlZFJlYnVpbGQpCiAgICAgICAgIG1fY29tcG9zaXRpbmdMYXllcnNOZWVkUmVidWls ZCA9IG5lZWRSZWJ1aWxkOwogfQogCi12b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2NoZWR1 bGVTeW5jKCkKK3ZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpzY2hlZHVsZUxheWVyRmx1c2go KQogewogICAgIEZyYW1lKiBmcmFtZSA9IG1fcmVuZGVyVmlldy0+ZnJhbWVWaWV3KCktPmZyYW1l KCk7CiAgICAgUGFnZSogcGFnZSA9IGZyYW1lID8gZnJhbWUtPnBhZ2UoKSA6IDA7CkBAIC0xODAs NiArMTgwLDE2IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpzY2hlZHVsZVN5bmMoKQog ICAgIHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+c2NoZWR1bGVDb21wb3NpdGluZ0xheWVyU3lu YygpOwogfQogCit2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6Zmx1c2hQZW5kaW5nTGF5ZXJD aGFuZ2VzKCkKK3sKKyAgICAvLyBGSVhNRTogRnJhbWVWaWV3OjpzeW5jQ29tcG9zaXRpbmdTdGF0 ZVJlY3Vyc2l2ZSgpIGNhbGxzIHRoaXMgZm9yIGVhY2gKKyAgICAvLyBmcmFtZSwgc28gd2hlbiBj b21wb3NpdGluZyBsYXllcnMgYXJlIGNvbm5lY3RlZCBiZXR3ZWVuIGZyYW1lcywgd2UnbGwKKyAg ICAvLyBlbmQgdXAgc3luY2luZyBzdWJmcmFtZSdzIGxheWVycyBtdWx0aXBsZSB0aW1lcy4KKyAg ICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI0ODkKKyAgICBp ZiAoR3JhcGhpY3NMYXllciogcm9vdExheWVyID0gcm9vdFBsYXRmb3JtTGF5ZXIoKSkKKyAgICAg ICAgcm9vdExheWVyLT5zeW5jQ29tcG9zaXRpbmdTdGF0ZSgpOworfQorCiB2b2lkIFJlbmRlckxh eWVyQ29tcG9zaXRvcjo6c2NoZWR1bGVDb21wb3NpdGluZ0xheWVyVXBkYXRlKCkKIHsKICAgICBp ZiAoIW1fdXBkYXRlQ29tcG9zaXRpbmdMYXllcnNUaW1lci5pc0FjdGl2ZSgpKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCmluZGV4IDQ5NzU5 YjUyZmU2ZTA1Mzk0YWE2Y2I5YmI4MTFiNWI0MjQxOWExNzYuLmZjMzZkY2FhNTgwMTQ0Y2VkODRi OWQ2YzAyZGFiMzY5ZmRmZWY0ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKQEAgLTg0LDcgKzg0LDEwIEBAIHB1YmxpYzoKICAgICB2 b2lkIHNldENvbXBvc2l0aW5nQ29uc3VsdHNPdmVybGFwKGJvb2wgYikgeyBtX2NvbXBvc2l0aW5n Q29uc3VsdHNPdmVybGFwID0gYjsgfQogICAgIGJvb2wgY29tcG9zaXRpbmdDb25zdWx0c092ZXJs YXAoKSBjb25zdCB7IHJldHVybiBtX2NvbXBvc2l0aW5nQ29uc3VsdHNPdmVybGFwOyB9CiAgICAg Ci0gICAgdm9pZCBzY2hlZHVsZVN5bmMoKTsKKyAgICAvLyBHcmFwaGljc0xheWVycyBidWZmZXIg c3RhdGUsIHdoaWNoIGdldHMgcHVzaGVkIHRvIHRoZSB1bmRlcmx5aW5nIHBsYXRmb3JtIGxheWVy cworICAgIC8vIGF0IHNwZWNpZmljIHRpbWVzLgorICAgIHZvaWQgc2NoZWR1bGVMYXllckZsdXNo KCk7CisgICAgdm9pZCBmbHVzaFBlbmRpbmdMYXllckNoYW5nZXMoKTsKICAgICAKICAgICAvLyBS ZWJ1aWxkIHRoZSB0cmVlIG9mIGNvbXBvc2l0aW5nIGxheWVycwogICAgIHZvaWQgdXBkYXRlQ29t cG9zaXRpbmdMYXllcnMoQ29tcG9zaXRpbmdVcGRhdGVUeXBlID0gQ29tcG9zaXRpbmdVcGRhdGVB ZnRlckxheW91dE9yU3R5bGVDaGFuZ2UsIFJlbmRlckxheWVyKiB1cGRhdGVSb290ID0gMCk7CkBA IC0xNzksNyArMTgyLDcgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICAvLyBHcmFwaGljc0xheWVy Q2xpZW50IEltcGxlbWVudGF0aW9uCiAgICAgdmlydHVhbCB2b2lkIG5vdGlmeUFuaW1hdGlvblN0 YXJ0ZWQoY29uc3QgR3JhcGhpY3NMYXllciosIGRvdWJsZSkgeyB9Ci0gICAgdmlydHVhbCB2b2lk IG5vdGlmeVN5bmNSZXF1aXJlZChjb25zdCBHcmFwaGljc0xheWVyKikgeyBzY2hlZHVsZVN5bmMo KTsgfQorICAgIHZpcnR1YWwgdm9pZCBub3RpZnlTeW5jUmVxdWlyZWQoY29uc3QgR3JhcGhpY3NM YXllciopIHsgc2NoZWR1bGVMYXllckZsdXNoKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRD b250ZW50cyhjb25zdCBHcmFwaGljc0xheWVyKiwgR3JhcGhpY3NDb250ZXh0JiwgR3JhcGhpY3NM YXllclBhaW50aW5nUGhhc2UsIGNvbnN0IEludFJlY3QmKSB7IH0KIAogICAgIC8vIFRoZXNlIGNh bGxzIHJldHVybiBmYWxzZSBhbHdheXMuIFRoZXkgYXJlIHNheWluZyB0aGF0IHRoZSBsYXllcnMg YXNzb2NpYXRlZCB3aXRoIHRoaXMgY2xpZW50Cg==