52485 2011-01-14 15:26:34 -0800 make line selection have a extend only from where you start the selection in the code review tool 2011-01-20 11:21:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth aroben eric mihaip oldest_to_newest 334662 0 ojan 2011-01-14 15:26:34 -0800 make line selection have a extend only from where you start the selection in the code review tool 334663 1 79012 ojan 2011-01-14 15:26:59 -0800 Created attachment 79012 Patch 334668 2 ojan 2011-01-14 15:29:54 -0800 As requested in bug 52462. 334777 3 79012 abarth 2011-01-14 17:36:48 -0800 Comment on attachment 79012 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79012&action=review This code reads very nicely with all these helper functions to convert between representations. > Websites/bugs.webkit.org/code-review.js:1067 > + while (current_index <= last_index) { > + $('#line' + current_index).addClass('selected') > + current_index++; > + } This looks like it could get expensive with a large selection. Have you tested a large selection? 334809 4 ojan 2011-01-14 18:27:37 -0800 (In reply to comment #3) > (From update of attachment 79012 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79012&action=review > > > Websites/bugs.webkit.org/code-review.js:1067 > > + while (current_index <= last_index) { > > + $('#line' + current_index).addClass('selected') > > + current_index++; > > + } > > This looks like it could get expensive with a large selection. Have you tested a large selection? There's only so large of a selection you can make given that we don't scroll. You can get at most 1 screenful of lines. In other words, you can't make a large selection. 337441 5 ojan 2011-01-20 10:49:23 -0800 Ping. 337450 6 79012 abarth 2011-01-20 11:02:46 -0800 Comment on attachment 79012 Patch Oops. Sorry. 337461 7 ojan 2011-01-20 11:21:54 -0800 Committed r76268: <http://trac.webkit.org/changeset/76268> 79012 2011-01-14 15:26:59 -0800 2011-01-20 11:02:46 -0800 Patch bug-52485-20110114152658.patch text/plain 3362 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDI3ZjAxZTQ4NTNlOTMzZjNkMGQ4YTQx ZGM5ZDRiODJmYmFlNTY3ZWIuLjJkM2MwZGI3MDQ4ZmE4NzVjNWY1OTlkMjQwN2M0MDI0Mjg1ZDY2 M2IgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEx LTAxLTE0ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbWFrZSBsaW5lIHNlbGVjdGlvbiBoYXZl IGEgZXh0ZW5kIG9ubHkgZnJvbSB3aGVyZSB5b3Ugc3RhcnQgdGhlIHNlbGVjdGlvbiBpbiB0aGUg Y29kZSByZXZpZXcgdG9vbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTI0ODUKKworICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOgorCisyMDExLTAxLTE0 ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBCYXJ0aC4KIAogICAgICAgICBpbXByb3ZlIGxpbmUgc2VsZWN0aW9uIHdpdGggZmFzdCBk cmFncwpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3Lmpz IGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzCmluZGV4IDhhYjc4OTlk Njc3NDM3YTM4MmE5NDljY2FhNzk4MTRlMWUzYTc0MTIuLmM4ODJhOWI4ZTBmNTNjNDM4ODA1MmVj MjllZDhiNTliYjI1YzBkZmUgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9j b2RlLXJldmlldy5qcworKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcu anMKQEAgLTEwMjMsMTEgKzEwMjMsMTEgQEAKICAgICB9KTsKICAgfQogCi0gIHZhciBpbl9kcmFn X3NlbGVjdCA9IGZhbHNlOworICB2YXIgZHJhZ19zZWxlY3Rfc3RhcnRfaW5kZXggPSAtMTsKIAog ICBmdW5jdGlvbiBzdG9wRHJhZ1NlbGVjdCgpIHsKICAgICAkKCcuc2VsZWN0ZWQnKS5yZW1vdmVD bGFzcygnc2VsZWN0ZWQnKTsKLSAgICBpbl9kcmFnX3NlbGVjdCA9IGZhbHNlOworICAgIGRyYWdf c2VsZWN0X3N0YXJ0X2luZGV4ID0gLTE7CiAgIH0KIAogICBmdW5jdGlvbiBsaW5lT2Zmc2V0RnJv bShsaW5lLCBvZmZzZXQpIHsKQEAgLTEwNTAsMzMgKzEwNTAsMzkgQEAKICAgICBpZiAobGluZS5o YXNDbGFzcygnY29tbWVudENvbnRleHQnKSkKICAgICAgIHRyaW1Db21tZW50Q29udGV4dFRvQmVm b3JlKHByZXZpb3VzTGluZUZvcihsaW5lKSwgbGluZS5hdHRyKCdkYXRhLWNvbW1lbnQtYmFzZS1s aW5lJykpOwogICB9KS5saXZlKCdtb3VzZWRvd24nLCBmdW5jdGlvbigpIHsKLSAgICBpbl9kcmFn X3NlbGVjdCA9IHRydWU7Ci0gICAgbGluZUZyb21MaW5lRGVzY2VuZGFudCgkKHRoaXMpKS5hZGRD bGFzcygnc2VsZWN0ZWQnKTsKKyAgICB2YXIgbGluZSA9IGxpbmVGcm9tTGluZURlc2NlbmRhbnQo JCh0aGlzKSk7CisgICAgZHJhZ19zZWxlY3Rfc3RhcnRfaW5kZXggPSBudW1iZXJGcm9tKGxpbmUu YXR0cignaWQnKSk7CisgICAgbGluZS5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKICAgICBldmVudC5w cmV2ZW50RGVmYXVsdCgpOwogICB9KTsKIAorICBmdW5jdGlvbiBzZWxlY3RUbyhmb2N1c19pbmRl eCkgeworICAgIHZhciBzZWxlY3RlZCA9ICQoJy5zZWxlY3RlZCcpLnJlbW92ZUNsYXNzKCdzZWxl Y3RlZCcpOworICAgIHZhciBpc19iYWNrd2FyZCA9IGRyYWdfc2VsZWN0X3N0YXJ0X2luZGV4ID4g Zm9jdXNfaW5kZXg7CisgICAgdmFyIGN1cnJlbnRfaW5kZXggPSBpc19iYWNrd2FyZCA/IGZvY3Vz X2luZGV4IDogZHJhZ19zZWxlY3Rfc3RhcnRfaW5kZXg7CisgICAgdmFyIGxhc3RfaW5kZXggPSBp c19iYWNrd2FyZCA/IGRyYWdfc2VsZWN0X3N0YXJ0X2luZGV4IDogZm9jdXNfaW5kZXg7CisgICAg d2hpbGUgKGN1cnJlbnRfaW5kZXggPD0gbGFzdF9pbmRleCkgeworICAgICAgJCgnI2xpbmUnICsg Y3VycmVudF9pbmRleCkuYWRkQ2xhc3MoJ3NlbGVjdGVkJykKKyAgICAgIGN1cnJlbnRfaW5kZXgr KzsKKyAgICB9CisgIH0KKworICBmdW5jdGlvbiBzZWxlY3RUb0xpbmVDb250YWluZXIobGluZV9j b250YWluZXIpIHsKKyAgICB2YXIgbGluZSA9IGxpbmVGcm9tTGluZUNvbnRhaW5lcihsaW5lX2Nv bnRhaW5lcik7CisgICAgc2VsZWN0VG8obnVtYmVyRnJvbShsaW5lLmF0dHIoJ2lkJykpKTsKKyAg fQorCiAgICQoJy5MaW5lQ29udGFpbmVyJykubGl2ZSgnbW91c2VlbnRlcicsIGZ1bmN0aW9uKCkg ewotICAgIGlmICghaW5fZHJhZ19zZWxlY3QpCisgICAgaWYgKGRyYWdfc2VsZWN0X3N0YXJ0X2lu ZGV4ID09IC0xKQogICAgICAgcmV0dXJuOwotCi0gICAgdmFyIGxpbmUgPSBsaW5lRnJvbUxpbmVD b250YWluZXIodGhpcyk7Ci0gICAgbGluZS5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKKyAgICBzZWxl Y3RUb0xpbmVDb250YWluZXIodGhpcyk7CiAgIH0pLmxpdmUoJ21vdXNldXAnLCBmdW5jdGlvbigp IHsKLSAgICBpZiAoIWluX2RyYWdfc2VsZWN0KQorICAgIGlmIChkcmFnX3NlbGVjdF9zdGFydF9p bmRleCA9PSAtMSkKICAgICAgIHJldHVybjsKIAotICAgIHZhciBzZWxlY3RlZCA9ICQoJy5zZWxl Y3RlZCcpOwotCi0gICAgLy8gU2VsZWN0IGFsbCB0aGUgbGluZXMgYmV0d2VlbiB0aGUgZmlyc3Qg YW5kIGxhc3Qgc2VsZWN0ZWQgbGluZXMKLSAgICAvLyBpbiBjYXNlIHdlIGRpZG4ndCBnZXQgbW91 c2VlbnRlciBldmVudHMgZm9yIGFueSBvZiB0aGVtLgotICAgIHZhciBjdXJyZW50X2luZGV4ID0g bnVtYmVyRnJvbShzZWxlY3RlZC5maXJzdCgpLmF0dHIoJ2lkJykpOwotICAgIHZhciBsYXN0X2lu ZGV4ID0gbnVtYmVyRnJvbShzZWxlY3RlZC5sYXN0KCkuYXR0cignaWQnKSk7Ci0gICAgd2hpbGUg KGN1cnJlbnRfaW5kZXggIT0gbGFzdF9pbmRleCkgewotICAgICAgJCgnI2xpbmUnICsgY3VycmVu dF9pbmRleCkuYWRkQ2xhc3MoJ3NlbGVjdGVkJykKLSAgICAgIGN1cnJlbnRfaW5kZXgrKzsKLSAg ICB9CisgICAgc2VsZWN0VG9MaW5lQ29udGFpbmVyKHRoaXMpOwogCi0gICAgc2VsZWN0ZWQgPSAk KCcuc2VsZWN0ZWQnKTsKKyAgICB2YXIgc2VsZWN0ZWQgPSAkKCcuc2VsZWN0ZWQnKTsKICAgICB2 YXIgYWxyZWFkeV9oYXNfY29tbWVudCA9IHNlbGVjdGVkLmxhc3QoKS5oYXNDbGFzcygnY29tbWVu dENvbnRleHQnKTsKICAgICBzZWxlY3RlZC5hZGRDbGFzcygnY29tbWVudENvbnRleHQnKTsKIAo=