52476 2011-01-14 13:55:35 -0800 ShouldLoadResourceForFrame should use strings, not URLs. 2011-04-07 11:09:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein ap aroben sam oldest_to_newest 334577 0 bweinstein 2011-01-14 13:55:35 -0800 ShouldLoadResourceForFrame should use strings, not URLs. 334601 1 78997 bweinstein 2011-01-14 14:11:46 -0800 Created attachment 78997 [PATCH] Fix 334606 2 78997 ggaren 2011-01-14 14:18:53 -0800 Comment on attachment 78997 [PATCH] Fix r=me 334859 3 ap 2011-01-14 22:48:14 -0800 Just for the education of unwashed masses (myself) - what's the reason for this change? 334904 4 ap 2011-01-15 11:13:39 -0800 I can see how avoiding a string to URL conversion in injected bundle method makes a lot of sense for performance. But WebKit obviously needs a KURL when loading - can you use an existing KURL object to pass to InjectedBundlePageLoaderClient::shouldLoadResourceForFrame()? 381497 5 bweinstein 2011-04-07 11:09:54 -0700 This was landed in r75826. 78997 2011-01-14 14:11:46 -0800 2011-01-14 14:18:52 -0800 [PATCH] Fix should_load_resource_refactor.patch text/plain 5749 bweinstein SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc1ODE0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDEtMTQgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNo b3VsZExvYWRSZXNvdXJjZUZvckZyYW1lIHNob3VsZCB1c2Ugc3RyaW5ncywgbm90IFVSTHMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjQ3NgorCisg ICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBh Z2UuY3BwOgorICAgICAgICAoV1RSOjpJbmplY3RlZEJ1bmRsZVBhZ2U6OnNob3VsZExvYWRSZXNv dXJjZUZvckZyYW1lKTogVXBkYXRlIHRvIHVzZSBhIFdLU3RyaW5nUmVmLgorICAgICAgICAqIFdl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmg6CisKIDIw MTEtMDEtMTQgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9Jbmpl Y3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcAkocmV2 aXNpb24gNzU3MzQpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0lu amVjdGVkQnVuZGxlUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMyw3ICszMjMsNyBAQCB2 b2lkIEluamVjdGVkQnVuZGxlUGFnZTo6ZGlkUnVuSW5zZWN1cmVDCiAgICAgc3RhdGljX2Nhc3Q8 SW5qZWN0ZWRCdW5kbGVQYWdlKj4oY29uc3RfY2FzdDx2b2lkKj4oY2xpZW50SW5mbykpLT5kaWRS dW5JbnNlY3VyZUNvbnRlbnRGb3JGcmFtZShmcmFtZSk7CiB9CiAKLWJvb2wgSW5qZWN0ZWRCdW5k bGVQYWdlOjpzaG91bGRMb2FkUmVzb3VyY2VGb3JGcmFtZShXS0J1bmRsZVBhZ2VSZWYgcGFnZSwg V0tCdW5kbGVGcmFtZVJlZiBmcmFtZSwgV0tVUkxSZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8p Citib29sIEluamVjdGVkQnVuZGxlUGFnZTo6c2hvdWxkTG9hZFJlc291cmNlRm9yRnJhbWUoV0tC dW5kbGVQYWdlUmVmIHBhZ2UsIFdLQnVuZGxlRnJhbWVSZWYgZnJhbWUsIFdLU3RyaW5nUmVmLCBj b25zdCB2b2lkKiBjbGllbnRJbmZvKQogewogICAgIHJldHVybiBzdGF0aWNfY2FzdDxJbmplY3Rl ZEJ1bmRsZVBhZ2UqPihjb25zdF9jYXN0PHZvaWQqPihjbGllbnRJbmZvKSktPnNob3VsZExvYWRS ZXNvdXJjZUZvckZyYW1lKGZyYW1lKTsKIH0KSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2UuaAkocmV2 aXNpb24gNzU3MzQpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0lu amVjdGVkQnVuZGxlUGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02NCw3ICs2NCw3IEBAIHByaXZh dGU6CiAgICAgc3RhdGljIHZvaWQgZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9yRnJhbWUoV0tCdW5k bGVQYWdlUmVmLCBXS0J1bmRsZUZyYW1lUmVmLCBjb25zdCB2b2lkKik7CiAgICAgc3RhdGljIHZv aWQgZGlkRGlzcGxheUluc2VjdXJlQ29udGVudEZvckZyYW1lKFdLQnVuZGxlUGFnZVJlZiwgV0tC dW5kbGVGcmFtZVJlZiwgV0tUeXBlUmVmKiwgY29uc3Qgdm9pZCopOwogICAgIHN0YXRpYyB2b2lk IGRpZFJ1bkluc2VjdXJlQ29udGVudEZvckZyYW1lKFdLQnVuZGxlUGFnZVJlZiwgV0tCdW5kbGVG cmFtZVJlZiwgV0tUeXBlUmVmKiwgY29uc3Qgdm9pZCopOwotICAgIHN0YXRpYyBib29sIHNob3Vs ZExvYWRSZXNvdXJjZUZvckZyYW1lKFdLQnVuZGxlUGFnZVJlZiwgV0tCdW5kbGVGcmFtZVJlZiwg V0tVUkxSZWYsIGNvbnN0IHZvaWQqKTsKKyAgICBzdGF0aWMgYm9vbCBzaG91bGRMb2FkUmVzb3Vy Y2VGb3JGcmFtZShXS0J1bmRsZVBhZ2VSZWYsIFdLQnVuZGxlRnJhbWVSZWYsIFdLU3RyaW5nUmVm LCBjb25zdCB2b2lkKik7CiAgICAgdm9pZCBkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyYW1l KFdLQnVuZGxlRnJhbWVSZWYpOwogICAgIHZvaWQgZGlkUmVjZWl2ZVNlcnZlclJlZGlyZWN0Rm9y UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUoV0tCdW5kbGVGcmFtZVJlZik7CiAgICAgdm9pZCBkaWRG YWlsUHJvdmlzaW9uYWxMb2FkV2l0aEVycm9yRm9yRnJhbWUoV0tCdW5kbGVGcmFtZVJlZiwgV0tF cnJvclJlZik7CkluZGV4OiBXZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQy L0NoYW5nZUxvZwkocmV2aXNpb24gNzU4MTMpCisrKyBXZWJLaXQyL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTAxLTE0ICBCcmlhbiBXZWluc3RlaW4gIDxi d2VpbnN0ZWluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaG91bGRMb2FkUmVzb3VyY2VGb3JGcmFtZSBzaG91bGQgdXNlIHN0cmlu Z3MsIG5vdCBVUkxzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTI0NzYKKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2Mv V0tCdW5kbGVQYWdlLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9Jbmpl Y3RlZEJ1bmRsZVBhZ2VMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpJbmplY3Rl ZEJ1bmRsZVBhZ2VMb2FkZXJDbGllbnQ6OnNob3VsZExvYWRSZXNvdXJjZUZvckZyYW1lKTogUGFz cyByZXNvdXJjZVVSTCBhcyBhIHN0cmluZyBpbnN0ZWFkIG9mCisgICAgICAgICAgICBhIFVSTCwg YW5kIHJlbmFtZSBmcm9tIHN1YnJlc291cmNlVVJMIHRvIHJlc291cmNlVVJMLgorCiAyMDExLTAx LTE0ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IFdlYktpdDIv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2VMb2FkZXJDbGllbnQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9Jbmpl Y3RlZEJ1bmRsZVBhZ2VMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiA3NTczNCkKKysrIFdlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2VMb2FkZXJDbGll bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzUsMTIgKzE3NSwxMiBAQCB2b2lkIEluamVjdGVk QnVuZGxlUGFnZUxvYWRlckNsaWVudDo6ZGlkCiAgICAgdXNlckRhdGEgPSBhZG9wdFJlZih0b0lt cGwodXNlckRhdGFUb1Bhc3MpKTsKIH0KIAotYm9vbCBJbmplY3RlZEJ1bmRsZVBhZ2VMb2FkZXJD bGllbnQ6OnNob3VsZExvYWRSZXNvdXJjZUZvckZyYW1lKFdlYlBhZ2UqIHBhZ2UsIFdlYkZyYW1l KiBmcmFtZSwgY29uc3QgU3RyaW5nJiBzdWJSZXNvdXJjZVVSTCkKK2Jvb2wgSW5qZWN0ZWRCdW5k bGVQYWdlTG9hZGVyQ2xpZW50OjpzaG91bGRMb2FkUmVzb3VyY2VGb3JGcmFtZShXZWJQYWdlKiBw YWdlLCBXZWJGcmFtZSogZnJhbWUsIGNvbnN0IFN0cmluZyYgcmVzb3VyY2VVUkwpCiB7CiAgICAg aWYgKCFtX2NsaWVudC5zaG91bGRMb2FkUmVzb3VyY2VGb3JGcmFtZSkKICAgICAgICAgcmV0dXJu IHRydWU7CiAKLSAgICByZXR1cm4gbV9jbGllbnQuc2hvdWxkTG9hZFJlc291cmNlRm9yRnJhbWUo dG9BUEkocGFnZSksIHRvQVBJKGZyYW1lKSwgdG9VUkxSZWYoc3ViUmVzb3VyY2VVUkwuaW1wbCgp KSwgbV9jbGllbnQuY2xpZW50SW5mbyk7CisgICAgcmV0dXJuIG1fY2xpZW50LnNob3VsZExvYWRS ZXNvdXJjZUZvckZyYW1lKHRvQVBJKHBhZ2UpLCB0b0FQSShmcmFtZSksIHRvQVBJKHJlc291cmNl VVJMLmltcGwoKSksIG1fY2xpZW50LmNsaWVudEluZm8pOwogfQogCiB2b2lkIEluamVjdGVkQnVu ZGxlUGFnZUxvYWRlckNsaWVudDo6ZGlkQ2xlYXJXaW5kb3dPYmplY3RGb3JGcmFtZShXZWJQYWdl KiBwYWdlLCBXZWJGcmFtZSogZnJhbWUsIERPTVdyYXBwZXJXb3JsZCogd29ybGQpCkluZGV4OiBX ZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVu ZGxlUGFnZS5oCShyZXZpc2lvbiA3NTczNCkKKysrIFdlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtODcsNyArODcs NyBAQCB0eXBlZGVmIHZvaWQgKCpXS0J1bmRsZVBhZ2VEaWRDbGVhcldpbmRvCiB0eXBlZGVmIHZv aWQgKCpXS0J1bmRsZVBhZ2VEaWRDYW5jZWxDbGllbnRSZWRpcmVjdEZvckZyYW1lQ2FsbGJhY2sp KFdLQnVuZGxlUGFnZVJlZiBwYWdlLCBXS0J1bmRsZUZyYW1lUmVmIGZyYW1lLCBjb25zdCB2b2lk ICpjbGllbnRJbmZvKTsKIHR5cGVkZWYgdm9pZCAoKldLQnVuZGxlUGFnZVdpbGxQZXJmb3JtQ2xp ZW50UmVkaXJlY3RGb3JGcmFtZUNhbGxiYWNrKShXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tCdW5k bGVGcmFtZVJlZiBmcmFtZSwgV0tVUkxSZWYgdXJsLCBkb3VibGUgZGVsYXksIGRvdWJsZSBkYXRl LCBjb25zdCB2b2lkICpjbGllbnRJbmZvKTsKIHR5cGVkZWYgdm9pZCAoKldLQnVuZGxlUGFnZURp ZEhhbmRsZU9ubG9hZEV2ZW50c0ZvckZyYW1lQ2FsbGJhY2spKFdLQnVuZGxlUGFnZVJlZiBwYWdl LCBXS0J1bmRsZUZyYW1lUmVmIGZyYW1lLCBjb25zdCB2b2lkICpjbGllbnRJbmZvKTsKLXR5cGVk ZWYgYm9vbCAoKldLQnVuZGxlUGFnZVNob3VsZExvYWRSZXNvdXJjZUZvckZyYW1lQ2FsbGJhY2sp KFdLQnVuZGxlUGFnZVJlZiBwYWdlLCBXS0J1bmRsZUZyYW1lUmVmIGZyYW1lLCBXS1VSTFJlZiB1 cmwsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwordHlwZWRlZiBib29sICgqV0tCdW5kbGVQYWdl U2hvdWxkTG9hZFJlc291cmNlRm9yRnJhbWVDYWxsYmFjaykoV0tCdW5kbGVQYWdlUmVmIHBhZ2Us IFdLQnVuZGxlRnJhbWVSZWYgZnJhbWUsIFdLU3RyaW5nUmVmIHVybCwgY29uc3Qgdm9pZCAqY2xp ZW50SW5mbyk7CiAKIAogc3RydWN0IFdLQnVuZGxlUGFnZUxvYWRlckNsaWVudCB7Cg==