52462 2011-01-14 11:39:02 -0800 tweak line selection in code review tool 2011-01-14 14:01:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth aroben eric mihaip oldest_to_newest 334455 0 ojan 2011-01-14 11:39:02 -0800 tweak line selection in code review tool 334459 1 78970 ojan 2011-01-14 11:42:01 -0800 Created attachment 78970 Patch 334570 2 78970 abarth 2011-01-14 13:42:59 -0800 Comment on attachment 78970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78970&action=review I'm not sure I quite follow 100%, but this looks fine. > Websites/bugs.webkit.org/ChangeLog:14 > + -Make it so that if you click on the line immediately above > + a line that has a comment it will add a new comment instead of > + adding lines to the following comment. If the last selected line > + overlaps existing comment lines though they will still get > + added to the existing comment. Interesting. That's a nice refinement. One thing I'd like to do better is if you drag select a bunch of lines and then move your mouse backwards, you should "unselect" some lines. Currently, once selected, there is no unselect. 334583 3 ojan 2011-01-14 13:58:25 -0800 (In reply to comment #2) > (From update of attachment 78970 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78970&action=review > Interesting. That's a nice refinement. One thing I'd like to do better is if you drag select a bunch of lines and then move your mouse backwards, you should "unselect" some lines. Currently, once selected, there is no unselect. Oh. I thought that was by design. I'd be happy to fix this. 334590 4 ojan 2011-01-14 14:01:10 -0800 Committed r75816: <http://trac.webkit.org/changeset/75816> 78970 2011-01-14 11:42:01 -0800 2011-01-14 13:42:59 -0800 Patch bug-52462-20110114114158.patch text/plain 5093 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDIzZThlODAyN2U0NTg0OWYyMmQxYmM2 Y2JlODliNDE2Yjg5ODcxNDguLjE4MzVlZGM1NmYwOGMxMDdjYjlmMzEwMmM4NDMwODRlNDUwZjYw OWYgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEx LTAxLTE0ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdHdlYWsgbGluZSBzZWxlY3Rpb24gaW4g Y29kZSByZXZpZXcgdG9vbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTI0NjIKKworICAgICAgICAtSW1wcm92ZSBoYW5kbGluZyBvZiBkYXRhLWNvbW1l bnQtYmFzZS1saW5lIGNvZGUgdG8gZGVhbCB3aXRoCisgICAgICAgIGxpbmVzIHRoYXQgaGF2ZSBt dWx0aXBsZSB2YWx1ZXMuCisgICAgICAgIC1NYWtlIGl0IHNvIHRoYXQgaWYgeW91IGNsaWNrIG9u IHRoZSBsaW5lIGltbWVkaWF0ZWx5IGFib3ZlCisgICAgICAgIGEgbGluZSB0aGF0IGhhcyBhIGNv bW1lbnQgaXQgd2lsbCBhZGQgYSBuZXcgY29tbWVudCBpbnN0ZWFkIG9mCisgICAgICAgIGFkZGlu ZyBsaW5lcyB0byB0aGUgZm9sbG93aW5nIGNvbW1lbnQuIElmIHRoZSBsYXN0IHNlbGVjdGVkIGxp bmUKKyAgICAgICAgb3ZlcmxhcHMgZXhpc3RpbmcgY29tbWVudCBsaW5lcyB0aG91Z2ggdGhleSB3 aWxsIHN0aWxsIGdldAorICAgICAgICBhZGRlZCB0byB0aGUgZXhpc3RpbmcgY29tbWVudC4KKwor ICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOgorCiAyMDExLTAxLTEzICBPamFuIFZhZmFpICA8b2ph bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAt LWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcyBiL1dlYnNpdGVz L2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcwppbmRleCBhOGJkZTQwNTI0YWNmZWFiMDZk MmMyOTk4MDJlMTdkNzBhNTZiMzYxLi5hZjQ4Nzc4MDgzMTU0Y2ZiMmExZWM5OGQxYTgzMGE2ZmJl ZDM3ZTkxIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcu anMKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzCkBAIC05MTMs NyArOTEzLDcgQEAKICAgICBmaW5kQ29tbWVudEJsb2NrRm9yKGxpbmUpLnNsaWRlVXAoJ2Zhc3Qn LCBmdW5jdGlvbigpIHsKICAgICAgICQodGhpcykucmVtb3ZlKCk7CiAgICAgICBsaW5lLnJlbW92 ZUF0dHIoJ2RhdGEtaGFzLWNvbW1lbnQnKTsKLSAgICAgIHRyaW1Db21tZW50Q29udGV4dFRvQmVm b3JlKGxpbmUpOworICAgICAgdHJpbUNvbW1lbnRDb250ZXh0VG9CZWZvcmUobGluZSwgbGluZS5h dHRyKCdkYXRhLWNvbW1lbnQtYmFzZS1saW5lJykpOwogICAgIH0pOwogICB9CiAKQEAgLTk5Niwy MyArOTk2LDI3IEBACiAgICAgfQogICB9KTsKIAotICBmdW5jdGlvbiBjb250ZXh0TGluZXNGb3Io bGluZV9pZCkgewotICAgIHJldHVybiAkKCdkaXZbZGF0YS1jb21tZW50LWJhc2UtbGluZX49Iicg KyBsaW5lX2lkICsgJyJdJyk7CisgIGZ1bmN0aW9uIGNvbnRleHRMaW5lc0Zvcihjb21tZW50X2Jh c2VfbGluZXMsIGZpbGVfZGlmZikgeworICAgIHZhciBiYXNlX2xpbmVzID0gY29tbWVudF9iYXNl X2xpbmVzLnNwbGl0KCcgJyk7CisgICAgcmV0dXJuICQoJ2RpdltkYXRhLWNvbW1lbnQtYmFzZS1s aW5lXScsIGZpbGVfZGlmZikuZmlsdGVyKGZ1bmN0aW9uKCkgeworICAgICAgcmV0dXJuICQodGhp cykuYXR0cignZGF0YS1jb21tZW50LWJhc2UtbGluZScpLnNwbGl0KCcgJykuc29tZShmdW5jdGlv bihpdGVtKSB7CisgICAgICAgIHJldHVybiBiYXNlX2xpbmVzLmluZGV4T2YoaXRlbSkgIT0gLTE7 CisgICAgICB9KTsKKyAgICB9KTsKICAgfQogCiAgIGZ1bmN0aW9uIG51bWJlckZyb20obGluZV9p ZCkgewogICAgIHJldHVybiBOdW1iZXIobGluZV9pZC5yZXBsYWNlKCdsaW5lJywgJycpKTsKICAg fQogCi0gIGZ1bmN0aW9uIHRyaW1Db21tZW50Q29udGV4dFRvQmVmb3JlKGxpbmUpIHsKLSAgICB2 YXIgYmFzZV9saW5lX2lkID0gbGluZS5hdHRyKCdkYXRhLWNvbW1lbnQtYmFzZS1saW5lJyk7Cisg IGZ1bmN0aW9uIHRyaW1Db21tZW50Q29udGV4dFRvQmVmb3JlKGxpbmUsIGNvbW1lbnRfYmFzZV9s aW5lKSB7CiAgICAgdmFyIGxpbmVfdG9fdHJpbV90byA9IG51bWJlckZyb20obGluZS5hdHRyKCdp ZCcpKTsKLSAgICBjb250ZXh0TGluZXNGb3IoYmFzZV9saW5lX2lkKS5lYWNoKGZ1bmN0aW9uKCkg eworICAgIGNvbnRleHRMaW5lc0Zvcihjb21tZW50X2Jhc2VfbGluZSwgZmlsZURpZmZGb3IobGlu ZSkpLmVhY2goZnVuY3Rpb24oKSB7CiAgICAgICB2YXIgaWQgPSAkKHRoaXMpLmF0dHIoJ2lkJyk7 CiAgICAgICBpZiAobnVtYmVyRnJvbShpZCkgPiBsaW5lX3RvX3RyaW1fdG8pCiAgICAgICAgIHJl dHVybjsKIAotICAgICAgcmVtb3ZlRGF0YUNvbW1lbnRCYXNlTGluZSh0aGlzLCBiYXNlX2xpbmVf aWQpOworICAgICAgcmVtb3ZlRGF0YUNvbW1lbnRCYXNlTGluZSh0aGlzLCBjb21tZW50X2Jhc2Vf bGluZSk7CiAgICAgICBpZiAoISQodGhpcykuYXR0cignZGF0YS1jb21tZW50LWJhc2UtbGluZScp KQogICAgICAgICAkKHRoaXMpLnJlbW92ZUNsYXNzKCdjb21tZW50Q29udGV4dCcpOwogICAgIH0p OwpAQCAtMTA0Myw3ICsxMDQ3LDcgQEAKICAgJCgnLmxpbmVOdW1iZXInKS5saXZlKCdjbGljaycs IGZ1bmN0aW9uKCkgewogICAgIHZhciBsaW5lID0gJCh0aGlzKS5wYXJlbnRzKCcuTGluZScpOwog ICAgIGlmIChsaW5lLmhhc0NsYXNzKCdjb21tZW50Q29udGV4dCcpKQotICAgICAgdHJpbUNvbW1l bnRDb250ZXh0VG9CZWZvcmUocHJldmlvdXNMaW5lRm9yKGxpbmUpKTsKKyAgICAgIHRyaW1Db21t ZW50Q29udGV4dFRvQmVmb3JlKHByZXZpb3VzTGluZUZvcihsaW5lKSwgbGluZS5hdHRyKCdkYXRh LWNvbW1lbnQtYmFzZS1saW5lJykpOwogICB9KS5saXZlKCdtb3VzZWRvd24nLCBmdW5jdGlvbigp IHsKICAgICBpbl9kcmFnX3NlbGVjdCA9IHRydWU7CiAgICAgJChsaW5lRnJvbUxpbmVEZXNjZW5k YW50KHRoaXMpKS5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKQEAgLTEwNTksMjEgKzEwNjMsMjIgQEAK ICAgfSkubGl2ZSgnbW91c2V1cCcsIGZ1bmN0aW9uKCkgewogICAgIGlmICghaW5fZHJhZ19zZWxl Y3QpCiAgICAgICByZXR1cm47CisKICAgICB2YXIgc2VsZWN0ZWQgPSAkKCcuc2VsZWN0ZWQnKTsK LSAgICB2YXIgc2hvdWxkX2FkZF9jb21tZW50ID0gIW5leHRMaW5lRm9yKHNlbGVjdGVkLmxhc3Qo KSkuaGFzQ2xhc3MoJ2NvbW1lbnRDb250ZXh0Jyk7CisgICAgdmFyIGFscmVhZHlfaGFzX2NvbW1l bnQgPSBzZWxlY3RlZC5sYXN0KCkuaGFzQ2xhc3MoJ2NvbW1lbnRDb250ZXh0Jyk7CiAgICAgc2Vs ZWN0ZWQuYWRkQ2xhc3MoJ2NvbW1lbnRDb250ZXh0Jyk7CiAKLSAgICB2YXIgaWQ7Ci0gICAgaWYg KHNob3VsZF9hZGRfY29tbWVudCkgeworICAgIHZhciBjb21tZW50X2Jhc2VfbGluZTsKKyAgICBp ZiAoYWxyZWFkeV9oYXNfY29tbWVudCkKKyAgICAgIGNvbW1lbnRfYmFzZV9saW5lID0gc2VsZWN0 ZWQubGFzdCgpLmF0dHIoJ2RhdGEtY29tbWVudC1iYXNlLWxpbmUnKTsKKyAgICBlbHNlIHsKICAg ICAgIHZhciBsYXN0ID0gbGluZUZyb21MaW5lRGVzY2VuZGFudChzZWxlY3RlZC5sYXN0KClbMF0p OwogICAgICAgYWRkQ29tbWVudEZvcigkKGxhc3QpKTsKLSAgICAgIGlkID0gbGFzdC5pZDsKLSAg ICB9IGVsc2UgewotICAgICAgaWQgPSBuZXh0TGluZUZvcihzZWxlY3RlZC5sYXN0KCkpWzBdLmdl dEF0dHJpYnV0ZSgnZGF0YS1jb21tZW50LWJhc2UtbGluZScpOworICAgICAgY29tbWVudF9iYXNl X2xpbmUgPSBsYXN0LmlkOwogICAgIH0KIAogICAgIHNlbGVjdGVkLmVhY2goZnVuY3Rpb24oKSB7 Ci0gICAgICBhZGREYXRhQ29tbWVudEJhc2VMaW5lKHRoaXMsIGlkKTsKKyAgICAgIGFkZERhdGFD b21tZW50QmFzZUxpbmUodGhpcywgY29tbWVudF9iYXNlX2xpbmUpOwogICAgIH0pOwogICB9KTsK IApAQCAtMTA5MCwxNSArMTA5NSwxNiBAQAogICAgICQobGluZSkuYXR0cignZGF0YS1jb21tZW50 LWJhc2UtbGluZScsIHBhcnRzLmpvaW4oJyAnKSk7CiAgIH0KIAotICBmdW5jdGlvbiByZW1vdmVE YXRhQ29tbWVudEJhc2VMaW5lKGxpbmUsIGlkKSB7CisgIGZ1bmN0aW9uIHJlbW92ZURhdGFDb21t ZW50QmFzZUxpbmUobGluZSwgY29tbWVudF9iYXNlX2xpbmVzKSB7CiAgICAgdmFyIHZhbCA9ICQo bGluZSkuYXR0cignZGF0YS1jb21tZW50LWJhc2UtbGluZScpOwogICAgIGlmICghdmFsKQogICAg ICAgcmV0dXJuOwogCisgICAgdmFyIGJhc2VfbGluZXMgPSBjb21tZW50X2Jhc2VfbGluZXMuc3Bs aXQoJyAnKTsKICAgICB2YXIgcGFydHMgPSB2YWwuc3BsaXQoJyAnKTsKICAgICB2YXIgbmV3VmFs ID0gW107CiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwYXJ0cy5sZW5ndGg7IGkrKykgewotICAg ICAgaWYgKHBhcnRzW2ldICE9IGlkKQorICAgICAgaWYgKGJhc2VfbGluZXMuaW5kZXhPZihwYXJ0 c1tpXSkgPT0gLTEpCiAgICAgICAgIG5ld1ZhbC5wdXNoKHBhcnRzW2ldKTsKICAgICB9CiAKQEAg LTExMjMsNyArMTEyOSw3IEBACiAKICAgZnVuY3Rpb24gY29udGV4dFNuaXBwZXRGb3IobGluZSwg aW5kZW50KSB7CiAgICAgdmFyIHNuaXBwZXRzID0gW10KLSAgICBjb250ZXh0TGluZXNGb3IobGlu ZS5hdHRyKCdpZCcpKS5lYWNoKGZ1bmN0aW9uKCkgeworICAgIGNvbnRleHRMaW5lc0ZvcihsaW5l LmF0dHIoJ2lkJyksIGZpbGVEaWZmRm9yKGxpbmUpKS5lYWNoKGZ1bmN0aW9uKCkgewogICAgICAg dmFyIGFjdGlvbiA9ICcgJzsKICAgICAgIGlmICgkKHRoaXMpLmhhc0NsYXNzKCdhZGQnKSkKICAg ICAgICAgYWN0aW9uID0gJysnOwo=