52437 2011-01-14 02:15:53 -0800 [chromium] remove obsolete createView method 2011-01-15 01:33:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jochen jochen commit-queue fishd jnd oldest_to_newest 334201 0 jochen 2011-01-14 02:15:53 -0800 [chromium] remove obsolete createView method 334206 1 78917 jochen 2011-01-14 02:24:50 -0800 Created attachment 78917 Patch 334209 2 jochen 2011-01-14 02:26:02 -0800 chromium side is here: http://codereview.chromium.org/6304003/ 334210 3 jochen 2011-01-14 02:26:20 -0800 chromium side is here: http://codereview.chromium.org/6304003/ 334874 4 78917 commit-queue 2011-01-15 01:33:30 -0800 Comment on attachment 78917 Patch Clearing flags on attachment: 78917 Committed r75875: <http://trac.webkit.org/changeset/75875> 334875 5 commit-queue 2011-01-15 01:33:34 -0800 All reviewed patches have been landed. Closing bug. 78917 2011-01-14 02:24:50 -0800 2011-01-15 01:33:29 -0800 Patch bug-52437-20110114112448.patch text/plain 4785 jochen ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNmI5 ZTA5MGZmNGNmNjI5NzM5ZGM3MDBkYzJjMTc5YTEyYzE1MGExLi4wZGU2ZGNlY2JjNGY3NmIxN2Vi NGZlMzgzOGU1NGU2MTVjZjQ3NmI1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMTQgIEpvY2hlbiBFaXNp bmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSByZW1vdmUgb2Jzb2xldGUgY3JlYXRlVmll dyBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUyNDM3CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5j cHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6Y3JlYXRlVmlldyk6CisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaDoKKwogMjAxMS0wMS0wNCAgSm9jaGVuIEVp c2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZp ZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZp ZXdIb3N0LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNw cAppbmRleCBmNWRkN2ZkYmM1MzljMTRjMzhmMWFiYWZiYzZhY2ZhZTczNzVmYTM5Li42MmRmMzkw Y2NkYzA5MTQwNjM1YmNkMWEzYmVkNWMyMDU5NjA0NTcxIDEwMDY0NAotLS0gYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCkBAIC0yMjcsNyArMjI3LDcgQEAgc3RhdGlj IHN0cmluZyB0ZXh0QWZmaW5pdHlEZXNjcmlwdGlvbihXZWJUZXh0QWZmaW5pdHkgYWZmaW5pdHkp CiAKIC8vIFdlYlZpZXdDbGllbnQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCi1XZWJWaWV3KiBXZWJWaWV3SG9zdDo6Y3JlYXRl VmlldyhXZWJGcmFtZSosIGNvbnN0IFdlYldpbmRvd0ZlYXR1cmVzJiwgY29uc3QgV2ViU3RyaW5n JikKK1dlYlZpZXcqIFdlYlZpZXdIb3N0OjpjcmVhdGVWaWV3KFdlYkZyYW1lKiwgY29uc3QgV2Vi VVJMUmVxdWVzdCYsIGNvbnN0IFdlYldpbmRvd0ZlYXR1cmVzJiwgY29uc3QgV2ViU3RyaW5nJikK IHsKICAgICBpZiAoIWxheW91dFRlc3RDb250cm9sbGVyKCktPmNhbk9wZW5XaW5kb3dzKCkpCiAg ICAgICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vV2ViVmlld0hvc3QuaCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdI b3N0LmgKaW5kZXggODZjMjNhNTYwN2JkODAyMTg1MmI1YjFlOWE0YWRlMDE2ZGM5OGU3NS4uMGEz NmFlYzBmNGRkOGYxYzA0MjM4MzgyYzdkMTFkYTY0YWQ3YjNmYyAxMDA2NDQKLS0tIGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAorKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oCkBAIC0xMDQsNyArMTA0LDcgQEAgY2xhc3Mg V2ViVmlld0hvc3QgOiBwdWJsaWMgV2ViS2l0OjpXZWJWaWV3Q2xpZW50LCBwdWJsaWMgV2ViS2l0 OjpXZWJGcmFtZUNsaWVudCwKICAgICB2aXJ0dWFsIGJvb2wgbmF2aWdhdGUoY29uc3QgVGVzdE5h dmlnYXRpb25FbnRyeSYsIGJvb2wgcmVsb2FkKTsKIAogICAgIC8vIFdlYktpdDo6V2ViVmlld0Ns aWVudAotICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJWaWV3KiBjcmVhdGVWaWV3KFdlYktpdDo6V2Vi RnJhbWUqLCBjb25zdCBXZWJLaXQ6OldlYldpbmRvd0ZlYXR1cmVzJiwgY29uc3QgV2ViS2l0OjpX ZWJTdHJpbmcmKTsKKyAgICB2aXJ0dWFsIFdlYktpdDo6V2ViVmlldyogY3JlYXRlVmlldyhXZWJL aXQ6OldlYkZyYW1lKiwgY29uc3QgV2ViS2l0OjpXZWJVUkxSZXF1ZXN0JiwgY29uc3QgV2ViS2l0 OjpXZWJXaW5kb3dGZWF0dXJlcyYsIGNvbnN0IFdlYktpdDo6V2ViU3RyaW5nJik7CiAgICAgdmly dHVhbCBXZWJLaXQ6OldlYldpZGdldCogY3JlYXRlUG9wdXBNZW51KFdlYktpdDo6V2ViUG9wdXBU eXBlKTsKICAgICB2aXJ0dWFsIFdlYktpdDo6V2ViV2lkZ2V0KiBjcmVhdGVQb3B1cE1lbnUoY29u c3QgV2ViS2l0OjpXZWJQb3B1cE1lbnVJbmZvJik7CiAgICAgdmlydHVhbCBXZWJLaXQ6OldlYlN0 b3JhZ2VOYW1lc3BhY2UqIGNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKHVuc2lnbmVkIHF1 b3RhKTsKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCmluZGV4IDQ5NTc5Y2VhZGVhMzM2Y2Q0NWRkNWZlMzU3ODBmYzVmZTkw NzIzMDkuLjZkM2IzMmMyMWIzYmM0MjIxZDNmODRjNjA2OWQzMzYyNjlhMTE0NzAgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAxLTE0ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2No ZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtjaHJvbWl1bV0gcmVtb3ZlIG9ic29sZXRlIGNyZWF0ZVZpZXcgbWV0aG9kCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjQzNworCisg ICAgICAgICogcHVibGljL1dlYlZpZXdDbGllbnQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmll d0NsaWVudDo6Y3JlYXRlVmlldyk6CisKIDIwMTEtMDEtMTQgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkOiBidWlsZCBmaXguCmRp ZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaCBiL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCmluZGV4IGEzYWQ5YjQ0ZmQzMzZhMGM4 ZjIwMDc5ODg3ZmZhYmFjYzkxZDRhMzkuLjA4ZmI5NDI2YTk4ODczZTMwYWVmMDMyYTBkZDg4Y2E0 NmExMjNhNGIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVu dC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCkBAIC04Mywy NSArODMsMTMgQEAgcHVibGljOgogICAgIC8vIENyZWF0ZSBhIG5ldyByZWxhdGVkIFdlYlZpZXcu ICBUaGlzIG1ldGhvZCBtdXN0IGNsb25lIGl0cyBzZXNzaW9uIHN0b3JhZ2UKICAgICAvLyBzbyBh bnkgc3Vic2VxdWVudCBjYWxscyB0byBjcmVhdGVTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZSBjb25m b3JtIHRvIHRoZQogICAgIC8vIFdlYlN0b3JhZ2Ugc3BlY2lmaWNhdGlvbi4KLSAgICAvLyBGSVhN RTogVGhpcyBtZXRob2QgaXMgREVQUkVDQVRFRCBhbmQgc2hvdWxkIGJlIHJlbW92ZWQgb25jZSB0 aGUgbmV3Ci0gICAgLy8gY3JlYXRlVmlldygpICh0aGUgbmV4dCBtZXRob2QpIGlzIGltcGxlbWVu dGVkIGF0IENocm9taXVtIHNpZGUuCi0gICAgdmlydHVhbCBXZWJWaWV3KiBjcmVhdGVWaWV3KFdl YkZyYW1lKiBjcmVhdG9yLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBX ZWJXaW5kb3dGZWF0dXJlcyYgZmVhdHVyZXMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbnN0IFdlYlN0cmluZyYgbmFtZSkgeyByZXR1cm4gMDsgfQotCi0gICAgLy8gQ3JlYXRl IGEgbmV3IHJlbGF0ZWQgV2ViVmlldy4gIFRoaXMgbWV0aG9kIG11c3QgY2xvbmUgaXRzIHNlc3Np b24gc3RvcmFnZQotICAgIC8vIHNvIGFueSBzdWJzZXF1ZW50IGNhbGxzIHRvIGNyZWF0ZVNlc3Np b25TdG9yYWdlTmFtZXNwYWNlIGNvbmZvcm0gdG8gdGhlCi0gICAgLy8gV2ViU3RvcmFnZSBzcGVj aWZpY2F0aW9uLgogICAgIC8vIFRoZSByZXF1ZXN0IHBhcmFtZXRlciBpcyBvbmx5IGZvciB0aGUg Y2xpZW50IHRvIGNoZWNrIGlmIHRoZSByZXF1ZXN0CiAgICAgLy8gY291bGQgYmUgZnVsZmlsbGVk LiAgVGhlIGNsaWVudCBzaG91bGQgbm90IGxvYWQgdGhlIHJlcXVlc3QuCiAgICAgdmlydHVhbCBX ZWJWaWV3KiBjcmVhdGVWaWV3KFdlYkZyYW1lKiBjcmVhdG9yLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjb25zdCBXZWJVUkxSZXF1ZXN0JiByZXF1ZXN0LAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBjb25zdCBXZWJXaW5kb3dGZWF0dXJlcyYgZmVhdHVyZXMsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYgbmFtZSkgewot ICAgICAgICAvLyBGSVhNRTogVGhpcyBpcyBhIHRlbXBvcmFyeSBkZWZhdWx0IGltcGxlbWVudGF0 aW9uIHdoaWNoIGNhbGxzIHRoZSBvbGQKLSAgICAgICAgLy8gdmVyc2lvbiBvZiBjcmVhdGVWaWV3 KCkuIFNob3VsZCBjaGFuZ2UgdG8gJ3JldHVybiAwJyB3aGVuIHRoZSBvbGQgb25lCi0gICAgICAg IC8vIGlzIHJlbW92ZWQuCi0gICAgICAgIHJldHVybiBjcmVhdGVWaWV3KGNyZWF0b3IsIGZlYXR1 cmVzLCBuYW1lKTsgCisgICAgICAgIHJldHVybiAwOwogICAgIH0KIAogICAgIC8vIENyZWF0ZSBh IG5ldyBXZWJQb3B1cE1lbnUuICBJbiB0aGUgc2Vjb25kIGZvcm0sIHRoZSBjbGllbnQgaXMK