52436 2011-01-14 01:56:59 -0800 Setting "selected" attribute to false should have no effect in single line <select> (affects jQuery) 2011-02-23 17:03:34 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 christian.lange.81 webkit-unassigned ap darin eae oldest_to_newest 334192 0 christian.lange.81 2011-01-14 01:56:59 -0800 Hi (I am using Ubuntu 10.04) I got a <select> element with three <option> inside (my page ist XHTML 1.0 Transitional), looks like this: <select> <option value="0">0</option> <option value="1">1</option> <option value="2">2</option> </select> None of those is selected manually (i.e. has the "selected='selected'" tag) but on first loading the page, the option "0" ist shown by default. When I use jQuery to delete all "selected" tags in all <option>-element (which are not there), suddenly no option is selected anymore. You can check it yourself with following (w3c validated) little code: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="de" lang="de"> <head> <title>test</title> <meta http-equiv="Content-Type" content="text/html;charset=utf-8"/> <script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.4/jquery.min.js"></script> </head> <body> <select id="s" size="1"> <option value="0">0</option> <option value="1">1</option> <option value="2">2</option> </select> <input id="i" type="button" value="Remove 'selected'"/> <script type="text/javascript"> $(document).ready(function() { $("#i").click(function() { $("#s").find("option").removeAttr("selected"); }); }); </script> </body> </html> This disappearing of a selected value happens in Google Chrome 8.0.552.237, Chromium 10.0.639.0 (71411) as well as Safari 5.0.3 (7533.19.4). You see, pretty new browsers. According to webkit.org the webkit version of Chromium is 534.16 but the newest webkit version is r75294. So I can't really tell if I got the newest one, it's a confusing name scheme. This behaviour, however, does not appear in Firefox 3.6.13, Opera 11.00 or Internet Explorer 8. I think that the way Firefox, Opera and IE handle this is the correct way. Could you please check if this is a bug in WebKit? Best regards, Christian 334416 1 78962 ap 2011-01-14 10:54:17 -0800 Created attachment 78962 reduced test case 334426 2 ap 2011-01-14 11:02:22 -0800 This is not really about removing the "selected" attribute - behind the scenes, jQuery first sets it to false. I'm not sure if WebKit is actually broken here, but we should investigate this as a difference with Firefox. Please consider also filing a bug against jQuery, as there is no apparent reason for removeAttr() to behave this way. removeAttr: function( name, fn ) { return this.each(function(){ jQuery.attr( this, name, "" ); // <-- this sets .selected to false in your test case if ( this.nodeType === 1 ) { this.removeAttribute( name ); } }); }, 334870 3 christian.lange.81 2011-01-15 00:21:57 -0800 I filed this bug at jQuery today: http://bugs.jquery.com/ticket/7981 341743 4 80498 eae 2011-01-28 14:36:30 -0800 Created attachment 80498 Patch While the original specification doesn't specify a behavior for this case the HTML5 [1] draft does. This patch changes the behavior to match the HTML5 draft specification and to match the Mozilla behavior. IE selects the last selectable element rather than the first but apart from that exhibits the same behavior. 1: http://dev.w3.org/html5/spec/Overview.html#the-select-element 341766 5 ap 2011-01-28 15:06:19 -0800 Could you please quote the relevant bits from HTML5? 341782 6 80498 darin 2011-01-28 15:17:37 -0800 Comment on attachment 80498 Patch I’d like to see a test that covers trying to set the selected index to -2. For future reference, you can sometimes make better tests by putting more of the test into the shouldBe function: shouldBe("selectElement.selectedIndex = 0; selectElement.selectedIndex", "0"); 341786 7 eae 2011-01-28 15:20:09 -0800 "If the multiple attribute is absent and the element's display size is 1, then whenever there are no option elements in the select element's list of options that have their selectedness set to true, the user agent must set the selectedness of the first option element in the list of options in tree order that is not disabled, if any, to true." 341808 8 80513 eae 2011-01-28 15:41:14 -0800 Created attachment 80513 Patch Thanks Darin. Added a test for -2 and used shouldBe as suggested. 342827 9 80513 darin 2011-01-31 14:48:49 -0800 Comment on attachment 80513 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80513&action=review > Source/WebCore/dom/SelectElement.cpp:325 > - const Vector<Element*>& items = data.listItems(element); > - int listIndex = optionToListIndex(data, element, optionIndex); > + if (optionIndex == -1 && !deselect && !data.multiple()) > + optionIndex = nextSelectableListIndex(data, element, -1); > if (!data.multiple()) > deselect = true; > > + const Vector<Element*>& items = data.listItems(element); > + int listIndex = optionToListIndex(data, element, optionIndex); > + I didn’t criticize this the first time around, but I realize now that the setSelectedIndex function is a kind of low level place to put this logic. Normally I’d expect to see the logic in the callers. Is there a higher level place in the class we can put this? I also think the new block of code needs a “Why” comment; it’s a bit mysterious without one. Maybe we could follow up this patch with a patch that adds that comment. Also, I don’t know why you chose to reorder the existing code. If you hadn’t reordered it, this patch would only show the new code you are adding. But because you chose to put the deselect = true code above the optionToListIndex code, there is a larger change here. With no rationale for the change. > LayoutTests/ChangeLog:8 > + Add test for changing the selection in a one-line select element using\ Stray backslash here. > LayoutTests/fast/dom/HTMLSelectElement/selected-false.html:30 > + optionElements[2].selected = true; > + optionElements[1].selected = true; > + shouldBe("selectElement.selectedIndex", "1"); These could be inside the shouldBe too just as the single statement lines are. There’s no reason to have this part of the test be hidden in the test output. 342895 10 80498 eric 2011-01-31 16:06:58 -0800 Comment on attachment 80498 Patch Cleared Darin Adler's review+ from obsolete attachment 80498 so that this bug does not appear in http://webkit.org/pending-commit. 342980 11 80513 commit-queue 2011-01-31 19:45:57 -0800 Comment on attachment 80513 Patch Clearing flags on attachment: 80513 Committed r77206: <http://trac.webkit.org/changeset/77206> 78962 2011-01-14 10:54:17 -0800 2011-01-14 10:54:17 -0800 reduced test case 52436.html text/html 507 ap PGJvZHk+CiAgICA8c2VsZWN0IHNpemU9IjEiPgogICAgICAgIDxvcHRpb24gdmFsdWU9IjAiPjA8 L29wdGlvbj4KICAgICAgICA8b3B0aW9uIHZhbHVlPSIxIj4xPC9vcHRpb24+CiAgICAgICAgPG9w dGlvbiB2YWx1ZT0iMiI+Mjwvb3B0aW9uPgogICAgPC9zZWxlY3Q+CiAgICA8cD5TZWxlY3RlZCBl bGVtZW50IGRvZXNuJ3QgY2hhbmdlIGluIEZpcmVmb3ggMy42LgogICAgPGlucHV0IHR5cGU9ImJ1 dHRvbiIgdmFsdWU9IlRlc3QiIG9uY2xpY2s9InRlc3QoKSI+CiAgICA8c2NyaXB0PgogICAgICAg IGZ1bmN0aW9uIHRlc3QoKSB7CiAgICAgICAgICAgIHRyeSB7CiAgICAgICAgICAgICAgICBkb2N1 bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgib3B0aW9uIilbMF0uc2VsZWN0ZWQgPSBmYWxzZTsK ICAgICAgICAgICAgfSBjYXRjaCAoZXgpIHsKICAgICAgICAgICAgICAgIGFsZXJ0KGV4KTsKICAg ICAgICAgICAgfQogICAgICAgIH0KICAgIDwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 80498 2011-01-28 14:36:30 -0800 2011-01-31 16:06:58 -0800 Patch 52436.patch text/plain 6557 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2OTgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDEtMjggIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNldHRpbmcgInNlbGVjdGVkIiBhdHRyaWJ1dGUgdG8gZmFsc2Ug c2hvdWxkIGhhdmUgbm8gZWZmZWN0IGluIHNpbmdsZSBsaW5lIDxzZWxlY3Q+CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjQzNgorCisgICAgICAgIENo YW5nZSBTZWxlY3RFbGVtZW50OjpzZXRTZWxlY3RlZEluZGV4IHRvIHNlbGVjdCB0aGUgZmlyc3Qg c2VsZWN0YWJsZQorICAgICAgICBvcHRpb24gd2hlbiB0aGUgc2VsZWN0IHN0YXRlIG9mIGFsbCBv cHRpb25zIGlzIHNldCB0byBmYWxzZSBhcyByZXF1aXJlZAorICAgICAgICBieSB0aGUgSFRNTDUg c3BlY2lmaWNhdGlvbi4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVu dC9zZWxlY3RlZC1mYWxzZS5odG1sCisKKyAgICAgICAgKiBkb20vU2VsZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RFbGVtZW50OjpzZXRTZWxlY3RlZEluZGV4KToKKwog MjAxMS0wMS0yOCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0RWxl bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQu Y3BwCShyZXZpc2lvbiA3Njg2MSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE1LDExICszMTUsMTQgQEAgaW50IFNlbGVjdEVsZW1l bnQ6OnNlbGVjdGVkSW5kZXgoY29uc3QgUwogCiB2b2lkIFNlbGVjdEVsZW1lbnQ6OnNldFNlbGVj dGVkSW5kZXgoU2VsZWN0RWxlbWVudERhdGEmIGRhdGEsIEVsZW1lbnQqIGVsZW1lbnQsIGludCBv cHRpb25JbmRleCwgYm9vbCBkZXNlbGVjdCwgYm9vbCBmaXJlT25DaGFuZ2VOb3csIGJvb2wgdXNl ckRyaXZlbkNoYW5nZSkKIHsKLSAgICBjb25zdCBWZWN0b3I8RWxlbWVudCo+JiBpdGVtcyA9IGRh dGEubGlzdEl0ZW1zKGVsZW1lbnQpOwotICAgIGludCBsaXN0SW5kZXggPSBvcHRpb25Ub0xpc3RJ bmRleChkYXRhLCBlbGVtZW50LCBvcHRpb25JbmRleCk7CisgICAgaWYgKG9wdGlvbkluZGV4ID09 IC0xICYmICFkZXNlbGVjdCAmJiAhZGF0YS5tdWx0aXBsZSgpKQorICAgICAgICBvcHRpb25JbmRl eCA9IG5leHRTZWxlY3RhYmxlTGlzdEluZGV4KGRhdGEsIGVsZW1lbnQsIC0xKTsKICAgICBpZiAo IWRhdGEubXVsdGlwbGUoKSkKICAgICAgICAgZGVzZWxlY3QgPSB0cnVlOwogCisgICAgY29uc3Qg VmVjdG9yPEVsZW1lbnQqPiYgaXRlbXMgPSBkYXRhLmxpc3RJdGVtcyhlbGVtZW50KTsKKyAgICBp bnQgbGlzdEluZGV4ID0gb3B0aW9uVG9MaXN0SW5kZXgoZGF0YSwgZWxlbWVudCwgb3B0aW9uSW5k ZXgpOworCiAgICAgRWxlbWVudCogZXhjbHVkZUVsZW1lbnQgPSAwOwogICAgIGlmIChPcHRpb25F bGVtZW50KiBvcHRpb25FbGVtZW50ID0gKGxpc3RJbmRleCA+PSAwID8gdG9PcHRpb25FbGVtZW50 KGl0ZW1zW2xpc3RJbmRleF0pIDogMCkpIHsKICAgICAgICAgZXhjbHVkZUVsZW1lbnQgPSBpdGVt c1tsaXN0SW5kZXhdOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzY5ODMpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0yOCAgRW1p bCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0dGluZyAic2VsZWN0ZWQiIGF0dHJpYnV0ZSB0byBm YWxzZSBzaG91bGQgaGF2ZSBubyBlZmZlY3QgaW4gc2luZ2xlIGxpbmUgPHNlbGVjdD4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNDM2CisKKyAgICAg ICAgQWRkIHRlc3QgZm9yIGNoYW5naW5nIHRoZSBzZWxlY3Rpb24gaW4gYSBvbmUtbGluZSBzZWxl Y3QgZWxlbWVudCB1c2luZ1wKKyAgICAgICAgdGhlIG9wdGlvbi5zZWxlY3RlZCBwcm9wZXJ0eS4K KworICAgICAgICAqIGZhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NlbGVjdGVkLWZhbHNlLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQv c2VsZWN0ZWQtZmFsc2UuaHRtbDogQWRkZWQuCisKIDIwMTEtMDEtMjggIERpbWl0cmkgR2xhemtv diAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIEFkZGVkIGV4 cGVjdGF0aW9ucyBmb3IgYSBwYXNzaW5nIHRlc3QuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9IVE1MU2VsZWN0RWxlbWVudC9zZWxlY3RlZC1mYWxzZS1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2VsZWN0ZWQtZmFs c2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRN TFNlbGVjdEVsZW1lbnQvc2VsZWN0ZWQtZmFsc2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDI2IEBACisKK1BBU1Mgc2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IGlzIDAK K1BBU1Mgb3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQgaXMgdHJ1ZQorUEFTUyBvcHRpb25FbGVt ZW50c1sxXS5zZWxlY3RlZCBpcyBmYWxzZQorUEFTUyBvcHRpb25FbGVtZW50c1syXS5zZWxlY3Rl ZCBpcyBmYWxzZQorUEFTUyBzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXggaXMgLTEKK1BBU1Mg b3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQgaXMgZmFsc2UKK1BBU1Mgb3B0aW9uRWxlbWVudHNb MV0uc2VsZWN0ZWQgaXMgZmFsc2UKK1BBU1Mgb3B0aW9uRWxlbWVudHNbMl0uc2VsZWN0ZWQgaXMg ZmFsc2UKK1BBU1Mgc2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IGlzIDEKK1BBU1Mgb3B0aW9u RWxlbWVudHNbMF0uc2VsZWN0ZWQgaXMgZmFsc2UKK1BBU1Mgb3B0aW9uRWxlbWVudHNbMV0uc2Vs ZWN0ZWQgaXMgdHJ1ZQorUEFTUyBvcHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCBpcyBmYWxzZQor UEFTUyBzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXggaXMgMgorUEFTUyBvcHRpb25FbGVtZW50 c1swXS5zZWxlY3RlZCBpcyBmYWxzZQorUEFTUyBvcHRpb25FbGVtZW50c1sxXS5zZWxlY3RlZCBp cyBmYWxzZQorUEFTUyBvcHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCBpcyB0cnVlCitQQVNTIHNl bGVjdEVsZW1lbnQuc2VsZWN0ZWRJbmRleCBpcyAwCitQQVNTIG9wdGlvbkVsZW1lbnRzWzBdLnNl bGVjdGVkIGlzIHRydWUKK1BBU1Mgb3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0ZWQgaXMgZmFsc2UK K1BBU1Mgb3B0aW9uRWxlbWVudHNbMl0uc2VsZWN0ZWQgaXMgZmFsc2UKK1BBU1Mgc2VsZWN0RWxl bWVudC5zZWxlY3RlZEluZGV4IGlzIDEKK1BBU1Mgb3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQg aXMgZmFsc2UKK1BBU1Mgb3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0ZWQgaXMgdHJ1ZQorUEFTUyBv cHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCBpcyBmYWxzZQorCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9zZWxlY3RlZC1mYWxzZS5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NlbGVjdGVkLWZhbHNl Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxl bWVudC9zZWxlY3RlZC1mYWxzZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDU2IEBACis8 aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBy ZS5qcyI+PC9zY3JpcHQ+Cis8Ym9keT4gCisgICAgPHNlbGVjdCBzaXplPSIxIj4gCisgICAgICAg IDxvcHRpb24gaWQ9Im9wdDEiIHZhbHVlPSIxIj4xPC9vcHRpb24+IAorICAgICAgICA8b3B0aW9u IGlkPSJvcHQyIiB2YWx1ZT0iMiI+Mjwvb3B0aW9uPgorICAgICAgICA8b3B0aW9uIGlkPSJvcHQy IiB2YWx1ZT0iMyI+Mzwvb3B0aW9uPiAKKyAgICA8L3NlbGVjdD4KKyAgICA8ZGl2IGlkPSJjb25z b2xlIj48L2Rpdj4KKzwvYm9keT4KKzxzY3JpcHQ+CisgICAgdmFyIHNlbGVjdEVsZW1lbnQgPSBk b2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgnc2VsZWN0JylbMF07CisgICAgdmFyIG9wdGlv bkVsZW1lbnRzID0gc2VsZWN0RWxlbWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgnb3B0aW9uJyk7 CisKKyAgICBzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXggPSAwOworICAgIHNob3VsZEJlKCJz ZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXgiLCAiMCIpOworICAgIHNob3VsZEJlKCJvcHRpb25F bGVtZW50c1swXS5zZWxlY3RlZCIsICJ0cnVlIik7CisgICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1l bnRzWzFdLnNlbGVjdGVkIiwgImZhbHNlIik7CisgICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1lbnRz WzJdLnNlbGVjdGVkIiwgImZhbHNlIik7CisKKyAgICBzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5k ZXggPSAtMTsKKyAgICBzaG91bGRCZSgic2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IiwgIi0x Iik7CisgICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1lbnRzWzBdLnNlbGVjdGVkIiwgImZhbHNlIik7 CisgICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1lbnRzWzFdLnNlbGVjdGVkIiwgImZhbHNlIik7Cisg ICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1lbnRzWzJdLnNlbGVjdGVkIiwgImZhbHNlIik7CisKKyAg ICBvcHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCA9IHRydWU7CisgICAgb3B0aW9uRWxlbWVudHNb MV0uc2VsZWN0ZWQgPSB0cnVlOworICAgIHNob3VsZEJlKCJzZWxlY3RFbGVtZW50LnNlbGVjdGVk SW5kZXgiLCAiMSIpOworICAgIHNob3VsZEJlKCJvcHRpb25FbGVtZW50c1swXS5zZWxlY3RlZCIs ICJmYWxzZSIpOworICAgIHNob3VsZEJlKCJvcHRpb25FbGVtZW50c1sxXS5zZWxlY3RlZCIsICJ0 cnVlIik7CisgICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1lbnRzWzJdLnNlbGVjdGVkIiwgImZhbHNl Iik7CisgICAgCisgICAgb3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0ZWQgPSB0cnVlOworICAgIG9w dGlvbkVsZW1lbnRzWzJdLnNlbGVjdGVkID0gdHJ1ZTsKKyAgICBzaG91bGRCZSgic2VsZWN0RWxl bWVudC5zZWxlY3RlZEluZGV4IiwgIjIiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNb MF0uc2VsZWN0ZWQiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMV0u c2VsZWN0ZWQiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMl0uc2Vs ZWN0ZWQiLCAidHJ1ZSIpOworCisgICAgb3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQgPSBmYWxz ZTsKKyAgICBvcHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCA9IGZhbHNlOworICAgIHNob3VsZEJl KCJzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXgiLCAiMCIpOworICAgIHNob3VsZEJlKCJvcHRp b25FbGVtZW50c1swXS5zZWxlY3RlZCIsICJ0cnVlIik7CisgICAgc2hvdWxkQmUoIm9wdGlvbkVs ZW1lbnRzWzFdLnNlbGVjdGVkIiwgImZhbHNlIik7CisgICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1l bnRzWzJdLnNlbGVjdGVkIiwgImZhbHNlIik7CisKKyAgICBvcHRpb25FbGVtZW50c1swXS5kaXNh YmxlZCA9IHRydWU7CisgICAgb3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQgPSBmYWxzZTsKKyAg ICBzaG91bGRCZSgic2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IiwgIjEiKTsKKyAgICBzaG91 bGRCZSgib3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRC ZSgib3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0ZWQiLCAidHJ1ZSIpOworICAgIHNob3VsZEJlKCJv cHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCIsICJmYWxzZSIpOworPC9zY3JpcHQ+Cis8L2h0bWw+ IAo= 80513 2011-01-28 15:41:14 -0800 2011-01-31 19:45:57 -0800 Patch 52436.patch text/plain 6776 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2OTgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDEtMjggIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNldHRpbmcgInNlbGVjdGVkIiBhdHRyaWJ1dGUgdG8gZmFsc2Ug c2hvdWxkIGhhdmUgbm8gZWZmZWN0IGluIHNpbmdsZSBsaW5lIDxzZWxlY3Q+CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjQzNgorCisgICAgICAgIENo YW5nZSBTZWxlY3RFbGVtZW50OjpzZXRTZWxlY3RlZEluZGV4IHRvIHNlbGVjdCB0aGUgZmlyc3Qg c2VsZWN0YWJsZQorICAgICAgICBvcHRpb24gd2hlbiB0aGUgc2VsZWN0IHN0YXRlIG9mIGFsbCBv cHRpb25zIGlzIHNldCB0byBmYWxzZSBhcyByZXF1aXJlZAorICAgICAgICBieSB0aGUgSFRNTDUg c3BlY2lmaWNhdGlvbi4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVu dC9zZWxlY3RlZC1mYWxzZS5odG1sCisKKyAgICAgICAgKiBkb20vU2VsZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RFbGVtZW50OjpzZXRTZWxlY3RlZEluZGV4KToKKwog MjAxMS0wMS0yOCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0RWxl bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQu Y3BwCShyZXZpc2lvbiA3Njg2MSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE1LDExICszMTUsMTQgQEAgaW50IFNlbGVjdEVsZW1l bnQ6OnNlbGVjdGVkSW5kZXgoY29uc3QgUwogCiB2b2lkIFNlbGVjdEVsZW1lbnQ6OnNldFNlbGVj dGVkSW5kZXgoU2VsZWN0RWxlbWVudERhdGEmIGRhdGEsIEVsZW1lbnQqIGVsZW1lbnQsIGludCBv cHRpb25JbmRleCwgYm9vbCBkZXNlbGVjdCwgYm9vbCBmaXJlT25DaGFuZ2VOb3csIGJvb2wgdXNl ckRyaXZlbkNoYW5nZSkKIHsKLSAgICBjb25zdCBWZWN0b3I8RWxlbWVudCo+JiBpdGVtcyA9IGRh dGEubGlzdEl0ZW1zKGVsZW1lbnQpOwotICAgIGludCBsaXN0SW5kZXggPSBvcHRpb25Ub0xpc3RJ bmRleChkYXRhLCBlbGVtZW50LCBvcHRpb25JbmRleCk7CisgICAgaWYgKG9wdGlvbkluZGV4ID09 IC0xICYmICFkZXNlbGVjdCAmJiAhZGF0YS5tdWx0aXBsZSgpKQorICAgICAgICBvcHRpb25JbmRl eCA9IG5leHRTZWxlY3RhYmxlTGlzdEluZGV4KGRhdGEsIGVsZW1lbnQsIC0xKTsKICAgICBpZiAo IWRhdGEubXVsdGlwbGUoKSkKICAgICAgICAgZGVzZWxlY3QgPSB0cnVlOwogCisgICAgY29uc3Qg VmVjdG9yPEVsZW1lbnQqPiYgaXRlbXMgPSBkYXRhLmxpc3RJdGVtcyhlbGVtZW50KTsKKyAgICBp bnQgbGlzdEluZGV4ID0gb3B0aW9uVG9MaXN0SW5kZXgoZGF0YSwgZWxlbWVudCwgb3B0aW9uSW5k ZXgpOworCiAgICAgRWxlbWVudCogZXhjbHVkZUVsZW1lbnQgPSAwOwogICAgIGlmIChPcHRpb25F bGVtZW50KiBvcHRpb25FbGVtZW50ID0gKGxpc3RJbmRleCA+PSAwID8gdG9PcHRpb25FbGVtZW50 KGl0ZW1zW2xpc3RJbmRleF0pIDogMCkpIHsKICAgICAgICAgZXhjbHVkZUVsZW1lbnQgPSBpdGVt c1tsaXN0SW5kZXhdOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzY5ODMpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0yOCAgRW1p bCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0dGluZyAic2VsZWN0ZWQiIGF0dHJpYnV0ZSB0byBm YWxzZSBzaG91bGQgaGF2ZSBubyBlZmZlY3QgaW4gc2luZ2xlIGxpbmUgPHNlbGVjdD4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNDM2CisKKyAgICAg ICAgQWRkIHRlc3QgZm9yIGNoYW5naW5nIHRoZSBzZWxlY3Rpb24gaW4gYSBvbmUtbGluZSBzZWxl Y3QgZWxlbWVudCB1c2luZ1wKKyAgICAgICAgdGhlIG9wdGlvbi5zZWxlY3RlZCBwcm9wZXJ0eS4K KworICAgICAgICAqIGZhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NlbGVjdGVkLWZhbHNlLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQv c2VsZWN0ZWQtZmFsc2UuaHRtbDogQWRkZWQuCisKIDIwMTEtMDEtMjggIERpbWl0cmkgR2xhemtv diAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIEFkZGVkIGV4 cGVjdGF0aW9ucyBmb3IgYSBwYXNzaW5nIHRlc3QuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9IVE1MU2VsZWN0RWxlbWVudC9zZWxlY3RlZC1mYWxzZS1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2VsZWN0ZWQtZmFs c2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRN TFNlbGVjdEVsZW1lbnQvc2VsZWN0ZWQtZmFsc2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDI3IEBACisKK1BBU1Mgc2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4ID0gMDsg c2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IGlzIDAKK1BBU1Mgb3B0aW9uRWxlbWVudHNbMF0u c2VsZWN0ZWQgaXMgdHJ1ZQorUEFTUyBvcHRpb25FbGVtZW50c1sxXS5zZWxlY3RlZCBpcyBmYWxz ZQorUEFTUyBvcHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCBpcyBmYWxzZQorUEFTUyBzZWxlY3RF bGVtZW50LnNlbGVjdGVkSW5kZXggPSAtMTsgc2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IGlz IC0xCitQQVNTIG9wdGlvbkVsZW1lbnRzWzBdLnNlbGVjdGVkIGlzIGZhbHNlCitQQVNTIG9wdGlv bkVsZW1lbnRzWzFdLnNlbGVjdGVkIGlzIGZhbHNlCitQQVNTIG9wdGlvbkVsZW1lbnRzWzJdLnNl bGVjdGVkIGlzIGZhbHNlCitQQVNTIHNlbGVjdEVsZW1lbnQuc2VsZWN0ZWRJbmRleCA9IC0yOyBz ZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXggaXMgLTEKK1BBU1Mgc2VsZWN0RWxlbWVudC5zZWxl Y3RlZEluZGV4IGlzIDEKK1BBU1Mgb3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQgaXMgZmFsc2UK K1BBU1Mgb3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0ZWQgaXMgdHJ1ZQorUEFTUyBvcHRpb25FbGVt ZW50c1syXS5zZWxlY3RlZCBpcyBmYWxzZQorUEFTUyBzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5k ZXggaXMgMgorUEFTUyBvcHRpb25FbGVtZW50c1swXS5zZWxlY3RlZCBpcyBmYWxzZQorUEFTUyBv cHRpb25FbGVtZW50c1sxXS5zZWxlY3RlZCBpcyBmYWxzZQorUEFTUyBvcHRpb25FbGVtZW50c1sy XS5zZWxlY3RlZCBpcyB0cnVlCitQQVNTIHNlbGVjdEVsZW1lbnQuc2VsZWN0ZWRJbmRleCBpcyAw CitQQVNTIG9wdGlvbkVsZW1lbnRzWzBdLnNlbGVjdGVkIGlzIHRydWUKK1BBU1Mgb3B0aW9uRWxl bWVudHNbMV0uc2VsZWN0ZWQgaXMgZmFsc2UKK1BBU1Mgb3B0aW9uRWxlbWVudHNbMl0uc2VsZWN0 ZWQgaXMgZmFsc2UKK1BBU1Mgc2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IGlzIDEKK1BBU1Mg b3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQgaXMgZmFsc2UKK1BBU1Mgb3B0aW9uRWxlbWVudHNb MV0uc2VsZWN0ZWQgaXMgdHJ1ZQorUEFTUyBvcHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCBpcyBm YWxzZQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9zZWxl Y3RlZC1mYWxzZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxT ZWxlY3RFbGVtZW50L3NlbGVjdGVkLWZhbHNlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9zZWxlY3RlZC1mYWxzZS5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDU2IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4u Ly4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8Ym9keT4gCisgICAg PHNlbGVjdCBzaXplPSIxIj4gCisgICAgICAgIDxvcHRpb24gaWQ9Im9wdDEiIHZhbHVlPSIxIj4x PC9vcHRpb24+IAorICAgICAgICA8b3B0aW9uIGlkPSJvcHQyIiB2YWx1ZT0iMiI+Mjwvb3B0aW9u PgorICAgICAgICA8b3B0aW9uIGlkPSJvcHQyIiB2YWx1ZT0iMyI+Mzwvb3B0aW9uPiAKKyAgICA8 L3NlbGVjdD4KKyAgICA8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzwvYm9keT4KKzxzY3JpcHQ+ CisgICAgdmFyIHNlbGVjdEVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgn c2VsZWN0JylbMF07CisgICAgdmFyIG9wdGlvbkVsZW1lbnRzID0gc2VsZWN0RWxlbWVudC5nZXRF bGVtZW50c0J5VGFnTmFtZSgnb3B0aW9uJyk7CisKKyAgICBzaG91bGRCZSgic2VsZWN0RWxlbWVu dC5zZWxlY3RlZEluZGV4ID0gMDsgc2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IiwgIjAiKTsK KyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQiLCAidHJ1ZSIpOworICAg IHNob3VsZEJlKCJvcHRpb25FbGVtZW50c1sxXS5zZWxlY3RlZCIsICJmYWxzZSIpOworICAgIHNo b3VsZEJlKCJvcHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCIsICJmYWxzZSIpOworCisgICAgc2hv dWxkQmUoInNlbGVjdEVsZW1lbnQuc2VsZWN0ZWRJbmRleCA9IC0xOyBzZWxlY3RFbGVtZW50LnNl bGVjdGVkSW5kZXgiLCAiLTEiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMF0uc2Vs ZWN0ZWQiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0 ZWQiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMl0uc2VsZWN0ZWQi LCAiZmFsc2UiKTsKKworICAgIHNob3VsZEJlKCJzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXgg PSAtMjsgc2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IiwgIi0xIik7CisKKyAgICBvcHRpb25F bGVtZW50c1syXS5zZWxlY3RlZCA9IHRydWU7CisgICAgb3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0 ZWQgPSB0cnVlOworICAgIHNob3VsZEJlKCJzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXgiLCAi MSIpOworICAgIHNob3VsZEJlKCJvcHRpb25FbGVtZW50c1swXS5zZWxlY3RlZCIsICJmYWxzZSIp OworICAgIHNob3VsZEJlKCJvcHRpb25FbGVtZW50c1sxXS5zZWxlY3RlZCIsICJ0cnVlIik7Cisg ICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1lbnRzWzJdLnNlbGVjdGVkIiwgImZhbHNlIik7CisgICAg CisgICAgb3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0ZWQgPSB0cnVlOworICAgIG9wdGlvbkVsZW1l bnRzWzJdLnNlbGVjdGVkID0gdHJ1ZTsKKyAgICBzaG91bGRCZSgic2VsZWN0RWxlbWVudC5zZWxl Y3RlZEluZGV4IiwgIjIiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0 ZWQiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMV0uc2VsZWN0ZWQi LCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZSgib3B0aW9uRWxlbWVudHNbMl0uc2VsZWN0ZWQiLCAi dHJ1ZSIpOworCisgICAgb3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQgPSBmYWxzZTsKKyAgICBv cHRpb25FbGVtZW50c1syXS5zZWxlY3RlZCA9IGZhbHNlOworICAgIHNob3VsZEJlKCJzZWxlY3RF bGVtZW50LnNlbGVjdGVkSW5kZXgiLCAiMCIpOworICAgIHNob3VsZEJlKCJvcHRpb25FbGVtZW50 c1swXS5zZWxlY3RlZCIsICJ0cnVlIik7CisgICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1lbnRzWzFd LnNlbGVjdGVkIiwgImZhbHNlIik7CisgICAgc2hvdWxkQmUoIm9wdGlvbkVsZW1lbnRzWzJdLnNl bGVjdGVkIiwgImZhbHNlIik7CisKKyAgICBvcHRpb25FbGVtZW50c1swXS5kaXNhYmxlZCA9IHRy dWU7CisgICAgb3B0aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQgPSBmYWxzZTsKKyAgICBzaG91bGRC ZSgic2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4IiwgIjEiKTsKKyAgICBzaG91bGRCZSgib3B0 aW9uRWxlbWVudHNbMF0uc2VsZWN0ZWQiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZSgib3B0aW9u RWxlbWVudHNbMV0uc2VsZWN0ZWQiLCAidHJ1ZSIpOworICAgIHNob3VsZEJlKCJvcHRpb25FbGVt ZW50c1syXS5zZWxlY3RlZCIsICJmYWxzZSIpOworPC9zY3JpcHQ+Cis8L2h0bWw+IAo=