52416 2011-01-13 17:43:43 -0800 webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files 2011-01-14 01:21:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue levin mihaip ojan pnormand oldest_to_newest 334055 0 eric 2011-01-13 17:43:43 -0800 webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files 334056 1 78879 eric 2011-01-13 17:45:21 -0800 Created attachment 78879 Patch 334063 2 eric 2011-01-13 17:57:03 -0800 Committed r75761: <http://trac.webkit.org/changeset/75761> 334151 3 pnormand 2011-01-14 00:38:31 -0800 This broke GTK+ 32-bits Debug: Traceback (most recent call last): File "./Tools/Scripts/test-webkitpy", line 266, in <module> Tester().run_tests(sys.argv, external_package_paths) File "/home/slave/webkitgtk/gtk-linux-32-debug/build/Tools/Scripts/webkitpy/test/main.py", line 140, in run_tests unittest.main(argv=sys_argv, module=None) File "/usr/lib/python2.5/unittest.py", line 767, in __init__ self.parseArgs(argv) File "/usr/lib/python2.5/unittest.py", line 794, in parseArgs self.createTests() File "/usr/lib/python2.5/unittest.py", line 800, in createTests self.module) File "/usr/lib/python2.5/unittest.py", line 565, in loadTestsFromNames suites = [self.loadTestsFromName(name, module) for name in names] File "/usr/lib/python2.5/unittest.py", line 533, in loadTestsFromName module = __import__('.'.join(parts_copy)) File "/home/slave/webkitgtk/gtk-linux-32-debug/build/Tools/Scripts/webkitpy/common/checkout/api_unittest.py", line 135 invalid_utf8 = str(b"\255") ^ SyntaxError: invalid syntax 334171 4 eric 2011-01-14 01:21:28 -0800 I found that syntax on the interblags. I assume b"\123" is a bytearray, I suspect the literal form is a new thing in 2.6. 78879 2011-01-13 17:45:21 -0800 2011-01-13 17:52:43 -0800 Patch bug-52416-20110113174520.patch text/plain 4852 eric ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYzUz NDUxNzE5OGY1NTk2ZjM4OWZjNDQyM2VhOWE0NWNhMjAyOWQ3Li44MmQ3YjhmYTBkZThjODQ4NTBl ZTIxZmQzZjYxYjQ4NTFjNGNmNzVkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDEtMTMgIEVyaWMgU2VpZGVs ICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBzdWdnZXN0LXJldmlld2VycyBmYWlscyBkdWUgdG8g aW52YWxpZCB1dGY4IGluIENoYW5nZUxvZyBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI0MTYKKworICAgICAgICBFeGFtcGxlOiB3ZWJraXQt cGF0Y2ggc3VnZ2VzdC1yZXZpZXdlcnMgLWcgY2EzODkwZmU3NGQ5NGQ4NWQ2YmZhNDhmOWVhNDk3 YjA5NGQ4ZTcxNyAKKyAgICAgICAgVW5pY29kZURlY29kZUVycm9yOiAndXRmOCcgY29kZWMgY2Fu J3QgZGVjb2RlIGJ5dGVzIGluIHBvc2l0aW9uIDUzNi01Mzg6IGludmFsaWQgZGF0YQorCisgICAg ICAgIEkgYWxzbyBhZGRlZCBGSVhNRXMgYWJvdXQgdGhlIGNoYW5nZWRfZmlsZXMgcmV0dXJuaW5n IGRlbGV0ZWQgZmlsZXMgcHJvYmxlbQorICAgICAgICB3aGljaCBpcyBjYXVzaW5nIHRoZSBvdGhl ciBtb3N0IGNvbW1vbiBleGNlcHRpb24gZm9yIHN1Z2dlc3QtcmV2aWV3ZXJzCisgICAgICAgIChh bmQgaXMgcHJvYmFibHkgYnJlYWtpbmcgc2hlcmlmZi1ib3RzIGJsYW1lIGRldGVjdGlvbikuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHk6CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weToKKwogMjAx MS0wMS0xMyAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9jaGVja291dC9hcGkucHkKaW5kZXggMjllNDNkM2Q1YzdlMzMxYWQ3NWRkZDA4OGJl MDA1ZDYyMWYzYjExMi4uYWI5M2MwYmE3MmQ1MTQ5NDYzZjI3NDdhNDQ1NDdhN2QwY2E0NGRmMyAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2FwaS5weQpAQCAt NTQsMTEgKzU0LDE0IEBAIGNsYXNzIENoZWNrb3V0KG9iamVjdCk6CiAgICAgICAgICMgY29udGVu dHNfYXRfcmV2aXNpb24gcmV0dXJucyBhIGJ5dGUgYXJyYXkgKHN0cigpKSwgYnV0IHdlIGtub3cK ICAgICAgICAgIyB0aGF0IENoYW5nZUxvZyBmaWxlcyBhcmUgdXRmLTguICBwYXJzZV9sYXRlc3Rf ZW50cnlfZnJvbV9maWxlCiAgICAgICAgICMgZXhwZWN0cyBhIGZpbGUtbGlrZSBvYmplY3Qgd2hp Y2ggdmVuZHMgdW5pY29kZSgpLCBzbyB3ZSBkZWNvZGUgaGVyZS4KLSAgICAgICAgY2hhbmdlbG9n X2ZpbGUgPSBTdHJpbmdJTy5TdHJpbmdJTyhjaGFuZ2Vsb2dfY29udGVudHMuZGVjb2RlKCJ1dGYt OCIpKQorICAgICAgICAjIE9sZCByZXZpc2lvbnMgb2YgU291cmNlcy9XZWJLaXQvd3gvQ2hhbmdl TG9nIGhhdmUgc29tZSBpbnZhbGlkIHV0ZjggY2hhcmFjdGVycy4KKyAgICAgICAgY2hhbmdlbG9n X2ZpbGUgPSBTdHJpbmdJTy5TdHJpbmdJTyhjaGFuZ2Vsb2dfY29udGVudHMuZGVjb2RlKCJ1dGYt OCIsICJpZ25vcmUiKSkKICAgICAgICAgcmV0dXJuIENoYW5nZUxvZy5wYXJzZV9sYXRlc3RfZW50 cnlfZnJvbV9maWxlKGNoYW5nZWxvZ19maWxlKQogCiAgICAgZGVmIGNoYW5nZWxvZ19lbnRyaWVz X2Zvcl9yZXZpc2lvbihzZWxmLCByZXZpc2lvbik6CiAgICAgICAgIGNoYW5nZWRfZmlsZXMgPSBz ZWxmLl9zY20uY2hhbmdlZF9maWxlc19mb3JfcmV2aXNpb24ocmV2aXNpb24pCisgICAgICAgICMg RklYTUU6IFRoaXMgZ2V0cyBjb25mdXNlZCBpZiBDaGFuZ2VMb2cgZmlsZXMgYXJlIG1vdmVkLCBh cworICAgICAgICAjIGRlbGV0ZXMgYXJlIHN0aWxsICJjaGFuZ2VkIGZpbGVzIiBwZXIgY2hhbmdl ZF9maWxlc19mb3JfcmV2aXNpb24uCiAgICAgICAgIHJldHVybiBbc2VsZi5fbGF0ZXN0X2VudHJ5 X2Zvcl9jaGFuZ2Vsb2dfYXRfcmV2aXNpb24ocGF0aCwgcmV2aXNpb24pIGZvciBwYXRoIGluIGNo YW5nZWRfZmlsZXMgaWYgc2VsZi5pc19wYXRoX3RvX2NoYW5nZWxvZyhwYXRoKV0KIAogICAgIEBt ZW1vaXplZApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tv dXQvYXBpX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tv dXQvYXBpX3VuaXR0ZXN0LnB5CmluZGV4IDFmOTdhYmQzZTc4M2M4NzUyNTM0YzdkYmU3Y2I2YjBi NjM0ZjAxY2YuLjZkY2VjNjE4OWM5NzM0N2U5MTQ5YmM5OWJmMWZhNmNhODQxMzM2N2QgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2FwaV91bml0dGVz dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGlfdW5p dHRlc3QucHkKQEAgLTEzMCw3ICsxMzAsOSBAQCBjbGFzcyBDaGVja291dFRlc3QodW5pdHRlc3Qu VGVzdENhc2UpOgogICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChyZXZpc2lvbiwgImJhciIp CiAgICAgICAgICAgICAjIGNvbnRlbnRzX2F0X3JldmlzaW9uIGlzIGV4cGVjdGVkIHRvIHJldHVy biBhIGJ5dGUgYXJyYXkgKHN0cikKICAgICAgICAgICAgICMgc28gd2UgZW5jb2RlIG91ciB1bmlj b2RlIENoYW5nZUxvZyBkb3duIHRvIGEgdXRmLTggc3RyZWFtLgotICAgICAgICAgICAgcmV0dXJu IF9jaGFuZ2Vsb2cxLmVuY29kZSgidXRmLTgiKQorICAgICAgICAgICAgIyBUaGUgQ2hhbmdlTG9n IHV0Zi04IGRlY29kaW5nIHNob3VsZCBpZ25vcmUgaW52YWxpZCBjb2RlcG9pbnRzLgorICAgICAg ICAgICAgaW52YWxpZF91dGY4ID0gc3RyKGIiXDI1NSIpCisgICAgICAgICAgICByZXR1cm4gX2No YW5nZWxvZzEuZW5jb2RlKCJ1dGYtOCIpICsgaW52YWxpZF91dGY4CiAgICAgICAgIHNjbS5jb250 ZW50c19hdF9yZXZpc2lvbiA9IG1vY2tfY29udGVudHNfYXRfcmV2aXNpb24KICAgICAgICAgY2hl Y2tvdXQgPSBDaGVja291dChzY20pCiAgICAgICAgIGVudHJ5ID0gY2hlY2tvdXQuX2xhdGVzdF9l bnRyeV9mb3JfY2hhbmdlbG9nX2F0X3JldmlzaW9uKCJmb28iLCAiYmFyIikKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQppbmRleCA5Y2ZkYWE0ZDNlMGI2 ODFlZDAyZjE0MTExNDgwZWFiZTU1YWY0NDgyLi5kNWQyOWY1ODczY2VlNjZlMGJlM2Y4MmZmZTcw ODRhZTMxOTU1MDU0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j aGVja291dC9zY20ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tv dXQvc2NtLnB5CkBAIC00MzksNiArNDM5LDcgQEAgY2xhc3MgU1ZOKFNDTSk6CiAgICAgZGVmIGNo YW5nZWRfZmlsZXMoc2VsZiwgZ2l0X2NvbW1pdD1Ob25lKToKICAgICAgICAgc3RhdHVzX2NvbW1h bmQgPSBbInN2biIsICJzdGF0dXMiXQogICAgICAgICBzdGF0dXNfY29tbWFuZC5leHRlbmQoc2Vs Zi5fcGF0Y2hfZGlyZWN0b3JpZXMpCisgICAgICAgICMgQUNETVI6IEFkZGRlZCwgQ29uZmxpY3Rl ZCwgRGVsZXRlZCwgTW9kaWZpZWQgb3IgUmVwbGFjZWQKICAgICAgICAgcmV0dXJuIHNlbGYucnVu X3N0YXR1c19hbmRfZXh0cmFjdF9maWxlbmFtZXMoc3RhdHVzX2NvbW1hbmQsIHNlbGYuX3N0YXR1 c19yZWdleHAoIkFDRE1SIikpCiAKICAgICBkZWYgY2hhbmdlZF9maWxlc19mb3JfcmV2aXNpb24o c2VsZiwgcmV2aXNpb24pOgpAQCAtNzA0LDcgKzcwNSwxMCBAQCBjbGFzcyBHaXQoU0NNKToKICAg ICAgICAgcmV0dXJuIHNlbGYucmVtb3RlX21lcmdlX2Jhc2UoKQogCiAgICAgZGVmIGNoYW5nZWRf ZmlsZXMoc2VsZiwgZ2l0X2NvbW1pdD1Ob25lKToKKyAgICAgICAgIyBGSVhNRTogLS1kaWZmLWZp bHRlciBjb3VsZCBiZSB1c2VkIHRvIGF2b2lkIHRoZSAiZXh0cmFjdF9maWxlbmFtZXMiIHN0ZXAu CiAgICAgICAgIHN0YXR1c19jb21tYW5kID0gWydnaXQnLCAnZGlmZicsICctcicsICctLW5hbWUt c3RhdHVzJywgJy1DJywgJy1NJywgIi0tbm8tZXh0LWRpZmYiLCAiLS1mdWxsLWluZGV4Iiwgc2Vs Zi5tZXJnZV9iYXNlKGdpdF9jb21taXQpXQorICAgICAgICAjIEZJWE1FOiBJJ20gbm90IHN1cmUg d2UncmUgcmV0dXJuaW5nIHRoZSBzYW1lIHNldCBvZiBmaWxlcyB0aGF0IFNWTi5jaGFuZ2VkX2Zp bGVzIGlzLgorICAgICAgICAjIEFkZGVkIChBKSwgQ29waWVkIChDKSwgRGVsZXRlZCAoRCksIE1v ZGlmaWVkIChNKSwgUmVuYW1lZCAoUikKICAgICAgICAgcmV0dXJuIHNlbGYucnVuX3N0YXR1c19h bmRfZXh0cmFjdF9maWxlbmFtZXMoc3RhdHVzX2NvbW1hbmQsIHNlbGYuX3N0YXR1c19yZWdleHAo IkFETSIpKQogCiAgICAgZGVmIF9jaGFuZ2VzX2ZpbGVzX2Zvcl9jb21taXQoc2VsZiwgZ2l0X2Nv bW1pdCk6Cg==