52413 2011-01-13 17:05:52 -0800 Prepare chromium/linux WebThemeEngine to support more theme parts 2011-01-14 22:01:47 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 xiyuan webkit-unassigned commit-queue fishd tony oldest_to_newest 334042 0 xiyuan 2011-01-13 17:05:52 -0800 This is the first step to hook up RenderTheme parts with WebThemeEngine. Those RenderTheme parts include: checkbox, radio, push button, text field (single line text edit, text area and listbox), menu list, slider track, slider thumb, inner spin button and progress bar. 334322 1 78943 xiyuan 2011-01-14 08:41:40 -0800 Created attachment 78943 Proposed WebThemeEngine API change Darin, could you help with the review? Thanks. 334849 2 78943 commit-queue 2011-01-14 22:01:42 -0800 Comment on attachment 78943 Proposed WebThemeEngine API change Clearing flags on attachment: 78943 Committed r75871: <http://trac.webkit.org/changeset/75871> 334850 3 commit-queue 2011-01-14 22:01:47 -0800 All reviewed patches have been landed. Closing bug. 78943 2011-01-14 08:41:40 -0800 2011-01-14 22:01:42 -0800 Proposed WebThemeEngine API change prepare_web_theme_interface.patch text/plain 3234 xiyuan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzU3OTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDEtMTQgIFhpeXVh biBYaWEgIDx4aXl1YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFByZXBhcmUgTGludXggV2ViVGhlbWVFbmdpbmUgaW50ZXJm YWNlIHRvIHN1cHBvcnQgbmV3IHRoZW1lIHBhcnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI0MTMKKworICAgICAgICAqIHB1YmxpYy9saW51eC9X ZWJUaGVtZUVuZ2luZS5oOgorCiAyMDExLTAxLTE0ICBGaW5udXIgVGhvcmFyaW5zc29uICA8Zmlu bnVyLndlYmtpdEBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4K SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvbGludXgvV2ViVGhlbWVFbmdpbmUuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL2xpbnV4L1dlYlRoZW1lRW5naW5lLmgJ KHJldmlzaW9uIDc1NzQ2KQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9saW51eC9XZWJUaGVt ZUVuZ2luZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00Myw2ICs0Myw3IEBAIGNsYXNzIFdlYlRoZW1l RW5naW5lIHsKIHB1YmxpYzoKICAgICAvLyBUaGUgVUkgcGFydCB3aGljaCBpcyBiZWluZyBhY2Nl c3NlZC4KICAgICBlbnVtIFBhcnQgeworICAgICAgICAvLyBTY3JvbGxiYXJUaGVtZSBwYXJ0cwog ICAgICAgICBQYXJ0U2Nyb2xsYmFyRG93bkFycm93LAogICAgICAgICBQYXJ0U2Nyb2xsYmFyTGVm dEFycm93LAogICAgICAgICBQYXJ0U2Nyb2xsYmFyUmlnaHRBcnJvdywKQEAgLTUwLDcgKzUxLDE4 IEBAIHB1YmxpYzoKICAgICAgICAgUGFydFNjcm9sbGJhckhvcml6b250YWxUaHVtYiwKICAgICAg ICAgUGFydFNjcm9sbGJhclZlcnRpY2FsVGh1bWIsCiAgICAgICAgIFBhcnRTY3JvbGxiYXJIb3Jp em9udGFsVHJhY2ssCi0gICAgICAgIFBhcnRTY3JvbGxiYXJWZXJ0aWNhbFRyYWNrCisgICAgICAg IFBhcnRTY3JvbGxiYXJWZXJ0aWNhbFRyYWNrLAorCisgICAgICAgIC8vIFJlbmRlclRoZW1lIHBh cnRzCisgICAgICAgIFBhcnRDaGVja2JveCwKKyAgICAgICAgUGFydFJhZGlvLAorICAgICAgICBQ YXJ0QnV0dG9uLAorICAgICAgICBQYXJ0VGV4dEZpZWxkLAorICAgICAgICBQYXJ0TWVudUxpc3Qs CisgICAgICAgIFBhcnRTbGlkZXJUcmFjaywKKyAgICAgICAgUGFydFNsaWRlclRodW1iLAorICAg ICAgICBQYXJ0SW5uZXJTcGluQnV0dG9uLAorICAgICAgICBQYXJ0UHJvZ3Jlc3NCYXIKICAgICB9 OwogCiAgICAgLy8gVGhlIGN1cnJlbnQgc3RhdGUgb2YgdGhlIGFzc29jaWF0ZWQgUGFydC4KQEAg LTcxLDggKzgzLDU3IEBAIHB1YmxpYzoKICAgICAgICAgaW50IHRyYWNrSGVpZ2h0OwogICAgIH07 CiAKKyAgICAvLyBFeHRyYSBwYXJhbWV0ZXJzIGZvciBQYXJ0Q2hlY2tib3gsIFBhcnRQdXNoQnV0 dG9uIGFuZCBQYXJ0UmFkaW8uCisgICAgc3RydWN0IEJ1dHRvbkV4dHJhUGFyYW1zIHsKKyAgICAg ICAgYm9vbCBjaGVja2VkOworICAgICAgICBib29sIGluZGV0ZXJtaW5hdGU7IC8vIFdoZXRoZXIg dGhlIGJ1dHRvbiBzdGF0ZSBpcyBpbmRldGVybWluYXRlLgorICAgICAgICBib29sIGlzRGVmYXVs dDsgLy8gV2hldGhlciB0aGUgYnV0dG9uIGlzIGRlZmF1bHQgYnV0dG9uLgorICAgICAgICBXZWJD b2xvciBiYWNrZ3JvdW5kQ29sb3I7CisgICAgfTsKKworICAgIC8vIEV4dHJhIHBhcmFtZXRlcnMg Zm9yIFBhcnRUZXh0RmllbGQKKyAgICBzdHJ1Y3QgVGV4dEZpZWxkRXh0cmFQYXJhbXMgeworICAg ICAgICBib29sIGlzVGV4dEFyZWE7CisgICAgICAgIGJvb2wgaXNMaXN0Ym94OworICAgICAgICBX ZWJDb2xvciBiYWNrZ3JvdW5kQ29sb3I7CisgICAgfTsKKworICAgIC8vIEV4dHJhIHBhcmFtZXRl cnMgZm9yIFBhcnRNZW51TGlzdAorICAgIHN0cnVjdCBNZW51TGlzdEV4dHJhUGFyYW1zIHsKKyAg ICAgICAgaW50IGFycm93WDsKKyAgICAgICAgaW50IGFycm93WTsKKyAgICAgICAgV2ViQ29sb3Ig YmFja2dyb3VuZENvbG9yOworICAgIH07CisKKyAgICAvLyBFeHRyYSBwYXJhbWV0ZXJzIGZvciBQ YXJ0U2xpZGVyVHJhY2sgYW5kIFBhcnRTbGlkZXJUaHVtYgorICAgIHN0cnVjdCBTbGlkZXJFeHRy YVBhcmFtcyB7CisgICAgICAgIGJvb2wgdmVydGljYWw7CisgICAgICAgIGJvb2wgaW5EcmFnOwor ICAgIH07CisKKyAgICAvLyBFeHRyYSBwYXJhbWV0ZXJzIGZvciBQYXJ0SW5uZXJTcGluQnV0dG9u CisgICAgc3RydWN0IElubmVyU3BpbkJ1dHRvbkV4dHJhUGFyYW1zIHsKKyAgICAgICAgYm9vbCBz cGluVXA7CisgICAgICAgIGJvb2wgcmVhZE9ubHk7CisgICAgfTsKKworICAgIC8vIEV4dHJhIHBh cmFtZXRlcnMgZm9yIFBhcnRQcm9ncmVzc0JhcgorICAgIHN0cnVjdCBQcm9ncmVzc0JhckV4dHJh UGFyYW1zIHsKKyAgICAgICAgYm9vbCBkZXRlcm1pbmF0ZTsKKyAgICAgICAgaW50IHZhbHVlUmVj dFg7CisgICAgICAgIGludCB2YWx1ZVJlY3RZOworICAgICAgICBpbnQgdmFsdWVSZWN0V2lkdGg7 CisgICAgICAgIGludCB2YWx1ZVJlY3RIZWlnaHQ7CisgICAgfTsKKwogICAgIHVuaW9uIEV4dHJh UGFyYW1zIHsKICAgICAgICAgU2Nyb2xsYmFyVHJhY2tFeHRyYVBhcmFtcyBzY3JvbGxiYXJUcmFj azsKKyAgICAgICAgQnV0dG9uRXh0cmFQYXJhbXMgYnV0dG9uOworICAgICAgICBUZXh0RmllbGRF eHRyYVBhcmFtcyB0ZXh0RmllbGQ7CisgICAgICAgIE1lbnVMaXN0RXh0cmFQYXJhbXMgbWVudUxp c3Q7CisgICAgICAgIFNsaWRlckV4dHJhUGFyYW1zIHNsaWRlcjsKKyAgICAgICAgSW5uZXJTcGlu QnV0dG9uRXh0cmFQYXJhbXMgaW5uZXJTcGluOworICAgICAgICBQcm9ncmVzc0JhckV4dHJhUGFy YW1zIHByb2dyZXNzQmFyOwogICAgIH07CiAKICAgICAvLyBHZXRzIHRoZSBzaXplIG9mIHRoZSBn aXZlbiB0aGVtZSBwYXJ0LiBGb3IgdmFyaWFibGUgc2l6ZWQgaXRlbXMK