52408 2011-01-13 16:31:26 -0800 [Qt] QtTestBrowser should have a UI setting to disable plugins 2011-01-26 09:33:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned commit-queue laszlo.gombos mansi.mithal oldest_to_newest 334021 0 yael 2011-01-13 16:31:26 -0800 It wuld help a lot when debugging if we could turn off plugins at runtime. 337514 1 mansi.mithal 2011-01-20 12:36:21 -0800 I have the patch ready. But since the patch depends on the bug : 52817 , I will submit it after the other one gets checked in. 339920 2 80119 mansi.mithal 2011-01-25 14:19:00 -0800 Created attachment 80119 Add "Disable Plugins" under Settings Menu 340102 3 80119 tonikitoo 2011-01-25 19:35:18 -0800 Comment on attachment 80119 Add "Disable Plugins" under Settings Menu View in context: https://bugs.webkit.org/attachment.cgi?id=80119&action=review > Tools/ChangeLog:5 > + QtTestBrowser should have a UI Setting to disable plugins two spaces after "UI" > Tools/ChangeLog:9 > + under the "Settings" menu You missed a "." at the end of sentence. 340104 4 80119 commit-queue 2011-01-25 19:38:42 -0800 Comment on attachment 80119 Add "Disable Plugins" under Settings Menu Rejecting attachment 80119 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'ap..." exit_code: 2 Last 500 characters of output: /ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/QtTestBrowser/launcherwindow.cpp Hunk #1 succeeded at 371 with fuzz 2 (offset 4 lines). Hunk #2 succeeded at 783 with fuzz 1 (offset 9 lines). patching file Tools/QtTestBrowser/launcherwindow.h Hunk #1 FAILED at 163. 1 out of 1 hunk FAILED -- saving rejects to file Tools/QtTestBrowser/launcherwindow.h.rej Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7559364 340276 5 80196 mansi.mithal 2011-01-26 08:32:22 -0800 Created attachment 80196 Add "Disable Plugins" under Settings Menu 340307 6 commit-queue 2011-01-26 09:32:21 -0800 The commit-queue encountered the following flaky tests while processing attachment 80196: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 340309 7 80196 commit-queue 2011-01-26 09:33:00 -0800 Comment on attachment 80196 Add "Disable Plugins" under Settings Menu Clearing flags on attachment: 80196 Committed r76693: <http://trac.webkit.org/changeset/76693> 340310 8 commit-queue 2011-01-26 09:33:03 -0800 All reviewed patches have been landed. Closing bug. 80119 2011-01-25 14:19:00 -0800 2011-01-26 08:32:22 -0800 Add "Disable Plugins" under Settings Menu 52408.patch text/plain 2543 mansi.mithal SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc2NjM5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDEtMjUgIE1hbnNpIE1pdGhhbCAgPG1hbnNpLm1pdGhhbEBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUXRU ZXN0QnJvd3NlciBzaG91bGQgaGF2ZSBhIFVJICBTZXR0aW5nIHRvIGRpc2FibGUgcGx1Z2lucwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI0MDgKKyAg ICAgICAgCisgICAgICAgIEFkZGVkIGEgbmV3IGFjdGlvbiBpdGVtIG5hbWVkICJEaXNhYmxlIFBs dWdpbnMiCisgICAgICAgIHVuZGVyIHRoZSAiU2V0dGluZ3MiIG1lbnUgCisKKyAgICAgICAgKiBR dFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcDoKKyAgICAgICAgKExhdW5jaGVyV2luZG93 OjpjcmVhdGVDaHJvbWUpOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OnRvZ2dsZVBsdWdpbnMp OgorICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaDoKKwogMjAxMS0wMS0y NSAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFRvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5k b3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cu Y3BwCShyZXZpc2lvbiA3NjYxMykKKysrIFRvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5k b3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjcsNiArMzY3LDEwIEBAIHZvaWQgTGF1bmNoZXJX aW5kb3c6OmNyZWF0ZUNocm9tZSgpCiAKICAgICBRTWVudSogc2V0dGluZ3NNZW51ID0gbWVudUJh cigpLT5hZGRNZW51KCImU2V0dGluZ3MiKTsKIAorICAgIFFBY3Rpb24qIHRvZ2dsZVBsdWdpbnMg PSBzZXR0aW5nc01lbnUtPmFkZEFjdGlvbigiRGlzYWJsZSBQbHVnaW5zIiwgdGhpcywgU0xPVCh0 b2dnbGVQbHVnaW5zKGJvb2wpKSk7CisgICAgdG9nZ2xlUGx1Z2lucy0+c2V0Q2hlY2thYmxlKHRy dWUpOworICAgIHRvZ2dsZVBsdWdpbnMtPnNldENoZWNrZWQoZmFsc2UpOworCiAgICAgUUFjdGlv biogdG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdGVFbmFibGVkID0gc2V0dGluZ3NNZW51LT5h ZGRBY3Rpb24oIkVuYWJsZSBpbnRlcnJ1cHRpbmcganMgc2NyaXB0cyIsIHRoaXMsIFNMT1QodG9n Z2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdEVuYWJsZWQoYm9vbCkpKTsKICAgICB0b2dnbGVJbnRl cnJ1cHRpbmdKYXZhU2NyaXB0ZUVuYWJsZWQtPnNldENoZWNrYWJsZSh0cnVlKTsKICAgICB0b2dn bGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0ZUVuYWJsZWQtPnNldENoZWNrZWQoZmFsc2UpOwpAQCAt NzcwLDYgKzc3NCwxMSBAQCB2b2lkIExhdW5jaGVyV2luZG93Ojp0b2dnbGVKYXZhc2NyaXB0Q2Fu CiAgICAgcGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZh c2NyaXB0Q2FuT3BlbldpbmRvd3MsIGVuYWJsZSk7CiB9CiAKK3ZvaWQgTGF1bmNoZXJXaW5kb3c6 OnRvZ2dsZVBsdWdpbnMoYm9vbCBlbmFibGUpCit7CisgICAgcGFnZSgpLT5zZXR0aW5ncygpLT5z ZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpQbHVnaW5zRW5hYmxlZCwgIWVuYWJsZSk7Cit9CisK ICNpZiBkZWZpbmVkKFFUX0NPTkZJR1VSRURfV0lUSF9PUEVOR0wpCiB2b2lkIExhdW5jaGVyV2lu ZG93Ojp0b2dnbGVRR0xXaWRnZXRWaWV3cG9ydChib29sIGVuYWJsZSkKIHsKSW5kZXg6IFRvb2xz L1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdFRl c3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgJKHJldmlzaW9uIDc2NjEzKQorKysgVG9vbHMvUXRU ZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjMsNyArMTYz LDcgQEAgcHJvdGVjdGVkIHNsb3RzOgogICAgIHZvaWQgdG9nZ2xlRnJhbWVGbGF0dGVuaW5nKGJv b2wgdG9nZ2xlKTsKICAgICB2b2lkIHRvZ2dsZUludGVycnVwdGluZ0phdmFTY3JpcHRFbmFibGVk KGJvb2wgZW5hYmxlKTsKICAgICB2b2lkIHRvZ2dsZUphdmFzY3JpcHRDYW5PcGVuV2luZG93cyhi b29sIGVuYWJsZSk7Ci0KKyAgICB2b2lkIHRvZ2dsZVBsdWdpbnMoYm9vbCBlbmFibGUpOwogI2lm IGRlZmluZWQoUVRfQ09ORklHVVJFRF9XSVRIX09QRU5HTCkKICAgICB2b2lkIHRvZ2dsZVFHTFdp ZGdldFZpZXdwb3J0KGJvb2wgZW5hYmxlKTsKICNlbmRpZgo= 80196 2011-01-26 08:32:22 -0800 2011-01-26 09:33:00 -0800 Add "Disable Plugins" under Settings Menu 52408.patch text/plain 2558 mansi.mithal SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc2NjkxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDEtMjYgIE1hbnNpIE1pdGhhbCAgPG1hbnNpLm1pdGhhbEBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUXRU ZXN0QnJvd3NlciBzaG91bGQgaGF2ZSBhIFVJIFNldHRpbmcgdG8gZGlzYWJsZSBwbHVnaW5zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjQwOAorICAg ICAgICAKKyAgICAgICAgQWRkZWQgYSBuZXcgYWN0aW9uIGl0ZW0gbmFtZWQgIkRpc2FibGUgUGx1 Z2lucyIKKyAgICAgICAgdW5kZXIgdGhlICJTZXR0aW5ncyIgbWVudS4gCisKKyAgICAgICAgKiBR dFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcDoKKyAgICAgICAgKExhdW5jaGVyV2luZG93 OjpjcmVhdGVDaHJvbWUpOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OnRvZ2dsZVBsdWdpbnMp OgorICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaDoKKwogMjAxMS0wMS0y NSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndp bmRvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRv dy5jcHAJKHJldmlzaW9uIDc2NjQ2KQorKysgVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndp bmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3MSw2ICszNzEsMTAgQEAgdm9pZCBMYXVuY2hl cldpbmRvdzo6Y3JlYXRlQ2hyb21lKCkKICAgICB0b2dnbGVBdXRvTG9hZEltYWdlcy0+c2V0Q2hl Y2thYmxlKHRydWUpOwogICAgIHRvZ2dsZUF1dG9Mb2FkSW1hZ2VzLT5zZXRDaGVja2VkKGZhbHNl KTsKIAorICAgIFFBY3Rpb24qIHRvZ2dsZVBsdWdpbnMgPSBzZXR0aW5nc01lbnUtPmFkZEFjdGlv bigiRGlzYWJsZSBQbHVnaW5zIiwgdGhpcywgU0xPVCh0b2dnbGVQbHVnaW5zKGJvb2wpKSk7Cisg ICAgdG9nZ2xlUGx1Z2lucy0+c2V0Q2hlY2thYmxlKHRydWUpOworICAgIHRvZ2dsZVBsdWdpbnMt PnNldENoZWNrZWQoZmFsc2UpOworCiAgICAgUUFjdGlvbiogdG9nZ2xlSW50ZXJydXB0aW5nSmF2 YVNjcmlwdGVFbmFibGVkID0gc2V0dGluZ3NNZW51LT5hZGRBY3Rpb24oIkVuYWJsZSBpbnRlcnJ1 cHRpbmcganMgc2NyaXB0cyIsIHRoaXMsIFNMT1QodG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlw dEVuYWJsZWQoYm9vbCkpKTsKICAgICB0b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0ZUVuYWJs ZWQtPnNldENoZWNrYWJsZSh0cnVlKTsKICAgICB0b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0 ZUVuYWJsZWQtPnNldENoZWNrZWQoZmFsc2UpOwpAQCAtNzc5LDYgKzc4MywxMSBAQCB2b2lkIExh dW5jaGVyV2luZG93Ojp0b2dnbGVBdXRvTG9hZEltYWdlCiAgICAgcGFnZSgpLT5zZXR0aW5ncygp LT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpBdXRvTG9hZEltYWdlcywgIWVuYWJsZSk7CiB9 CiAKK3ZvaWQgTGF1bmNoZXJXaW5kb3c6OnRvZ2dsZVBsdWdpbnMoYm9vbCBlbmFibGUpCit7Cisg ICAgcGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpQbHVnaW5z RW5hYmxlZCwgIWVuYWJsZSk7Cit9CisKICNpZiBkZWZpbmVkKFFUX0NPTkZJR1VSRURfV0lUSF9P UEVOR0wpCiB2b2lkIExhdW5jaGVyV2luZG93Ojp0b2dnbGVRR0xXaWRnZXRWaWV3cG9ydChib29s IGVuYWJsZSkKIHsKSW5kZXg6IFRvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgJKHJldmlz aW9uIDc2NjQ2KQorKysgVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjQsNiArMTY0LDcgQEAgcHJvdGVjdGVkIHNsb3RzOgogICAgIHZvaWQg dG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdEVuYWJsZWQoYm9vbCBlbmFibGUpOwogICAgIHZv aWQgdG9nZ2xlSmF2YXNjcmlwdENhbk9wZW5XaW5kb3dzKGJvb2wgZW5hYmxlKTsKICAgICB2b2lk IHRvZ2dsZUF1dG9Mb2FkSW1hZ2VzKGJvb2wgZW5hYmxlKTsKKyAgICB2b2lkIHRvZ2dsZVBsdWdp bnMoYm9vbCBlbmFibGUpOwogCiAjaWYgZGVmaW5lZChRVF9DT05GSUdVUkVEX1dJVEhfT1BFTkdM KQogICAgIHZvaWQgdG9nZ2xlUUdMV2lkZ2V0Vmlld3BvcnQoYm9vbCBlbmFibGUpOwo=