52407 2011-01-13 16:21:01 -0800 simplify keyboard handling in code review tool 2011-01-13 16:40:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth arv eric oldest_to_newest 334013 0 ojan 2011-01-13 16:21:01 -0800 simplify keyboard handling in code review tool 334014 1 78873 ojan 2011-01-13 16:22:17 -0800 Created attachment 78873 Patch 334020 2 78873 abarth 2011-01-13 16:30:41 -0800 Comment on attachment 78873 Patch Very nice. 334027 3 ojan 2011-01-13 16:40:07 -0800 Committed r75754: <http://trac.webkit.org/changeset/75754> 78873 2011-01-13 16:22:17 -0800 2011-01-13 16:30:41 -0800 Patch bug-52407-20110113162215.patch text/plain 4328 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDMxMGY3ODJlNDNkZTgzMjZkNDJlMTg5 MzNlN2M2NThmZTRkZDBiMzIuLjhlNTYwODc3YmY3NzEzZjFkNjczYzQzNmMyYTkwYjc3MGUyZGUz ZGIgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEx LTAxLTEzICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc2ltcGxpZnkga2V5Ym9hcmQgaGFuZGxp bmcgaW4gY29kZSByZXZpZXcgdG9vbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTI0MDcKKworICAgICAgICBOb3cgdGhhdCB3ZSBoYXZlIERpZmZCbG9j ayBjb250YWluZXJzLCB0aGUgb25seSB0aGluZ3MgdGhhdCBhcmUKKyAgICAgICAgZm9jdXNhYmxl IGFyZSBwcmV2aW91c0NvbW1lbnQgbm9kZXMgYW5kIERpZmZCbG9jayBjb250YWluZXJzCisgICAg ICAgIHRoYXQgY29udGFpbiBhZGQvcmVtb3ZlIGxpbmVzLgorCisgICAgICAgIEFsc28sIHRoaXMg bWVhbnMgd2Ugc2hvdyB0aGUgZm9jdXMgYm9yZGVyIGFyb3VuZCB0aGUgZW50aXJlIGRpZmYKKyAg ICAgICAgaW5zdGVhZCBvZiBqdXN0IHRoZSBmaXJzdCBsaW5lLgorCisgICAgICAgICogY29kZS1y ZXZpZXcuanM6CisKKzIwMTEtMDEtMTMgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4K KwogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAgIGFkZCBjb250YWlu ZXIgZGl2cyBmb3IgZGlmZiBibG9ja3MKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0 Lm9yZy9jb2RlLXJldmlldy5qcyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmll dy5qcwppbmRleCBmMmNmOGE5MDgxNjRiMmNlOWRmMzk2MWNlNDhhNzczZjU1OTE1NGIxLi5hOGJk ZTQwNTI0YWNmZWFiMDZkMmMyOTk4MDJlMTdkNzBhNTZiMzYxIDEwMDY0NAotLS0gYS9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJr aXQub3JnL2NvZGUtcmV2aWV3LmpzCkBAIC05NDYsNjQgKzk0NiwyMCBAQAogICAgICQoZG9jdW1l bnQpLnNjcm9sbFRvcChub2RlLmFkZENsYXNzKCdmb2N1c2VkJykucG9zaXRpb24oKS50b3AgLSB3 aW5kb3cuaW5uZXJIZWlnaHQgLyAyKTsKICAgfQogCi0gIGZ1bmN0aW9uIGRpZmZCbG9ja0VuZFBv aW50KGZvY3VzYWJsZV9ub2RlcywgbGluZSwgbGluZV9vZmZzZXQsIGlzX2JhY2t3YXJkKSB7Ci0g ICAgaWYgKCFsaW5lX29mZnNldCAmJiBpc19iYWNrd2FyZCkKLSAgICAgIHJldHVybiBsaW5lOwot Ci0gICAgdmFyIG9mZnNldCA9IGlzX2JhY2t3YXJkID8gLTEgOiAxOwotCi0gICAgLy8gSWYgd2Un cmUgYXQgYSBjb21tZW50LCBnZXQgYSBMaW5lIGluIHRoZSBkaWZmIGJsb2NrIHRoYXQgY29udGFp bnMgdGhlIGNvbW1lbnQuCi0gICAgaWYgKGxpbmUuaGFzQ2xhc3MoJ3ByZXZpb3VzQ29tbWVudCcp KSB7Ci0gICAgICB2YXIgbGluZV9mb3JfY29tbWVudCA9ICQoJyMnICsgbGluZS5hdHRyKCdkYXRh LWNvbW1lbnQtZm9yJykpOwotICAgICAgbGluZV9vZmZzZXQgPSBmb2N1c2FibGVfbm9kZXMuaW5k ZXgobGluZV9mb3JfY29tbWVudCk7Ci0KLSAgICAgIC8vIElmIHRoZSBjb21tZW50IGlzIG5vdCBp bnNpZGUgYSBkaWZmIGJsb2NrLCByZXR1cm4gdGhlIGNvbW1lbnQgbm9kZS4KLSAgICAgIGlmIChs aW5lX29mZnNldCA9PSAtMSkKLSAgICAgICAgcmV0dXJuIGxpbmU7Ci0KLSAgICAgIGxpbmUgPSBs aW5lX2Zvcl9jb21tZW50OwotICAgIH0KLQotICAgIC8vIEZpbmQgdGhlIExpbmUgYXQgdGhlIGJl Z2lubmluZy9lbmQgb2YgdGhpcyBjb250aWd1b3VzIGJsb2NrIG9mIGxpbmVzLgotICAgIC8vIENv bnRpZ3VvdXMgYmxvY2tzIG9mIGxpbmVzIGhhdmUgY29udGlndW91cyBJRHMgYW5kIGFyZSBjb250 YWluZWQgaW4gdGhlIHNhbWUgRmlsZURpZmYuCi0gICAgLy8gU2tpcCBvdmVyIGNvbW1lbnQgbm9k ZXMuCi0gICAgdmFyIGlkID0gbnVtYmVyRnJvbShsaW5lLmF0dHIoJ2lkJykpOwotICAgIHZhciBu ZXh0X25vZGUgPSAkKGZvY3VzYWJsZV9ub2Rlc1tsaW5lX29mZnNldCArIG9mZnNldF0pOwotICAg IHdoaWxlIChuZXh0X25vZGUuc2l6ZSgpCi0gICAgICAgICAgICYmICghbmV4dF9ub2RlLmhhc0Ns YXNzKCdMaW5lJykgfHwgbmV4dF9ub2RlLmF0dHIoJ2lkJykgPT0gJ2xpbmUnICsgKGlkICsgb2Zm c2V0KSkKLSAgICAgICAgICAgJiYgZmlsZURpZmZGb3IobGluZSlbMF0gPT0gZmlsZURpZmZGb3Io bmV4dF9ub2RlKVswXSkgewotICAgICAgaWYgKG5leHRfbm9kZS5oYXNDbGFzcygnTGluZScpKSB7 Ci0gICAgICAgIGxpbmUgPSBuZXh0X25vZGU7Ci0gICAgICAgIGlkICs9IG9mZnNldDsKLSAgICAg IH0KLQotICAgICAgbGluZV9vZmZzZXQgKz0gb2Zmc2V0OwotICAgICAgbmV4dF9ub2RlID0gJChm b2N1c2FibGVfbm9kZXNbbGluZV9vZmZzZXQgKyBvZmZzZXRdKTsKLSAgICB9Ci0gICAgcmV0dXJu IGxpbmU7Ci0gIH0KLQogICBmdW5jdGlvbiBmb2N1c05leHQoY2xhc3NOYW1lLCBpc19iYWNrd2Fy ZCkgewotICAgIHZhciBmb2N1c2FibGVfbm9kZXMgPSAkKCcucHJldmlvdXNDb21tZW50LC5MaW5l LmFkZCwuTGluZS5yZW1vdmUnKTsKLSAgICB2YXIgZm9jdXNlZF9ub2RlID0gJCgnLmZvY3VzZWQn KTsKLSAgICB2YXIgaW5kZXggPSBmb2N1c2FibGVfbm9kZXMuaW5kZXgoZm9jdXNlZF9ub2RlKTsK LSAgICBpZiAoaXNfYmFja3dhcmQgJiYgKCFpbmRleCB8fCBpbmRleCA9PSAtMSkpCi0gICAgICBy ZXR1cm47CisgICAgdmFyIGZvY3VzYWJsZV9ub2RlcyA9ICQoJy5wcmV2aW91c0NvbW1lbnQsLkRp ZmZCbG9jaycpLmZpbHRlcihmdW5jdGlvbigpIHsKKyAgICAgIHJldHVybiAoJCh0aGlzKS5oYXND bGFzcygncHJldmlvdXNDb21tZW50JykgfHwgJCgnLmFkZCwucmVtb3ZlJywgdGhpcykuc2l6ZSgp KTsKKyAgICB9KTsKIAotICAgIGlmIChmb2N1c2VkX25vZGUuc2l6ZSgpICYmIGNsYXNzTmFtZSA9 PSAnTGluZScpIHsKLSAgICAgIGZvY3VzZWRfbm9kZSA9IGRpZmZCbG9ja0VuZFBvaW50KGZvY3Vz YWJsZV9ub2RlcywgZm9jdXNlZF9ub2RlLCBpbmRleCwgaXNfYmFja3dhcmQpOwotICAgICAgaW5k ZXggPSBmb2N1c2FibGVfbm9kZXMuaW5kZXgoZm9jdXNlZF9ub2RlKTsKLSAgICB9CisgICAgdmFy IGluZGV4ID0gZm9jdXNhYmxlX25vZGVzLmluZGV4KCQoJy5mb2N1c2VkJykpOworICAgIGlmIChp bmRleCA9PSAtMSAmJiBpc19iYWNrd2FyZCkKKyAgICAgIGluZGV4ID0gZm9jdXNhYmxlX25vZGVz Lmxlbmd0aDsKIAotICAgIHZhciBlbmQgPSBpc19iYWNrd2FyZCA/IDAgOiBmb2N1c2FibGVfbm9k ZXMuc2l6ZSgpOwogICAgIHZhciBvZmZzZXQgPSBpc19iYWNrd2FyZCA/IC0xIDogMTsKKyAgICB2 YXIgZW5kID0gaXNfYmFja3dhcmQgPyAtMSA6IGZvY3VzYWJsZV9ub2Rlcy5zaXplKCk7CiAgICAg Zm9yICh2YXIgaSA9IGluZGV4ICsgb2Zmc2V0OyBpICE9IGVuZDsgaSA9IGkgKyBvZmZzZXQpIHsK ICAgICAgIHZhciBub2RlID0gJChmb2N1c2FibGVfbm9kZXNbaV0pOwogICAgICAgaWYgKG5vZGUu aGFzQ2xhc3MoY2xhc3NOYW1lKSkgewotICAgICAgICBpZiAoY2xhc3NOYW1lID09ICdMaW5lJykg ewotICAgICAgICAgIC8vIFBhc3MgaW4gdHJ1ZSBmb3IgaXNfYmFja3dhcmQgYmVjYXVzZSB3ZSBh bHdheXMgd2FudCB0byBmb2N1cyB0aGUgc3RhcnQgb2YgdGhlIGRpZmYgYmxvY2suCi0gICAgICAg ICAgbm9kZSA9IGRpZmZCbG9ja0VuZFBvaW50KGZvY3VzYWJsZV9ub2Rlcywgbm9kZSwgaSwgdHJ1 ZSk7Ci0gICAgICAgIH0KICAgICAgICAgZm9jdXNPbihub2RlKTsKICAgICAgICAgcmV0dXJuOwog ICAgICAgfQpAQCAtMTAzMSwxMSArOTg3LDExIEBACiAgICAgICBicmVhazsKIAogICAgIGNhc2Ug a0NoYXJDb2RlRm9ySjoKLSAgICAgIGZvY3VzTmV4dCgnTGluZScsIGZhbHNlKTsKKyAgICAgIGZv Y3VzTmV4dCgnRGlmZkJsb2NrJywgZmFsc2UpOwogICAgICAgYnJlYWs7CiAKICAgICBjYXNlIGtD aGFyQ29kZUZvcks6Ci0gICAgICBmb2N1c05leHQoJ0xpbmUnLCB0cnVlKTsKKyAgICAgIGZvY3Vz TmV4dCgnRGlmZkJsb2NrJywgdHJ1ZSk7CiAgICAgICBicmVhazsKICAgICB9CiAgIH0pOwo=