52405 2011-01-13 15:44:33 -0800 results archives from commit-queue are too large to upload 2011-01-13 18:23:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue eric webkit.review.bot oldest_to_newest 333991 0 eric 2011-01-13 15:44:33 -0800 results archives from commit-queue are too large to upload 333992 1 78869 eric 2011-01-13 15:44:53 -0800 Created attachment 78869 Patch 333995 2 78869 abarth 2011-01-13 15:50:20 -0800 Comment on attachment 78869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78869&action=review > Tools/Scripts/webkitpy/common/system/filesystem_mock.py:121 > + def remove_tree(self, path, ignore_errors=False): > + self.files = [file for file in self.files if not file.startswith(path)] You wrote a mock but no unit test! 333996 3 78869 abarth 2011-01-13 15:50:50 -0800 Comment on attachment 78869 Patch Ok on no unit test. But I'm not going to give you a cookie. 334060 4 78869 commit-queue 2011-01-13 17:52:14 -0800 Comment on attachment 78869 Patch Clearing flags on attachment: 78869 Committed r75760: <http://trac.webkit.org/changeset/75760> 334061 5 commit-queue 2011-01-13 17:52:20 -0800 All reviewed patches have been landed. Closing bug. 334073 6 webkit.review.bot 2011-01-13 18:23:33 -0800 http://trac.webkit.org/changeset/75760 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/cross-origin-authorization.html 78869 2011-01-13 15:44:53 -0800 2011-01-13 17:52:13 -0800 Patch bug-52405-20110113154452.patch text/plain 3257 eric ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYzUz NDUxNzE5OGY1NTk2ZjM4OWZjNDQyM2VhOWE0NWNhMjAyOWQ3Li5hYmQzNjUxZjFmNGY0NzE4YmRk MGY3ZWY5YzEyYzhhZjM0N2RkNzkyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMTMgIEVyaWMgU2VpZGVs ICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIHJlc3VsdHMgYXJjaGl2ZXMgZnJvbSBjb21taXQtcXVldWUgYXJlIHRvbyBs YXJnZSB0byB1cGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUyNDA1CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v ZmlsZXN5c3RlbS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v ZmlsZXN5c3RlbV9tb2NrLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21t YW5kcy9xdWV1ZXMucHk6CisKIDIwMTEtMDEtMTMgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4 QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW0u cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQpp bmRleCA4ODMwZWE4ZGM2YzA1MWRhNGIzMjRlZWZmY2EyMDYxNzA3MTI5MGQxLi41MjdiNmJkZWE1 YWQ2OGRhMjUzMGYzMDY5ZmU3Zjg3YmYyZWI2ZWIyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQpAQCAtMTI0LDYgKzEyNCw5IEBA IGNsYXNzIEZpbGVTeXN0ZW0ob2JqZWN0KToKICAgICAgICAgICAgICAgICBpZiByZXRyeV90aW1l b3V0X3NlYyA8IDA6CiAgICAgICAgICAgICAgICAgICAgIHJhaXNlIGUKIAorICAgIGRlZiByZW1v dmVfdHJlZShzZWxmLCBwYXRoLCBpZ25vcmVfZXJyb3JzPUZhbHNlKToKKyAgICAgICAgc2h1dGls LnJtdHJlZShwYXRoLCBpZ25vcmVfZXJyb3JzKQorCiAgICAgZGVmIHJlYWRfYmluYXJ5X2ZpbGUo c2VsZiwgcGF0aCk6CiAgICAgICAgICIiIlJldHVybiB0aGUgY29udGVudHMgb2YgdGhlIGZpbGUg YXQgdGhlIGdpdmVuIHBhdGggYXMgYSBieXRlIHN0cmluZy4iIiIKICAgICAgICAgd2l0aCBmaWxl KHBhdGgsICdyYicpIGFzIGY6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV9tb2NrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL2ZpbGVzeXN0ZW1fbW9jay5weQppbmRleCBjNjA1Y2IyMThkN2JlMjZiYmYz MzAxZTg4YzdkODY5MWFlYzI0OGZjLi44MDljNGM2ZmJhYWJhYzA1NjU2NWE3ZDYzZTZjYmM5MzUz YjliMWZjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v ZmlsZXN5c3RlbV9tb2NrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9maWxlc3lzdGVtX21vY2sucHkKQEAgLTExNiwzICsxMTYsNiBAQCBjbGFzcyBNb2NrRmls ZVN5c3RlbShvYmplY3QpOgogCiAgICAgZGVmIHJlbW92ZShzZWxmLCBwYXRoKToKICAgICAgICAg ZGVsIHNlbGYuZmlsZXNbcGF0aF0KKworICAgIGRlZiByZW1vdmVfdHJlZShzZWxmLCBwYXRoLCBp Z25vcmVfZXJyb3JzPUZhbHNlKToKKyAgICAgICAgc2VsZi5maWxlcyA9IFtmaWxlIGZvciBmaWxl IGluIHNlbGYuZmlsZXMgaWYgbm90IGZpbGUuc3RhcnRzd2l0aChwYXRoKV0KZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CmluZGV4IDkwYjJiNGRkOTQ4 NjdhM2U3OGM1OGI0MjM4ZmU5ZDU0ZWVjNDM4MTUuLjQyMzIxY2ZiNDViYWU4ZjI5ZTU1YjFlODM4 ZjM3OGUwMzJhZDc0NTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9xdWV1ZXMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1h bmRzL3F1ZXVlcy5weQpAQCAtMzIzLDcgKzMyMywxMSBAQCBjbGFzcyBDb21taXRRdWV1ZShBYnN0 cmFjdFBhdGNoUXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlciwgQ29tbWl0UXVldWVUYXNr RAogICAgICAgICByZXN1bHRzX25hbWUsIF8gPSBvcy5wYXRoLnNwbGl0ZXh0KG9zLnBhdGguYmFz ZW5hbWUocmVzdWx0c19kaXJlY3RvcnkpKQogICAgICAgICAjIE5vdGU6IFdlIG5hbWUgdGhlIHpp cCB3aXRoIHRoZSBidWdfaWQgaW5zdGVhZCBvZiBwYXRjaF9pZCB0byBtYXRjaCB3b3JrX2l0ZW1f bG9nX3BhdGgoKS4KICAgICAgICAgemlwX3BhdGggPSBzZWxmLl90b29sLndvcmtzcGFjZS5maW5k X3VudXNlZF9maWxlbmFtZShzZWxmLl9sb2dfZGlyZWN0b3J5KCksICIlcy0lcyIgJSAocGF0Y2gu YnVnX2lkKCksIHJlc3VsdHNfbmFtZSksICJ6aXAiKQotICAgICAgICByZXR1cm4gc2VsZi5fdG9v bC53b3Jrc3BhY2UuY3JlYXRlX3ppcCh6aXBfcGF0aCwgcmVzdWx0c19kaXJlY3RvcnkpCisgICAg ICAgIGFyY2hpdmUgPSBzZWxmLl90b29sLndvcmtzcGFjZS5jcmVhdGVfemlwKHppcF9wYXRoLCBy ZXN1bHRzX2RpcmVjdG9yeSkKKyAgICAgICAgIyBSZW1vdmUgdGhlIHJlc3VsdHMgZGlyZWN0b3J5 IHRvIHByZXZlbnQgaHR0cCBsb2dzLCBldGMuIGZyb20gZ2V0dGluZyBodWdlIGJldHdlZW4gcnVu cy4KKyAgICAgICAgIyBXZSBjb3VsZCBoYXZlIGNyZWF0ZV96aXAgcmVtb3ZlIHRoZSBvcmlnaW5h bCwgYnV0IHRoaXMgaXMgbW9yZSBleHBsaWNpdC4KKyAgICAgICAgc2VsZi5fdG9vbC5maWxlc3lz dGVtLnJlbW92ZV90cmVlKHJlc3VsdHNfZGlyZWN0b3J5LCBpZ25vcmVfZXJyb3JzPVRydWUpCisg ICAgICAgIHJldHVybiBhcmNoaXZlCiAKICAgICBkZWYgcmVmZXRjaF9wYXRjaChzZWxmLCBwYXRj aCk6CiAgICAgICAgIHJldHVybiBzZWxmLl90b29sLmJ1Z3MuZmV0Y2hfYXR0YWNobWVudChwYXRj aC5pZCgpKQo=