5240 2005-10-02 20:10:04 -0700 WebKit+SVG does not always display <use> tags correctly. 2005-10-08 03:18:22 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED http://openclipart.org/clipart//computer/cpu_heatsink_fan_socket_.svg P2 Normal --- 1 tjrichard eric oldest_to_newest 21205 0 tjrichard 2005-10-02 20:10:04 -0700 This is possibly a KSVG problem. Some SVG images appear incomplete when displayed using Safari+SVG (latest build from 2005-09-03). Example 1: http://openclipart.org/clipart//computer/cpu_heatsink_fan_socket_.svg should look like http://openclipart.org/clipart//computer/cpu_heatsink_fan_socket_.png (note missing side) Example 2: http://openclipart.org/clipart//unsorted/newspaper_aubanel_monnie_01.svg should look like http://openclipart.org/clipart//unsorted/newspaper_aubanel_monnie_01.png (note missing text) 21234 1 eric 2005-10-02 23:38:35 -0700 The missing text is caused by: http://bugzilla.opendarwin.org/show_bug.cgi?id=4883 The first example seems to be something else. Not sure yet. 21400 2 4212 julien.palmas 2005-10-05 05:07:05 -0700 Created attachment 4212 Reduced example The problem comes from the <use> tag. 21417 3 eric 2005-10-05 09:55:31 -0700 This may have been related to memory fixes I made to KSVG::StyledElementImpl::attach() if (parentElement && parentElement->isStyled()) styledParent = static_cast<SVGStyledElementImpl *>(parentElement); if(styledParent && styledParent->canvasItem() && styledParent->allowAttachChildren(this)) styledParent->canvasItem()->appendItem(m_canvasItem); else if (styledParent && (styledParent->id() != ID_PATTERN)) { // FIXME: This exists until we can find a better way to create root && pattern nodes. -- ecs 8/7/05 delete m_canvasItem; m_canvasItem = NULL; //fprintf(stderr, "FAILED CANVAS INSERTION: <%s>\n", KDOM::DOMString(nodeName ()).string().ascii()) } Then again, it may not be related to that at all, since <use> shouldnt' have any children in this example. We would have to talk with rwlbuis or WildFox to make sure. It might also be worth checking this SVG in DrawTest (where you can scroll around), or reducing it further to not have such complicated transforms. It's possible we're actually still drawing the <use> content, but outside the visible region. I know we have some transformation bugs, possibly in <use> content too. 21426 4 4218 julien.palmas 2005-10-05 10:54:16 -0700 Created attachment 4218 same file, but line 2 and 3 have been inverted. Working now Actually, the <use> element works, but it needs to be written after the reference element declaration in the source code. Working example : <rect width="10" height="10" fill="blue" id="myrect"> <use x="20" y="30" xlink:href="#myrect"/> Wrong example : <use x="20" y="30" xlink:href="#myrect"/> <rect width="10" height="10" fill="blue" id="myrect"> 21429 5 rwlbuis 2005-10-05 12:35:01 -0700 First, a good bug find! I think the second example is not a <use> problem, but just indicating missing text support. Lets not make this all more complex than needed ;) I'll attach my current solution soon. Cheers, Rob. 21430 6 4221 rwlbuis 2005-10-05 12:36:06 -0700 Created attachment 4221 Handle <use> that forward references 21513 7 4229 rwlbuis 2005-10-06 00:30:29 -0700 Created attachment 4229 Handle forward references correctly A cleaned up version. 21527 8 4231 julien.palmas 2005-10-06 05:40:22 -0700 Created attachment 4231 Only one out of 2 <use> tags are rendered Patch 4229 solved the first reduced example, but this new example is still not rendered correctly. 21528 9 4232 julien.palmas 2005-10-06 05:41:34 -0700 Created attachment 4232 Expected result 21576 10 4229 eric 2005-10-08 02:08:40 -0700 Comment on attachment 4229 Handle forward references correctly Looks good. I made one small modification (moved the remove() out when doing the delayed close, and instead added a clear() after all the closes). I'll post my fixed patch and land. 21577 11 4253 eric 2005-10-08 02:10:03 -0700 Created attachment 4253 Final patch which I landed. 4212 2005-10-05 05:07:05 -0700 2005-10-05 05:07:05 -0700 Reduced example reducted.svg text/plain 355 julien.palmas PHN2ZyBpZD0ic3ZnMTI5MSIgaGVpZ2h0PSIxMDAiIHdpZHRoPSIxMDAiIHhtbG5zPSJodHRwOi8v d3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkv eGxpbmsiPgogICAgPHVzZSBoZWlnaHQ9IjIwMC4wMDAwMCIgaWQ9InVzZTM5MTgiIHRyYW5zZm9y bT0idHJhbnNsYXRlKC0zOS44NDM3NSwtMjAuMTU2MjUpIiB4bGluazpocmVmPSIjcGF0aDM4NzQi Lz4KICAgIDxwYXRoIGQ9Ik0gNTAgNTAgTCA1MCA4MCBMIDkwIDYwIEwgOTAgMzAgeiIgaWQ9InBh dGgzODc0IiBzdHlsZT0iZmlsbDojNGM0YzRjO3N0cm9rZTpibGFjaztzdHJva2Utd2lkdGg6MC4y NXB0Ii8+Cjwvc3ZnPg== 4218 2005-10-05 10:54:16 -0700 2005-10-05 10:54:16 -0700 same file, but line 2 and 3 have been inverted. Working now reduced.svg text/plain 355 julien.palmas PHN2ZyBpZD0ic3ZnMTI5MSIgaGVpZ2h0PSIxMDAiIHdpZHRoPSIxMDAiIHhtbG5zPSJodHRwOi8v d3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkv eGxpbmsiPgogICAgPHBhdGggZD0iTSA1MCA1MCBMIDUwIDgwIEwgOTAgNjAgTCA5MCAzMCB6IiBp ZD0icGF0aDM4NzQiIHN0eWxlPSJmaWxsOiM0YzRjNGM7c3Ryb2tlOmJsYWNrO3N0cm9rZS13aWR0 aDowLjI1cHQiLz4KICAgIDx1c2UgaGVpZ2h0PSIyMDAuMDAwMDAiIGlkPSJ1c2UzOTE4IiB0cmFu c2Zvcm09InRyYW5zbGF0ZSgtMzkuODQzNzUsLTIwLjE1NjI1KSIgeGxpbms6aHJlZj0iI3BhdGgz ODc0Ii8+Cjwvc3ZnPg== 4221 2005-10-05 12:36:06 -0700 2005-10-06 00:30:29 -0700 Handle <use> that forward references forward-reference-use-fix.diff text/plain 2699 rwlbuis SW5kZXg6IHN2Zy9TVkdEb2N1bWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN2Zy9TVkdEb2N1 bWVudEltcGwuY3BwCShyZXZpc2lvbiA0NjY0OTkpCisrKyBzdmcvU1ZHRG9jdW1lbnRJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODE1LDYgKzgxNSwxNyBAQAogICAgIGlmKGNhbnZhcygpICYm IG5lZWRzU3R5bGVTZWxlY3RvclVwZGF0ZSkKICAgICAgICAgdXBkYXRlU3R5bGVTZWxlY3Rvcigp OwogCisgICAgLy8gY2xvc2UgYW55IHVuY2xvc2VkIG5vZGVzCisgICAgUTNQdHJMaXN0SXRlcmF0 b3I8U1ZHRWxlbWVudEltcGw+IGl0KG1fZm9yd2FyZFJlZmVyZW5jZXMpOworICAgIGZvcig7aXQu Y3VycmVudCgpOyArK2l0KQorICAgIHsKKyAgICAgICAgaWYoIWl0LmN1cnJlbnQoKS0+Y2xvc2Vk KCkpCisgICAgICAgIHsKKyAgICAgICAgICAgIGtkRGVidWcoKSA8PCAiTm9kZSAiIDw8IGl0LmN1 cnJlbnQoKS0+bm9kZU5hbWUoKS0+c3RyaW5nKCkgPDwgIiB3YXMgbm90IGNsb3NlZCEhIiA8PCBl bmRsOworICAgICAgICAgICAgaXQuY3VycmVudCgpLT5jbG9zZSgpOworICAgICAgICB9CisgICAg fQorCiAgICAgLy8gU3RhcnQgYW5pbWF0aW9ucywgYXMgImxvYWQiIHNjcmlwdHMgYXJlIGV4ZWN1 dGVkLgogICAgIG1fdGltZVNjaGVkdWxlci0+c3RhcnRBbmltYXRpb25zKCk7CiB9CkBAIC0xMDIy LDQgKzEwMzMsOSBAQAogICAgIGV2ZW50VHlwZS0+ZGVyZWYoKTsKIH0KIAordm9pZCBTVkdEb2N1 bWVudEltcGw6OmFkZEZvcndhcmRSZWZlcmVuY2UoY29uc3QgU1ZHRWxlbWVudEltcGwgKmVsZW1l bnQpCit7CisgICAgbV9mb3J3YXJkUmVmZXJlbmNlcy5hcHBlbmQoZWxlbWVudCk7Cit9CisKIC8v IHZpbTp0cz00Om5vZXQKSW5kZXg6IHN2Zy9TVkdEb2N1bWVudEltcGwuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBzdmcvU1ZHRG9jdW1lbnRJbXBsLmgJKHJldmlzaW9uIDQ2NjQ5OSkKKysrIHN2Zy9TVkdEb2N1 bWVudEltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtOTYsNiArOTYsOCBAQAogICAgICAgICB2aXJ0 dWFsIHZvaWQgcmVjYWxjU3R5bGVTZWxlY3RvcigpOwogICAgICAgICB2aXJ0dWFsIHZvaWQgcmVj YWxjU3R5bGUoU3R5bGVDaGFuZ2UgPSBOb0NoYW5nZSk7CiAKKyAgICAgICAgdm9pZCBhZGRGb3J3 YXJkUmVmZXJlbmNlKGNvbnN0IFNWR0VsZW1lbnRJbXBsICplbGVtZW50KTsKKwogICAgIHByb3Rl Y3RlZDoKICAgICAgICAgdmlydHVhbCBLRE9NOjpDU1NTdHlsZVNlbGVjdG9yICpjcmVhdGVTdHls ZVNlbGVjdG9yKGNvbnN0IFFTdHJpbmcgJik7CiAKQEAgLTExNyw2ICsxMTksNyBAQAogICAgICAg ICBLRE9NOjpDYWNoZWRTY3JpcHQgKm1fY2FjaGVkU2NyaXB0OwogICAgICAgICBRM1B0ckxpc3Q8 U1ZHU2NyaXB0RWxlbWVudEltcGw+IG1fc2NyaXB0czsKICAgICAgICAgUTNQdHJMaXN0SXRlcmF0 b3I8U1ZHU2NyaXB0RWxlbWVudEltcGw+ICptX3NjcmlwdHNJdDsKKyAgICAgICAgUTNQdHJMaXN0 PFNWR0VsZW1lbnRJbXBsPiBtX2ZvcndhcmRSZWZlcmVuY2VzOwogICAgIH07CiB9OwogCkluZGV4 OiBzdmcvU1ZHVXNlRWxlbWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN2Zy9TVkdVc2VFbGVt ZW50SW1wbC5jcHAJKHJldmlzaW9uIDQ2NjQ5OSkKKysrIHN2Zy9TVkdVc2VFbGVtZW50SW1wbC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNywxNCArMTI3LDE3IEBACiAgICAgUVN0cmluZyB0YXJn ZXRJZCA9IFNWR1VSSVJlZmVyZW5jZUltcGw6OmdldFRhcmdldChyZWYpOwogICAgIFNWR0VsZW1l bnRJbXBsICp0YXJnZXQgPSBkeW5hbWljX2Nhc3Q8U1ZHRWxlbWVudEltcGwgKj4ob3duZXJEb2N1 bWVudCgpLT5nZXRFbGVtZW50QnlJZChuZXcgS0RPTTo6RE9NU3RyaW5nSW1wbCh0YXJnZXRJZCkp KTsKICAgICBpZighdGFyZ2V0KQorICAgIHsKKyAgICAgICAgZ2V0RG9jdW1lbnQoKS0+YWRkRm9y d2FyZFJlZmVyZW5jZSh0aGlzKTsKICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIGZsb2F0 IF94ID0geCgpLT5iYXNlVmFsKCktPnZhbHVlKCksIF95ID0geSgpLT5iYXNlVmFsKCktPnZhbHVl KCk7CiAgICAgZmxvYXQgX3cgPSB3aWR0aCgpLT5iYXNlVmFsKCktPnZhbHVlKCksIF9oID0gaGVp Z2h0KCktPmJhc2VWYWwoKS0+dmFsdWUoKTsKLSAgICAKKwogICAgIFFTdHJpbmcgdyA9IFFTdHJp bmc6Om51bWJlcihfdyk7CiAgICAgUVN0cmluZyBoID0gUVN0cmluZzo6bnVtYmVyKF9oKTsKLSAg ICAKKwogICAgIFFTdHJpbmcgdHJhbnMgPSBRU3RyaW5nOjpmcm9tTGF0aW4xKCJ0cmFuc2xhdGUo JTEsICUyKSIpLmFyZyhfeCkuYXJnKF95KTsgICAgCiAgICAgaWYodGFyZ2V0LT5pZCgpID09IElE X1NZTUJPTCkKICAgICB7CkBAIC0xNzcsNiArMTgwLDggQEAKICAgICAgICAgYXBwZW5kQ2hpbGQo ZHVtbXkpOwogICAgICAgICBkdW1teS0+YXBwZW5kQ2hpbGQocm9vdCk7CiAgICAgfQorCisgICAg U1ZHRWxlbWVudEltcGw6OmNsb3NlKCk7CiB9CiAKIGJvb2wgU1ZHVXNlRWxlbWVudEltcGw6Omhh c0NoaWxkTm9kZXMoKSBjb25zdAo= 4229 2005-10-06 00:30:29 -0700 2005-10-08 02:10:03 -0700 Handle forward references correctly forward-reference-use-fix.diff text/plain 1411 rwlbuis SW5kZXg6IGtzdmcyL3N2Zy9TVkdEb2N1bWVudEltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvU1ZHU3VwcG9ydC9rc3ZnMi9zdmcvU1ZHRG9jdW1lbnRJbXBsLmgsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNwpkaWZmIC1yMS43IFNWR0RvY3VtZW50SW1wbC5oCjk5YTEwMCwxMDEK PiAgICAgICAgIHZvaWQgYWRkRm9yd2FyZFJlZmVyZW5jZShjb25zdCBTVkdFbGVtZW50SW1wbCAq ZWxlbWVudCk7Cj4gCjEyMGExMjMKPiAgICAgICAgIFEzUHRyTGlzdDxTVkdFbGVtZW50SW1wbD4g bV9mb3J3YXJkUmVmZXJlbmNlczsKSW5kZXg6IGtzdmcyL3N2Zy9TVkdEb2N1bWVudEltcGwuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9TVkdTdXBwb3J0L2tzdmcyL3N2Zy9TVkdE b2N1bWVudEltcGwuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEwCmRpZmYgLXIxLjEwIFNW R0RvY3VtZW50SW1wbC5jcHAKODIwYTgyMSw4MzEKPiAgICAgLy8gY2xvc2UgYW55IHVuY2xvc2Vk IG5vZGVzCj4gICAgIFEzUHRyTGlzdEl0ZXJhdG9yPFNWR0VsZW1lbnRJbXBsPiBpdChtX2Zvcndh cmRSZWZlcmVuY2VzKTsKPiAgICAgZm9yKDtpdC5jdXJyZW50KCk7ICsraXQpCj4gICAgIHsKPiAg ICAgICAgIGlmKCFpdC5jdXJyZW50KCktPmNsb3NlZCgpKQo+ICAgICAgICAgewo+ICAgICAgICAg ICAgIGl0LmN1cnJlbnQoKS0+Y2xvc2UoKTsKPiAgICAgICAgICAgICBtX2ZvcndhcmRSZWZlcmVu Y2VzLnJlbW92ZShpdC5jdXJyZW50KCkpOwo+ICAgICAgICAgfQo+ICAgICB9Cj4gCjEwMjdhMTAz OSwxMDQzCj4gdm9pZCBTVkdEb2N1bWVudEltcGw6OmFkZEZvcndhcmRSZWZlcmVuY2UoY29uc3Qg U1ZHRWxlbWVudEltcGwgKmVsZW1lbnQpCj4gewo+ICAgICBtX2ZvcndhcmRSZWZlcmVuY2VzLmFw cGVuZChlbGVtZW50KTsKPiB9Cj4gCkluZGV4OiBrc3ZnMi9zdmcvU1ZHVXNlRWxlbWVudEltcGwu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9TVkdTdXBwb3J0L2tzdmcyL3N2Zy9T VkdVc2VFbGVtZW50SW1wbC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNwpkaWZmIC1yMS43 IFNWR1VzZUVsZW1lbnRJbXBsLmNwcAoxMzFhMTMyLDEzMwo+ICAgICB7Cj4gICAgICAgICBnZXRE b2N1bWVudCgpLT5hZGRGb3J3YXJkUmVmZXJlbmNlKHRoaXMpOwoxMzJhMTM1Cj4gICAgIH0KMTgx YTE4NSwxODYKPiAKPiAgICAgU1ZHRWxlbWVudEltcGw6OmNsb3NlKCk7Cg== 4231 2005-10-06 05:40:22 -0700 2005-10-08 01:56:35 -0700 Only one out of 2 <use> tags are rendered reduced.svg image/svg+xml 1899 julien.palmas PHN2ZyBpZD0ic3ZnMTI5MSIgaGVpZ2h0PSIyMDBweCIgd2lkdGg9IjIwMHB4IiB4bWxucz0iaHR0 cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8x OTk5L3hsaW5rIj4KICAgIDx1c2UgaGVpZ2h0PSIyMDAiIGlkPSJ1c2UzOTE4IiB0cmFuc2Zvcm09 InRyYW5zbGF0ZSgtMzkuODQzNzUsLTIwLjE1NjI1KSIgeGxpbms6aHJlZj0iI3BhdGgzODc0Ii8+ CiAgICA8dXNlIGhlaWdodD0iMjAwIiBpZD0idXNlMzk1OSIgdHJhbnNmb3JtPSJ0cmFuc2xhdGUo LTM3LjM0Mzc1LC0xOC41OTM3NSkiIHhsaW5rOmhyZWY9IiNwYXRoMzg3NCIvPgogICAgPHVzZSBo ZWlnaHQ9IjIwMCIgaWQ9InVzZTM5MjAiIHRyYW5zZm9ybT0idHJhbnNsYXRlKC0zNC44NDM3NSwt MTcuNjU2MjUpIiB4bGluazpocmVmPSIjcGF0aDM4NzQiLz4KICAgIDx1c2UgaGVpZ2h0PSIyMDAi IGlkPSJ1c2UzOTU3IiB0cmFuc2Zvcm09InRyYW5zbGF0ZSgtMzIuMzQzNzUsLTE2LjA5Mzc1KSIg eGxpbms6aHJlZj0iI3BhdGgzODc0Ii8+CiAgICA8dXNlIGhlaWdodD0iMjAwIiBpZD0idXNlMzky MiIgdHJhbnNmb3JtPSJ0cmFuc2xhdGUoLTMwLjE1NjI1LC0xNS4xNTYyNSkiIHhsaW5rOmhyZWY9 IiNwYXRoMzg3NCIvPgogICAgPHVzZSBoZWlnaHQ9IjIwMCIgaWQ9InVzZTM5NTUiIHRyYW5zZm9y bT0idHJhbnNsYXRlKC0yNy4zNDM3NSwtMTMuNTkzNzUpIiB4bGluazpocmVmPSIjcGF0aDM4NzQi Lz4KICAgIDx1c2UgaGVpZ2h0PSIyMDAiIGlkPSJ1c2UzOTI0IiB0cmFuc2Zvcm09InRyYW5zbGF0 ZSgtMjUuMTU2MjUsLTEyLjY1NjI1KSIgeGxpbms6aHJlZj0iI3BhdGgzODc0Ii8+CiAgICA8dXNl IGhlaWdodD0iMjAwIiBpZD0idXNlMzk1MyIgdHJhbnNmb3JtPSJ0cmFuc2xhdGUoLTIyLjM0Mzc1 LC0xMS40MDYyNSkiIHhsaW5rOmhyZWY9IiNwYXRoMzg3NCIvPgogICAgPHVzZSBoZWlnaHQ9IjIw MCIgaWQ9InVzZTM5MjYiIHRyYW5zZm9ybT0idHJhbnNsYXRlKC0xOS44NDM3NSwtMTAuMTU2MjUp IiB4bGluazpocmVmPSIjcGF0aDM4NzQiLz4KICAgIDx1c2UgaGVpZ2h0PSIyMDAiIGlkPSJ1c2Uz OTUxIiB0cmFuc2Zvcm09InRyYW5zbGF0ZSgtMTcuMzQzNzUsLTguOTA2MjUwKSIgeGxpbms6aHJl Zj0iI3BhdGgzODc0Ii8+CiAgICA8dXNlIGhlaWdodD0iMjAwIiBpZD0idXNlMzkyOCIgdHJhbnNm b3JtPSJ0cmFuc2xhdGUoLTE0Ljg0Mzc1LC03LjY1NjI1MCkiIHhsaW5rOmhyZWY9IiNwYXRoMzg3 NCIvPgogICAgPHVzZSBoZWlnaHQ9IjIwMCIgaWQ9InVzZTM5NDkiIHRyYW5zZm9ybT0idHJhbnNs YXRlKC0xMi42NTYyNSwtNi40MDYyNTApIiB4bGluazpocmVmPSIjcGF0aDM4NzQiLz4KICAgIDx1 c2UgaGVpZ2h0PSIyMDAiIGlkPSJ1c2UzOTMwIiB0cmFuc2Zvcm09InRyYW5zbGF0ZSgtOS44NDM3 NTAsLTUuMTU2MjUwKSIgeGxpbms6aHJlZj0iI3BhdGgzODc0Ii8+CiAgICA8dXNlIGhlaWdodD0i MjAwIiBpZD0idXNlMzk0NyIgdHJhbnNmb3JtPSJ0cmFuc2xhdGUoLTcuNjU2MjUwLC0zLjkwNjI1 MCkiIHhsaW5rOmhyZWY9IiNwYXRoMzg3NCIvPgogICAgPHVzZSBoZWlnaHQ9IjIwMCIgaWQ9InVz ZTM5MzIiIHRyYW5zZm9ybT0idHJhbnNsYXRlKC01LjE1NjI1MCwtMi42NTYyNTApIiB4bGluazpo cmVmPSIjcGF0aDM4NzQiLz4KICAgIDx1c2UgaGVpZ2h0PSIyMDAiIGlkPSJ1c2UzOTQ1IiB0cmFu c2Zvcm09InRyYW5zbGF0ZSgtMi42NTYyNTAsLTEuNDA2MjUwKSIgeGxpbms6aHJlZj0iI3BhdGgz ODc0Ii8+CiAgICA8cGF0aCBkPSJNIDUwIDUwIEwgNTAgODAgTCA5MCA2MCBMIDkwIDMwIHoiIGlk PSJwYXRoMzg3NCIgc3R5bGU9ImZpbGw6IzRjNGM0YztzdHJva2U6YmxhY2s7c3Ryb2tlLXdpZHRo OjAuMjVwdCIvPgo8L3N2Zz4K 4232 2005-10-06 05:41:34 -0700 2005-10-06 05:41:34 -0700 Expected result expected.png image/png 2639 julien.palmas iVBORw0KGgoAAAANSUhEUgAAAGsAAABcCAIAAADmotxOAAACFGlDQ1BJQ0MgUHJvZmlsZQAAeJyV ksFrE0EUh7/daCtSQgOxRUEcBLFKKqFBEL0kpioGlZBGSKKX7WabrOxupruTarRgTx48evPgRXvw Ioh40OKhN4voQapSwT9AxFtFClLXwzbkIKH6YOB7P2Z4837vQeyDIaWjA66n/NK506JSrYnBj+xG BxKMGmYgc8XiBfrGz09oAKvjhpRO4cq34VmxtHr3SWGtfOfAkf7vAIj7lWoNtBSQbEScBZLTEZeB 5HUlFWhNIGk2jTpo80DKL5fyoD0G4o2IXwDx6YhXgPic2VCgrQFpr257oO8CTtStwAQ9C7TqgemC /hR467qtOsTmgTFT+gpii8B4pVoT0ZfVAJxyIPayp139Ac9WYN/tnnboCyS+wvPvPW19BA3QRt4E M5kJALQhH3ZuhOH6fhhcgk0/DH89CMPNRYh9huVZs+3Pbfmlae9guzzqOcrhvepSP458ASANj5ah vACFLNxfgMOjkLgFRaCcRc9kuifyEIA9OSkdS+Rtz3INMWkH0jE628z+v8N12t16O4AhKzgzBZwE spZ3eQoYA27O+GdLwFHg4TWjUOzqFDHwUBg4OBgIckgkDhaCPDYeFi4GgklsAiQOBp1/vneRFh42 Cos2fv8K0Z4BDAzDvb36b+31q4OX/upZWTcUQL4lO77daCqx5XTLlW1l+Slx3jOPpcREOn0c4A+Y UquYu9xmMgAAB/ZJREFUeJztnE1o0+4fwJ+2adKmrW3t2+wmo4dVNoUJMnYQnVTB4VA8uenFt1Eo HmQy9aITxJOgoE4PgoiefMGDhx0miGNShldf2UA7ca9dt7ZpSZq1Sf6H759S5m9vTZqkNZ/TwrOm 3+dDmm+/z/dpdIIgIA0R6JUOoOrRDIpFMygWzaBYNINi0QyKRTMoFs2gWFRnUBCEX79+xeNxpQPZ KCoyKAhCLBa7c+dOX19fNBpVOpyNgikdAEIICYIwOTn55s2baDRK0zTHcYVCIRqNvn//fmBgQOno 1kFhgyvc4ThuMBhSqdTr169TqZTf74/FYi9fvty3b9/evXuVDXU1FDP4n+7S6TTDMGazOZvNchw3 OTl56dIliqKam5tzudzv37937NihVMCroZN/beZvdxzHZbNZhmFIkrRYLCzLZjIZDMNsNhuO49ls trOzc3Z2dn5+/tmzZ1++fGltbcUwVdx/kMwGN+sORrPZrNPpxHEcx/GmpqZv3749fvx4+/btsoW9 NjIZLM8djJIkSdM0TdPwnwRB3L59Ox6PqyTPVNygJO7MZrPVajUYDBzHMQwTDAZjsVhdXd2FCxde vHhx7do1l8tV0VmsQQUNSu5uxSjP83BJPnjwgOO4kZGRs2fPVmgua1ARg5V2VxzV6/XLy8vt7e1f v361Wq3Pnz+PxWJWq9Xr9Uo+qdWQ2KCc7hiGKZ7KaDSazeb29vaPHz+eOXPm+PHjiUTC4/FIOLXV kMyggu7gEMdxi8VSKBS6u7spivrx48eTJ08kmdraSGBQcXelh0tLS/ARrq+vv379ugz1jCiDqnK3 4pDjOKfTSVFUJBJpaGhIpVKdnZ0SiitSpkE1uyseYhiWSCQCgUAymQyFQleuXKlEntm0wWpxl81m aZo2mUw2m43n+d27d7vdbsgzXV1dDMPY7Xa5DVaXu9JTpdPpLVu2GI3GfD5/5MiRmZkZv9/f398v n8HqdbdiNJPJbN26FcOwjo6OUCgkST2zvsFYLFYD7oqjOp0OLkme5wmCuHv37sLCgpg8s5bBQqHw 8OHDkZGRmnFXenPU6XQ0TTc3N//8+TMUCl29ehU+3VIanJqaCofDBoNBEASKomrA3X8eCoKwZ8+e xsbGV69e3bt3r6WlZVMG11mnJAiiUCgkEgkcx71eL8uyiUQCwzBYsOM4DlaVSZJ0u900TScSCbPZ 7PF4wN1qo6UTdjqdYCeZTG7ksNTO36daMVoq6+9Dg8GQy+XS6fTY2NinT5/y+fym3G3IICAIAhRM S0tLHo+nZtwtLS0hhOx2u8lkQghV0CDAcRxJkjiOsyybTCZrwJ3NZgN3Yiin27C4uAjLHv+4u/IN YhhW/E5AkqQgCP+mu/INAnq9XqfTIYSKeSabzf5T7gAJeoaQZzKZjCAIEDRN0/+CO0CyrivP8yaT CXYcwMoSjuM0TdewO0D6vjXLsi6XS6/XLyws6PX6GnYHSG8Qbo4sywqC4HK5CoVCPB6vSXdABfdO GI1GhFA8Hne5XARB1J47oOK7TzAMMxgMy8vLUM/Ukrv/T1CetynWM3Nzc8X5l6bsanQHyL0DSqfT 2e12nueLeaZ63QEKGEQleQb6k1XqDlBsFx7kmUQi4ff7DQYDRVFV5w5QeB8jQRCwdRXqmepyB6hi J2ixninNM+p3B6jCYBHIMwihhYUFpHp3gOoMIoQymQxCSJ6dV+JR0S9ySlH/pVdEpQarCM2gWDSD YtEMikUzKBbNoFjWNwg1lgyhVClrGcQwzGKxhMPhUCiEEOI4rrYfMZXL5cp41VoG6+rqBgcHu7u7 TSYTz/PBYNButwuCUN7+EjWTy+WsVuv58+c3u3ELrVvVORwOhFBra+v+/fu9Xm8kEvF6vT6fb2Zm psxgVUYul3O73ceOHevq6ipj8yDaYF18+PBhhBDDMOfOnTt06NDTp0+np6cLhQKMVulHW7w7YBMr C2azubu7GyGk0+laWloaGhqGhoZYlnU6nWW/vSJI5Q4oZ22mt7fXbDZ/+PAhFov19PSMjo6Ojo7y PC8yFBmQ1h1QjkFYwjtw4EBHR4fJZIpGozzP19fXJ5NJnuc5jpMkMmmphDug/PVBgiDgD8gzMzMz jx49ampqampqGh8fFwRBJVdl5dwBEqywQp6ZmJi4ceNGW1vb4ODg58+fXS4XRVHiTy6GSrsDJFuj DgaDwWAQIeT3+8Ph8M6dOwcGBiiKKtYzcqZsedwB0q/ynzp1CiE0NzdnsVh6enrGx8fHxsYYhtHr 5ajB5XQHVKpPAvWMw+G4deuWx+M5evTo8PAwx3GVyzPyuwMq2GmCeub06dMkSTIM8/bt223btkEv ied5CfOMUu6Aivfq4NE6xXqmv79/eno6EAjMzs4i0TdHZd0BMnU7i/VMIBDo7e31+XyXL1+mKAr2 fpSBGtwBcveL4SlFxTwzNDS0uLiYz+c33t5UjztAgSeXAalUyuFwnDx50ufz1dfXDw8PEwQRj8fr 6uqg426z2Va8BNyFQiGVuAMUMwiMj483Nja+e/fu/v37u3btmpqaYlk2nU7r9fpSg+p0ByhsEJiY mJifn29ra4tEItPT0z6f78+fP2BQze4AVRgscvPmzYMHD5Ik2dfXZzQaVe4OUJdB4Pv37xcvXjxx 4oTK3QFqNIgQKu8H+4qgUoNVhNZxF4tmUCyaQbFoBsWiGRSLZlAsmkGxaAbFohkUi2ZQLP8DSqh8 EipQYroAAAAASUVORK5CYII= 4253 2005-10-08 02:10:03 -0700 2005-10-08 02:10:03 -0700 Final patch which I landed. final.patch text/plain 2986 eric SW5kZXg6IHN2Zy9TVkdEb2N1bWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv cm9vdC9TVkdTdXBwb3J0L2tzdmcyL3N2Zy9TVkdEb2N1bWVudEltcGwuY3BwLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjEwCmRpZmYgLXAgLXUgLXIxLjEwIHN2Zy9TVkdEb2N1bWVudEltcGwuY3Bw Ci0tLSBzdmcvU1ZHRG9jdW1lbnRJbXBsLmNwcAk1IE9jdCAyMDA1IDA1OjM1OjE5IC0wMDAwCTEu MTAKKysrIHN2Zy9TVkdEb2N1bWVudEltcGwuY3BwCTggT2N0IDIwMDUgMDk6MTM6MDQgLTAwMDAK QEAgLTgxOCw2ICs4MTgsMTUgQEAgdm9pZCBTVkdEb2N1bWVudEltcGw6OmV4ZWN1dGVTY3JpcHRz KGJvbwogICAgIGlmKGNhbnZhcygpICYmIG5lZWRzU3R5bGVTZWxlY3RvclVwZGF0ZSkKICAgICAg ICAgdXBkYXRlU3R5bGVTZWxlY3RvcigpOwogCisgICAgLy8gY2xvc2UgYW55IHVuY2xvc2VkIG5v ZGVzCisgICAgUTNQdHJMaXN0SXRlcmF0b3I8U1ZHRWxlbWVudEltcGw+IGl0KG1fZm9yd2FyZFJl ZmVyZW5jZXMpOworICAgIGZvcig7aXQuY3VycmVudCgpOyArK2l0KQorICAgIHsKKyAgICAgICAg aWYoIWl0LmN1cnJlbnQoKS0+Y2xvc2VkKCkpCisgICAgICAgICAgICBpdC5jdXJyZW50KCktPmNs b3NlKCk7CisgICAgfQorICAgIG1fZm9yd2FyZFJlZmVyZW5jZXMuY2xlYXIoKTsKKwogICAgIC8v IFN0YXJ0IGFuaW1hdGlvbnMsIGFzICJsb2FkIiBzY3JpcHRzIGFyZSBleGVjdXRlZC4KICAgICBt X3RpbWVTY2hlZHVsZXItPnN0YXJ0QW5pbWF0aW9ucygpOwogfQpAQCAtMTAyNSw0ICsxMDM0LDkg QEAgdm9pZCBTVkdEb2N1bWVudEltcGw6OmRpc3BhdGNoTW91c2VFdmVudAogICAgIGV2ZW50VHlw ZS0+ZGVyZWYoKTsKIH0KIAordm9pZCBTVkdEb2N1bWVudEltcGw6OmFkZEZvcndhcmRSZWZlcmVu Y2UoY29uc3QgU1ZHRWxlbWVudEltcGwgKmVsZW1lbnQpCit7CisgICAgbV9mb3J3YXJkUmVmZXJl bmNlcy5hcHBlbmQoZWxlbWVudCk7Cit9CisKIC8vIHZpbTp0cz00Om5vZXQKSW5kZXg6IHN2Zy9T VkdEb2N1bWVudEltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvU1ZHU3VwcG9y dC9rc3ZnMi9zdmcvU1ZHRG9jdW1lbnRJbXBsLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNwpk aWZmIC1wIC11IC1yMS43IHN2Zy9TVkdEb2N1bWVudEltcGwuaAotLS0gc3ZnL1NWR0RvY3VtZW50 SW1wbC5oCTggU2VwIDIwMDUgMDg6MDM6MzUgLTAwMDAJMS43CisrKyBzdmcvU1ZHRG9jdW1lbnRJ bXBsLmgJOCBPY3QgMjAwNSAwOToxMzowNCAtMDAwMApAQCAtOTcsNiArOTcsOCBAQCBuYW1lc3Bh Y2UgS1NWRwogICAgICAgICB2aXJ0dWFsIHZvaWQgcmVjYWxjU3R5bGVTZWxlY3RvcigpOwogICAg ICAgICB2aXJ0dWFsIHZvaWQgcmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2UgPSBOb0NoYW5nZSk7CiAK KyAgICAgICAgdm9pZCBhZGRGb3J3YXJkUmVmZXJlbmNlKGNvbnN0IFNWR0VsZW1lbnRJbXBsICpl bGVtZW50KTsKKwogICAgIHByb3RlY3RlZDoKICAgICAgICAgdmlydHVhbCBLRE9NOjpDU1NTdHls ZVNlbGVjdG9yICpjcmVhdGVTdHlsZVNlbGVjdG9yKGNvbnN0IFFTdHJpbmcgJik7CiAKQEAgLTEx OCw2ICsxMjAsNyBAQCBuYW1lc3BhY2UgS1NWRwogICAgICAgICBLRE9NOjpDYWNoZWRTY3JpcHQg Km1fY2FjaGVkU2NyaXB0OwogICAgICAgICBRM1B0ckxpc3Q8U1ZHU2NyaXB0RWxlbWVudEltcGw+ IG1fc2NyaXB0czsKICAgICAgICAgUTNQdHJMaXN0SXRlcmF0b3I8U1ZHU2NyaXB0RWxlbWVudElt cGw+ICptX3NjcmlwdHNJdDsKKyAgICAgICAgUTNQdHJMaXN0PFNWR0VsZW1lbnRJbXBsPiBtX2Zv cndhcmRSZWZlcmVuY2VzOwogICAgIH07CiB9OwogCkluZGV4OiBzdmcvU1ZHVXNlRWxlbWVudElt cGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9TVkdTdXBwb3J0L2tzdmcyL3N2 Zy9TVkdVc2VFbGVtZW50SW1wbC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNwpkaWZmIC1w IC11IC1yMS43IHN2Zy9TVkdVc2VFbGVtZW50SW1wbC5jcHAKLS0tIHN2Zy9TVkdVc2VFbGVtZW50 SW1wbC5jcHAJNSBPY3QgMjAwNSAwNTozNTozMCAtMDAwMAkxLjcKKysrIHN2Zy9TVkdVc2VFbGVt ZW50SW1wbC5jcHAJOCBPY3QgMjAwNSAwOToxMzowNCAtMDAwMApAQCAtMTI5LDcgKzEyOSwxMCBA QCB2b2lkIFNWR1VzZUVsZW1lbnRJbXBsOjpjbG9zZSgpCiAgICAgS0RPTTo6RWxlbWVudEltcGwg KnRhcmdldEVsZW1lbnQgPSBvd25lckRvY3VtZW50KCktPmdldEVsZW1lbnRCeUlkKHRhcmdldElk LmhhbmRsZSgpKTsKICAgICBTVkdFbGVtZW50SW1wbCAqdGFyZ2V0ID0gc3ZnX2R5bmFtaWNfY2Fz dCh0YXJnZXRFbGVtZW50KTsKICAgICBpZiAoIXRhcmdldCkKKyAgICB7CisgICAgICAgIGdldERv Y3VtZW50KCktPmFkZEZvcndhcmRSZWZlcmVuY2UodGhpcyk7CiAgICAgICAgIHJldHVybjsKKyAg ICB9CiAKICAgICBmbG9hdCBfeCA9IHgoKS0+YmFzZVZhbCgpLT52YWx1ZSgpLCBfeSA9IHkoKS0+ YmFzZVZhbCgpLT52YWx1ZSgpOwogICAgIGZsb2F0IF93ID0gd2lkdGgoKS0+YmFzZVZhbCgpLT52 YWx1ZSgpLCBfaCA9IGhlaWdodCgpLT5iYXNlVmFsKCktPnZhbHVlKCk7CkBAIC0xNzksNiArMTgy LDggQEAgdm9pZCBTVkdVc2VFbGVtZW50SW1wbDo6Y2xvc2UoKQogICAgICAgICBhcHBlbmRDaGls ZChkdW1teSk7CiAgICAgICAgIGR1bW15LT5hcHBlbmRDaGlsZChyb290KTsKICAgICB9CisKKyAg ICBTVkdFbGVtZW50SW1wbDo6Y2xvc2UoKTsKIH0KIAogYm9vbCBTVkdVc2VFbGVtZW50SW1wbDo6 aGFzQ2hpbGROb2RlcygpIGNvbnN0Cg==