5239 2005-10-02 19:58:20 -0700 Viewing a particular SVG image causes Safari+SVG to stop responding. 2005-10-03 01:52:45 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED http://upload.wikimedia.org/wikipedia/en/0/01/Eye.svg P2 Normal --- 1 tjrichard eric oldest_to_newest 21203 0 tjrichard 2005-10-02 19:58:20 -0700 Attempting to open http://upload.wikimedia.org/wikipedia/en/0/01/Eye.svg (linked to from http://en.wikipedia.org/wiki/Image:Eye.svg) causes Safari+SVG (latest build from 2005-09-03) to stop responding. 21233 1 eric 2005-10-02 23:34:46 -0700 Wow, thanks for the bug! It looks like SVGPathParser::parseSVG( const QString &s, bool process ) is just not robust enough. This particular SVG has a non-ascii character right in the middle of a pata data attribute string, and it's causing parseSVG to just loop forever. I'll talk this one out with the KSVG2 guys and see if we can't come up with a fix. 21243 2 rwlbuis 2005-10-03 00:26:58 -0700 (In reply to comment #0) > Attempting to open http://upload.wikimedia.org/wikipedia/en/0/01/Eye.svg (linked > to from http://en.wikipedia.org/wiki/Image:Eye.svg) causes Safari+SVG (latest > build from 2005-09-03) to stop responding. Good catch! I'll attach a patch that seems to work. I am checking whether just skipping the invalid char is according to svg... Cheers, Rob. 21244 3 4169 rwlbuis 2005-10-03 00:28:25 -0700 Created attachment 4169 Stop da loop 21252 4 4174 rwlbuis 2005-10-03 01:08:56 -0700 Created attachment 4174 stop da loop II 21254 5 4174 eric 2005-10-03 01:10:53 -0700 Comment on attachment 4174 stop da loop II Looks fine. r=me 21255 6 4175 rwlbuis 2005-10-03 01:24:46 -0700 Created attachment 4175 More informative error reporting 21259 7 eric 2005-10-03 01:52:45 -0700 Thanks for the great bug! 4169 2005-10-03 00:28:25 -0700 2005-10-03 00:28:25 -0700 Stop da loop path-loop.diff text/plain 514 rwlbuis SW5kZXg6IHN2Zy9zdmdwYXRocGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzdmcvc3ZncGF0aHBh cnNlci5jcHAJKHJldmlzaW9uIDQ2NjQ5OSkKKysrIHN2Zy9zdmdwYXRocGFyc2VyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzg5LDYgKzM4OSwxMSBAQAogICAgICAgICAgICAgICAgICAgICBlbHNl CiAgICAgICAgICAgICAgICAgICAgICAgICBzdmdBcmNUbyggdG94LCB0b3ksIHJ4LCByeSwgYW5n bGUsIGxhcmdlQXJjLCBzd2VlcCwgIXJlbGF0aXZlICk7CiAgICAgICAgICAgICAgICAgfQorICAg ICAgICAgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAg ICAgICBwdHIrKzsKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAg ICAgfQogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBsYXN0Q29tbWFuZCA9IGNvbW1hbmQ7 Cg== 4174 2005-10-03 01:08:56 -0700 2005-10-03 01:10:53 -0700 stop da loop II path-loop.diff text/plain 583 rwlbuis SW5kZXg6IHN2Zy9zdmdwYXRocGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzdmcvc3ZncGF0aHBh cnNlci5jcHAJKHJldmlzaW9uIDQ2NjQ5OSkKKysrIHN2Zy9zdmdwYXRocGFyc2VyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzg5LDYgKzM4OSwxMSBAQAogICAgICAgICAgICAgICAgICAgICBlbHNl CiAgICAgICAgICAgICAgICAgICAgICAgICBzdmdBcmNUbyggdG94LCB0b3ksIHJ4LCByeSwgYW5n bGUsIGxhcmdlQXJjLCBzd2VlcCwgIXJlbGF0aXZlICk7CiAgICAgICAgICAgICAgICAgfQorICAg ICAgICAgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAg ICAgICBmcHJpbnRmKHN0ZGVyciwgIkVSUk9SOiBVbmtub3duIHBhdGggY29tbWFuZDogJWMgKGE6 ICVkKSIsIGNvbW1hbmQsIGNvbW1hbmQpOworICAgICAgICAgICAgICAgICAgICByZXR1cm47Cisg ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBsYXN0Q29tbWFu ZCA9IGNvbW1hbmQ7Cg== 4175 2005-10-03 01:24:46 -0700 2005-10-03 01:24:46 -0700 More informative error reporting path-loop.diff text/plain 704 rwlbuis SW5kZXg6IHN2Zy9zdmdwYXRocGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzdmcvc3ZncGF0aHBh cnNlci5jcHAJKHJldmlzaW9uIDQ2NjQ5OSkKKysrIHN2Zy9zdmdwYXRocGFyc2VyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzg5LDYgKzM4OSwxMiBAQAogICAgICAgICAgICAgICAgICAgICBlbHNl CiAgICAgICAgICAgICAgICAgICAgICAgICBzdmdBcmNUbyggdG94LCB0b3ksIHJ4LCByeSwgYW5n bGUsIGxhcmdlQXJjLCBzd2VlcCwgIXJlbGF0aXZlICk7CiAgICAgICAgICAgICAgICAgfQorICAg ICAgICAgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAg ICAgICBmcHJpbnRmKHN0ZGVyciwgIkVSUk9SOiBVbmtub3duIHBhdGggY29tbWFuZDogJWMgKGE6 ICVkKVxuIiwgY29tbWFuZCwgY29tbWFuZCk7CisgICAgICAgICAgICAgICAgICAgIGZwcmludGYo c3RkZXJyLCAiRVJST1I6IFBhdGggRGF0YSBwYXJzaW5nIHN0b3BwZWQgYXQgY2hhcmFjdGVyIHBv c2l0aW9uICVkXG4iLCBwdHIgLSBkLmxhdGluMSgpKTsKKyAgICAgICAgICAgICAgICAgICAgcmV0 dXJuOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgbGFz dENvbW1hbmQgPSBjb21tYW5kOwo=