52379 2011-01-13 10:48:55 -0800 [chromium] Crash in tiled compositor memcpy 2011-07-06 13:14:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 enne enne abarth commit-queue darin enne eric jamesr kbr vangelis webkit.review.bot oldest_to_newest 333796 0 enne 2011-01-13 10:48:55 -0800 [chromium] Crash in tiled compositor memcpy 333813 1 78829 enne 2011-01-13 11:12:46 -0800 Created attachment 78829 Patch 333819 2 enne 2011-01-13 11:14:35 -0800 This relates to http://code.google.com/p/chromium/issues/detail?id=69458. The crash is in the read of the memcpy, but after rereading the code, it's not clear to me where this might be failing. I suspect that maybe it's the intersect call that's resulting in an empty rect (which resets the position to 0,0), causing a negative coordinate somewhere, which is causing a failed memory read. 333857 3 78829 kbr 2011-01-13 12:04:04 -0800 Comment on attachment 78829 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78829&action=review OK, let's see whether this fixes it. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Need to get rid of this OOPS. 333894 4 enne 2011-01-13 12:51:55 -0800 Committed r75733: <http://trac.webkit.org/changeset/75733> 341119 5 enne 2011-01-27 16:23:52 -0800 This fix did not address the bug. Reopening. 341146 6 80381 enne 2011-01-27 17:10:08 -0800 Created attachment 80381 Patch 341148 7 enne 2011-01-27 17:12:40 -0800 (In reply to comment #6) > Created an attachment (id=80381) [details] > Patch I opened up a number of crash dumps to try to see what was going on, but they were internally inconsistent in a way that made me not trust their values and so were not that helpful. So, this is an attempt to get more information about what's going wrong and the CRASH values can be reverted later. 341227 8 vangelis 2011-01-27 18:27:46 -0800 Looks fine. Hopefully we'll get some useful info from it. 341229 9 80381 kbr 2011-01-27 18:31:08 -0800 Comment on attachment 80381 Patch rs=me 341283 10 80381 commit-queue 2011-01-27 20:26:09 -0800 Comment on attachment 80381 Patch Clearing flags on attachment: 80381 Committed r76914: <http://trac.webkit.org/changeset/76914> 341284 11 commit-queue 2011-01-27 20:26:12 -0800 All reviewed patches have been landed. Closing bug. 341316 12 webkit.review.bot 2011-01-27 22:01:41 -0800 http://trac.webkit.org/changeset/76914 might have broken Leopard Intel Release (Tests) 341565 13 enne 2011-01-28 11:30:44 -0800 I didn't mean for this to get closed, since the last patch was just diagnostic. (Thanks for the quick review and cq+, kbr.) 341595 14 80473 enne 2011-01-28 11:57:58 -0800 Created attachment 80473 Patch 341604 15 enne 2011-01-28 12:02:02 -0800 (In reply to comment #14) > Created an attachment (id=80473) [details] > Patch I got a report from Mike Reed that one of these CRASH calls got triggered, but it looked like there was somehow an empty intersection between the tile and the invalid rect. However, from code inspection, this would not cause any trouble because the tile wouldn't be dirty. And, even if somehow the dirty rect was not contained by the tile rect, there's another intersection later in the file that should prevent this from being a problem when uploading the texture. Offhand, is it reasonable to upload a series of patches to the same bug, or do I need to open different bugs for each of these patches? 341612 16 80473 kbr 2011-01-28 12:08:42 -0800 Comment on attachment 80473 Patch Looks fine. 341618 17 kbr 2011-01-28 12:14:09 -0800 (In reply to comment #15) > (In reply to comment #14) > > Created an attachment (id=80473) [details] [details] > > Patch > > I got a report from Mike Reed that one of these CRASH calls got triggered, but it looked like there was somehow an empty intersection between the tile and the invalid rect. However, from code inspection, this would not cause any trouble because the tile wouldn't be dirty. And, even if somehow the dirty rect was not contained by the tile rect, there's another intersection later in the file that should prevent this from being a problem when uploading the texture. > > Offhand, is it reasonable to upload a series of patches to the same bug, or do I need to open different bugs for each of these patches? I think it's reasonable to apply multiple patches from this bug. I've seen it done before on other bugs, and will make it easier to find them all later. 341710 18 enne 2011-01-28 13:55:58 -0800 Committed r76984: <http://trac.webkit.org/changeset/76984> 431615 19 darin 2011-07-02 11:44:13 -0700 Despite the fact that others have done it, it’s not good practice to use multiple patches in the same bug report. There are other ways to tie the bug reports and patches together, and the automation tools get confused. For example, in part due to the multiple patches at the moment it is unclear if this bug should be open or closed; it’s showing up in the “reviewed but possibly not landed” query. 432966 20 enne 2011-07-06 13:14:07 -0700 (In reply to comment #19) > Despite the fact that others have done it, it’s not good practice to use multiple patches in the same bug report. There are other ways to tie the bug reports and patches together, and the automation tools get confused. > > For example, in part due to the multiple patches at the moment it is unclear if this bug should be open or closed; it’s showing up in the “reviewed but possibly not landed” query. I'll keep in mind next time that it's not good practice. Thanks for the information. I don't know why this didn't get re-marked as closed when I landed the second patch. I'll just mark this as closed now. 78829 2011-01-13 11:12:46 -0800 2011-01-27 17:10:06 -0800 Patch bug-52379-20110113111245.patch text/plain 2082 enne ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OWE3MjM1ZWI4ZGVhYmIzNjQzNzExYzE2ZmYyZjY2NDIyNmJjM2E1Li4y MDA5YTI0MjFmYTE4NWEzMDJmMmU4ZTZlODQxOTc2MjYwNDU2ZTMwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDEtMTMgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIEF0dGVtcHQgdG8gZml4IGNyYXNoIGluIHRpbGVkIGNvbXBvc2l0b3IgbWVtY3B5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjM3OQorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okxh eWVyVGlsZXJDaHJvbWl1bTo6dXBkYXRlKToKKwogMjAxMS0wMS0xMiAgRGltaXRyaSBHbGF6a292 ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHAKaW5kZXggMzE2NDlhNDY5ZTFhODI5 NjIzMWY5MDdhNzIyNGE0YzQ4ZjVmNGZjYy4uYjRiNGE3MmRhYjk0YzM5YTcyMGUzYTkzZTExNDM5 MzFkM2M1MjNmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwCkBAIC0zMTUsMTIg KzMxNSwxOCBAQCB2b2lkIExheWVyVGlsZXJDaHJvbWl1bTo6dXBkYXRlKFRpbGVQYWludEludGVy ZmFjZSYgcGFpbnRlciwgY29uc3QgSW50UmVjdCYgY29udAogICAgICAgICAgICAgSW50UmVjdCBz b3VyY2VSZWN0ID0gdGlsZUNvbnRlbnRSZWN0KGksIGopOwogICAgICAgICAgICAgY29uc3QgSW50 UG9pbnQgYW5jaG9yID0gc291cmNlUmVjdC5sb2NhdGlvbigpOwogICAgICAgICAgICAgc291cmNl UmVjdC5pbnRlcnNlY3QobGF5ZXJSZWN0VG9Db250ZW50UmVjdCh0aWxlLT5tX2RpcnR5TGF5ZXJS ZWN0KSk7CisgICAgICAgICAgICBpZiAoc291cmNlUmVjdC5pc0VtcHR5KCkpCisgICAgICAgICAg ICAgICAgY29udGludWU7CiAKICAgICAgICAgICAgIC8vIENhbGN1bGF0ZSB0aWxlLXNwYWNlIHJl Y3RhbmdsZSB0byB1cGxvYWQgaW50by4KICAgICAgICAgICAgIEludFJlY3QgZGVzdFJlY3QoSW50 UG9pbnQoc291cmNlUmVjdC54KCkgLSBhbmNob3IueCgpLCBzb3VyY2VSZWN0LnkoKSAtIGFuY2hv ci55KCkpLCBzb3VyY2VSZWN0LnNpemUoKSk7CisgICAgICAgICAgICBBU1NFUlQoZGVzdFJlY3Qu eCgpID49IDApOworICAgICAgICAgICAgQVNTRVJUKGRlc3RSZWN0LnkoKSA+PSAwKTsKIAogICAg ICAgICAgICAgLy8gT2Zmc2V0IGZyb20gcGFpbnQgcmVjdGFuZ2xlIHRvIHRoaXMgdGlsZSdzIGRp cnR5IHJlY3RhbmdsZS4KICAgICAgICAgICAgIEludFBvaW50IHBhaW50T2Zmc2V0KHNvdXJjZVJl Y3QueCgpIC0gcGFpbnRSZWN0LngoKSwgc291cmNlUmVjdC55KCkgLSBwYWludFJlY3QueSgpKTsK KyAgICAgICAgICAgIEFTU0VSVChwYWludE9mZnNldC54KCkgPj0gMCk7CisgICAgICAgICAgICBB U1NFUlQocGFpbnRPZmZzZXQueSgpID49IDApOwogCiAgICAgICAgICAgICB1aW50OF90KiBwaXhl bFNvdXJjZTsKICAgICAgICAgICAgIGlmIChwYWludFJlY3Qud2lkdGgoKSA9PSBzb3VyY2VSZWN0 LndpZHRoKCkgJiYgIXBhaW50T2Zmc2V0LngoKSkK 80381 2011-01-27 17:10:08 -0800 2011-01-28 11:57:55 -0800 Patch bug-52379-20110127171007.patch text/plain 3729 enne ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZjBhMmFjMWQ2MTg3ZjM0YTY1Mzc4MjA4YThhNTI3NWQwZTQ1YzZiLi5j ZTg3NzE2YzE5YTk0NGNjZDBlMjRhMjI5YzdkYzVkODJlNjA2MTE2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTEtMDEtMjcgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIEFkZCBDUkFTSCBjYWxscyB0byBmdXJ0aGVyIGRlYnVnIHRpbGVkIGNvbXBvc2l0b3Ig bWVtY3B5IGNyYXNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTIzNzkKKworICAgICAgICBUZXN0OiBMYXlvdXRUZXN0cy9jb21wb3NpdGluZyAodG8g dmVyaWZ5IHRoZXNlIHdlcmVuJ3QgdHJpZ2dlcmVkKQorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyVGlsZXJDaHJvbWl1bTo6aW52YWxpZGF0ZVJlY3QpOgorICAgICAgICAoV2ViQ29yZTo6 TGF5ZXJUaWxlckNocm9taXVtOjp1cGRhdGUpOgorCiAyMDExLTAxLTI3ICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2luQ0UgYnVp bGQgZml4IGZvciByNzY3NDMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcAppbmRleCA2 YjY1ZTY2OTQ4NWUwZTdiYmRlZmU4NTVhNmYwNTM0OTRiZDg3ZDdlLi40NTZkZmU0NWNjY2EyNGI2 MWRkMjg1OWYwYWZhNjU5YmY5NjcxZjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5j cHAKQEAgLTIwOCw2ICsyMDgsOCBAQCB2b2lkIExheWVyVGlsZXJDaHJvbWl1bTo6aW52YWxpZGF0 ZVJlY3QoY29uc3QgSW50UmVjdCYgY29udGVudFJlY3QpCiAgICAgICAgICAgICBJbnRSZWN0IGJv dW5kID0gdGlsZUxheWVyUmVjdChpLCBqKTsKICAgICAgICAgICAgIGJvdW5kLmludGVyc2VjdChs YXllclJlY3QpOwogICAgICAgICAgICAgdGlsZS0+bV9kaXJ0eUxheWVyUmVjdC51bml0ZShib3Vu ZCk7CisgICAgICAgICAgICBpZiAoIXRpbGVMYXllclJlY3QoaSwgaikuY29udGFpbnModGlsZS0+ bV9kaXJ0eUxheWVyUmVjdCkpCisgICAgICAgICAgICAgICAgQ1JBU0goKTsKICAgICAgICAgfQog ICAgIH0KIH0KQEAgLTI3Miw3ICsyNzQsMTEgQEAgdm9pZCBMYXllclRpbGVyQ2hyb21pdW06OnVw ZGF0ZShUaWxlUGFpbnRJbnRlcmZhY2UmIHBhaW50ZXIsIGNvbnN0IEludFJlY3QmIGNvbnQKICAg ICAvLyBHZXQgdGhlIGNvbnRlbnRzIG9mIHRoZSB1cGRhdGVkIHJlY3QuCiAgICAgY29uc3QgU2tC aXRtYXAmIGJpdG1hcCA9IGNhbnZhcy0+Z2V0RGV2aWNlKCktPmFjY2Vzc0JpdG1hcChmYWxzZSk7 CiAgICAgQVNTRVJUKGJpdG1hcC53aWR0aCgpID09IHBhaW50UmVjdC53aWR0aCgpICYmIGJpdG1h cC5oZWlnaHQoKSA9PSBwYWludFJlY3QuaGVpZ2h0KCkpOworICAgIGlmIChiaXRtYXAud2lkdGgo KSAhPSBwYWludFJlY3Qud2lkdGgoKSB8fCBiaXRtYXAuaGVpZ2h0KCkgIT0gcGFpbnRSZWN0Lmhl aWdodCgpKQorICAgICAgICBDUkFTSCgpOwogICAgIHVpbnQ4X3QqIHBhaW50UGl4ZWxzID0gc3Rh dGljX2Nhc3Q8dWludDhfdCo+KGJpdG1hcC5nZXRQaXhlbHMoKSk7CisgICAgaWYgKCFwYWludFBp eGVscykKKyAgICAgICAgQ1JBU0goKTsKICNlbGlmIFBMQVRGT1JNKENHKQogICAgIFZlY3Rvcjx1 aW50OF90PiBjYW52YXNQaXhlbHM7CiAgICAgaW50IHJvd0J5dGVzID0gNCAqIHBhaW50UmVjdC53 aWR0aCgpOwpAQCAtMzAyLDYgKzMwOCw4IEBAIHZvaWQgTGF5ZXJUaWxlckNocm9taXVtOjp1cGRh dGUoVGlsZVBhaW50SW50ZXJmYWNlJiBwYWludGVyLCBjb25zdCBJbnRSZWN0JiBjb250CiAgICAg Zm9yIChpbnQgaiA9IHRvcDsgaiA8PSBib3R0b207ICsraikgewogICAgICAgICBmb3IgKGludCBp ID0gbGVmdDsgaSA8PSByaWdodDsgKytpKSB7CiAgICAgICAgICAgICBUaWxlKiB0aWxlID0gbV90 aWxlc1t0aWxlSW5kZXgoaSwgaildLmdldCgpOworICAgICAgICAgICAgaWYgKCF0aWxlKQorICAg ICAgICAgICAgICAgIENSQVNIKCk7CiAgICAgICAgICAgICBpZiAoIXRpbGUtPmRpcnR5KCkpCiAg ICAgICAgICAgICAgICAgY29udGludWU7CiAKQEAgLTMyMCwxMyArMzI4LDIxIEBAIHZvaWQgTGF5 ZXJUaWxlckNocm9taXVtOjp1cGRhdGUoVGlsZVBhaW50SW50ZXJmYWNlJiBwYWludGVyLCBjb25z dCBJbnRSZWN0JiBjb250CiAKICAgICAgICAgICAgIC8vIENhbGN1bGF0ZSB0aWxlLXNwYWNlIHJl Y3RhbmdsZSB0byB1cGxvYWQgaW50by4KICAgICAgICAgICAgIEludFJlY3QgZGVzdFJlY3QoSW50 UG9pbnQoc291cmNlUmVjdC54KCkgLSBhbmNob3IueCgpLCBzb3VyY2VSZWN0LnkoKSAtIGFuY2hv ci55KCkpLCBzb3VyY2VSZWN0LnNpemUoKSk7Ci0gICAgICAgICAgICBBU1NFUlQoZGVzdFJlY3Qu eCgpID49IDApOwotICAgICAgICAgICAgQVNTRVJUKGRlc3RSZWN0LnkoKSA+PSAwKTsKKyAgICAg ICAgICAgIGlmIChkZXN0UmVjdC54KCkgPCAwKQorICAgICAgICAgICAgICAgIENSQVNIKCk7Cisg ICAgICAgICAgICBpZiAoZGVzdFJlY3QueSgpIDwgMCkKKyAgICAgICAgICAgICAgICBDUkFTSCgp OwogCiAgICAgICAgICAgICAvLyBPZmZzZXQgZnJvbSBwYWludCByZWN0YW5nbGUgdG8gdGhpcyB0 aWxlJ3MgZGlydHkgcmVjdGFuZ2xlLgogICAgICAgICAgICAgSW50UG9pbnQgcGFpbnRPZmZzZXQo c291cmNlUmVjdC54KCkgLSBwYWludFJlY3QueCgpLCBzb3VyY2VSZWN0LnkoKSAtIHBhaW50UmVj dC55KCkpOwotICAgICAgICAgICAgQVNTRVJUKHBhaW50T2Zmc2V0LngoKSA+PSAwKTsKLSAgICAg ICAgICAgIEFTU0VSVChwYWludE9mZnNldC55KCkgPj0gMCk7CisgICAgICAgICAgICBpZiAocGFp bnRPZmZzZXQueCgpIDwgMCkKKyAgICAgICAgICAgICAgICBDUkFTSCgpOworICAgICAgICAgICAg aWYgKHBhaW50T2Zmc2V0LnkoKSA8IDApCisgICAgICAgICAgICAgICAgQ1JBU0goKTsKKyAgICAg ICAgICAgIGlmIChwYWludE9mZnNldC54KCkgKyBkZXN0UmVjdC53aWR0aCgpID4gcGFpbnRSZWN0 LndpZHRoKCkpCisgICAgICAgICAgICAgICAgQ1JBU0goKTsKKyAgICAgICAgICAgIGlmIChwYWlu dE9mZnNldC55KCkgKyBkZXN0UmVjdC5oZWlnaHQoKSA+IHBhaW50UmVjdC5oZWlnaHQoKSkKKyAg ICAgICAgICAgICAgICBDUkFTSCgpOwogCiAgICAgICAgICAgICB1aW50OF90KiBwaXhlbFNvdXJj ZTsKICAgICAgICAgICAgIGlmIChwYWludFJlY3Qud2lkdGgoKSA9PSBzb3VyY2VSZWN0LndpZHRo KCkgJiYgIXBhaW50T2Zmc2V0LngoKSkK 80473 2011-01-28 11:57:58 -0800 2011-01-28 12:08:42 -0800 Patch bug-52379-20110128115757.patch text/plain 1385 enne ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjdjYzBmY2NiOTUwYjUxZDA0YWRmOWNjNjM4ZTBmM2NjZGU4ZTg3Li41 NmU0YTYzMTMxZTIwMzNiNDdkZWU0ZjViMGI3YjFlZmM5YWU4Y2U3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTEtMDEtMjggIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIFJlbW92ZSBhIHNwdXJpb3VzIGRpYWdub3N0aWMgQ1JBU0ggY2hlY2suCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjM3OQorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkxheWVyVGlsZXJDaHJvbWl1bTo6aW52YWxpZGF0ZVJlY3QpOgorCiAy MDExLTAxLTI4ICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3Bw CmluZGV4IGNhMjRmMDdkMzNlZDQ0ZTc1OGEyZDIxNmEyYTVhYzlkNTBiYjE0ZWQuLjUzZTdjMGQ1 MjkxNmU4YzI4OTc5ZTE3NmNhYjMzNjVjMmRlMWIwZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNo cm9taXVtLmNwcApAQCAtMjA4LDggKzIwOCw2IEBAIHZvaWQgTGF5ZXJUaWxlckNocm9taXVtOjpp bnZhbGlkYXRlUmVjdChjb25zdCBJbnRSZWN0JiBjb250ZW50UmVjdCkKICAgICAgICAgICAgIElu dFJlY3QgYm91bmQgPSB0aWxlTGF5ZXJSZWN0KGksIGopOwogICAgICAgICAgICAgYm91bmQuaW50 ZXJzZWN0KGxheWVyUmVjdCk7CiAgICAgICAgICAgICB0aWxlLT5tX2RpcnR5TGF5ZXJSZWN0LnVu aXRlKGJvdW5kKTsKLSAgICAgICAgICAgIGlmICghdGlsZUxheWVyUmVjdChpLCBqKS5jb250YWlu cyh0aWxlLT5tX2RpcnR5TGF5ZXJSZWN0KSkKLSAgICAgICAgICAgICAgICBDUkFTSCgpOwogICAg ICAgICB9CiAgICAgfQogfQo=