52375 2011-01-13 10:05:31 -0800 Crash in Widget::setFrameRect() 2011-01-13 10:21:52 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 mitz mitz oldest_to_newest 333753 0 mitz 2011-01-13 10:05:31 -0800 Crash in Widget::setFrameRect() 333758 1 mitz 2011-01-13 10:11:56 -0800 <rdar://problem/8098442> 333759 2 78822 mitz 2011-01-13 10:12:41 -0800 Created attachment 78822 Protect the Widget from deletion when calling out to the platform widget 333766 3 mitz 2011-01-13 10:21:52 -0800 Fixed in <http://trac.webkit.org/changeset/75720>. 78822 2011-01-13 10:12:41 -0800 2011-01-13 10:16:42 -0800 Protect the Widget from deletion when calling out to the platform widget 8098442_r1.diff text/plain 6639 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1NzE5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDEtMTMgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODA5ODQ0Mj4gQ3Jhc2ggaW4gV2lkZ2V0 OjpzZXRGcmFtZVJlY3QoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTIzNzUKKworICAgICAgICBUZXN0OiBwbHVnaW5zL2Rlc3Ryb3ktb24tc2V0d2lu ZG93Lmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9XaWRnZXRNYWMubW06CisgICAgICAg IChXZWJDb3JlOjpXaWRnZXQ6OnNldEZyYW1lUmVjdCk6IFByb3RlY3QgdGhlIFdpZGdldCBmcm9t IGJlaW5nIGRlbGV0ZWQgYXMgYSByZXN1bHQgb2YgY2FsbGluZworICAgICAgICBvdXQgdG8gdGhl IHZpZXcuCisgICAgICAgIChXZWJDb3JlOjpXaWRnZXQ6OmdldE91dGVyVmlldyk6IENvZGluZyBz dHlsZSBmaXguCisgICAgICAgIChXZWJDb3JlOjpXaWRnZXQ6OnBhaW50KTogUHJvdGVjdCB0aGUg V2lkZ2V0IGZyb20gYmVpbmcgZGVsZXRlZCBhcyBhIHJlc3VsdCBvZiBjYWxsaW5nIG91dCB0bwor ICAgICAgICB0aGUgdmlld3MuIFRoaXMgaXMgcHJlY2F1dGlvbmFyeSwgc2luY2UgdGhpcyBmdW5j dGlvbiBkb2VzIG5vdCBhcHBsZWFyIHRvIGFjY2VzcyBtZW1iZXIgdmFyaWFibGVzCisgICAgICAg IGFmdGVyIHN1Y2ggY2FsbHMuCisgICAgICAgICogcGxhdGZvcm0vd3gvV2lkZ2V0V3guY3BwOgor ICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0OjpzZXRGcmFtZVJlY3QpOiBQcm90ZWN0IHRoZSBXaWRn ZXQgZnJvbSBiZWluZyBkZWxldGVkIGFzIGEgcmVzdWx0IG9mIGNhbGxpbmcKKyAgICAgICAgb3V0 IHRvIHRoZSBwbGF0Zm9ybSB3aWRnZXQuCisKIDIwMTEtMDEtMTMgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkZml4IGFmdGVy IHI3NTcxNS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XaWRnZXRNYWMubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dpZGdldE1hYy5tbQko cmV2aXNpb24gNzU3MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2lkZ2V0TWFj Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykg MjAwNCwgMjAwNSwgMjAwNiwgMjAwOCwgMjAxMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDQsIDIwMDUsIDIwMDYsIDIwMDgsIDIwMTAsIDIwMTEg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCkBAIC0xNzAsMjUgKzE3MCwyOSBAQCB2b2lkIFdpZGdldDo6c2V0RnJhbWVSZWN0KGNv bnN0IEludFJlY3QmCiAgICAgbV9mcmFtZSA9IHJlY3Q7CiAKICAgICBCRUdJTl9CTE9DS19PQkpD X0VYQ0VQVElPTlM7Ci0gICAgTlNWaWV3ICp2ID0gZ2V0T3V0ZXJWaWV3KCk7Ci0gICAgaWYgKCF2 KQorICAgIE5TVmlldyAqb3V0ZXJWaWV3ID0gZ2V0T3V0ZXJWaWV3KCk7CisgICAgaWYgKCFvdXRl clZpZXcpCiAgICAgICAgIHJldHVybjsKIAotICAgIE5TUmVjdCB2aXNpYmxlUmVjdCA9IFt2IHZp c2libGVSZWN0XTsKKyAgICAvLyBUYWtlIGEgcmVmZXJlbmNlIHRvIHRoaXMgV2lkZ2V0LCBiZWNh dXNlIHNlbmRpbmcgbWVzc2FnZXMgdG8gb3V0ZXJWaWV3IGNhbiBpbnZva2UgYXJiaXRyYXJ5Cisg ICAgLy8gY29kZSwgd2hpY2ggY2FuIGRlcmVmIGl0LgorICAgIFJlZlB0cjxXaWRnZXQ+IHByb3Rl Y3RlZFRoaXModGhpcyk7CisKKyAgICBOU1JlY3QgdmlzaWJsZVJlY3QgPSBbb3V0ZXJWaWV3IHZp c2libGVSZWN0XTsKICAgICBOU1JlY3QgZiA9IHJlY3Q7Ci0gICAgaWYgKCFOU0VxdWFsUmVjdHMo ZiwgW3YgZnJhbWVdKSkgewotICAgICAgICBbdiBzZXRGcmFtZTpmXTsKLSAgICAgICAgW3Ygc2V0 TmVlZHNEaXNwbGF5Ok5PXTsKLSAgICB9IGVsc2UgaWYgKCFOU0VxdWFsUmVjdHModmlzaWJsZVJl Y3QsIG1fZGF0YS0+cHJldmlvdXNWaXNpYmxlUmVjdCkgJiYgW3YgcmVzcG9uZHNUb1NlbGVjdG9y OkBzZWxlY3Rvcih2aXNpYmxlUmVjdERpZENoYW5nZSldKQotICAgICAgICBbdiB2aXNpYmxlUmVj dERpZENoYW5nZV07CisgICAgaWYgKCFOU0VxdWFsUmVjdHMoZiwgW291dGVyVmlldyBmcmFtZV0p KSB7CisgICAgICAgIFtvdXRlclZpZXcgc2V0RnJhbWU6Zl07CisgICAgICAgIFtvdXRlclZpZXcg c2V0TmVlZHNEaXNwbGF5Ok5PXTsKKyAgICB9IGVsc2UgaWYgKCFOU0VxdWFsUmVjdHModmlzaWJs ZVJlY3QsIG1fZGF0YS0+cHJldmlvdXNWaXNpYmxlUmVjdCkgJiYgW291dGVyVmlldyByZXNwb25k c1RvU2VsZWN0b3I6QHNlbGVjdG9yKHZpc2libGVSZWN0RGlkQ2hhbmdlKV0pCisgICAgICAgIFtv dXRlclZpZXcgdmlzaWJsZVJlY3REaWRDaGFuZ2VdOwogCiAgICAgbV9kYXRhLT5wcmV2aW91c1Zp c2libGVSZWN0ID0gdmlzaWJsZVJlY3Q7CiAgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsK IH0KIAotTlNWaWV3KiBXaWRnZXQ6OmdldE91dGVyVmlldygpIGNvbnN0CitOU1ZpZXcgKldpZGdl dDo6Z2V0T3V0ZXJWaWV3KCkgY29uc3QKIHsKLSAgICBOU1ZpZXcqIHZpZXcgPSBwbGF0Zm9ybVdp ZGdldCgpOworICAgIE5TVmlldyAqdmlldyA9IHBsYXRmb3JtV2lkZ2V0KCk7CiAKICAgICAvLyBJ ZiB0aGlzIHdpZGdldCdzIHZpZXcgaXMgYSBXZWJDb3JlRnJhbWVTY3JvbGxWaWV3IHRoZW4gd2UK ICAgICAvLyByZXNpemUgaXRzIGNvbnRhaW5pbmcgdmlldywgYSBXZWJGcmFtZVZpZXcuCkBAIC0y MDUsNiArMjA5LDExIEBAIHZvaWQgV2lkZ2V0OjpwYWludChHcmFwaGljc0NvbnRleHQqIHAsIGMK ICAgICBpZiAocC0+cGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm47CiAgICAgTlNW aWV3ICp2aWV3ID0gZ2V0T3V0ZXJWaWV3KCk7CisKKyAgICAvLyBUYWtlIGEgcmVmZXJlbmNlIHRv IHRoaXMgV2lkZ2V0LCBiZWNhdXNlIHNlbmRpbmcgbWVzc2FnZXMgdG8gdGhlIHZpZXdzIGNhbiBp bnZva2UgYXJiaXRyYXJ5CisgICAgLy8gY29kZSwgd2hpY2ggY2FuIGRlcmVmIGl0LgorICAgIFJl ZlB0cjxXaWRnZXQ+IHByb3RlY3RlZFRoaXModGhpcyk7CisKICAgICBOU0dyYXBoaWNzQ29udGV4 dCAqY3VycmVudENvbnRleHQgPSBbTlNHcmFwaGljc0NvbnRleHQgY3VycmVudENvbnRleHRdOwog ICAgIGlmIChjdXJyZW50Q29udGV4dCA9PSBbW3ZpZXcgd2luZG93XSBncmFwaGljc0NvbnRleHRd IHx8ICFbY3VycmVudENvbnRleHQgaXNEcmF3aW5nVG9TY3JlZW5dKSB7CiAgICAgICAgIC8vIFRo aXMgaXMgdGhlIGNvbW1vbiBjYXNlIG9mIGRyYXdpbmcgaW50byBhIHdpbmRvdyBvciBwcmludGlu Zy4KQEAgLTI2MSw2ICsyNzAsNyBAQCB2b2lkIFdpZGdldDo6cGFpbnQoR3JhcGhpY3NDb250ZXh0 KiBwLCBjCiB2b2lkIFdpZGdldDo6c2V0SXNTZWxlY3RlZChib29sIGlzU2VsZWN0ZWQpCiB7CiAg ICAgTlNWaWV3ICp2aWV3ID0gcGxhdGZvcm1XaWRnZXQoKTsKKwogICAgIEJFR0lOX0JMT0NLX09C SkNfRVhDRVBUSU9OUzsKICAgICBpZiAoW3ZpZXcgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rv cih3ZWJQbHVnSW5TZXRJc1NlbGVjdGVkOildKQogICAgICAgICBbdmlldyB3ZWJQbHVnSW5TZXRJ c1NlbGVjdGVkOmlzU2VsZWN0ZWRdOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3gv V2lkZ2V0V3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3d4L1dp ZGdldFd4LmNwcAkocmV2aXNpb24gNzU3MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93 eC9XaWRnZXRXeC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgwLDYgKzgwLDEwIEBAIEludFJlY3Qg V2lkZ2V0OjpmcmFtZVJlY3QoKSBjb25zdAogCiB2b2lkIFdpZGdldDo6c2V0RnJhbWVSZWN0KGNv bnN0IEludFJlY3QmIHJlY3QpCiB7CisgICAgLy8gVGFrZSBhIHJlZmVyZW5jZSB0byB0aGlzIFdp ZGdldCwgYmVjYXVzZSBjYWxsaW5nIGZ1bmN0aW9ucyBvZiB0aGUgUGxhdGZvcm1XaWRnZXQgY2Fu IGludm9rZSBhcmJpdHJhcnkKKyAgICAvLyBjb2RlLCB3aGljaCBjYW4gZGVyZWYgaXQuCisgICAg UmVmUHRyPFdpZGdldD4gcHJvdGVjdGVkVGhpcyh0aGlzKTsKKwogICAgIGlmIChQbGF0Zm9ybVdp ZGdldCB3aWRnZXQgPSBwbGF0Zm9ybVdpZGdldCgpKQogICAgICAgICB3aWRnZXQtPlNldFNpemUo cmVjdCk7CiAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3NTcxOSkKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTAxLTEzICBEYW4g QmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgwOTg0NDI+IENyYXNoIGluIFdp ZGdldDo6c2V0RnJhbWVSZWN0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTUyMzc1CisKKyAgICAgICAgKiBwbHVnaW5zL2Rlc3Ryb3ktb24tc2V0d2lu ZG93LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGx1Z2lucy9kZXN0cm95LW9uLXNl dHdpbmRvdy5odG1sOiBBZGRlZC4KKwogMjAxMS0wMS0xMyAgVG9ueSBDaGFuZyAgPHRvbnlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpJbmRleDogTGF5 b3V0VGVzdHMvcGx1Z2lucy9kZXN0cm95LW9uLXNldHdpbmRvdy1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGx1Z2lucy9kZXN0cm95LW9uLXNldHdpbmRvdy1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbHVnaW5zL2Rlc3Ryb3ktb24tc2V0 d2luZG93LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitUZXN0IHRo YXQgYSBwbHVnLWluIHRoYXQgY2F1c2VzIGl0cyBXaWRnZXQgdG8gYmUgZGVzdHJveWVkIGR1cmlu ZyBzZXRXaW5kb3cgZG9lcyBub3QgY2F1c2UgYSBjcmFzaC4KKworCkluZGV4OiBMYXlvdXRUZXN0 cy9wbHVnaW5zL2Rlc3Ryb3ktb24tc2V0d2luZG93Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGx1Z2lucy9kZXN0cm95LW9uLXNldHdpbmRvdy5odG1sCShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvcGx1Z2lucy9kZXN0cm95LW9uLXNldHdpbmRvdy5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDIzIEBACis8cD4KKyAgICBUZXN0IHRoYXQgYSBwbHVnLWluIHRoYXQgY2F1 c2VzIGl0cyBXaWRnZXQgdG8gYmUgZGVzdHJveWVkIGR1cmluZyBzZXRXaW5kb3cgZG9lcyBub3Qg Y2F1c2UgYSBjcmFzaC4KKzwvcD4KKzxlbWJlZCBpZD0icGx1Zy1pbiIgdHlwZT0iYXBwbGljYXRp b24veC13ZWJraXQtdGVzdC1uZXRzY2FwZSIgb25TZXRXaW5kb3c9ImhhbmRsZVNldFdpbmRvdygp Ij4KKzxzY3JpcHQ+CisgICAgdmFyIHBsdWdJbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJw bHVnLWluIik7CisgICAgdmFyIGNvdW50ID0gMDsKKworICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK KworICAgIGZ1bmN0aW9uIGhhbmRsZVNldFdpbmRvdygpCisgICAgeworICAgICAgICBjb3VudCsr OworCisgICAgICAgIGlmIChjb3VudCA9PSAyKQorICAgICAgICAgICAgcGx1Z0luLnN0eWxlLndp ZHRoID0gIjUwMHB4IjsKKyAgICAgICAgZWxzZSBpZiAoY291bnQgPT0gMykKKyAgICAgICAgICAg IHBsdWdJbi5wYXJlbnROb2RlLnJlbW92ZUNoaWxkKHBsdWdJbik7CisgICAgfQorCisgICAgaGFu ZGxlU2V0V2luZG93KCk7Cis8L3NjcmlwdD4K