52367 2011-01-13 06:55:03 -0800 [Chromium]: FindInPage scoping function needs to handle user-select-none better 2011-01-14 02:25:11 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 finnur.webkit webkit-unassigned commit-queue ojan webkit.review.bot oldest_to_newest 333666 0 finnur.webkit 2011-01-13 06:55:03 -0800 The scoping function used in Chromium does not handle user-select-none well. It basically stops when it hits the first user-select-none style. This is similar to the problem fixed in bug 33508 and the same fix applies here as well. I'll upload a patch. 333668 1 78805 finnur.webkit 2011-01-13 07:01:37 -0800 Created attachment 78805 A patch for this 333669 2 finnur.webkit 2011-01-13 07:02:16 -0800 Also related: bug 51623. 333670 3 webkit.review.bot 2011-01-13 07:04:29 -0800 Attachment 78805 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit/chromium/ChangeLog', u'WebKit/chrom..." exit_code: 1 WebKit/chromium/ChangeLog:3: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 333671 4 78806 finnur.webkit 2011-01-13 07:06:40 -0800 Created attachment 78806 Another patch, addressing crlf issue. 333742 5 78806 commit-queue 2011-01-13 09:35:27 -0800 Comment on attachment 78806 Another patch, addressing crlf issue. Rejecting attachment 78806 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 1 Last 500 characters of output: rks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 756, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 706, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/7521018 333789 6 78806 commit-queue 2011-01-13 10:41:25 -0800 Comment on attachment 78806 Another patch, addressing crlf issue. Rejecting attachment 78806 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 1 Last 500 characters of output: WebCore/rendering/RenderSlider.cpp M Source/WebCore/rendering/MediaControlElements.cpp M Source/WebCore/rendering/RenderSlider.h M Source/WebCore/css/CSSStyleSelector.cpp r75725 = 61dc5b176da5cc962fff04efe17be06ac33c2c32 (refs/remotes/trunk) M Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg M Tools/ChangeLog r75726 = a331c0a2664e0c98329756cfa83269df92c74daa (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/7555019 333804 7 ojan 2011-01-13 11:01:45 -0800 Finnur, I missed this in the review. You're ChangeLog needs the dummy line for filling in the reviewer at that top. For example, see the one at https://bugs.webkit.org/attachment.cgi?id=78826&action=review. 334186 8 78911 finnur.webkit 2011-01-14 01:52:13 -0800 Created attachment 78911 Same patch, with dummy reviewer line in ChangeLog (and svn up'ed) 334189 9 finnur.webkit 2011-01-14 01:54:29 -0800 Fixed. Sorry about that. Forgot it was necessary. 334190 10 78911 levin 2011-01-14 01:56:12 -0800 Comment on attachment 78911 Same patch, with dummy reviewer line in ChangeLog (and svn up'ed) Per comments in irc. 334196 11 78912 finnur.webkit 2011-01-14 02:00:16 -0800 Created attachment 78912 Previously reviewed, just missing reviewer line. 334197 12 78912 webkit.review.bot 2011-01-14 02:00:37 -0800 Comment on attachment 78912 Previously reviewed, just missing reviewer line. Rejecting attachment 78912 from commit-queue. finnur.webkit@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 334207 13 78912 commit-queue 2011-01-14 02:25:04 -0800 Comment on attachment 78912 Previously reviewed, just missing reviewer line. Clearing flags on attachment: 78912 Committed r75784: <http://trac.webkit.org/changeset/75784> 334208 14 commit-queue 2011-01-14 02:25:11 -0800 All reviewed patches have been landed. Closing bug. 78805 2011-01-13 07:01:37 -0800 2011-01-13 07:06:40 -0800 A patch for this patch1 text/plain 4998 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzU3MTApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzIgQEAKKzIwMTEtMDEtMTMgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBBZGRy ZXNzIHNvbWUgdXNlci1zZWxlY3Qtbm9uZSBpc3N1ZXMgYmV0dGVyIGluIG91ciBGaW5kIGluIHBh Z2Ugc2NvcGluZw0KKyAgICAgICAgZnVuY3Rpb24uDQorDQorICAgICAgICBUaGUgc2NvcGluZyBm dW5jdGlvbiBpcyBpbiBwYXJ0IGJhc2VkIG9uIEVkaXRvcjo6Y291bnRNYXRjaGVzRm9yVGV4dAor ICAgICAgICAoZm9ybWVybHkgRnJhbWU6Om1hcmtBbGxNYXRjaGVzRm9yVGV4dCksIGJ1dCB3YXMg cmV3cml0dGVuIHdpdGgKKyAgICAgICAgYXN5Y2hyb25vdXMgc2VhcmNoIGFuZCBpbnRlcnJ1cHRh YmlsaXR5IGluIG1pbmQuIEF0IHRoZSB0aW1lIHRoZQorICAgICAgICBmdW5jdGlvbiB3YXMgd3Jp dHRlbiwgY291bnRNYXRjaGVzRm9yVGV4dCBkaWRuJ3Qgd29yayB3ZWxsIHdpdGgKKyAgICAgICAg dXNlci1zZWxlY3Qtbm9uZSBzdHlsZSBidXQgdGhhdCBoYXMgbm93IGNoYW5nZWQuIFdoaWxlCisg ICAgICAgIGludmVzdGlnYXRpbmcgaHR0cDovL2NyYnVnLmNvbS82ODQ5NCBJIG5vdGljZWQgV2Vi S2l0IGhhZCBmaXhlZCB0aGlzCisgICAgICAgIHZlcnkgcHJvYmxlbSBpbiB0aGUgY291bnRNYXRj aGVzRm9yVGV4dCBhbmQgSSBiZWxpZXZlIHdlIHNob3VsZCBtYWtlCisgICAgICAgIHRoZSBzYW1l IGNoYW5nZXMgaW4gb3VyIHBsYXRmb3JtIGNvZGUuIFRoZXJlZm9yZSwgdGhpcyBjaGFuZ2VsaXN0 CisgICAgICAgIGFkb3B0cyB0aGUgc2FtZSBhcHByb2FjaCBieSBpbnRlZ3JhdGluZzoKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNTA4CisgICAgICAg IChyNTMxNDI6IGhhbmRsaW5nIHVzZXItc2VsZWN0LW5vbmUgYmV0dGVyKSBhbmQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjIzCisgICAgICAgIChy NzQ4ODY6IGhhbmRsaW5nIG1hdGNoIHdpdGhpbiB0ZXh0ZmllbGQgYmV0dGVyKS4gDQorICAgICAg ICBGb3IgbW9yZSBkZXRhaWxzIHNlZSB0aG9zZSBjaGFuZ2VsaXN0cy4NCisKKyAgICAgICAgVGhp cyBjaGFuZ2VsaXN0LCBob3dldmVyLCBpcyB0cmFja2VkIGhlcmU6CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjM2NworICAgICAgICAKKyAgICAgICAg VGhlIG9yaWdpbmFsIGNoYW5nZWxpc3RzIGRpZCBub3QgY29tZSB3aXRoIGxheW91dCB0ZXN0cywg YnV0IEknbSBhZGRpbmcKKyAgICAgICAgYSB0ZXN0IG9uIHRoZSBDaHJvbWl1bSBzaWRlIGZvciB0 aGlzLgorCisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYkZyYW1lSW1wbDo6c2NvcGVTdHJpbmdNYXRjaGVzKToKKwogMjAxMS0wMS0xMiAgTWloYWkg UGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXZpZCBMZXZpbi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlz aW9uIDc1NzEwKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNTIsNyArMTUyLDYgQEAKICNpbmNsdWRlIDxhbGdvcml0aG0+CiAjaW5j bHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAKLQogI2lmIE9TKERBUldJTikKICNpbmNsdWRlICJM b2NhbEN1cnJlbnRHcmFwaGljc0NvbnRleHQuaCIKICNlbmRpZgpAQCAtMTUzNCw2ICsxNTMzLDkg QEAgdm9pZCBXZWJGcmFtZUltcGw6OnNjb3BlU3RyaW5nTWF0Y2hlcyhpbgogICAgICAgICB9CiAg ICAgfQogCisgICAgTm9kZSogb3JpZ2luYWxFbmRDb250YWluZXIgPSBzZWFyY2hSYW5nZS0+ZW5k Q29udGFpbmVyKCk7CisgICAgaW50IG9yaWdpbmFsRW5kT2Zmc2V0ID0gc2VhcmNoUmFuZ2UtPmVu ZE9mZnNldCgpOworCiAgICAgLy8gVGhpcyB0aW1lb3V0IGNvbnRyb2xzIGhvdyBsb25nIHdlIHNj b3BlIGJlZm9yZSByZWxlYXNpbmcgY29udHJvbC4gIFRoaXMKICAgICAvLyB2YWx1ZSBkb2VzIG5v dCBwcmV2ZW50IHVzIGZyb20gcnVubmluZyBmb3IgbG9uZ2VyIHRoYW4gdGhpcywgYnV0IGl0IGlz CiAgICAgLy8gcGVyaW9kaWNhbGx5IGNoZWNrZWQgdG8gc2VlIGlmIHdlIGhhdmUgZXhjZWVkZWQg b3VyIGFsbG9jYXRlZCB0aW1lLgpAQCAtMTU1NiwyOSArMTU1OCwxNiBAQCB2b2lkIFdlYkZyYW1l SW1wbDo6c2NvcGVTdHJpbmdNYXRjaGVzKGluCiAgICAgICAgICAgICBpZiAoIXJlc3VsdFJhbmdl LT5zdGFydENvbnRhaW5lcigpLT5pc0luU2hhZG93VHJlZSgpKQogICAgICAgICAgICAgICAgIGJy ZWFrOwogCi0gICAgICAgICAgICBzZWFyY2hSYW5nZSA9IHJhbmdlT2ZDb250ZW50cyhmcmFtZSgp LT5kb2N1bWVudCgpKTsKICAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRTdGFydEFmdGVyKAog ICAgICAgICAgICAgICAgIHJlc3VsdFJhbmdlLT5zdGFydENvbnRhaW5lcigpLT5zaGFkb3dBbmNl c3Rvck5vZGUoKSwgZWMpOworICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldEVuZChvcmlnaW5h bEVuZENvbnRhaW5lciwgb3JpZ2luYWxFbmRPZmZzZXQsIGVjKTsKICAgICAgICAgICAgIGNvbnRp bnVlOwogICAgICAgICB9CiAKLSAgICAgICAgLy8gQSBub24tY29sbGFwc2VkIHJlc3VsdCByYW5n ZSBjYW4gaW4gc29tZSBmdW5reSB3aGl0ZXNwYWNlIGNhc2VzIHN0aWxsIG5vdAotICAgICAgICAv LyBhZHZhbmNlIHRoZSByYW5nZSdzIHN0YXJ0IHBvc2l0aW9uICg0NTA5MzI4KS4gQnJlYWsgdG8g YXZvaWQgaW5maW5pdGUKLSAgICAgICAgLy8gbG9vcC4gKFRoaXMgZnVuY3Rpb24gaXMgYmFzZWQg b24gdGhlIGltcGxlbWVudGF0aW9uIG9mCi0gICAgICAgIC8vIEZyYW1lOjptYXJrQWxsTWF0Y2hl c0ZvclRleHQsIHdoaWNoIGlzIHdoZXJlIHRoaXMgc2FmZWd1YXJkIGNvbWVzIGZyb20pLgotICAg ICAgICBWaXNpYmxlUG9zaXRpb24gbmV3U3RhcnQgPSBlbmRWaXNpYmxlUG9zaXRpb24ocmVzdWx0 UmFuZ2UuZ2V0KCksIERPV05TVFJFQU0pOwotICAgICAgICBpZiAobmV3U3RhcnQgPT0gc3RhcnRW aXNpYmxlUG9zaXRpb24oc2VhcmNoUmFuZ2UuZ2V0KCksIERPV05TVFJFQU0pKQotICAgICAgICAg ICAgYnJlYWs7Ci0KICAgICAgICAgLy8gT25seSB0cmVhdCB0aGUgcmVzdWx0IGFzIGEgbWF0Y2gg aWYgaXQgaXMgdmlzaWJsZQogICAgICAgICBpZiAoZnJhbWUoKS0+ZWRpdG9yKCktPmluc2lkZVZp c2libGVBcmVhKHJlc3VsdFJhbmdlLmdldCgpKSkgewogICAgICAgICAgICAgKyttYXRjaENvdW50 OwogCi0gICAgICAgICAgICBzZXRTdGFydChzZWFyY2hSYW5nZS5nZXQoKSwgbmV3U3RhcnQpOwot ICAgICAgICAgICAgTm9kZSogc2hhZG93VHJlZVJvb3QgPSBzZWFyY2hSYW5nZS0+c2hhZG93VHJl ZVJvb3ROb2RlKCk7Ci0gICAgICAgICAgICBpZiAoc2VhcmNoUmFuZ2UtPmNvbGxhcHNlZChlYykg JiYgc2hhZG93VHJlZVJvb3QpCi0gICAgICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldEVuZChz aGFkb3dUcmVlUm9vdCwgc2hhZG93VHJlZVJvb3QtPmNoaWxkTm9kZUNvdW50KCksIGVjKTsKLQog ICAgICAgICAgICAgLy8gQ2F0Y2ggYSBzcGVjaWFsIGNhc2Ugd2hlcmUgRmluZCBmb3VuZCBzb21l dGhpbmcgYnV0IGRvZXNuJ3Qga25vdyB3aGF0CiAgICAgICAgICAgICAvLyB0aGUgYm91bmRpbmcg Ym94IGZvciBpdCBpcy4gSW4gdGhpcyBjYXNlIHdlIHNldCB0aGUgZmlyc3QgbWF0Y2ggd2UgZmlu ZAogICAgICAgICAgICAgLy8gYXMgdGhlIGFjdGl2ZSByZWN0LgpAQCAtMTYxNSw2ICsxNjA0LDE2 IEBAIHZvaWQgV2ViRnJhbWVJbXBsOjpzY29wZVN0cmluZ01hdGNoZXMoaW4KICAgICAgICAgICAg IGFkZE1hcmtlcihyZXN1bHRSYW5nZS5nZXQoKSwgZm91bmRBY3RpdmVNYXRjaCk7CiAgICAgICAg IH0KIAorICAgICAgICAvLyBTZXQgdGhlIG5ldyBzdGFydCBmb3IgdGhlIHNlYXJjaCByYW5nZSB0 byBiZSB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cworICAgICAgICAvLyByZXN1bHQgcmFuZ2UuIFRo ZXJlIGlzIG5vIG5lZWQgdG8gdXNlIGEgVmlzaWJsZVBvc2l0aW9uIGhlcmUsCisgICAgICAgIC8v IHNpbmNlIGZpbmRQbGFpblRleHQgd2lsbCB1c2UgYSBUZXh0SXRlcmF0b3IgdG8gZ28gb3ZlciB0 aGUgdmlzaWJsZQorICAgICAgICAvLyB0ZXh0IG5vZGVzLiAKKyAgICAgICAgc2VhcmNoUmFuZ2Ut PnNldFN0YXJ0KHJlc3VsdFJhbmdlLT5lbmRDb250YWluZXIoZWMpLCByZXN1bHRSYW5nZS0+ZW5k T2Zmc2V0KGVjKSwgZWMpOworCisgICAgICAgIE5vZGUqIHNoYWRvd1RyZWVSb290ID0gc2VhcmNo UmFuZ2UtPnNoYWRvd1RyZWVSb290Tm9kZSgpOworICAgICAgICBpZiAoc2VhcmNoUmFuZ2UtPmNv bGxhcHNlZChlYykgJiYgc2hhZG93VHJlZVJvb3QpCisgICAgICAgICAgICBzZWFyY2hSYW5nZS0+ c2V0RW5kKHNoYWRvd1RyZWVSb290LCBzaGFkb3dUcmVlUm9vdC0+Y2hpbGROb2RlQ291bnQoKSwg ZWMpOworCiAgICAgICAgIG1fcmVzdW1lU2NvcGluZ0Zyb21SYW5nZSA9IHJlc3VsdFJhbmdlOwog ICAgICAgICB0aW1lZE91dCA9IChjdXJyZW50VGltZSgpIC0gc3RhcnRUaW1lKSA+PSBtYXhTY29w aW5nRHVyYXRpb247CiAgICAgfSB3aGlsZSAoIXRpbWVkT3V0KTsK 78806 2011-01-13 07:06:40 -0800 2011-01-14 01:52:13 -0800 Another patch, addressing crlf issue. patch2 text/plain 4993 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzU3MTApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzIgQEAKKzIwMTEtMDEtMTMgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBBZGRy ZXNzIHNvbWUgdXNlci1zZWxlY3Qtbm9uZSBpc3N1ZXMgYmV0dGVyIGluIG91ciBGaW5kIGluIHBh Z2Ugc2NvcGluZworICAgICAgICBmdW5jdGlvbi4KKworICAgICAgICBUaGUgc2NvcGluZyBmdW5j dGlvbiBpcyBpbiBwYXJ0IGJhc2VkIG9uIEVkaXRvcjo6Y291bnRNYXRjaGVzRm9yVGV4dAorICAg ICAgICAoZm9ybWVybHkgRnJhbWU6Om1hcmtBbGxNYXRjaGVzRm9yVGV4dCksIGJ1dCB3YXMgcmV3 cml0dGVuIHdpdGgKKyAgICAgICAgYXN5Y2hyb25vdXMgc2VhcmNoIGFuZCBpbnRlcnJ1cHRhYmls aXR5IGluIG1pbmQuIEF0IHRoZSB0aW1lIHRoZQorICAgICAgICBmdW5jdGlvbiB3YXMgd3JpdHRl biwgY291bnRNYXRjaGVzRm9yVGV4dCBkaWRuJ3Qgd29yayB3ZWxsIHdpdGgKKyAgICAgICAgdXNl ci1zZWxlY3Qtbm9uZSBzdHlsZSBidXQgdGhhdCBoYXMgbm93IGNoYW5nZWQuIFdoaWxlCisgICAg ICAgIGludmVzdGlnYXRpbmcgaHR0cDovL2NyYnVnLmNvbS82ODQ5NCBJIG5vdGljZWQgV2ViS2l0 IGhhZCBmaXhlZCB0aGlzCisgICAgICAgIHZlcnkgcHJvYmxlbSBpbiB0aGUgY291bnRNYXRjaGVz Rm9yVGV4dCBhbmQgSSBiZWxpZXZlIHdlIHNob3VsZCBtYWtlCisgICAgICAgIHRoZSBzYW1lIGNo YW5nZXMgaW4gb3VyIHBsYXRmb3JtIGNvZGUuIFRoZXJlZm9yZSwgdGhpcyBjaGFuZ2VsaXN0Cisg ICAgICAgIGFkb3B0cyB0aGUgc2FtZSBhcHByb2FjaCBieSBpbnRlZ3JhdGluZzoKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNTA4CisgICAgICAgIChy NTMxNDI6IGhhbmRsaW5nIHVzZXItc2VsZWN0LW5vbmUgYmV0dGVyKSBhbmQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjIzCisgICAgICAgIChyNzQ4 ODY6IGhhbmRsaW5nIG1hdGNoIHdpdGhpbiB0ZXh0ZmllbGQgYmV0dGVyKS4gCisgICAgICAgIEZv ciBtb3JlIGRldGFpbHMgc2VlIHRob3NlIGNoYW5nZWxpc3RzLgorCisgICAgICAgIFRoaXMgY2hh bmdlbGlzdCwgaG93ZXZlciwgaXMgdHJhY2tlZCBoZXJlOgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIzNjcKKyAgICAgICAgCisgICAgICAgIFRoZSBv cmlnaW5hbCBjaGFuZ2VsaXN0cyBkaWQgbm90IGNvbWUgd2l0aCBsYXlvdXQgdGVzdHMsIGJ1dCBJ J20gYWRkaW5nCisgICAgICAgIGEgdGVzdCBvbiB0aGUgQ2hyb21pdW0gc2lkZSBmb3IgdGhpcy4K KworICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJG cmFtZUltcGw6OnNjb3BlU3RyaW5nTWF0Y2hlcyk6CisKIDIwMTEtMDEtMTIgIE1paGFpIFBhcnBh cml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQg TGV2aW4uCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCShyZXZpc2lvbiA3 NTcxMCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTUyLDcgKzE1Miw2IEBACiAjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2luY2x1ZGUg PHd0Zi9DdXJyZW50VGltZS5oPgogCi0KICNpZiBPUyhEQVJXSU4pCiAjaW5jbHVkZSAiTG9jYWxD dXJyZW50R3JhcGhpY3NDb250ZXh0LmgiCiAjZW5kaWYKQEAgLTE1MzQsNiArMTUzMyw5IEBAIHZv aWQgV2ViRnJhbWVJbXBsOjpzY29wZVN0cmluZ01hdGNoZXMoaW4KICAgICAgICAgfQogICAgIH0K IAorICAgIE5vZGUqIG9yaWdpbmFsRW5kQ29udGFpbmVyID0gc2VhcmNoUmFuZ2UtPmVuZENvbnRh aW5lcigpOworICAgIGludCBvcmlnaW5hbEVuZE9mZnNldCA9IHNlYXJjaFJhbmdlLT5lbmRPZmZz ZXQoKTsKKwogICAgIC8vIFRoaXMgdGltZW91dCBjb250cm9scyBob3cgbG9uZyB3ZSBzY29wZSBi ZWZvcmUgcmVsZWFzaW5nIGNvbnRyb2wuICBUaGlzCiAgICAgLy8gdmFsdWUgZG9lcyBub3QgcHJl dmVudCB1cyBmcm9tIHJ1bm5pbmcgZm9yIGxvbmdlciB0aGFuIHRoaXMsIGJ1dCBpdCBpcwogICAg IC8vIHBlcmlvZGljYWxseSBjaGVja2VkIHRvIHNlZSBpZiB3ZSBoYXZlIGV4Y2VlZGVkIG91ciBh bGxvY2F0ZWQgdGltZS4KQEAgLTE1NTYsMjkgKzE1NTgsMTYgQEAgdm9pZCBXZWJGcmFtZUltcGw6 OnNjb3BlU3RyaW5nTWF0Y2hlcyhpbgogICAgICAgICAgICAgaWYgKCFyZXN1bHRSYW5nZS0+c3Rh cnRDb250YWluZXIoKS0+aXNJblNoYWRvd1RyZWUoKSkKICAgICAgICAgICAgICAgICBicmVhazsK IAotICAgICAgICAgICAgc2VhcmNoUmFuZ2UgPSByYW5nZU9mQ29udGVudHMoZnJhbWUoKS0+ZG9j dW1lbnQoKSk7CiAgICAgICAgICAgICBzZWFyY2hSYW5nZS0+c2V0U3RhcnRBZnRlcigKICAgICAg ICAgICAgICAgICByZXN1bHRSYW5nZS0+c3RhcnRDb250YWluZXIoKS0+c2hhZG93QW5jZXN0b3JO b2RlKCksIGVjKTsKKyAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRFbmQob3JpZ2luYWxFbmRD b250YWluZXIsIG9yaWdpbmFsRW5kT2Zmc2V0LCBlYyk7CiAgICAgICAgICAgICBjb250aW51ZTsK ICAgICAgICAgfQogCi0gICAgICAgIC8vIEEgbm9uLWNvbGxhcHNlZCByZXN1bHQgcmFuZ2UgY2Fu IGluIHNvbWUgZnVua3kgd2hpdGVzcGFjZSBjYXNlcyBzdGlsbCBub3QKLSAgICAgICAgLy8gYWR2 YW5jZSB0aGUgcmFuZ2UncyBzdGFydCBwb3NpdGlvbiAoNDUwOTMyOCkuIEJyZWFrIHRvIGF2b2lk IGluZmluaXRlCi0gICAgICAgIC8vIGxvb3AuIChUaGlzIGZ1bmN0aW9uIGlzIGJhc2VkIG9uIHRo ZSBpbXBsZW1lbnRhdGlvbiBvZgotICAgICAgICAvLyBGcmFtZTo6bWFya0FsbE1hdGNoZXNGb3JU ZXh0LCB3aGljaCBpcyB3aGVyZSB0aGlzIHNhZmVndWFyZCBjb21lcyBmcm9tKS4KLSAgICAgICAg VmlzaWJsZVBvc2l0aW9uIG5ld1N0YXJ0ID0gZW5kVmlzaWJsZVBvc2l0aW9uKHJlc3VsdFJhbmdl LmdldCgpLCBET1dOU1RSRUFNKTsKLSAgICAgICAgaWYgKG5ld1N0YXJ0ID09IHN0YXJ0VmlzaWJs ZVBvc2l0aW9uKHNlYXJjaFJhbmdlLmdldCgpLCBET1dOU1RSRUFNKSkKLSAgICAgICAgICAgIGJy ZWFrOwotCiAgICAgICAgIC8vIE9ubHkgdHJlYXQgdGhlIHJlc3VsdCBhcyBhIG1hdGNoIGlmIGl0 IGlzIHZpc2libGUKICAgICAgICAgaWYgKGZyYW1lKCktPmVkaXRvcigpLT5pbnNpZGVWaXNpYmxl QXJlYShyZXN1bHRSYW5nZS5nZXQoKSkpIHsKICAgICAgICAgICAgICsrbWF0Y2hDb3VudDsKIAot ICAgICAgICAgICAgc2V0U3RhcnQoc2VhcmNoUmFuZ2UuZ2V0KCksIG5ld1N0YXJ0KTsKLSAgICAg ICAgICAgIE5vZGUqIHNoYWRvd1RyZWVSb290ID0gc2VhcmNoUmFuZ2UtPnNoYWRvd1RyZWVSb290 Tm9kZSgpOwotICAgICAgICAgICAgaWYgKHNlYXJjaFJhbmdlLT5jb2xsYXBzZWQoZWMpICYmIHNo YWRvd1RyZWVSb290KQotICAgICAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRFbmQoc2hhZG93 VHJlZVJvb3QsIHNoYWRvd1RyZWVSb290LT5jaGlsZE5vZGVDb3VudCgpLCBlYyk7Ci0KICAgICAg ICAgICAgIC8vIENhdGNoIGEgc3BlY2lhbCBjYXNlIHdoZXJlIEZpbmQgZm91bmQgc29tZXRoaW5n IGJ1dCBkb2Vzbid0IGtub3cgd2hhdAogICAgICAgICAgICAgLy8gdGhlIGJvdW5kaW5nIGJveCBm b3IgaXQgaXMuIEluIHRoaXMgY2FzZSB3ZSBzZXQgdGhlIGZpcnN0IG1hdGNoIHdlIGZpbmQKICAg ICAgICAgICAgIC8vIGFzIHRoZSBhY3RpdmUgcmVjdC4KQEAgLTE2MTUsNiArMTYwNCwxNiBAQCB2 b2lkIFdlYkZyYW1lSW1wbDo6c2NvcGVTdHJpbmdNYXRjaGVzKGluCiAgICAgICAgICAgICBhZGRN YXJrZXIocmVzdWx0UmFuZ2UuZ2V0KCksIGZvdW5kQWN0aXZlTWF0Y2gpOwogICAgICAgICB9CiAK KyAgICAgICAgLy8gU2V0IHRoZSBuZXcgc3RhcnQgZm9yIHRoZSBzZWFyY2ggcmFuZ2UgdG8gYmUg dGhlIGVuZCBvZiB0aGUgcHJldmlvdXMKKyAgICAgICAgLy8gcmVzdWx0IHJhbmdlLiBUaGVyZSBp cyBubyBuZWVkIHRvIHVzZSBhIFZpc2libGVQb3NpdGlvbiBoZXJlLAorICAgICAgICAvLyBzaW5j ZSBmaW5kUGxhaW5UZXh0IHdpbGwgdXNlIGEgVGV4dEl0ZXJhdG9yIHRvIGdvIG92ZXIgdGhlIHZp c2libGUKKyAgICAgICAgLy8gdGV4dCBub2Rlcy4gCisgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRT dGFydChyZXN1bHRSYW5nZS0+ZW5kQ29udGFpbmVyKGVjKSwgcmVzdWx0UmFuZ2UtPmVuZE9mZnNl dChlYyksIGVjKTsKKworICAgICAgICBOb2RlKiBzaGFkb3dUcmVlUm9vdCA9IHNlYXJjaFJhbmdl LT5zaGFkb3dUcmVlUm9vdE5vZGUoKTsKKyAgICAgICAgaWYgKHNlYXJjaFJhbmdlLT5jb2xsYXBz ZWQoZWMpICYmIHNoYWRvd1RyZWVSb290KQorICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldEVu ZChzaGFkb3dUcmVlUm9vdCwgc2hhZG93VHJlZVJvb3QtPmNoaWxkTm9kZUNvdW50KCksIGVjKTsK KwogICAgICAgICBtX3Jlc3VtZVNjb3BpbmdGcm9tUmFuZ2UgPSByZXN1bHRSYW5nZTsKICAgICAg ICAgdGltZWRPdXQgPSAoY3VycmVudFRpbWUoKSAtIHN0YXJ0VGltZSkgPj0gbWF4U2NvcGluZ0R1 cmF0aW9uOwogICAgIH0gd2hpbGUgKCF0aW1lZE91dCk7Cg== 78911 2011-01-14 01:52:13 -0800 2011-01-14 01:56:22 -0800 Same patch, with dummy reviewer line in ChangeLog (and svn up'ed) patch3 text/plain 5026 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzU3NzcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzQgQEAKKzIwMTEtMDEtMTQgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRyZXNzIHNvbWUgdXNlci1zZWxl Y3Qtbm9uZSBpc3N1ZXMgYmV0dGVyIGluIG91ciBGaW5kIGluIHBhZ2Ugc2NvcGluZworICAgICAg ICBmdW5jdGlvbi4KKworICAgICAgICBUaGUgc2NvcGluZyBmdW5jdGlvbiBpcyBpbiBwYXJ0IGJh c2VkIG9uIEVkaXRvcjo6Y291bnRNYXRjaGVzRm9yVGV4dAorICAgICAgICAoZm9ybWVybHkgRnJh bWU6Om1hcmtBbGxNYXRjaGVzRm9yVGV4dCksIGJ1dCB3YXMgcmV3cml0dGVuIHdpdGgKKyAgICAg ICAgYXN5Y2hyb25vdXMgc2VhcmNoIGFuZCBpbnRlcnJ1cHRhYmlsaXR5IGluIG1pbmQuIEF0IHRo ZSB0aW1lIHRoZQorICAgICAgICBmdW5jdGlvbiB3YXMgd3JpdHRlbiwgY291bnRNYXRjaGVzRm9y VGV4dCBkaWRuJ3Qgd29yayB3ZWxsIHdpdGgKKyAgICAgICAgdXNlci1zZWxlY3Qtbm9uZSBzdHls ZSBidXQgdGhhdCBoYXMgbm93IGNoYW5nZWQuIFdoaWxlCisgICAgICAgIGludmVzdGlnYXRpbmcg aHR0cDovL2NyYnVnLmNvbS82ODQ5NCBJIG5vdGljZWQgV2ViS2l0IGhhZCBmaXhlZCB0aGlzCisg ICAgICAgIHZlcnkgcHJvYmxlbSBpbiB0aGUgY291bnRNYXRjaGVzRm9yVGV4dCBhbmQgSSBiZWxp ZXZlIHdlIHNob3VsZCBtYWtlCisgICAgICAgIHRoZSBzYW1lIGNoYW5nZXMgaW4gb3VyIHBsYXRm b3JtIGNvZGUuIFRoZXJlZm9yZSwgdGhpcyBjaGFuZ2VsaXN0CisgICAgICAgIGFkb3B0cyB0aGUg c2FtZSBhcHByb2FjaCBieSBpbnRlZ3JhdGluZzoKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNTA4CisgICAgICAgIChyNTMxNDI6IGhhbmRsaW5nIHVz ZXItc2VsZWN0LW5vbmUgYmV0dGVyKSBhbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUxNjIzCisgICAgICAgIChyNzQ4ODY6IGhhbmRsaW5nIG1hdGNo IHdpdGhpbiB0ZXh0ZmllbGQgYmV0dGVyKS4KKyAgICAgICAgRm9yIG1vcmUgZGV0YWlscyBzZWUg dGhvc2UgY2hhbmdlbGlzdHMuCisKKyAgICAgICAgVGhpcyBjaGFuZ2VsaXN0LCBob3dldmVyLCBp cyB0cmFja2VkIGhlcmU6CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01MjM2NworCisgICAgICAgIFRoZSBvcmlnaW5hbCBjaGFuZ2VsaXN0cyBkaWQgbm90 IGNvbWUgd2l0aCBsYXlvdXQgdGVzdHMsIGJ1dCBJJ20gYWRkaW5nCisgICAgICAgIGEgdGVzdCBv biB0aGUgQ2hyb21pdW0gc2lkZSBmb3IgdGhpcy4KKworICAgICAgICAqIHNyYy9XZWJGcmFtZUlt cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OnNjb3BlU3RyaW5nTWF0Y2hl cyk6CisKIDIwMTEtMDEtMTMgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBNaWhhaSBQYXJwYXJpdGEuCkluZGV4OiBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJGcmFtZUltcGwuY3BwCShyZXZpc2lvbiA3NTc3NykKKysrIFdlYktpdC9jaHJvbWl1 bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU0LDcgKzE1NCw2IEBA CiAjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgogCi0K ICNpZiBPUyhEQVJXSU4pCiAjaW5jbHVkZSAiTG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0Lmgi CiAjZW5kaWYKQEAgLTE1NDEsNiArMTU0MCw5IEBAIHZvaWQgV2ViRnJhbWVJbXBsOjpzY29wZVN0 cmluZ01hdGNoZXMoaW4KICAgICAgICAgfQogICAgIH0KIAorICAgIE5vZGUqIG9yaWdpbmFsRW5k Q29udGFpbmVyID0gc2VhcmNoUmFuZ2UtPmVuZENvbnRhaW5lcigpOworICAgIGludCBvcmlnaW5h bEVuZE9mZnNldCA9IHNlYXJjaFJhbmdlLT5lbmRPZmZzZXQoKTsKKwogICAgIC8vIFRoaXMgdGlt ZW91dCBjb250cm9scyBob3cgbG9uZyB3ZSBzY29wZSBiZWZvcmUgcmVsZWFzaW5nIGNvbnRyb2wu ICBUaGlzCiAgICAgLy8gdmFsdWUgZG9lcyBub3QgcHJldmVudCB1cyBmcm9tIHJ1bm5pbmcgZm9y IGxvbmdlciB0aGFuIHRoaXMsIGJ1dCBpdCBpcwogICAgIC8vIHBlcmlvZGljYWxseSBjaGVja2Vk IHRvIHNlZSBpZiB3ZSBoYXZlIGV4Y2VlZGVkIG91ciBhbGxvY2F0ZWQgdGltZS4KQEAgLTE1NjMs MjkgKzE1NjUsMTYgQEAgdm9pZCBXZWJGcmFtZUltcGw6OnNjb3BlU3RyaW5nTWF0Y2hlcyhpbgog ICAgICAgICAgICAgaWYgKCFyZXN1bHRSYW5nZS0+c3RhcnRDb250YWluZXIoKS0+aXNJblNoYWRv d1RyZWUoKSkKICAgICAgICAgICAgICAgICBicmVhazsKIAotICAgICAgICAgICAgc2VhcmNoUmFu Z2UgPSByYW5nZU9mQ29udGVudHMoZnJhbWUoKS0+ZG9jdW1lbnQoKSk7CiAgICAgICAgICAgICBz ZWFyY2hSYW5nZS0+c2V0U3RhcnRBZnRlcigKICAgICAgICAgICAgICAgICByZXN1bHRSYW5nZS0+ c3RhcnRDb250YWluZXIoKS0+c2hhZG93QW5jZXN0b3JOb2RlKCksIGVjKTsKKyAgICAgICAgICAg IHNlYXJjaFJhbmdlLT5zZXRFbmQob3JpZ2luYWxFbmRDb250YWluZXIsIG9yaWdpbmFsRW5kT2Zm c2V0LCBlYyk7CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQogCi0gICAgICAgIC8v IEEgbm9uLWNvbGxhcHNlZCByZXN1bHQgcmFuZ2UgY2FuIGluIHNvbWUgZnVua3kgd2hpdGVzcGFj ZSBjYXNlcyBzdGlsbCBub3QKLSAgICAgICAgLy8gYWR2YW5jZSB0aGUgcmFuZ2UncyBzdGFydCBw b3NpdGlvbiAoNDUwOTMyOCkuIEJyZWFrIHRvIGF2b2lkIGluZmluaXRlCi0gICAgICAgIC8vIGxv b3AuIChUaGlzIGZ1bmN0aW9uIGlzIGJhc2VkIG9uIHRoZSBpbXBsZW1lbnRhdGlvbiBvZgotICAg ICAgICAvLyBGcmFtZTo6bWFya0FsbE1hdGNoZXNGb3JUZXh0LCB3aGljaCBpcyB3aGVyZSB0aGlz IHNhZmVndWFyZCBjb21lcyBmcm9tKS4KLSAgICAgICAgVmlzaWJsZVBvc2l0aW9uIG5ld1N0YXJ0 ID0gZW5kVmlzaWJsZVBvc2l0aW9uKHJlc3VsdFJhbmdlLmdldCgpLCBET1dOU1RSRUFNKTsKLSAg ICAgICAgaWYgKG5ld1N0YXJ0ID09IHN0YXJ0VmlzaWJsZVBvc2l0aW9uKHNlYXJjaFJhbmdlLmdl dCgpLCBET1dOU1RSRUFNKSkKLSAgICAgICAgICAgIGJyZWFrOwotCiAgICAgICAgIC8vIE9ubHkg dHJlYXQgdGhlIHJlc3VsdCBhcyBhIG1hdGNoIGlmIGl0IGlzIHZpc2libGUKICAgICAgICAgaWYg KGZyYW1lKCktPmVkaXRvcigpLT5pbnNpZGVWaXNpYmxlQXJlYShyZXN1bHRSYW5nZS5nZXQoKSkp IHsKICAgICAgICAgICAgICsrbWF0Y2hDb3VudDsKIAotICAgICAgICAgICAgc2V0U3RhcnQoc2Vh cmNoUmFuZ2UuZ2V0KCksIG5ld1N0YXJ0KTsKLSAgICAgICAgICAgIE5vZGUqIHNoYWRvd1RyZWVS b290ID0gc2VhcmNoUmFuZ2UtPnNoYWRvd1RyZWVSb290Tm9kZSgpOwotICAgICAgICAgICAgaWYg KHNlYXJjaFJhbmdlLT5jb2xsYXBzZWQoZWMpICYmIHNoYWRvd1RyZWVSb290KQotICAgICAgICAg ICAgICAgIHNlYXJjaFJhbmdlLT5zZXRFbmQoc2hhZG93VHJlZVJvb3QsIHNoYWRvd1RyZWVSb290 LT5jaGlsZE5vZGVDb3VudCgpLCBlYyk7Ci0KICAgICAgICAgICAgIC8vIENhdGNoIGEgc3BlY2lh bCBjYXNlIHdoZXJlIEZpbmQgZm91bmQgc29tZXRoaW5nIGJ1dCBkb2Vzbid0IGtub3cgd2hhdAog ICAgICAgICAgICAgLy8gdGhlIGJvdW5kaW5nIGJveCBmb3IgaXQgaXMuIEluIHRoaXMgY2FzZSB3 ZSBzZXQgdGhlIGZpcnN0IG1hdGNoIHdlIGZpbmQKICAgICAgICAgICAgIC8vIGFzIHRoZSBhY3Rp dmUgcmVjdC4KQEAgLTE2MjIsNiArMTYxMSwxNiBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6c2NvcGVT dHJpbmdNYXRjaGVzKGluCiAgICAgICAgICAgICBhZGRNYXJrZXIocmVzdWx0UmFuZ2UuZ2V0KCks IGZvdW5kQWN0aXZlTWF0Y2gpOwogICAgICAgICB9CiAKKyAgICAgICAgLy8gU2V0IHRoZSBuZXcg c3RhcnQgZm9yIHRoZSBzZWFyY2ggcmFuZ2UgdG8gYmUgdGhlIGVuZCBvZiB0aGUgcHJldmlvdXMK KyAgICAgICAgLy8gcmVzdWx0IHJhbmdlLiBUaGVyZSBpcyBubyBuZWVkIHRvIHVzZSBhIFZpc2li bGVQb3NpdGlvbiBoZXJlLAorICAgICAgICAvLyBzaW5jZSBmaW5kUGxhaW5UZXh0IHdpbGwgdXNl IGEgVGV4dEl0ZXJhdG9yIHRvIGdvIG92ZXIgdGhlIHZpc2libGUKKyAgICAgICAgLy8gdGV4dCBu b2Rlcy4gCisgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRTdGFydChyZXN1bHRSYW5nZS0+ZW5kQ29u dGFpbmVyKGVjKSwgcmVzdWx0UmFuZ2UtPmVuZE9mZnNldChlYyksIGVjKTsKKworICAgICAgICBO b2RlKiBzaGFkb3dUcmVlUm9vdCA9IHNlYXJjaFJhbmdlLT5zaGFkb3dUcmVlUm9vdE5vZGUoKTsK KyAgICAgICAgaWYgKHNlYXJjaFJhbmdlLT5jb2xsYXBzZWQoZWMpICYmIHNoYWRvd1RyZWVSb290 KQorICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldEVuZChzaGFkb3dUcmVlUm9vdCwgc2hhZG93 VHJlZVJvb3QtPmNoaWxkTm9kZUNvdW50KCksIGVjKTsKKwogICAgICAgICBtX3Jlc3VtZVNjb3Bp bmdGcm9tUmFuZ2UgPSByZXN1bHRSYW5nZTsKICAgICAgICAgdGltZWRPdXQgPSAoY3VycmVudFRp bWUoKSAtIHN0YXJ0VGltZSkgPj0gbWF4U2NvcGluZ0R1cmF0aW9uOwogICAgIH0gd2hpbGUgKCF0 aW1lZE91dCk7Cg== 78912 2011-01-14 02:00:16 -0800 2011-01-14 02:25:04 -0800 Previously reviewed, just missing reviewer line. patch5 text/plain 5022 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzU3NzcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzQgQEAKKzIwMTEtMDEtMTQgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBPamFuIFZhZmFpLgorCisgICAgICAgIEFkZHJlc3Mgc29tZSB1c2VyLXNlbGVjdC1u b25lIGlzc3VlcyBiZXR0ZXIgaW4gb3VyIEZpbmQgaW4gcGFnZSBzY29waW5nCisgICAgICAgIGZ1 bmN0aW9uLgorCisgICAgICAgIFRoZSBzY29waW5nIGZ1bmN0aW9uIGlzIGluIHBhcnQgYmFzZWQg b24gRWRpdG9yOjpjb3VudE1hdGNoZXNGb3JUZXh0CisgICAgICAgIChmb3JtZXJseSBGcmFtZTo6 bWFya0FsbE1hdGNoZXNGb3JUZXh0KSwgYnV0IHdhcyByZXdyaXR0ZW4gd2l0aAorICAgICAgICBh c3ljaHJvbm91cyBzZWFyY2ggYW5kIGludGVycnVwdGFiaWxpdHkgaW4gbWluZC4gQXQgdGhlIHRp bWUgdGhlCisgICAgICAgIGZ1bmN0aW9uIHdhcyB3cml0dGVuLCBjb3VudE1hdGNoZXNGb3JUZXh0 IGRpZG4ndCB3b3JrIHdlbGwgd2l0aAorICAgICAgICB1c2VyLXNlbGVjdC1ub25lIHN0eWxlIGJ1 dCB0aGF0IGhhcyBub3cgY2hhbmdlZC4gV2hpbGUKKyAgICAgICAgaW52ZXN0aWdhdGluZyBodHRw Oi8vY3JidWcuY29tLzY4NDk0IEkgbm90aWNlZCBXZWJLaXQgaGFkIGZpeGVkIHRoaXMKKyAgICAg ICAgdmVyeSBwcm9ibGVtIGluIHRoZSBjb3VudE1hdGNoZXNGb3JUZXh0IGFuZCBJIGJlbGlldmUg d2Ugc2hvdWxkIG1ha2UKKyAgICAgICAgdGhlIHNhbWUgY2hhbmdlcyBpbiBvdXIgcGxhdGZvcm0g Y29kZS4gVGhlcmVmb3JlLCB0aGlzIGNoYW5nZWxpc3QKKyAgICAgICAgYWRvcHRzIHRoZSBzYW1l IGFwcHJvYWNoIGJ5IGludGVncmF0aW5nOgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzM1MDgKKyAgICAgICAgKHI1MzE0MjogaGFuZGxpbmcgdXNlci1z ZWxlY3Qtbm9uZSBiZXR0ZXIpIGFuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTE2MjMKKyAgICAgICAgKHI3NDg4NjogaGFuZGxpbmcgbWF0Y2ggd2l0 aGluIHRleHRmaWVsZCBiZXR0ZXIpLgorICAgICAgICBGb3IgbW9yZSBkZXRhaWxzIHNlZSB0aG9z ZSBjaGFuZ2VsaXN0cy4KKworICAgICAgICBUaGlzIGNoYW5nZWxpc3QsIGhvd2V2ZXIsIGlzIHRy YWNrZWQgaGVyZToKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUyMzY3CisKKyAgICAgICAgVGhlIG9yaWdpbmFsIGNoYW5nZWxpc3RzIGRpZCBub3QgY29t ZSB3aXRoIGxheW91dCB0ZXN0cywgYnV0IEknbSBhZGRpbmcKKyAgICAgICAgYSB0ZXN0IG9uIHRo ZSBDaHJvbWl1bSBzaWRlIGZvciB0aGlzLgorCisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6c2NvcGVTdHJpbmdNYXRjaGVzKToK KwogMjAxMS0wMS0xMyAgSm9obiBBYmQtRWwtTWFsZWsgIDxqYW1AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1paGFpIFBhcnBhcml0YS4KSW5kZXg6IFdlYktpdC9jaHJvbWl1 bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDc1Nzc3KQorKysgV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTQsNyArMTU0LDYgQEAKICNp bmNsdWRlIDxhbGdvcml0aG0+CiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAKLQogI2lm IE9TKERBUldJTikKICNpbmNsdWRlICJMb2NhbEN1cnJlbnRHcmFwaGljc0NvbnRleHQuaCIKICNl bmRpZgpAQCAtMTU0MSw2ICsxNTQwLDkgQEAgdm9pZCBXZWJGcmFtZUltcGw6OnNjb3BlU3RyaW5n TWF0Y2hlcyhpbgogICAgICAgICB9CiAgICAgfQogCisgICAgTm9kZSogb3JpZ2luYWxFbmRDb250 YWluZXIgPSBzZWFyY2hSYW5nZS0+ZW5kQ29udGFpbmVyKCk7CisgICAgaW50IG9yaWdpbmFsRW5k T2Zmc2V0ID0gc2VhcmNoUmFuZ2UtPmVuZE9mZnNldCgpOworCiAgICAgLy8gVGhpcyB0aW1lb3V0 IGNvbnRyb2xzIGhvdyBsb25nIHdlIHNjb3BlIGJlZm9yZSByZWxlYXNpbmcgY29udHJvbC4gIFRo aXMKICAgICAvLyB2YWx1ZSBkb2VzIG5vdCBwcmV2ZW50IHVzIGZyb20gcnVubmluZyBmb3IgbG9u Z2VyIHRoYW4gdGhpcywgYnV0IGl0IGlzCiAgICAgLy8gcGVyaW9kaWNhbGx5IGNoZWNrZWQgdG8g c2VlIGlmIHdlIGhhdmUgZXhjZWVkZWQgb3VyIGFsbG9jYXRlZCB0aW1lLgpAQCAtMTU2MywyOSAr MTU2NSwxNiBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6c2NvcGVTdHJpbmdNYXRjaGVzKGluCiAgICAg ICAgICAgICBpZiAoIXJlc3VsdFJhbmdlLT5zdGFydENvbnRhaW5lcigpLT5pc0luU2hhZG93VHJl ZSgpKQogICAgICAgICAgICAgICAgIGJyZWFrOwogCi0gICAgICAgICAgICBzZWFyY2hSYW5nZSA9 IHJhbmdlT2ZDb250ZW50cyhmcmFtZSgpLT5kb2N1bWVudCgpKTsKICAgICAgICAgICAgIHNlYXJj aFJhbmdlLT5zZXRTdGFydEFmdGVyKAogICAgICAgICAgICAgICAgIHJlc3VsdFJhbmdlLT5zdGFy dENvbnRhaW5lcigpLT5zaGFkb3dBbmNlc3Rvck5vZGUoKSwgZWMpOworICAgICAgICAgICAgc2Vh cmNoUmFuZ2UtPnNldEVuZChvcmlnaW5hbEVuZENvbnRhaW5lciwgb3JpZ2luYWxFbmRPZmZzZXQs IGVjKTsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9CiAKLSAgICAgICAgLy8gQSBu b24tY29sbGFwc2VkIHJlc3VsdCByYW5nZSBjYW4gaW4gc29tZSBmdW5reSB3aGl0ZXNwYWNlIGNh c2VzIHN0aWxsIG5vdAotICAgICAgICAvLyBhZHZhbmNlIHRoZSByYW5nZSdzIHN0YXJ0IHBvc2l0 aW9uICg0NTA5MzI4KS4gQnJlYWsgdG8gYXZvaWQgaW5maW5pdGUKLSAgICAgICAgLy8gbG9vcC4g KFRoaXMgZnVuY3Rpb24gaXMgYmFzZWQgb24gdGhlIGltcGxlbWVudGF0aW9uIG9mCi0gICAgICAg IC8vIEZyYW1lOjptYXJrQWxsTWF0Y2hlc0ZvclRleHQsIHdoaWNoIGlzIHdoZXJlIHRoaXMgc2Fm ZWd1YXJkIGNvbWVzIGZyb20pLgotICAgICAgICBWaXNpYmxlUG9zaXRpb24gbmV3U3RhcnQgPSBl bmRWaXNpYmxlUG9zaXRpb24ocmVzdWx0UmFuZ2UuZ2V0KCksIERPV05TVFJFQU0pOwotICAgICAg ICBpZiAobmV3U3RhcnQgPT0gc3RhcnRWaXNpYmxlUG9zaXRpb24oc2VhcmNoUmFuZ2UuZ2V0KCks IERPV05TVFJFQU0pKQotICAgICAgICAgICAgYnJlYWs7Ci0KICAgICAgICAgLy8gT25seSB0cmVh dCB0aGUgcmVzdWx0IGFzIGEgbWF0Y2ggaWYgaXQgaXMgdmlzaWJsZQogICAgICAgICBpZiAoZnJh bWUoKS0+ZWRpdG9yKCktPmluc2lkZVZpc2libGVBcmVhKHJlc3VsdFJhbmdlLmdldCgpKSkgewog ICAgICAgICAgICAgKyttYXRjaENvdW50OwogCi0gICAgICAgICAgICBzZXRTdGFydChzZWFyY2hS YW5nZS5nZXQoKSwgbmV3U3RhcnQpOwotICAgICAgICAgICAgTm9kZSogc2hhZG93VHJlZVJvb3Qg PSBzZWFyY2hSYW5nZS0+c2hhZG93VHJlZVJvb3ROb2RlKCk7Ci0gICAgICAgICAgICBpZiAoc2Vh cmNoUmFuZ2UtPmNvbGxhcHNlZChlYykgJiYgc2hhZG93VHJlZVJvb3QpCi0gICAgICAgICAgICAg ICAgc2VhcmNoUmFuZ2UtPnNldEVuZChzaGFkb3dUcmVlUm9vdCwgc2hhZG93VHJlZVJvb3QtPmNo aWxkTm9kZUNvdW50KCksIGVjKTsKLQogICAgICAgICAgICAgLy8gQ2F0Y2ggYSBzcGVjaWFsIGNh c2Ugd2hlcmUgRmluZCBmb3VuZCBzb21ldGhpbmcgYnV0IGRvZXNuJ3Qga25vdyB3aGF0CiAgICAg ICAgICAgICAvLyB0aGUgYm91bmRpbmcgYm94IGZvciBpdCBpcy4gSW4gdGhpcyBjYXNlIHdlIHNl dCB0aGUgZmlyc3QgbWF0Y2ggd2UgZmluZAogICAgICAgICAgICAgLy8gYXMgdGhlIGFjdGl2ZSBy ZWN0LgpAQCAtMTYyMiw2ICsxNjExLDE2IEBAIHZvaWQgV2ViRnJhbWVJbXBsOjpzY29wZVN0cmlu Z01hdGNoZXMoaW4KICAgICAgICAgICAgIGFkZE1hcmtlcihyZXN1bHRSYW5nZS5nZXQoKSwgZm91 bmRBY3RpdmVNYXRjaCk7CiAgICAgICAgIH0KIAorICAgICAgICAvLyBTZXQgdGhlIG5ldyBzdGFy dCBmb3IgdGhlIHNlYXJjaCByYW5nZSB0byBiZSB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cworICAg ICAgICAvLyByZXN1bHQgcmFuZ2UuIFRoZXJlIGlzIG5vIG5lZWQgdG8gdXNlIGEgVmlzaWJsZVBv c2l0aW9uIGhlcmUsCisgICAgICAgIC8vIHNpbmNlIGZpbmRQbGFpblRleHQgd2lsbCB1c2UgYSBU ZXh0SXRlcmF0b3IgdG8gZ28gb3ZlciB0aGUgdmlzaWJsZQorICAgICAgICAvLyB0ZXh0IG5vZGVz LiAKKyAgICAgICAgc2VhcmNoUmFuZ2UtPnNldFN0YXJ0KHJlc3VsdFJhbmdlLT5lbmRDb250YWlu ZXIoZWMpLCByZXN1bHRSYW5nZS0+ZW5kT2Zmc2V0KGVjKSwgZWMpOworCisgICAgICAgIE5vZGUq IHNoYWRvd1RyZWVSb290ID0gc2VhcmNoUmFuZ2UtPnNoYWRvd1RyZWVSb290Tm9kZSgpOworICAg ICAgICBpZiAoc2VhcmNoUmFuZ2UtPmNvbGxhcHNlZChlYykgJiYgc2hhZG93VHJlZVJvb3QpCisg ICAgICAgICAgICBzZWFyY2hSYW5nZS0+c2V0RW5kKHNoYWRvd1RyZWVSb290LCBzaGFkb3dUcmVl Um9vdC0+Y2hpbGROb2RlQ291bnQoKSwgZWMpOworCiAgICAgICAgIG1fcmVzdW1lU2NvcGluZ0Zy b21SYW5nZSA9IHJlc3VsdFJhbmdlOwogICAgICAgICB0aW1lZE91dCA9IChjdXJyZW50VGltZSgp IC0gc3RhcnRUaW1lKSA+PSBtYXhTY29waW5nRHVyYXRpb247CiAgICAgfSB3aGlsZSAoIXRpbWVk T3V0KTsK