52364 2011-01-13 05:28:17 -0800 Make old-run-webkit-tests more robust on buildbots 2011-01-13 13:11:42 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ossy webkit-unassigned abarth aroben commit-queue eric levin mjs webkit.review.bot wsiegrist oldest_to_newest 333644 0 ossy 2011-01-13 05:28:17 -0800 Maciej committed a debug print accidentally (http://trac.webkit.org/changeset/75682) and it made all layout tests fail and buildbots sick. The size of results for ~22000 failing layout tests is more than 100Mb. I propose some changes to avoid overloading buildbot slaves and master: 1.) add --exit-after-n-failures 500 option to the old-run-webkit-tests It is enough for online rebaselineing and avoiding 100Mb sizes results 2.) old-run-webkit-tests should remove results directory before testing (Now test-result-archive does it after zipping. But if it is terminated or killed, the results directory will contain some mess.) Patches are coming soon. 333646 1 78798 ossy 2011-01-13 05:31:05 -0800 Created attachment 78798 old-run-webkit-tests fix 333647 2 78799 ossy 2011-01-13 05:36:15 -0800 Created attachment 78799 exit-after-n-failures 500 patch 333733 3 78798 darin 2011-01-13 09:14:23 -0800 Comment on attachment 78798 old-run-webkit-tests fix Seems OK. As long as rmtree is available in all the versions of perl we support, and error handling works. I’ll be optimistic. 333734 4 78799 darin 2011-01-13 09:15:12 -0800 Comment on attachment 78799 exit-after-n-failures 500 patch View in context: https://bugs.webkit.org/attachment.cgi?id=78799&action=review Not great to attach two patches to the same bug. > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:196 > + WithProperties("--%(configuration)s"), "--exit-after-n-crashes-or-timeouts", "20", "--exit-after-n-failures", "500"] Would be slightly better to have a comment explaining the reason for this. There’s also an extra space after the comma. 333770 5 78798 commit-queue 2011-01-13 10:23:15 -0800 Comment on attachment 78798 old-run-webkit-tests fix Clearing flags on attachment: 78798 Committed r75721: <http://trac.webkit.org/changeset/75721> 333786 6 78799 commit-queue 2011-01-13 10:37:49 -0800 Comment on attachment 78799 exit-after-n-failures 500 patch Clearing flags on attachment: 78799 Committed r75726: <http://trac.webkit.org/changeset/75726> 333787 7 commit-queue 2011-01-13 10:37:55 -0800 All reviewed patches have been landed. Closing bug. 333902 8 webkit.review.bot 2011-01-13 13:11:42 -0800 http://trac.webkit.org/changeset/75726 might have broken Leopard Intel Release (Tests) 78798 2011-01-13 05:31:05 -0800 2011-01-13 10:23:15 -0800 old-run-webkit-tests fix 1.patch text/plain 1191 ossy SW5kZXg6IFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwkocmV2aXNpb24gNzU3MDYpCisrKyBU b29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC00NDgs NiArNDQ4LDggQEAKICRleHBlY3RlZERpcmVjdG9yeSA9ICRFTlZ7IldlYktpdEV4cGVjdGVkVGVz dFJlc3VsdHNEaXJlY3RvcnkifSBpZiAkRU5WeyJXZWJLaXRFeHBlY3RlZFRlc3RSZXN1bHRzRGly ZWN0b3J5In07CiAKICR0ZXN0UmVzdWx0c0RpcmVjdG9yeSA9IEZpbGU6OlNwZWMtPnJlbDJhYnMo JHRlc3RSZXN1bHRzRGlyZWN0b3J5KTsKKyMgJHRlc3RSZXN1bHRzRGlyZWN0b3J5IG11c3QgYmUg ZW1wdHkgYmVmb3JlIHRlc3RpbmcuCitybXRyZWUgJHRlc3RSZXN1bHRzRGlyZWN0b3J5OwogbXkg JHRlc3RSZXN1bHRzID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkdGVzdFJlc3VsdHNEaXJlY3Rvcnks ICJyZXN1bHRzLmh0bWwiKTsKIAogaWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgewpJbmRleDogVG9v bHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNzU3 MDYpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAor MjAxMS0wMS0xMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugb2xkLXJ1bi13 ZWJraXQtdGVzdHMgbW9yZSByb2J1c3Qgb24gYnVpbGRib3RzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjM2NAorCisgICAgICAgICogU2NyaXB0cy9v bGQtcnVuLXdlYmtpdC10ZXN0czogRW5zdXJlIHRoYXQgdGVzdFJlc3VsdHNEaXJlY3RvcnkgaXMg ZW1wdHkuCisKIDIwMTEtMDEtMTMgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3NDg4MS4K 78799 2011-01-13 05:36:15 -0800 2011-01-13 10:37:49 -0800 exit-after-n-failures 500 patch 1.patch text/plain 1528 ossy SW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21h c3Rlci5jZmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwkocmV2aXNpb24gNzU3MDYpCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCSh3b3JraW5n IGNvcHkpCkBAIC0xOTMsNyArMTkzLDcgQEAKICAgICBkZXNjcmlwdGlvbkRvbmUgPSBbImxheW91 dC10ZXN0cyJdCiAgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xzL1NjcmlwdHMvcnVuLXdl YmtpdC10ZXN0cyIsICItLW5vLWxhdW5jaC1zYWZhcmkiLCAiLS1uby1uZXctdGVzdC1yZXN1bHRz IiwKICAgICAgICAgICAgICAgICItLW5vLXNhbXBsZS1vbi10aW1lb3V0IiwgIi0tcmVzdWx0cy1k aXJlY3RvcnkiLCAibGF5b3V0LXRlc3QtcmVzdWx0cyIsICItLXVzZS1yZW1vdGUtbGlua3MtdG8t dGVzdHMiLAotICAgICAgICAgICAgICAgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9u KXMiKSwgIi0tZXhpdC1hZnRlci1uLWNyYXNoZXMtb3ItdGltZW91dHMiLCAiMjAiXQorICAgICAg ICAgICAgICAgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKSwgIi0tZXhpdC1h ZnRlci1uLWNyYXNoZXMtb3ItdGltZW91dHMiLCAiMjAiLCAgIi0tZXhpdC1hZnRlci1uLWZhaWx1 cmVzIiwgIjUwMCJdCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgc2tpcEJ1aWxkPUZhbHNlLCAq YXJncywgKiprd2FyZ3MpOgogICAgICAgICBzZWxmLnNraXBCdWlsZCA9IHNraXBCdWlsZApJbmRl eDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNp b24gNzU3MTApCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MiBAQAorMjAxMS0wMS0xMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugb2xk LXJ1bi13ZWJraXQtdGVzdHMgbW9yZSByb2J1c3Qgb24gYnVpbGRib3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjM2NAorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzogUGFzcyAt LWV4aXQtYWZ0ZXItbi1mYWlsdXJlcyA1MDAgdG8gb2xkLXJ1bi13ZWJraXQtdGVzdHMgc2NyaXB0 LgorCiAyMDExLTAxLTEzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzQ4ODEuCg==