52361 2011-01-13 01:25:17 -0800 [GTK] Paint toggle buttons inconsistent when the object state is indeterminate 2011-01-13 04:08:33 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mrobinson webkit.review.bot oldest_to_newest 333587 0 cgarcia 2011-01-13 01:25:17 -0800 In gtk3 code we never set the flag GTK_STATE_FLAG_INCONSISTENT when rendering check and radio buttons. 333589 1 78785 cgarcia 2011-01-13 01:30:57 -0800 Created attachment 78785 Check whether the object state is indeterminate It also removes an unused variable and moves the code to get the indicator spacing to the isFocused() block since we only need the indicator spacing when the object is focused to inflate the rectangle. 333611 2 webkit.review.bot 2011-01-13 02:54:09 -0800 Attachment 78785 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:227: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 333638 3 78785 xan.lopez 2011-01-13 04:01:32 -0800 Comment on attachment 78785 Check whether the object state is indeterminate r=me 333641 4 cgarcia 2011-01-13 04:07:47 -0800 Committed r75710: <http://trac.webkit.org/changeset/75710> 78785 2011-01-13 01:30:57 -0800 2011-01-13 04:08:33 -0800 Check whether the object state is indeterminate buttons-inconsistent.diff text/plain 3008 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOTE1YWM3Li5hMjJlODgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDEtMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IFBhaW50IHRvZ2dsZSBidXR0b25zIGluY29uc2lzdGVudCB3aGVuIHRoZSBvYmplY3Qgc3RhdGUg aXMgaW5kZXRlcm1pbmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTIzNjEKKworICAgICAgICBDaGVjayB3aGV0aGVyIHRoZSBvYmplY3Qgc3RhdGUg aXMgaW5kZXRlcm1pbmF0ZSB0byBzZXQgdGhlIGZsYWcKKyAgICAgICAgR1RLX1NUQVRFX0ZMQUdf SU5DT05TSVNURU5UIGJlZm9yZSByZW5kZXJpbmcgY2hlY2sgYW5kIHJhZGlvCisgICAgICAgIGJ1 dHRvbnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OnBhaW50VG9nZ2xlKToKKwogMjAxMS0wMS0xMiAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHAKaW5k ZXggZWUyYTM3Zi4uYzJmY2ZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL1JlbmRlclRoZW1lR3RrMy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L1JlbmRlclRoZW1lR3RrMy5jcHAKQEAgLTIwMywyNSArMjAzLDE5IEBAIHN0YXRpYyB2b2lkIHBh aW50VG9nZ2xlKGNvbnN0IFJlbmRlclRoZW1lR3RrKiB0aGVtZSwgR1R5cGUgd2lkZ2V0VHlwZSwg UmVuZGVyT2JqCiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfc2V0X2RpcmVjdGlvbihjb250ZXh0LCBz dGF0aWNfY2FzdDxHdGtUZXh0RGlyZWN0aW9uPihndGtUZXh0RGlyZWN0aW9uKHJlbmRlck9iamVj dC0+c3R5bGUoKS0+ZGlyZWN0aW9uKCkpKSk7CiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfYWRkX2Ns YXNzKGNvbnRleHQsIHdpZGdldFR5cGUgPT0gR1RLX1RZUEVfQ0hFQ0tfQlVUVE9OID8gR1RLX1NU WUxFX0NMQVNTX0NIRUNLIDogR1RLX1NUWUxFX0NMQVNTX1JBRElPKTsKIAotICAgIGdpbnQgaW5k aWNhdG9yU2l6ZSwgaW5kaWNhdG9yU3BhY2luZzsKLSAgICBndGtfc3R5bGVfY29udGV4dF9nZXRf c3R5bGUoY29udGV4dCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImluZGljYXRv ci1zaXplIiwgJmluZGljYXRvclNpemUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJpbmRpY2F0b3Itc3BhY2luZyIsICZpbmRpY2F0b3JTcGFjaW5nLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBOVUxMKTsKLQogICAgIGd1aW50IGZsYWdzID0gMDsKICAgICBpZiAo IXRoZW1lLT5pc0VuYWJsZWQocmVuZGVyT2JqZWN0KSB8fCB0aGVtZS0+aXNSZWFkT25seUNvbnRy b2wocmVuZGVyT2JqZWN0KSkKICAgICAgICAgZmxhZ3MgfD0gR1RLX1NUQVRFX0ZMQUdfSU5TRU5T SVRJVkU7CiAgICAgZWxzZSBpZiAodGhlbWUtPmlzSG92ZXJlZChyZW5kZXJPYmplY3QpKQogICAg ICAgICBmbGFncyB8PSBHVEtfU1RBVEVfRkxBR19QUkVMSUdIVDsKLSAgICBpZiAodGhlbWUtPmlz Q2hlY2tlZChyZW5kZXJPYmplY3QpKQorICAgIGlmICh0aGVtZS0+aXNJbmRldGVybWluYXRlKHJl bmRlck9iamVjdCkpCisgICAgICAgIGZsYWdzIHw9IEdUS19TVEFURV9GTEFHX0lOQ09OU0lTVEVO VDsKKyAgICBlbHNlIGlmICh0aGVtZS0+aXNDaGVja2VkKHJlbmRlck9iamVjdCkpCiAgICAgICAg IGZsYWdzIHw9IEdUS19TVEFURV9GTEFHX0FDVElWRTsKICAgICBpZiAodGhlbWUtPmlzUHJlc3Nl ZChyZW5kZXJPYmplY3QpKQogICAgICAgICBmbGFncyB8PSBHVEtfU1RBVEVfRkxBR19TRUxFQ1RF RDsKICAgICBndGtfc3R5bGVfY29udGV4dF9zZXRfc3RhdGUoY29udGV4dCwgc3RhdGljX2Nhc3Q8 R3RrU3RhdGVGbGFncz4oZmxhZ3MpKTsKIAotICAgIEludFJlY3QgaW5kaWNhdG9yUmVjdChyZWN0 KTsKLQogICAgIGlmICh3aWRnZXRUeXBlID09IEdUS19UWVBFX0NIRUNLX0JVVFRPTikKICAgICAg ICAgZ3RrX3JlbmRlcl9jaGVjayhjb250ZXh0LCBwYWludEluZm8uY29udGV4dC0+cGxhdGZvcm1D b250ZXh0KCksIHJlY3QueCgpLCByZWN0LnkoKSwgcmVjdC53aWR0aCgpLCByZWN0LmhlaWdodCgp KTsKICAgICBlbHNlCkBAIC0yMjksNiArMjIzLDggQEAgc3RhdGljIHZvaWQgcGFpbnRUb2dnbGUo Y29uc3QgUmVuZGVyVGhlbWVHdGsqIHRoZW1lLCBHVHlwZSB3aWRnZXRUeXBlLCBSZW5kZXJPYmoK IAogICAgIGlmICh0aGVtZS0+aXNGb2N1c2VkKHJlbmRlck9iamVjdCkpIHsKICAgICAgICAgSW50 UmVjdCBpbmRpY2F0b3JSZWN0KHJlY3QpOworICAgICAgICBnaW50IGluZGljYXRvclNwYWNpbmc7 CisgICAgICAgIGd0a19zdHlsZV9jb250ZXh0X2dldF9zdHlsZShjb250ZXh0LCAiaW5kaWNhdG9y LXNwYWNpbmciLCAmaW5kaWNhdG9yU3BhY2luZywgTlVMTCk7CiAgICAgICAgIGluZGljYXRvclJl Y3QuaW5mbGF0ZShpbmRpY2F0b3JTcGFjaW5nKTsKICAgICAgICAgZ3RrX3JlbmRlcl9mb2N1cyhj b250ZXh0LCBwYWludEluZm8uY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCksIGluZGljYXRvclJl Y3QueCgpLCBpbmRpY2F0b3JSZWN0LnkoKSwKICAgICAgICAgICAgICAgICAgICAgICAgICBpbmRp Y2F0b3JSZWN0LndpZHRoKCksIGluZGljYXRvclJlY3QuaGVpZ2h0KCkpOwo=