52344 2011-01-12 18:19:20 -0800 Region improvements 2011-01-12 18:35:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 333471 0 andersca 2011-01-12 18:19:20 -0800 Region improvements 333472 1 78766 andersca 2011-01-12 18:20:12 -0800 Created attachment 78766 Patch 333487 2 78766 mitz 2011-01-12 18:33:24 -0800 Comment on attachment 78766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78766&action=review > WebKit2/Platform/Region.cpp:214 > +void Region::Shape::move(const IntSize& delta) The English word offset is probably a better name than a greek letter. Would be nice to see this function renamed to “translate” too. 333488 3 andersca 2011-01-12 18:35:01 -0800 Committed r75669: <http://trac.webkit.org/changeset/75669> 78766 2011-01-12 18:20:12 -0800 2011-01-12 18:33:24 -0800 Patch bug-52344-20110112182011.patch text/plain 3050 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTY2OCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTEtMDEtMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZWdpb24gaW1wcm92ZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MjM0NAorCisgICAgICAgICogUGxhdGZvcm0vUmVnaW9uLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6UmVnaW9uOjpTaGFwZTo6bW92ZSk6CisgICAgICAgIChXZWJLaXQ6OlJl Z2lvbjo6bW92ZSk6CisgICAgICAgIENoYW5nZSBSZWdpb246Om1vdmUgdG8gdGFrZSBhbiBJbnRT aXplLgorCisgICAgICAgICogUGxhdGZvcm0vUmVnaW9uLmg6CisgICAgICAgIChXZWJLaXQ6Omlu dGVyc2VjdCk6CisgICAgICAgIChXZWJLaXQ6OnN1YnRyYWN0KToKKyAgICAgICAgKFdlYktpdDo6 bW92ZSk6CisgICAgICAgIEFkZCBjb252ZW5pZW5jZSBmdW5jdGlvbnMuCisKIDIwMTEtMDEtMTIg IFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBR dCBidWlsZCBmaXggZm9yIHI3NTY2MQpJbmRleDogV2ViS2l0Mi9QbGF0Zm9ybS9SZWdpb24uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdDIvUGxhdGZvcm0vUmVnaW9uLmNwcAkocmV2aXNpb24gNzU2 NTcpCisrKyBXZWJLaXQyL1BsYXRmb3JtL1JlZ2lvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIx MSwxMiArMjExLDEyIEBAIEludFJlY3QgUmVnaW9uOjpTaGFwZTo6Ym91bmRzKCkgY29uc3QKICAg ICByZXR1cm4gSW50UmVjdChtaW5YLCBtaW5ZLCBtYXhYIC0gbWluWCwgbWF4WSAtIG1pblkpOwog fQogCi12b2lkIFJlZ2lvbjo6U2hhcGU6Om1vdmUoaW50IHgsIGludCB5KQordm9pZCBSZWdpb246 OlNoYXBlOjptb3ZlKGNvbnN0IEludFNpemUmIGRlbHRhKQogewogICAgIGZvciAoc2l6ZV90IGkg PSAwOyBpIDwgbV9zZWdtZW50cy5zaXplKCk7ICsraSkKLSAgICAgICAgbV9zZWdtZW50c1tpXSAr PSB4OworICAgICAgICBtX3NlZ21lbnRzW2ldICs9IGRlbHRhLndpZHRoKCk7CiAgICAgZm9yIChz aXplX3QgaSA9IDA7IGkgPCBtX3NwYW5zLnNpemUoKTsgKytpKQotICAgICAgICBtX3NwYW5zW2ld LnkgKz0geTsKKyAgICAgICAgbV9zcGFuc1tpXS55ICs9IGRlbHRhLmhlaWdodCgpOwogfQogCiB2 b2lkIFJlZ2lvbjo6U2hhcGU6OnN3YXAoU2hhcGUmIG90aGVyKQpAQCAtNDQ0LDEwICs0NDQsMTAg QEAgdm9pZCBSZWdpb246OnN1YnRyYWN0KGNvbnN0IFJlZ2lvbiYgcmVnaQogICAgIG1fYm91bmRz ID0gbV9zaGFwZS5ib3VuZHMoKTsKIH0KIAotdm9pZCBSZWdpb246Om1vdmUoaW50IHgsIGludCB5 KQordm9pZCBSZWdpb246Om1vdmUoY29uc3QgSW50U2l6ZSYgZGVsdGEpCiB7Ci0gICAgbV9ib3Vu ZHMubW92ZSh4LCB5KTsKLSAgICBtX3NoYXBlLm1vdmUoeCwgeSk7CisgICAgbV9ib3VuZHMubW92 ZShkZWx0YSk7CisgICAgbV9zaGFwZS5tb3ZlKGRlbHRhKTsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug V2ViS2l0CkluZGV4OiBXZWJLaXQyL1BsYXRmb3JtL1JlZ2lvbi5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdDIvUGxhdGZvcm0vUmVnaW9uLmgJKHJldmlzaW9uIDc1NjU3KQorKysgV2ViS2l0Mi9QbGF0 Zm9ybS9SZWdpb24uaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNyArNDcsNyBAQCBwdWJsaWM6CiAg ICAgdm9pZCBpbnRlcnNlY3QoY29uc3QgUmVnaW9uJik7CiAgICAgdm9pZCBzdWJ0cmFjdChjb25z dCBSZWdpb24mKTsKIAotICAgIHZvaWQgbW92ZShpbnQgeCwgaW50IHkpOworICAgIHZvaWQgbW92 ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJik7CiAKICNpZm5kZWYgTkRFQlVHCiAgICAgdm9pZCBk dW1wKCkgY29uc3Q7CkBAIC04NCw3ICs4NCw3IEBAIHByaXZhdGU6CiAgICAgICAgIHN0YXRpYyBT aGFwZSBpbnRlcnNlY3RTaGFwZXMoY29uc3QgU2hhcGUmIHNoYXBlMSwgY29uc3QgU2hhcGUmIHNo YXBlMik7CiAgICAgICAgIHN0YXRpYyBTaGFwZSBzdWJ0cmFjdFNoYXBlcyhjb25zdCBTaGFwZSYg c2hhcGUxLCBjb25zdCBTaGFwZSYgc2hhcGUyKTsKIAotICAgICAgICB2b2lkIG1vdmUoaW50IHgs IGludCB5KTsKKyAgICAgICAgdm9pZCBtb3ZlKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKTsKICAg ICAgICAgdm9pZCBzd2FwKFNoYXBlJik7CiAKICNpZm5kZWYgTkRFQlVHCkBAIC0xMTUsNiArMTE1 LDMwIEBAIHByaXZhdGU6CiAgICAgU2hhcGUgbV9zaGFwZTsKIH07CiAKK3N0YXRpYyBpbmxpbmUg UmVnaW9uIGludGVyc2VjdChjb25zdCBSZWdpb24mIGEsIGNvbnN0IFJlZ2lvbiYgYikKK3sKKyAg ICBSZWdpb24gcmVzdWx0KGEpOworICAgIHJlc3VsdC5pbnRlcnNlY3QoYik7CisKKyAgICByZXR1 cm4gcmVzdWx0OworfQorICAgIAorc3RhdGljIGlubGluZSBSZWdpb24gc3VidHJhY3QoY29uc3Qg UmVnaW9uJiBhLCBjb25zdCBSZWdpb24mIGIpCit7CisgICAgUmVnaW9uIHJlc3VsdChhKTsKKyAg ICByZXN1bHQuc3VidHJhY3QoYik7CisKKyAgICByZXR1cm4gcmVzdWx0OworfQorCitzdGF0aWMg aW5saW5lIFJlZ2lvbiBtb3ZlKGNvbnN0IFJlZ2lvbiYgcmVnaW9uLCBjb25zdCBXZWJDb3JlOjpJ bnRTaXplJiBkZWx0YSkKK3sKKyAgICBSZWdpb24gcmVzdWx0KHJlZ2lvbik7CisgICAgcmVzdWx0 Lm1vdmUoZGVsdGEpOworCisgICAgcmV0dXJuIHJlc3VsdDsKK30KKwogfSAvLyBuYW1lc3BhY2Ug V2ViS2l0CiAKICNlbmRpZiAvLyBSZWdpb25faAo=