52339 2011-01-12 17:12:09 -0800 Remove sizeInBytes from GraphicsContext3D's various implementations 2011-01-24 14:42:38 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo cmarrin enne kbr oldest_to_newest 333440 0 zmo 2011-01-12 17:12:09 -0800 Since we defined CG3D types to match GL types, we can just use that to implement sizeInBytes instead. Maybe we could just remove this function from GraphicsContext3D and just implement it on the WebGLRenderingContext side. 339274 1 79978 zmo 2011-01-24 14:30:22 -0800 Created attachment 79978 Patch 339275 2 zmo 2011-01-24 14:31:38 -0800 (In reply to comment #1) > Created an attachment (id=79978) [details] > Patch Note that we didn't remove sizeInBytes from WebGraphicsContext3D. We can do it in 51947. 339277 3 79978 darin 2011-01-24 14:32:39 -0800 Comment on attachment 79978 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79978&action=review > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:506 > + default: > + return 0; Normally we leave defaults out of our switch statements to allow the compiler to check that we covered all the enum values. Then, outside the switch we put something like this: ASSERT_NOT_REACHED(); return 0; Because it’s not correct for someone to pass in a value that is not one of the enum constants. 339278 4 zmo 2011-01-24 14:33:53 -0800 (In reply to comment #3) > (From update of attachment 79978 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79978&action=review > > > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:506 > > + default: > > + return 0; > > Normally we leave defaults out of our switch statements to allow the compiler to check that we covered all the enum values. Then, outside the switch we put something like this: > > ASSERT_NOT_REACHED(); > return 0; > > Because it’s not correct for someone to pass in a value that is not one of the enum constants. I'll fix this in the landing patch. Thank you. 339282 5 zmo 2011-01-24 14:42:38 -0800 Committed r76549: <http://trac.webkit.org/changeset/76549> 79978 2011-01-24 14:30:22 -0800 2011-01-24 14:32:39 -0800 Patch bug-52339-20110124143021.patch text/plain 7012 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NTQ4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEtMjQgIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgc2l6ZUluQnl0ZXMgZnJvbSBHcmFwaGljc0NvbnRleHQzRCdz IHZhcmlvdXMgaW1wbGVtZW50YXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MjMzOQorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5k ZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4 dDo6c2l6ZUluQnl0ZXMpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29u dGV4dDNELmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29u dGV4dDNET3BlbkdMLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHQzRFF0LmNwcDoKKwogMjAxMS0wMS0yNCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBs ZS5jb20+CiAKICAgICAgICAgV2luZG93cyBQcm9kdWN0aW9uIGJ1aWxkIGZpeApJbmRleDogU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQu Y3BwCShyZXZpc2lvbiA3NjQwOCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM UmVuZGVyaW5nQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4Nyw3ICs0ODcsMjQgQEAg dm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnJlc2hhcGUoaW50IAogCiB1bnNpZ25lZCBpbnQg V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpzaXplSW5CeXRlcyhHQzNEZW51bSB0eXBlKQogewotICAg IHJldHVybiBtX2NvbnRleHQtPnNpemVJbkJ5dGVzKHR5cGUpOworICAgIHN3aXRjaCAodHlwZSkg eworICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OkJZVEU6CisgICAgICAgIHJldHVybiBzaXpl b2YoR0MzRGJ5dGUpOworICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX0JZVEU6 CisgICAgICAgIHJldHVybiBzaXplb2YoR0MzRHVieXRlKTsKKyAgICBjYXNlIEdyYXBoaWNzQ29u dGV4dDNEOjpTSE9SVDoKKyAgICAgICAgcmV0dXJuIHNpemVvZihHQzNEc2hvcnQpOworICAgIGNh c2UgR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX1NIT1JUOgorICAgICAgICByZXR1cm4gc2l6 ZW9mKEdDM0R1c2hvcnQpOworICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OklOVDoKKyAgICAg ICAgcmV0dXJuIHNpemVvZihHQzNEaW50KTsKKyAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpV TlNJR05FRF9JTlQ6CisgICAgICAgIHJldHVybiBzaXplb2YoR0MzRHVpbnQpOworICAgIGNhc2Ug R3JhcGhpY3NDb250ZXh0M0Q6OkZMT0FUOgorICAgICAgICByZXR1cm4gc2l6ZW9mKEdDM0RmbG9h dCk7CisgICAgZGVmYXVsdDoKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQogfQogCiB2b2lkIFdl YkdMUmVuZGVyaW5nQ29udGV4dDo6YWN0aXZlVGV4dHVyZShHQzNEZW51bSB0ZXh0dXJlLCBFeGNl cHRpb25Db2RlJiBlYykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNELmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAkocmV2aXNpb24gNzY0MDgpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCSh3b3JraW5nIGNv cHkpCkBAIC00Nyw3ICs0Nyw5IEBACiB0eXBlZGVmIHVuc2lnbmVkIGludCBHQzNEZW51bTsKIHR5 cGVkZWYgdW5zaWduZWQgY2hhciBHQzNEYm9vbGVhbjsKIHR5cGVkZWYgdW5zaWduZWQgaW50IEdD M0RiaXRmaWVsZDsKK3R5cGVkZWYgc2lnbmVkIGNoYXIgR0MzRGJ5dGU7CiB0eXBlZGVmIHVuc2ln bmVkIGNoYXIgR0MzRHVieXRlOwordHlwZWRlZiBzaG9ydCBHQzNEc2hvcnQ7CiB0eXBlZGVmIHVu c2lnbmVkIHNob3J0IEdDM0R1c2hvcnQ7CiB0eXBlZGVmIGludCBHQzNEaW50OwogdHlwZWRlZiBp bnQgR0MzRHNpemVpOwpAQCAtNDg3LDEwICs0ODksNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBwcmVw YXJlVGV4dHVyZSgpOwogI2VuZGlmCiAKLSAgICAvLyBIZWxwZXIgdG8gcmV0dXJuIHRoZSBzaXpl IGluIGJ5dGVzIG9mIE9wZW5HTCBkYXRhIHR5cGVzCi0gICAgLy8gbGlrZSBHTF9GTE9BVCwgR0xf SU5ULCBldGMuCi0gICAgdW5zaWduZWQgaW50IHNpemVJbkJ5dGVzKEdDM0RlbnVtIHR5cGUpOwot CiAgICAgLy8gSGVscGVyIHRvIHRleEltYWdlMkQgd2l0aCBwaXhlbD09MCBjYXNlOiBwaXhlbHMg YXJlIGluaXRpYWxpemVkIHRvIDAuCiAgICAgLy8gUmV0dXJuIHRydWUgaWYgbm8gR0wgZXJyb3Ig aXMgc3ludGhlc2l6ZWQuCiAgICAgLy8gQnkgZGVmYXVsdCwgYWxpZ25tZW50IGlzIDQsIHRoZSBP cGVuR0wgZGVmYXVsdCBzZXR0aW5nLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RP cGVuR0wuY3BwCShyZXZpc2lvbiA3NjQwOCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE0MzcsMjggKzE0MzcsNiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpkZWxldGVUZXh0 dXJlKFBsCiAgICAgZ2xEZWxldGVUZXh0dXJlcygxLCAmdGV4dHVyZSk7CiB9CiAKLXVpbnQzMl90 IEdyYXBoaWNzQ29udGV4dDNEOjpzaXplSW5CeXRlcyhHQzNEZW51bSB0eXBlKQotewotICAgIHN3 aXRjaCAodHlwZSkgewotICAgICAgICBjYXNlIEdMX0JZVEU6Ci0gICAgICAgICAgICByZXR1cm4g c2l6ZW9mKEdMYnl0ZSk7Ci0gICAgICAgIGNhc2UgR0xfVU5TSUdORURfQllURToKLSAgICAgICAg ICAgIHJldHVybiBzaXplb2YoR0x1Ynl0ZSk7Ci0gICAgICAgIGNhc2UgR0xfU0hPUlQ6Ci0gICAg ICAgICAgICByZXR1cm4gc2l6ZW9mKEdMc2hvcnQpOwotICAgICAgICBjYXNlIEdMX1VOU0lHTkVE X1NIT1JUOgotICAgICAgICAgICAgcmV0dXJuIHNpemVvZihHTHVzaG9ydCk7Ci0gICAgICAgIGNh c2UgR0xfSU5UOgotICAgICAgICAgICAgcmV0dXJuIHNpemVvZihHTGludCk7Ci0gICAgICAgIGNh c2UgR0xfVU5TSUdORURfSU5UOgotICAgICAgICAgICAgcmV0dXJuIHNpemVvZihHTHVpbnQpOwot ICAgICAgICBjYXNlIEdMX0ZMT0FUOgotICAgICAgICAgICAgcmV0dXJuIHNpemVvZihHTGZsb2F0 KTsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIHJldHVybiAwOwotICAgIH0KLX0KLQog dm9pZCBHcmFwaGljc0NvbnRleHQzRDo6c3ludGhlc2l6ZUdMRXJyb3IoR0MzRGVudW0gZXJyb3Ip CiB7CiAgICAgbV9zeW50aGV0aWNFcnJvcnMuYWRkKGVycm9yKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4 dDNEUXQuY3BwCShyZXZpc2lvbiA3NjQwOCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjEx LDI4ICsxNjExLDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6ZGVsZXRlVGV4dHVyZShQbAog ICAgIGdsRGVsZXRlVGV4dHVyZXMoMSwgJnRleHR1cmUpOwogfQogCi11bnNpZ25lZCBpbnQgR3Jh cGhpY3NDb250ZXh0M0Q6OnNpemVJbkJ5dGVzKEdDM0RlbnVtIHR5cGUpCi17Ci0gICAgc3dpdGNo ICh0eXBlKSB7Ci0gICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6QllURToKLSAgICAgICAgcmV0 dXJuIHNpemVvZihHTGJ5dGUpOwotICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVE X0JZVEU6Ci0gICAgICAgIHJldHVybiBzaXplb2YoR0x1Ynl0ZSk7Ci0gICAgY2FzZSBHcmFwaGlj c0NvbnRleHQzRDo6U0hPUlQ6Ci0gICAgICAgIHJldHVybiBzaXplb2YoR0xzaG9ydCk7Ci0gICAg Y2FzZSBHcmFwaGljc0NvbnRleHQzRDo6VU5TSUdORURfU0hPUlQ6Ci0gICAgICAgIHJldHVybiBz aXplb2YoR0x1c2hvcnQpOwotICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OklOVDoKLSAgICAg ICAgcmV0dXJuIHNpemVvZihHTGludCk7Ci0gICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6VU5T SUdORURfSU5UOgotICAgICAgICByZXR1cm4gc2l6ZW9mKEdMdWludCk7Ci0gICAgY2FzZSBHcmFw aGljc0NvbnRleHQzRDo6RkxPQVQ6Ci0gICAgICAgIHJldHVybiBzaXplb2YoR0xmbG9hdCk7Ci0g ICAgZGVmYXVsdDoKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQotfQotCiB2b2lkIEdyYXBoaWNz Q29udGV4dDNEOjpzeW50aGVzaXplR0xFcnJvcihHQzNEZW51bSBlcnJvcikKIHsKICAgICBtX2lu dGVybmFsLT5tX3N5bnRoZXRpY0Vycm9ycy5hZGQoZXJyb3IpOwpJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NTQ4KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMS0yNCAgWmhl bnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW92ZSBzaXplSW5CeXRlcyBmcm9tIEdyYXBoaWNzQ29udGV4 dDNEJ3MgdmFyaW91cyBpbXBsZW1lbnRhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMzM5CisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250 ZXh0M0RDaHJvbWl1bS5jcHA6CisgICAgICAgICogc3JjL0dyYXBoaWNzQ29udGV4dDNESW50ZXJu YWwuaDoKKwogMjAxMS0wMS0yNCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgpJbmRleDogU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAJ KHJldmlzaW9uIDc2NDA4KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3ND b250ZXh0M0RDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2NSw3ICszNjUsNiBAQCBy dCBHcmFwaGljc0NvbnRleHQzREludGVybmFsOjpuYW1lKHQxIGExCiB9CiAKIERFTEVHQVRFX1RP X0lNUExfUihtYWtlQ29udGV4dEN1cnJlbnQsIGJvb2wpCi1ERUxFR0FURV9UT19JTVBMXzFSKHNp emVJbkJ5dGVzLCBHQzNEZW51bSwgdW5zaWduZWQgaW50KQogCiBib29sIEdyYXBoaWNzQ29udGV4 dDNESW50ZXJuYWw6OmlzR0xFUzJDb21wbGlhbnQoKSBjb25zdAogewpAQCAtODk3LDcgKzg5Niw2 IEBAIFBsYXRmb3JtTGF5ZXIqIEdyYXBoaWNzQ29udGV4dDNEOjpwbGF0Zm8KICNlbmRpZgogCiBE RUxFR0FURV9UT19JTlRFUk5BTChtYWtlQ29udGV4dEN1cnJlbnQpCi1ERUxFR0FURV9UT19JTlRF Uk5BTF8xUihzaXplSW5CeXRlcywgR0MzRGVudW0sIHVuc2lnbmVkIGludCkKIERFTEVHQVRFX1RP X0lOVEVSTkFMXzIocmVzaGFwZSwgaW50LCBpbnQpCiBERUxFR0FURV9UT19JTlRFUk5BTF9SKGdl dEludGVybmFsRnJhbWVidWZmZXJTaXplLCBJbnRTaXplKQogCkluZGV4OiBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzREludGVybmFsLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbC5oCShy ZXZpc2lvbiA3NjQwOCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29u dGV4dDNESW50ZXJuYWwuaAkod29ya2luZyBjb3B5KQpAQCAtNjIsOCArNjIsNiBAQCBwdWJsaWM6 CiAKICAgICBib29sIG1ha2VDb250ZXh0Q3VycmVudCgpOwogCi0gICAgdW5zaWduZWQgaW50IHNp emVJbkJ5dGVzKEdDM0RlbnVtIHR5cGUpOwotCiAgICAgdm9pZCByZXNoYXBlKGludCB3aWR0aCwg aW50IGhlaWdodCk7CiAgICAgSW50U2l6ZSBnZXRJbnRlcm5hbEZyYW1lYnVmZmVyU2l6ZSgpOwog Cg==