52328 2011-01-12 15:09:08 -0800 More work on getting the drawing area proxy to paint 2011-01-12 15:29:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 333340 0 andersca 2011-01-12 15:09:08 -0800 More work on getting the drawing area proxy to paint 333345 1 78742 andersca 2011-01-12 15:14:46 -0800 Created attachment 78742 Patch 333355 2 78742 sam 2011-01-12 15:28:28 -0800 Comment on attachment 78742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78742&action=review > WebKit2/UIProcess/mac/BackingStoreMac.mm:31 > +//+#include <WebCore/IntRect.h> Woops. 333358 3 andersca 2011-01-12 15:29:33 -0800 Committed r75647: <http://trac.webkit.org/changeset/75647> 78742 2011-01-12 15:14:46 -0800 2011-01-12 15:28:28 -0800 Patch bug-52328-20110112151444.patch text/plain 5786 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTY0MykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMTEtMDEtMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNb3JlIHdvcmsgb24gZ2V0dGluZyB0aGUgZHJhd2luZyBhcmVhIHByb3h5IHRvIHBhaW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjMyOAorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcg ZHJhd1JlY3Q6XSk6CisgICAgICAgIEhhbmRsZSB0aGUgbmV3IGRyYXdpbmcgYXJlYS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpCYWNr aW5nU3RvcmU6OkJhY2tpbmdTdG9yZSk6CisgICAgICAgIEFzc2VydCB0aGF0IHRoZSBzaXplIGlz bid0IGVtcHR5LgorICAgICAgICAKKyAgICAgICAgKiBVSVByb2Nlc3MvQmFja2luZ1N0b3JlLmg6 CisgICAgICAgICogVUlQcm9jZXNzL21hYy9CYWNraW5nU3RvcmVNYWMubW06CisgICAgICAgIChX ZWJLaXQ6OkJhY2tpbmdTdG9yZTo6aW5jb3Jwb3JhdGVVcGRhdGUpOgorICAgICAgICBQYWludCBh bGwgdXBkYXRlIHJlY3RzIGludG8gdGhlIGJpdG1hcCBjb250ZXh0LgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRy YXdpbmdBcmVhSW1wbDo6ZGlzcGxheSk6CisgICAgICAgIENyZWF0ZSBhIGhhbmRsZSBzbyB0aGUg c2hhcmVhYmxlIGJpdG1hcCB3aWxsIGFjdHVhbGx5IGJlIHRyYW5zZmVycmVkIG92ZXIuCisKIDIw MTEtMDEtMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXggYnVpbGQuCkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0JhY2tpbmdTdG9yZS5jcHAJKHJldmlzaW9u IDc1NjQwKQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvQmFja2luZ1N0b3JlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDEsNiArNDEsNyBAQCBQYXNzT3duUHRyPEJhY2tpbmdTdG9yZT4gQmFja2luZ1N0 b3JlOjpjCiBCYWNraW5nU3RvcmU6OkJhY2tpbmdTdG9yZShjb25zdCBJbnRTaXplJiBzaXplKQog ICAgIDogbV9zaXplKHNpemUpCiB7CisgICAgQVNTRVJUKCFtX3NpemUuaXNFbXB0eSgpKTsKIH0K IAogQmFja2luZ1N0b3JlOjp+QmFja2luZ1N0b3JlKCkKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNz L0JhY2tpbmdTdG9yZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0JhY2tpbmdT dG9yZS5oCShyZXZpc2lvbiA3NTY0MCkKKysrIFdlYktpdDIvVUlQcm9jZXNzL0JhY2tpbmdTdG9y ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02MCw4ICs2MCw2IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAg ICAgZXhwbGljaXQgQmFja2luZ1N0b3JlKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKTsKIAotICAg IHZvaWQgcGxhdGZvcm1Jbml0aWFsaXplKCk7Ci0KICAgICBXZWJDb3JlOjpJbnRTaXplIG1fc2l6 ZTsKIAogI2lmIFBMQVRGT1JNKE1BQykKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMv V0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3 Lm1tCShyZXZpc2lvbiA3NTYxNSkKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3 Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEzLDcgKzExMTMsMTUgQEAgLSAodm9pZClfd2luZG93 RnJhbWVEaWRDaGFuZ2U6KE5TTm90aWZpYwogLSAodm9pZClkcmF3UmVjdDooTlNSZWN0KXJlY3QK IHsKICAgICBpZiAodXNlTmV3RHJhd2luZ0FyZWEoKSkgewotICAgICAgICAvLyBGSVhNRTogSW1w bGVtZW50LgorICAgICAgICBpZiAoRHJhd2luZ0FyZWFQcm94eUltcGwqIGRyYXdpbmdBcmVhID0g c3RhdGljX2Nhc3Q8RHJhd2luZ0FyZWFQcm94eUltcGwqPihfZGF0YS0+X3BhZ2UtPmRyYXdpbmdB cmVhKCkpKSB7CisgICAgICAgICAgICBDR0NvbnRleHRSZWYgY29udGV4dCA9IHN0YXRpY19jYXN0 PENHQ29udGV4dFJlZj4oW1tOU0dyYXBoaWNzQ29udGV4dCBjdXJyZW50Q29udGV4dF0gZ3JhcGhp Y3NQb3J0XSk7CisgICAgICAgICAgICBkcmF3aW5nQXJlYS0+cGFpbnQoY29udGV4dCwgZW5jbG9z aW5nSW50UmVjdChyZWN0KSk7CisgICAgICAgIH0gZWxzZSBpZiAoX2RhdGEtPl9wYWdlLT5kcmF3 c0JhY2tncm91bmQoKSkgeworICAgICAgICAgICAgW19kYXRhLT5fcGFnZS0+ZHJhd3NUcmFuc3Bh cmVudEJhY2tncm91bmQoKSA/IFtOU0NvbG9yIGNsZWFyQ29sb3JdIDogW05TQ29sb3Igd2hpdGVD b2xvcl0gc2V0XTsKKyAgICAgICAgICAgIE5TUmVjdEZpbGwocmVjdCk7CisgICAgICAgIH0KKwor ICAgICAgICBfZGF0YS0+X3BhZ2UtPmRpZERyYXcoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K IApJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL0JhY2tpbmdTdG9yZU1hYy5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9tYWMvQmFja2luZ1N0b3JlTWFjLm1tCShyZXZpc2lv biA3NTY0MCkKKysrIFdlYktpdDIvVUlQcm9jZXNzL21hYy9CYWNraW5nU3RvcmVNYWMubW0JKHdv cmtpbmcgY29weSkKQEAgLTI1LDI1ICsyNSw1MCBAQAogCiAjaW5jbHVkZSAiQmFja2luZ1N0b3Jl LmgiCiAKKyNpbmNsdWRlICJTaGFyZWFibGVCaXRtYXAuaCIKKyNpbmNsdWRlICJVcGRhdGVJbmZv LmgiCisjaW5jbHVkZSA8V2ViQ29yZS9HcmFwaGljc0NvbnRleHQuaD4KKy8vKyNpbmNsdWRlIDxX ZWJDb3JlL0ludFJlY3QuaD4KKwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFj ZSBXZWJLaXQgewogCi12b2lkIEJhY2tpbmdTdG9yZTo6cGxhdGZvcm1Jbml0aWFsaXplKCkKLXsK LSAgICBSZXRhaW5QdHI8Q0dDb2xvclNwYWNlUmVmPiBjb2xvclNwYWNlKEFkb3B0Q0YsIENHQ29s b3JTcGFjZUNyZWF0ZURldmljZVJHQigpKTsKLQotICAgIG1fYml0bWFwQ29udGV4dC5hZG9wdENG KENHQml0bWFwQ29udGV4dENyZWF0ZSgwLCBtX3NpemUud2lkdGgoKSwgbV9zaXplLmhlaWdodCgp LCA4LCBtX3NpemUud2lkdGgoKSAqIDQsIGNvbG9yU3BhY2UuZ2V0KCksIGtDR0ltYWdlQWxwaGFQ cmVtdWx0aXBsaWVkRmlyc3QgfCBrQ0dCaXRtYXBCeXRlT3JkZXIzMkhvc3QpKTsKLX0KLQogdm9p ZCBCYWNraW5nU3RvcmU6OnBhaW50KFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0LCBjb25zdCBJbnRS ZWN0JikKIHsKICAgICAvLyBGSVhNRTogSW1wbGVtZW50LgogfQogCi12b2lkIEJhY2tpbmdTdG9y ZTo6aW5jb3Jwb3JhdGVVcGRhdGUoY29uc3QgVXBkYXRlSW5mbyYpCit2b2lkIEJhY2tpbmdTdG9y ZTo6aW5jb3Jwb3JhdGVVcGRhdGUoY29uc3QgVXBkYXRlSW5mbyYgdXBkYXRlSW5mbykKIHsKLSAg ICAvLyBGSVhNRTogSW1wbGVtZW50LgorICAgIEFTU0VSVChtX3NpemUgPT0gdXBkYXRlSW5mby52 aWV3U2l6ZSk7CisKKyAgICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBTaGFyZWFi bGVCaXRtYXA6OmNyZWF0ZSh1cGRhdGVJbmZvLnVwZGF0ZVJlY3RCb3VuZHMuc2l6ZSgpLCB1cGRh dGVJbmZvLmJpdG1hcEhhbmRsZSk7CisgICAgaWYgKCFiaXRtYXApCisgICAgICAgIHJldHVybjsK KworICAgIGlmICghbV9iaXRtYXBDb250ZXh0KSB7CisgICAgICAgIFJldGFpblB0cjxDR0NvbG9y U3BhY2VSZWY+IGNvbG9yU3BhY2UoQWRvcHRDRiwgQ0dDb2xvclNwYWNlQ3JlYXRlRGV2aWNlUkdC KCkpOworICAgICAgICAKKyAgICAgICAgbV9iaXRtYXBDb250ZXh0LmFkb3B0Q0YoQ0dCaXRtYXBD b250ZXh0Q3JlYXRlKDAsIG1fc2l6ZS53aWR0aCgpLCBtX3NpemUuaGVpZ2h0KCksIDgsIG1fc2l6 ZS53aWR0aCgpICogNCwgY29sb3JTcGFjZS5nZXQoKSwga0NHSW1hZ2VBbHBoYVByZW11bHRpcGxp ZWRGaXJzdCB8IGtDR0JpdG1hcEJ5dGVPcmRlcjMySG9zdCkpOworICAgICAgICAKKyAgICAgICAg Ly8gV2Ugd2FudCB0aGUgb3JpZ2luIHRvIGJlIGluIHRoZSB0b3AgbGVmdCBjb3JuZXIgc28gZmxp cCB0aGUgYmFja2luZyBzdG9yZSBjb250ZXh0LgorICAgICAgICBDR0NvbnRleHRUcmFuc2xhdGVD VE0obV9iaXRtYXBDb250ZXh0LmdldCgpLCAwLCBtX3NpemUuaGVpZ2h0KCkpOworICAgICAgICBD R0NvbnRleHRTY2FsZUNUTShtX2JpdG1hcENvbnRleHQuZ2V0KCksIDEsIC0xKTsKKyAgICB9CisK KyAgICBJbnRQb2ludCB1cGRhdGVSZWN0TG9jYXRpb24gPSB1cGRhdGVJbmZvLnVwZGF0ZVJlY3RC b3VuZHMubG9jYXRpb24oKTsKKworICAgIEdyYXBoaWNzQ29udGV4dCBncmFwaGljc0NvbnRleHQo bV9iaXRtYXBDb250ZXh0LmdldCgpKTsKKworICAgIC8vIFBhaW50IGFsbCB1cGRhdGUgcmVjdHMu CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB1cGRhdGVJbmZvLnVwZGF0ZVJlY3RzLnNpemUo KTsgKytpKSB7CisgICAgICAgIEludFJlY3QgdXBkYXRlUmVjdCA9IHVwZGF0ZUluZm8udXBkYXRl UmVjdHNbaV07CisgICAgICAgIEludFJlY3Qgc3JjUmVjdCA9IHVwZGF0ZVJlY3Q7CisgICAgICAg IHNyY1JlY3QubW92ZSgtdXBkYXRlUmVjdExvY2F0aW9uLngoKSwgLXVwZGF0ZVJlY3RMb2NhdGlv bi55KCkpOworCisgICAgICAgIGJpdG1hcC0+cGFpbnQoZ3JhcGhpY3NDb250ZXh0LCB1cGRhdGVS ZWN0LmxvY2F0aW9uKCksIHNyY1JlY3QpOworICAgIH0KIH0KIAogfSAvLyBuYW1lc3BhY2UgV2Vi S2l0CkluZGV4OiBXZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1w bC5jcHAJKHJldmlzaW9uIDc1NjMwKQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJh d2luZ0FyZWFJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUyLDYgKzE1Miw4IEBAIHZvaWQg RHJhd2luZ0FyZWFJbXBsOjpkaXNwbGF5KFVwZGF0ZUluZm8KICAgICBtX2RpcnR5UmVnaW9uID0g UmVnaW9uKCk7CiAKICAgICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBTaGFyZWFi bGVCaXRtYXA6OmNyZWF0ZVNoYXJlYWJsZShib3VuZHMuc2l6ZSgpKTsKKyAgICBpZiAoIWJpdG1h cC0+Y3JlYXRlSGFuZGxlKHVwZGF0ZUluZm8uYml0bWFwSGFuZGxlKSkKKyAgICAgICAgcmV0dXJu OwogCiAgICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dD4gZ3JhcGhpY3NDb250ZXh0ID0gYml0bWFw LT5jcmVhdGVHcmFwaGljc0NvbnRleHQoKTsKIAo=