52307 2011-01-12 10:41:49 -0800 Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR 2011-01-12 10:55:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 333154 0 mjs 2011-01-12 10:41:49 -0800 Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR 333156 1 78705 mjs 2011-01-12 10:44:35 -0800 Created attachment 78705 Patch 333162 2 mjs 2011-01-12 10:55:35 -0800 Committed r75623: <http://trac.webkit.org/changeset/75623> 333163 3 78705 aroben 2011-01-12 10:55:48 -0800 Comment on attachment 78705 Patch The review page seems broken at the moment, so reviewing this manually. +my $noBuildDumpTool = 0; I find positive names easier to understand, so I'd prefer: my $buildDumpTool = 1; + 'no-build' => \$noBuildDumpTool, Then this can become: 'build!' => \$buildDumpTool, That will support both --build and --no-build. You should add this new option to the usage notes. +if (!defined($root) && !$noBuildDumpTool) { This will of course have to change, too. 78705 2011-01-12 10:44:35 -0800 2011-01-12 10:55:48 -0800 Patch bug-52307-20110112104432.patch text/plain 1614 mjs SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc1NjIyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDEtMTIgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBu by1idWlsZCBvcHRpb24gdG8gcnVuLXdlYmtpdC10ZXN0cywgdG8gYXZvaWQgYnVpbGRpbmcgRFJU L1dLVFIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUy MzA3CisKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorCiAyMDExLTAx LTEyICBLb2FuLVNpbiBUYW4gIDxrb2Fuc2luLnRhbkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpJbmRleDogVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdl YmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRl c3RzCShyZXZpc2lvbiA3NTU2NSkKKysrIFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVz dHMJKHdvcmtpbmcgY29weSkKQEAgLTE3MCw2ICsxNzAsNyBAQCBteSAkdXNlVmFsZ3JpbmQgPSAw OwogbXkgJHZlcmJvc2UgPSAwOwogbXkgJHNob3VsZFdhaXRGb3JIVFRQRCA9IDA7CiBteSAkdXNl V2ViS2l0VGVzdFJ1bm5lciA9IDA7CitteSAkbm9CdWlsZER1bXBUb29sID0gMDsKIAogbXkgQGxl YWtzRmlsZW5hbWVzOwogCkBAIC0zMjksNiArMzMwLDcgQEAgbXkgJGdldE9wdGlvbnNSZXN1bHQg PSBHZXRPcHRpb25zKAogICAgICdsZWFrc3xsJyA9PiBcJHNob3VsZENoZWNrTGVha3MsCiAgICAg J21lcmdlLWxlYWstZGVwdGh8bTo1JyA9PiBcJG1lcmdlRGVwdGgsCiAgICAgJ25ldy10ZXN0LXJl c3VsdHMhJyA9PiBcJGdlbmVyYXRlTmV3UmVzdWx0cywKKyAgICAnbm8tYnVpbGQnID0+IFwkbm9C dWlsZER1bXBUb29sLAogICAgICdudGhseT1pJyA9PiBcJHRlc3RzUGVyRHVtcFRvb2wsCiAgICAg J3BpeGVsLXRlc3RzfHAnID0+IFwkcGl4ZWxUZXN0cywKICAgICAncGxhdGZvcm09cycgPT4gXCRw bGF0Zm9ybSwKQEAgLTQwNSw3ICs0MDcsNyBAQCAkcHJvZHVjdERpciAuPSAiL1Byb2dyYW1zIiBp ZiBpc0d0aygpOwogCiBjaGRpcldlYktpdCgpOwogCi1pZiAoIWRlZmluZWQoJHJvb3QpKSB7Citp ZiAoIWRlZmluZWQoJHJvb3QpICYmICEkbm9CdWlsZER1bXBUb29sKSB7CiAgICAgIyBGSVhNRTog V2UgYnVpbGQgYm90aCBEdW1wUmVuZGVyVHJlZSBhbmQgV2ViS2l0VGVzdFJ1bm5lciBmb3IKICAg ICAjIFdlYktpdFRlc3RSdW5uZXIgcnVucyBiZWN1YXNlIER1bXBSZW5kZXJUcmVlIHN0aWxsIGlu Y2x1ZGVzCiAgICAgIyB0aGUgRHVtcFJlbmRlclRyZWVTdXBwb3J0IG1vZHVsZSBhbmQgdGhlIFRl c3ROZXRzY2FwZVBsdWdpbi4K