52305 2011-01-12 10:27:27 -0800 Bugzilla: Add keyboard shortcuts to jump to next change 2011-01-12 15:27:56 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 arv webkit-unassigned abarth aroben eric mihaip ojan oldest_to_newest 333145 0 arv 2011-01-12 10:27:27 -0800 We could use J/K to jump to next/previous file. 333311 1 78734 ojan 2011-01-12 14:40:27 -0800 Created attachment 78734 Patch 333349 2 78734 abarth 2011-01-12 15:20:35 -0800 Comment on attachment 78734 Patch Very nice. 333354 3 ojan 2011-01-12 15:27:56 -0800 Committed r75646: <http://trac.webkit.org/changeset/75646> 78734 2011-01-12 14:40:27 -0800 2011-01-12 15:20:35 -0800 Patch bug-52305-20110112144026.patch text/plain 7744 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDc1OTQyYWI2ZmIzMDZlOGUyOTQ0ODk5 ODgxM2IwOTZjYmY0YzFjMDcuLjZhMDU2Y2FjMWZlMmZlYjYzOTkzODRiNTExOGNjN2E3YWY3MTcw NTIgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEx LTAxLTEyICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnemlsbGE6IEFkZCBrZXlib2FyZCBz aG9ydGN1dHMgdG8ganVtcCB0byBuZXh0IGNoYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIzMDUKKworICAgICAgICBDb21tZW50cyBhbmQgZGlm ZiBibG9ja3MgZ28gaW4gdGhlIHNhbWUgcXVldWUuIElmIHlvdSBoYXZlIGEgCisgICAgICAgIGNv bW1lbnQgZm9jdXNlZCwgdGhlbiBqL2sgd2lsbCBmb2N1cyB0aGUgbmV4dC9wcmV2IGRpZmYgYmxv Y2sKKyAgICAgICAgd2l0aCByZXNwZWN0IHRvIHRoYXQgY29tbWVudC4KKworICAgICAgICAqIFBy ZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiOgorICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOgorCisy MDExLTAxLTEyICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2 aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KIAogICAgICAgICBmaXggd3JhcHBpbmcgYnVnIGluIGV4cGFu c2lvbiBsaW5lcyBpbiB0aGUgY29kZSByZXZpZXcgdG9vbApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMv YnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiIGIvV2Vic2l0ZXMvYnVn cy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCmluZGV4IDg0YjFmZjIwMDVl Y2IyMGU2ZjliOTVkNDNlOWYxMmY5OWZjYjM1N2YuLjZjOGNiM2M2NzJjMWE2ODgwYTM3ZmI5ZTU2 ZTE3OTljOTAwZWM0MGIgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0 dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgorKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJl dHR5UGF0Y2gvUHJldHR5UGF0Y2gucmIKQEAgLTM3NCw3ICszNzQsOCBAQCBib2R5IHsKIH0KIAog LmZvY3VzZWQgewotICBib3JkZXI6IDFweCBzb2xpZCBibHVlOworICBvdXRsaW5lOiAxcHggc29s aWQgYmx1ZTsKKyAgb3V0bGluZS1vZmZzZXQ6IC0xcHg7CiB9CiAKIC5zdGF0dXNCdWJibGUgewpk aWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzIGIvV2Vi c2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzCmluZGV4IDY4MzZiZTJkYjcyN2I1 N2MwOGMyYmM5NzU1MzMxZDE1OThiMjMyNDUuLjQ4MDFkMzJjZjkwYWQ5ZjFiYWQ0ZWI2OTVmZGZi NjI0NmQ2NzY4OWUgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJl dmlldy5qcworKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKQEAg LTk3LDE4ICs5NywxOCBAQAogICAgIH0pOwogICB9CiAKLSAgZnVuY3Rpb24gZGlmZlNlY3Rpb25G cm9tKGxpbmUpIHsKKyAgZnVuY3Rpb24gZmlsZURpZmZGb3IobGluZSkgewogICAgIHJldHVybiBs aW5lLnBhcmVudHMoJy5GaWxlRGlmZicpOwogICB9CiAKICAgZnVuY3Rpb24gYWN0aXZlQ29tbWVu dEZvcihsaW5lKSB7CiAgICAgLy8gU2NvcGUgdG8gdGhlIGRpZmZTZWN0aW9uIGFzIGEgcGVyZm9y bWFuY2UgaW1wcm92ZW1lbnQuCi0gICAgcmV0dXJuICQoJ3RleHRhcmVhW2RhdGEtY29tbWVudC1m b3J+PSInICsgbGluZVswXS5pZCArICciXScsIGRpZmZTZWN0aW9uRnJvbShsaW5lKSk7CisgICAg cmV0dXJuICQoJ3RleHRhcmVhW2RhdGEtY29tbWVudC1mb3J+PSInICsgbGluZVswXS5pZCArICci XScsIGZpbGVEaWZmRm9yKGxpbmUpKTsKICAgfQogCiAgIGZ1bmN0aW9uIHByZXZpb3VzQ29tbWVu dHNGb3IobGluZSkgewogICAgIC8vIFNjb3BlIHRvIHRoZSBkaWZmU2VjdGlvbiBhcyBhIHBlcmZv cm1hbmNlIGltcHJvdmVtZW50LgotICAgIHJldHVybiAkKCdkaXZbZGF0YS1jb21tZW50LWZvcn49 IicgKyBsaW5lWzBdLmlkICsgJyJdLnByZXZpb3VzQ29tbWVudCcsIGRpZmZTZWN0aW9uRnJvbShs aW5lKSk7CisgICAgcmV0dXJuICQoJ2RpdltkYXRhLWNvbW1lbnQtZm9yfj0iJyArIGxpbmVbMF0u aWQgKyAnIl0ucHJldmlvdXNDb21tZW50JywgZmlsZURpZmZGb3IobGluZSkpOwogICB9CiAKICAg ZnVuY3Rpb24gZmluZENvbW1lbnRQb3NpdGlvbkZvcihsaW5lKSB7CkBAIC0xODksMTIgKzE4OSwx NyBAQAogICAgICAgICBhZGRQcmV2aW91c0NvbW1lbnQobGluZSwgYXV0aG9yLCBjb21tZW50X3Rl eHQpOwogICAgICAgfSk7CiAgICAgfQotICAgIGlmIChjb21tZW50cy5sZW5ndGggPT0gMCkKKwor ICAgIHZhciBoZWxwX3RleHQgPSAnU2Nyb2xsIHRob3VnaCBkaWZmcyB3aXRoIHRoZSAiaiIgYW5k ICJrIiBrZXlzLic7CisgICAgaWYgKGNvbW1lbnRzLmxlbmd0aCA9PSAwKSB7CisgICAgICAkKCcj bWVzc2FnZSAuY29tbWVudFN0YXR1cycpLnRleHQoaGVscF90ZXh0KTsKICAgICAgIHJldHVybjsK KyAgICB9CisKICAgICBkZXNjcmlwdG9yID0gY29tbWVudHMubGVuZ3RoICsgJyBjb21tZW50JzsK ICAgICBpZiAoY29tbWVudHMubGVuZ3RoID4gMSkKICAgICAgIGRlc2NyaXB0b3IgKz0gJ3MnOwot ICAgICQoJyNtZXNzYWdlIC5jb21tZW50U3RhdHVzJykudGV4dCgnVGhpcyBwYXRjaCBoYXMgJyAr IGRlc2NyaXB0b3IgKyAnLiAgU2Nyb2xsIHRocm91Z2ggdGhlbSB3aXRoIHRoZSAibiIgYW5kICJw IiBrZXlzLicpOworICAgICQoJyNtZXNzYWdlIC5jb21tZW50U3RhdHVzJykudGV4dCgnVGhpcyBw YXRjaCBoYXMgJyArIGRlc2NyaXB0b3IgKyAnLiAgU2Nyb2xsIHRocm91Z2ggdGhlbSB3aXRoIHRo ZSAibiIgYW5kICJwIiBrZXlzLiAnICsgaGVscF90ZXh0KTsKICAgfQogCiAgIGZ1bmN0aW9uIHNj YW5Gb3JDb21tZW50cyhhdXRob3IsIHRleHQpIHsKQEAgLTkzNCw0OCArOTM5LDEwNSBAQAogICAg IGZpbmRDb21tZW50QmxvY2tGb3IobGluZSkuaGlkZSgpLmFmdGVyKCQoJzxkaXYgY2xhc3M9ImZy b3plbkNvbW1lbnQiPjwvZGl2PicpLnRleHQoY29tbWVudF90ZXh0YXJlYS52YWwoKSkpOwogICB9 KTsKIAotICBmdW5jdGlvbiBmb2N1c09uKGNvbW1lbnQpIHsKKyAgZnVuY3Rpb24gZm9jdXNPbihu b2RlKSB7CiAgICAgJCgnLmZvY3VzZWQnKS5yZW1vdmVDbGFzcygnZm9jdXNlZCcpOwotICAgIGlm IChjb21tZW50Lmxlbmd0aCA9PSAwKQorICAgIGlmIChub2RlLmxlbmd0aCA9PSAwKQogICAgICAg cmV0dXJuOwotICAgICQoZG9jdW1lbnQpLnNjcm9sbFRvcChjb21tZW50LmFkZENsYXNzKCdmb2N1 c2VkJykucG9zaXRpb24oKS50b3AgLSB3aW5kb3cuaW5uZXJIZWlnaHQvMik7CisgICAgJChkb2N1 bWVudCkuc2Nyb2xsVG9wKG5vZGUuYWRkQ2xhc3MoJ2ZvY3VzZWQnKS5wb3NpdGlvbigpLnRvcCAt IHdpbmRvdy5pbm5lckhlaWdodCAvIDIpOwogICB9CiAKLSAgZnVuY3Rpb24gZm9jdXNOZXh0Q29t bWVudCgpIHsKLSAgICB2YXIgY29tbWVudHMgPSAkKCcucHJldmlvdXNDb21tZW50Jyk7Ci0gICAg aWYgKGNvbW1lbnRzLmxlbmd0aCA9PSAwKQotICAgICAgcmV0dXJuOwotICAgIHZhciBpbmRleCA9 IGNvbW1lbnRzLmluZGV4KCQoJy5mb2N1c2VkJykpOwotICAgIC8vIE5vdGljZSB0aGF0IC0xIGdl dHMgbWFwcGVkIHRvIDAuCi0gICAgZm9jdXNPbigkKGNvbW1lbnRzLmdldChpbmRleCArIDEpKSk7 CisgIGZ1bmN0aW9uIGRpZmZCbG9ja0VuZFBvaW50KGZvY3VzYWJsZV9ub2RlcywgbGluZSwgbGlu ZV9vZmZzZXQsIGlzX2JhY2t3YXJkKSB7CisgICAgaWYgKCFsaW5lX29mZnNldCAmJiBpc19iYWNr d2FyZCkKKyAgICAgIHJldHVybiBsaW5lOworCisgICAgdmFyIG9mZnNldCA9IGlzX2JhY2t3YXJk ID8gLTEgOiAxOworCisgICAgLy8gSWYgd2UncmUgYXQgYSBjb21tZW50LCBnZXQgYSBMaW5lIGlu IHRoZSBkaWZmIGJsb2NrIHRoYXQgY29udGFpbnMgdGhlIGNvbW1lbnQuCisgICAgaWYgKGxpbmUu aGFzQ2xhc3MoJ3ByZXZpb3VzQ29tbWVudCcpKSB7CisgICAgICB2YXIgbGluZV9mb3JfY29tbWVu dCA9ICQoJyMnICsgbGluZS5hdHRyKCdkYXRhLWNvbW1lbnQtZm9yJykpOworICAgICAgbGluZV9v ZmZzZXQgPSBmb2N1c2FibGVfbm9kZXMuaW5kZXgobGluZV9mb3JfY29tbWVudCk7CisKKyAgICAg IC8vIElmIHRoZSBjb21tZW50IGlzIG5vdCBpbnNpZGUgYSBkaWZmIGJsb2NrLCByZXR1cm4gdGhl IGNvbW1lbnQgbm9kZS4KKyAgICAgIGlmIChsaW5lX29mZnNldCA9PSAtMSkKKyAgICAgICAgcmV0 dXJuIGxpbmU7CisKKyAgICAgIGxpbmUgPSBsaW5lX2Zvcl9jb21tZW50OworICAgIH0KKworICAg IC8vIEZpbmQgdGhlIExpbmUgYXQgdGhlIGJlZ2lubmluZy9lbmQgb2YgdGhpcyBjb250aWd1b3Vz IGJsb2NrIG9mIGxpbmVzLgorICAgIC8vIENvbnRpZ3VvdXMgYmxvY2tzIG9mIGxpbmVzIGhhdmUg Y29udGlndW91cyBJRHMgYW5kIGFyZSBjb250YWluZWQgaW4gdGhlIHNhbWUgRmlsZURpZmYuCisg ICAgLy8gU2tpcCBvdmVyIGNvbW1lbnQgbm9kZXMuCisgICAgdmFyIGlkID0gbnVtYmVyRnJvbShs aW5lLmF0dHIoJ2lkJykpOworICAgIHZhciBuZXh0X25vZGUgPSAkKGZvY3VzYWJsZV9ub2Rlc1ts aW5lX29mZnNldCArIG9mZnNldF0pOworICAgIHdoaWxlIChuZXh0X25vZGUuc2l6ZSgpCisgICAg ICAgICAgICYmICghbmV4dF9ub2RlLmhhc0NsYXNzKCdMaW5lJykgfHwgbmV4dF9ub2RlLmF0dHIo J2lkJykgPT0gJ2xpbmUnICsgKGlkICsgb2Zmc2V0KSkKKyAgICAgICAgICAgJiYgZmlsZURpZmZG b3IobGluZSlbMF0gPT0gZmlsZURpZmZGb3IobmV4dF9ub2RlKVswXSkgeworICAgICAgaWYgKG5l eHRfbm9kZS5oYXNDbGFzcygnTGluZScpKSB7CisgICAgICAgIGxpbmUgPSBuZXh0X25vZGU7Cisg ICAgICAgIGlkICs9IG9mZnNldDsKKyAgICAgIH0KKworICAgICAgbGluZV9vZmZzZXQgKz0gb2Zm c2V0OworICAgICAgbmV4dF9ub2RlID0gJChmb2N1c2FibGVfbm9kZXNbbGluZV9vZmZzZXQgKyBv ZmZzZXRdKTsKKyAgICB9CisgICAgcmV0dXJuIGxpbmU7CiAgIH0KIAotICBmdW5jdGlvbiBmb2N1 c1ByZXZpb3VzQ29tbWVudCgpIHsKLSAgICB2YXIgY29tbWVudHMgPSAkKCcucHJldmlvdXNDb21t ZW50Jyk7Ci0gICAgaWYgKGNvbW1lbnRzLmxlbmd0aCA9PSAwKQotICAgICAgcmV0dXJuOwotICAg IHZhciBpbmRleCA9IGNvbW1lbnRzLmluZGV4KCQoJy5mb2N1c2VkJykpOwotICAgIGlmIChpbmRl eCA9PSAtMSkKLSAgICAgIGluZGV4ID0gY29tbWVudHMubGVuZ3RoOwotICAgIGlmIChpbmRleCA9 PSAwKSB7Ci0gICAgICBmb2N1c09uKFtdKTsKKyAgZnVuY3Rpb24gZm9jdXNOZXh0KGNsYXNzTmFt ZSwgaXNfYmFja3dhcmQpIHsKKyAgICB2YXIgZm9jdXNhYmxlX25vZGVzID0gJCgnLnByZXZpb3Vz Q29tbWVudCwuTGluZS5hZGQsLkxpbmUucmVtb3ZlJyk7CisgICAgdmFyIGZvY3VzZWRfbm9kZSA9 ICQoJy5mb2N1c2VkJyk7CisgICAgdmFyIGluZGV4ID0gZm9jdXNhYmxlX25vZGVzLmluZGV4KGZv Y3VzZWRfbm9kZSk7CisgICAgaWYgKGlzX2JhY2t3YXJkICYmICghaW5kZXggfHwgaW5kZXggPT0g LTEpKQogICAgICAgcmV0dXJuOworCisgICAgaWYgKGZvY3VzZWRfbm9kZS5zaXplKCkgJiYgY2xh c3NOYW1lID09ICdMaW5lJykgeworICAgICAgZm9jdXNlZF9ub2RlID0gZGlmZkJsb2NrRW5kUG9p bnQoZm9jdXNhYmxlX25vZGVzLCBmb2N1c2VkX25vZGUsIGluZGV4LCBpc19iYWNrd2FyZCk7Cisg ICAgICBpbmRleCA9IGZvY3VzYWJsZV9ub2Rlcy5pbmRleChmb2N1c2VkX25vZGUpOworICAgIH0K KworICAgIHZhciBlbmQgPSBpc19iYWNrd2FyZCA/IDAgOiBmb2N1c2FibGVfbm9kZXMuc2l6ZSgp OworICAgIHZhciBvZmZzZXQgPSBpc19iYWNrd2FyZCA/IC0xIDogMTsKKyAgICBmb3IgKHZhciBp ID0gaW5kZXggKyBvZmZzZXQ7IGkgIT0gZW5kOyBpID0gaSArIG9mZnNldCkgeworICAgICAgdmFy IG5vZGUgPSAkKGZvY3VzYWJsZV9ub2Rlc1tpXSk7CisgICAgICBpZiAobm9kZS5oYXNDbGFzcyhj bGFzc05hbWUpKSB7CisgICAgICAgIGlmIChjbGFzc05hbWUgPT0gJ0xpbmUnKSB7CisgICAgICAg ICAgLy8gUGFzcyBpbiB0cnVlIGZvciBpc19iYWNrd2FyZCBiZWNhdXNlIHdlIGFsd2F5cyB3YW50 IHRvIGZvY3VzIHRoZSBzdGFydCBvZiB0aGUgZGlmZiBibG9jay4KKyAgICAgICAgICBub2RlID0g ZGlmZkJsb2NrRW5kUG9pbnQoZm9jdXNhYmxlX25vZGVzLCBub2RlLCBpLCB0cnVlKTsKKyAgICAg ICAgfQorICAgICAgICBmb2N1c09uKG5vZGUpOworICAgICAgICByZXR1cm47CisgICAgICB9CiAg ICAgfQotICAgIGZvY3VzT24oJChjb21tZW50cy5nZXQoaW5kZXggLSAxKSkpOwogICB9CiAKICAg dmFyIGtDaGFyQ29kZUZvck4gPSAnbicuY2hhckNvZGVBdCgwKTsKICAgdmFyIGtDaGFyQ29kZUZv clAgPSAncCcuY2hhckNvZGVBdCgwKTsKKyAgdmFyIGtDaGFyQ29kZUZvckogPSAnaicuY2hhckNv ZGVBdCgwKTsKKyAgdmFyIGtDaGFyQ29kZUZvcksgPSAnaycuY2hhckNvZGVBdCgwKTsKIAogICAk KCdib2R5JykubGl2ZSgna2V5cHJlc3MnLCBmdW5jdGlvbigpIHsKICAgICAvLyBGSVhNRTogVGhl cmUncyBnb3QgdG8gYmUgYSBiZXR0ZXIgd2F5IHRvIGF2b2lkIHNlZWluZyB0aGVzZSBrZXlwcmVz cwogICAgIC8vIGV2ZW50cy4KICAgICBpZiAoZXZlbnQudGFyZ2V0Lm5vZGVOYW1lID09ICdURVhU QVJFQScpCiAgICAgICByZXR1cm47Ci0gICAgaWYgKGV2ZW50LmNoYXJDb2RlID09IGtDaGFyQ29k ZUZvck4pCi0gICAgICBmb2N1c05leHRDb21tZW50KCk7Ci0gICAgZWxzZSBpZiAoZXZlbnQuY2hh ckNvZGUgPT0ga0NoYXJDb2RlRm9yUCkKLSAgICAgIGZvY3VzUHJldmlvdXNDb21tZW50KCk7CisK KyAgICBzd2l0Y2ggKGV2ZW50LmNoYXJDb2RlKSB7CisgICAgY2FzZSBrQ2hhckNvZGVGb3JOOgor ICAgICAgZm9jdXNOZXh0KCdwcmV2aW91c0NvbW1lbnQnLCBmYWxzZSk7CisgICAgICBicmVhazsK KworICAgIGNhc2Uga0NoYXJDb2RlRm9yUDoKKyAgICAgIGZvY3VzTmV4dCgncHJldmlvdXNDb21t ZW50JywgdHJ1ZSk7CisgICAgICBicmVhazsKKworICAgIGNhc2Uga0NoYXJDb2RlRm9ySjoKKyAg ICAgIGZvY3VzTmV4dCgnTGluZScsIGZhbHNlKTsKKyAgICAgIGJyZWFrOworCisgICAgY2FzZSBr Q2hhckNvZGVGb3JLOgorICAgICAgZm9jdXNOZXh0KCdMaW5lJywgdHJ1ZSk7CisgICAgICBicmVh azsKKyAgICB9CiAgIH0pOwogCiAgIGZ1bmN0aW9uIGNvbnRleHRMaW5lc0ZvcihsaW5lX2lkKSB7 CkBAIC0xMTE3LDcgKzExNzksNyBAQAogICB9CiAKICAgZnVuY3Rpb24gZmlsZU5hbWVGb3IobGlu ZSkgewotICAgIHJldHVybiBsaW5lLnBhcmVudHNVbnRpbCgnLkZpbGVEaWZmJykucGFyZW50KCku ZmluZCgnaDEnKS50ZXh0KCk7CisgICAgcmV0dXJuIGZpbGVEaWZmRm9yKGxpbmUpLmZpbmQoJ2gx JykudGV4dCgpOwogICB9CiAKICAgZnVuY3Rpb24gaW5kZW50Rm9yKGRlcHRoKSB7Cg==