52303 2011-01-12 10:20:33 -0800 Web Inspector: cookie table is multiplied after repeated switching to cookies tab in network item view 2011-01-12 12:08:15 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 333140 0 caseq 2011-01-12 10:20:33 -0800 1. Open Inspector 2. Navigate to a page with cookies 3. Network panel -> any resource with cookies -> Cookies tab 4. Switch back and forth between Cookies tab and some other tab 5. Observe multiple instance of cookies table in the tab 333148 1 78703 caseq 2011-01-12 10:29:53 -0800 Created attachment 78703 patch 333161 2 78703 joepeck 2011-01-12 10:53:42 -0800 Comment on attachment 78703 patch View in context: https://bugs.webkit.org/attachment.cgi?id=78703&action=review > Source/WebCore/ChangeLog:6 > + Only create cookiesTable is it hasn't been done yet. Nit: (typo) "is it hasn't" => "if it hasn't" This is not a big deal. 333215 3 78703 commit-queue 2011-01-12 12:08:09 -0800 Comment on attachment 78703 patch Clearing flags on attachment: 78703 Committed r75629: <http://trac.webkit.org/changeset/75629> 333217 4 commit-queue 2011-01-12 12:08:15 -0800 All reviewed patches have been landed. Closing bug. 78703 2011-01-12 10:29:53 -0800 2011-01-12 12:08:09 -0800 patch mult-cookies-table.diff text/plain 2413 caseq ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1YmYxMDczLi4yMDM1YmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDEtMTIgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBjb29raWUgdGFibGUgaXMgbXVsdGlwbGllZCBhZnRlciByZXBlYXRlZCBzd2l0Y2hpbmcg dG8gY29va2llcyB0YWIgaW4gbmV0d29yayBpdGVtIHZpZXcKKyAgICAgICAgT25seSBjcmVhdGUg Y29va2llc1RhYmxlIGlzIGl0IGhhc24ndCBiZWVuIGRvbmUgeWV0LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIzMDMKKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvUmVzb3VyY2VDb29raWVzVmlldy5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5SZXNvdXJjZUNvb2tpZXNWaWV3LnByb3RvdHlwZS5zaG93KToKKwogMjAxMC0xMi0yOSAg WXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9SZXNvdXJjZUNvb2tpZXNWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZUNvb2tpZXNWaWV3LmpzCmluZGV4IGU0MTkwNzAuLmI2MGIx YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3Vy Y2VDb29raWVzVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Jlc291cmNlQ29va2llc1ZpZXcuanMKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0 IChDKSAyMDA5LCAyMDEwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5 cmlnaHQgKEMpIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBS ZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9y IHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRo ZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTU2LDEwICs1NiwxMiBAQCBXZWJJbnNwZWN0 b3IuUmVzb3VyY2VDb29raWVzVmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICh0aGlzLl9l bXB0eU1zZ0VsZW1lbnQpCiAgICAgICAgICAgICB0aGlzLl9lbXB0eU1zZ0VsZW1lbnQucGFyZW50 RWxlbWVudC5yZW1vdmVDaGlsZCh0aGlzLl9lbXB0eU1zZ0VsZW1lbnQpOwogCi0gICAgICAgIHRo aXMuX2Nvb2tpZXNUYWJsZSA9IG5ldyBXZWJJbnNwZWN0b3IuQ29va2llc1RhYmxlKG51bGwsIHRy dWUsIHRydWUpOwotICAgICAgICB0aGlzLl9jb29raWVzVGFibGUuYWRkQ29va2llc0ZvbGRlcihX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJlcXVlc3QgQ29va2llcyIpLCB0aGlzLl9yZXNvdXJjZS5y ZXF1ZXN0Q29va2llcyk7Ci0gICAgICAgIHRoaXMuX2Nvb2tpZXNUYWJsZS5hZGRDb29raWVzRm9s ZGVyKFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmVzcG9uc2UgQ29va2llcyIpLCB0aGlzLl9yZXNv dXJjZS5yZXNwb25zZUNvb2tpZXMpOwotICAgICAgICB0aGlzLmVsZW1lbnQuYXBwZW5kQ2hpbGQo dGhpcy5fY29va2llc1RhYmxlLmVsZW1lbnQpOworICAgICAgICBpZiAoIXRoaXMuX2Nvb2tpZXNU YWJsZSkgeworICAgICAgICAgICAgdGhpcy5fY29va2llc1RhYmxlID0gbmV3IFdlYkluc3BlY3Rv ci5Db29raWVzVGFibGUobnVsbCwgdHJ1ZSwgdHJ1ZSk7CisgICAgICAgICAgICB0aGlzLl9jb29r aWVzVGFibGUuYWRkQ29va2llc0ZvbGRlcihXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJlcXVlc3Qg Q29va2llcyIpLCB0aGlzLl9yZXNvdXJjZS5yZXF1ZXN0Q29va2llcyk7CisgICAgICAgICAgICB0 aGlzLl9jb29raWVzVGFibGUuYWRkQ29va2llc0ZvbGRlcihXZWJJbnNwZWN0b3IuVUlTdHJpbmco IlJlc3BvbnNlIENvb2tpZXMiKSwgdGhpcy5fcmVzb3VyY2UucmVzcG9uc2VDb29raWVzKTsKKyAg ICAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9jb29raWVzVGFibGUuZWxl bWVudCk7CisgICAgICAgIH0KIAogICAgICAgICBXZWJJbnNwZWN0b3IuVmlldy5wcm90b3R5cGUu c2hvdy5jYWxsKHRoaXMsIHBhcmVudEVsZW1lbnQpOwogICAgICAgICB0aGlzLl9jb29raWVzVGFi bGUudXBkYXRlV2lkdGhzKCk7Cg==