52289 2011-01-12 03:48:37 -0800 [Qt] cookiesEnabled could create the cookieJar on the wrong thread. 2011-02-08 01:01:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 1 jturcotte benjamin abarth commit-queue eric webkit.review.bot oldest_to_newest 333012 0 jturcotte 2011-01-12 03:48:37 -0800 This will happen if QNetworkAccessManager::cookieJar() is called when the cookie jar hasn't been created in the QNAM yet. See bug #52081. 333014 1 benjamin 2011-01-12 03:59:03 -0800 Thanks Jocelyn for creating the bug report. I'll look into that. 346704 2 81502 benjamin 2011-02-07 11:51:48 -0800 Created attachment 81502 Patch 346711 3 jturcotte 2011-02-07 12:15:58 -0800 (In reply to comment #2) > Created an attachment (id=81502) [details] > Patch I have no authority to say so, but nevertheless this patch LGTM. 346742 4 benjamin 2011-02-07 13:00:13 -0800 (In reply to comment #3) > I have no authority to say so, but nevertheless this patch LGTM. Thanks for looking, I was hoping you would do so :) 347108 5 81502 commit-queue 2011-02-07 22:27:27 -0800 Comment on attachment 81502 Patch Clearing flags on attachment: 81502 Committed r77901: <http://trac.webkit.org/changeset/77901> 347109 6 commit-queue 2011-02-07 22:27:32 -0800 All reviewed patches have been landed. Closing bug. 347128 7 webkit.review.bot 2011-02-07 22:54:23 -0800 http://trac.webkit.org/changeset/77901 might have broken Qt Linux Release The following tests are not passing: http/tests/websocket/tests/websocket-protocol-ignored.html 347226 8 benjamin 2011-02-08 01:01:22 -0800 (In reply to comment #7) > http://trac.webkit.org/changeset/77901 might have broken Qt Linux Release > The following tests are not passing: > http/tests/websocket/tests/websocket-protocol-ignored.html Unlikely related to this patch. 81502 2011-02-07 11:51:48 -0800 2011-02-07 22:27:27 -0800 Patch bug-52289-20110207205145.patch text/plain 6998 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMDE4MDUwN2JmMzYzOWI1ZDk3OWY2YTI3NTczZjA1NGYyMzI4NGUzLi5k ZmVjMzY2MDlmODc5NzRjYjVmNzk5NTUzMmRhOWMyMTU5NjBlNDczIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjAgQEAKKzIwMTEtMDItMDcgIEJlbmphbWluIFBvdWxhaW4gIDxpa2lwb3VAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtR dF0gY29va2llc0VuYWJsZWQgY291bGQgY3JlYXRlIHRoZSBjb29raWVKYXIgb24gdGhlIHdyb25n IHRocmVhZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUyMjg5CisKKyAgICAgICAgVXNlIHRoZSBRdE5BTVRocmVhZFNhZmVQcm94eSB0byBtYWtlIHN1 cmUgdGhlIGNvb2tpZSBqYXIgaXMgY3JlYXRlZAorICAgICAgICBpbiB0aGUgc2FtZSB0aHJlYWQg YXMgdGhlIFFOZXR3b3JrQWNjZXNzTWFuYWdlci4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvcXQvUXROQU1UaHJlYWRTYWZlUHJveHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UXROQU1U aHJlYWRTYWZlUHJveHk6OlF0TkFNVGhyZWFkU2FmZVByb3h5KToKKyAgICAgICAgKFdlYkNvcmU6 OlF0TkFNVGhyZWFkU2FmZVByb3h5OjpoYXNDb29raWVKYXIpOgorICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvcXQvUXROQU1UaHJlYWRTYWZlUHJveHkuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9x dC9Db29raWVKYXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb29raWVzRW5hYmxlZCk6CisK IDIwMTEtMDItMDYgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL3F0L1F0TkFNVGhyZWFkU2FmZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvcXQvUXROQU1UaHJlYWRTYWZlUHJveHkuY3BwCmluZGV4IGUwZDZl NjkzNGU3YmFlYzM4NzNkMmFjZTJiYzM1YmNhMjdlNTQxZjIuLmE5OGI0ZjQwMGM2MTBkMjc3ZTVm OTE4NWViZTQ3YmI3ZGQ4NmVlMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvcXQvUXROQU1UaHJlYWRTYWZlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvcXQvUXROQU1UaHJlYWRTYWZlUHJveHkuY3BwCkBAIC0zNSw2ICsz NSwxOCBAQCBRdE5BTVRocmVhZFNhZmVQcm94eTo6UXROQU1UaHJlYWRTYWZlUHJveHkoUU5ldHdv cmtBY2Nlc3NNYW5hZ2VyICptYW5hZ2VyKQogICAgIGNvbm5lY3QodGhpcywgU0lHTkFMKGxvY2Fs U2V0Q29va2llc1JlcXVlc3RlZChjb25zdCBRVXJsJiwgY29uc3QgUVN0cmluZyYpKSwgU0xPVChs b2NhbFNldENvb2tpZXMoY29uc3QgUVVybCYsIGNvbnN0IFFTdHJpbmcmKSkpOwogICAgIGNvbm5l Y3QodGhpcywgU0lHTkFMKGxvY2FsQ29va2llc0ZvclVybFJlcXVlc3RlZChjb25zdCBRVXJsJiwg Ym9vbCosIFFMaXN0PFFOZXR3b3JrQ29va2llPiopKSwgU0xPVChsb2NhbENvb2tpZXNGb3JVcmwo Y29uc3QgUVVybCYsIGJvb2wqLCBRTGlzdDxRTmV0d29ya0Nvb2tpZT4qKSkpOwogICAgIGNvbm5l Y3QodGhpcywgU0lHTkFMKGxvY2FsV2lsbExvYWRGcm9tQ2FjaGVSZXF1ZXN0ZWQoY29uc3QgUVVy bCYsIGJvb2wqLCBib29sKikpLCBTTE9UKGxvY2FsV2lsbExvYWRGcm9tQ2FjaGUoY29uc3QgUVVy bCYsIGJvb2wqLCBib29sKikpKTsKKyAgICBjb25uZWN0KHRoaXMsIFNJR05BTChoYXNDb29raWVK YXJSZXF1ZXN0ZWQoYm9vbCosIGJvb2wqKSksIFNMT1QoaGFzQ29va2llSmFyKGJvb2wqLCBib29s KikpKTsKK30KKworYm9vbCBRdE5BTVRocmVhZFNhZmVQcm94eTo6aGFzQ29va2llSmFyKCkKK3sK KyAgICBib29sIHJlc3VsdDsKKyAgICBib29sIGRvbmUgPSBmYWxzZTsKKyAgICBlbWl0IGhhc0Nv b2tpZUphclJlcXVlc3RlZCgmZG9uZSwgJnJlc3VsdCk7CisgICAgUU11dGV4TG9ja2VyIGxvY2so Jm1fcmVzdWx0TXV0ZXgpOworICAgIHdoaWxlICghZG9uZSkKKyAgICAgICAgbV9yZXN1bHRXYWl0 Q29uZGl0aW9uLndhaXQoJm1fcmVzdWx0TXV0ZXgpOworICAgIHJldHVybiByZXN1bHQ7CiB9CiAK IHZvaWQgUXROQU1UaHJlYWRTYWZlUHJveHk6OmxvY2FsU2V0Q29va2llcyhjb25zdCBRVXJsJiB1 cmwsIGNvbnN0IFFTdHJpbmcmIGNvb2tpZXMpCkBAIC02OSw2ICs4MSwxNCBAQCB2b2lkIFF0TkFN VGhyZWFkU2FmZVByb3h5Ojpsb2NhbFdpbGxMb2FkRnJvbUNhY2hlKGNvbnN0IFFVcmwmIHVybCwg Ym9vbCogZG9uZSwgYgogICAgIG1fcmVzdWx0V2FpdENvbmRpdGlvbi53YWtlQWxsKCk7CiB9CiAK K3ZvaWQgUXROQU1UaHJlYWRTYWZlUHJveHk6Omhhc0Nvb2tpZUphcihib29sKiBkb25lLCBib29s KiByZXN1bHQpCit7CisgICAgUU11dGV4TG9ja2VyIGxvY2soJm1fcmVzdWx0TXV0ZXgpOworICAg ICpyZXN1bHQgPSAhIW1fbWFuYWdlci0+Y29va2llSmFyKCk7CisgICAgKmRvbmUgPSB0cnVlOwor ICAgIG1fcmVzdWx0V2FpdENvbmRpdGlvbi53YWtlQWxsKCk7Cit9CisKIFF0TmV0d29ya1JlcGx5 VGhyZWFkU2FmZVByb3h5OjpRdE5ldHdvcmtSZXBseVRocmVhZFNhZmVQcm94eShRTmV0d29ya0Fj Y2Vzc01hbmFnZXIgKm1hbmFnZXIpCiAgICAgOiBtX21hbmFnZXIobWFuYWdlcikKICAgICAsIG1f cmVwbHkoMCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQv UXROQU1UaHJlYWRTYWZlUHJveHkuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv cXQvUXROQU1UaHJlYWRTYWZlUHJveHkuaAppbmRleCBhZTk2M2NmNzAyMzJjNzViNTZmM2UxMTMw NWNjY2E5ODY4OTZmOGRiLi40OTA2ZmUyOTQ1ZTA1NGQ0OTY3YzJhYzRjNmQ2Y2ZkY2JlMjk3NzJi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1F0TkFNVGhy ZWFkU2FmZVByb3h5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9R dE5BTVRocmVhZFNhZmVQcm94eS5oCkBAIC02NywxNSArNjcsMTkgQEAgcHVibGljOgogICAgICAg ICByZXR1cm4gcmVzdWx0OwogICAgIH0KIAorICAgIGJvb2wgaGFzQ29va2llSmFyKCk7CisKIHNp Z25hbHM6CiAgICAgdm9pZCBsb2NhbFNldENvb2tpZXNSZXF1ZXN0ZWQoY29uc3QgUVVybCYsIGNv bnN0IFFTdHJpbmcmIGNvb2tpZXMpOwogICAgIHZvaWQgbG9jYWxDb29raWVzRm9yVXJsUmVxdWVz dGVkKGNvbnN0IFFVcmwmLCBib29sKiBkb25lLCBRTGlzdDxRTmV0d29ya0Nvb2tpZT4qIHJlc3Vs dCk7CiAgICAgdm9pZCBsb2NhbFdpbGxMb2FkRnJvbUNhY2hlUmVxdWVzdGVkKGNvbnN0IFFVcmwm LCBib29sKiBkb25lLCBib29sKiByZXN1bHQpOworICAgIHZvaWQgaGFzQ29va2llSmFyUmVxdWVz dGVkKGJvb2wqIGRvbmUsIGJvb2wqIHJlc3VsdCk7CiAKIHByaXZhdGUgc2xvdHM6CiAgICAgdm9p ZCBsb2NhbFNldENvb2tpZXMoY29uc3QgUVVybCYsIGNvbnN0IFFTdHJpbmcmIGNvb2tpZXMpOwog ICAgIHZvaWQgbG9jYWxDb29raWVzRm9yVXJsKGNvbnN0IFFVcmwmLCBib29sKiBkb25lLCBRTGlz dDxRTmV0d29ya0Nvb2tpZT4qIHJlc3VsdCk7CiAgICAgdm9pZCBsb2NhbFdpbGxMb2FkRnJvbUNh Y2hlKGNvbnN0IFFVcmwmLCBib29sKiBkb25lLCBib29sKiByZXN1bHQpOworICAgIHZvaWQgaGFz Q29va2llSmFyKGJvb2wqIGRvbmUsIGJvb2wqIHJlc3VsdCk7CiAKIHByaXZhdGU6CiAgICAgUU5l dHdvcmtBY2Nlc3NNYW5hZ2VyKiBtX21hbmFnZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9x dC9Db29raWVKYXJRdC5jcHAKaW5kZXggYjdmZjVkMTQ2NjczZTlkNjkxM2M5MWJjMzE0ODhlN2M4 YTM3OTNjMC4uZTVhMmRjZGZkMzgzNmRkODEzZmYxMTI2MDNlY2I5MjE0MzY1NmQyNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0Nvb2tpZUphclF0LmNwcApAQCAtMTE0LDEwICsxMTQs MTIgQEAgU3RyaW5nIGNvb2tpZVJlcXVlc3RIZWFkZXJGaWVsZFZhbHVlKGNvbnN0IERvY3VtZW50 KiBkb2N1bWVudCwgY29uc3QgS1VSTCAmdXJsKQogCiBib29sIGNvb2tpZXNFbmFibGVkKGNvbnN0 IERvY3VtZW50KiBkb2N1bWVudCkKIHsKLSAgICBpZiAoUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyKiBt YW5hZ2VyID0gbmV0d29ya0FjY2Vzc01hbmFnZXIoZG9jdW1lbnQpKQotICAgICAgICByZXR1cm4g ISFtYW5hZ2VyLT5jb29raWVKYXIoKTsKKyAgICBRTmV0d29ya0FjY2Vzc01hbmFnZXIqIG1hbmFn ZXIgPSBuZXR3b3JrQWNjZXNzTWFuYWdlcihkb2N1bWVudCk7CisgICAgaWYgKCFtYW5hZ2VyKQor ICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICByZXR1cm4gZmFsc2U7CisgICAgUXROQU1UaHJl YWRTYWZlUHJveHkgbWFuYWdlclByb3h5KG1hbmFnZXIpOworICAgIHJldHVybiBtYW5hZ2VyUHJv eHkuaGFzQ29va2llSmFyKCk7CiB9CiAKIGJvb2wgZ2V0UmF3Q29va2llcyhjb25zdCBEb2N1bWVu dCosIGNvbnN0IEtVUkwmLCBWZWN0b3I8Q29va2llPiYgcmF3Q29va2llcykKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cK aW5kZXggOTNhN2NmOGJmZDRlYWZhMjJiNzU0MTdmNmFhNDM3ZTVlNGQzNzI2MC4uYmFlM2Q5MWZi YWU5MzYxNDQzNmFkNTdmNmJhMmMzOGUyNWQ1MWI3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxMS0wMi0wNyAgQmVuamFtaW4gUG91bGFpbiAgPGlraXBvdUBnbWFpbC5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBj b29raWVzRW5hYmxlZCBjb3VsZCBjcmVhdGUgdGhlIGNvb2tpZUphciBvbiB0aGUgd3JvbmcgdGhy ZWFkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIy ODkKKworICAgICAgICBUZXN0IGlmIHRoZSBjb29raWUgamFyIGlzIGNyZWF0ZWQgaW4gdGhlIHJp Z2h0IHRocmVhZCB3aGVuIGFjY2Vzc2VkIGZyb20KKyAgICAgICAgdGhlIG5hdmlnYXRvciBvYmpl Y3QuCisKKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOgorICAgICAg ICAodHN0X1FXZWJQYWdlOjpuYXZpZ2F0b3JDb29raWVFbmFibGVkRm9yTmV0d29ya0FjY2Vzc01h bmFnZXJPbkRpZmZlcmVudFRocmVhZCk6CisKIDIwMTEtMDItMDYgIFJvYmVydCBIb2dhbiAgPHJv YmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKaW5k ZXggZWMxZjMzNjU1M2QwYTEzMDIwYzhlZDRhNjEwMDQ2YTMyM2RlYmZjYy4uYjhlZmM2ZTU0MDdi YmE2MzgxZjE5NGU5M2RjMjUyYTQwNmRmMjY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9x dC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQv dGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcApAQCAtMTMzLDYgKzEzMyw3IEBAIHByaXZh dGUgc2xvdHM6CiAgICAgdm9pZCBpbmZpbml0ZUxvb3BKUygpOwogICAgIHZvaWQgbmV0d29ya0Fj Y2Vzc01hbmFnZXJPbkRpZmZlcmVudFRocmVhZCgpOwogICAgIHZvaWQgbmF2aWdhdG9yQ29va2ll RW5hYmxlZCgpOworICAgIHZvaWQgbmF2aWdhdG9yQ29va2llRW5hYmxlZEZvck5ldHdvcmtBY2Nl c3NNYW5hZ2VyT25EaWZmZXJlbnRUaHJlYWQoKTsKIAogI2lmZGVmIFFfT1NfTUFDCiAgICAgdm9p ZCBtYWNDb3B5VW5pY29kZVRvQ2xpcGJvYXJkKCk7CkBAIC0yNzQwLDYgKzI3NDEsMTkgQEAgdm9p ZCB0c3RfUVdlYlBhZ2U6Om5hdmlnYXRvckNvb2tpZUVuYWJsZWQoKQogICAgIFFWRVJJRlkobV9w YWdlLT5tYWluRnJhbWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJuYXZpZ2F0b3IuY29va2llRW5h YmxlZCIpLnRvQm9vbCgpKTsKIH0KIAordm9pZCB0c3RfUVdlYlBhZ2U6Om5hdmlnYXRvckNvb2tp ZUVuYWJsZWRGb3JOZXR3b3JrQWNjZXNzTWFuYWdlck9uRGlmZmVyZW50VGhyZWFkKCkKK3sKKyAg ICBRdE5BTVRocmVhZCBxbmFtVGhyZWFkOworICAgIHFuYW1UaHJlYWQuc3RhcnQoKTsKKyAgICBt X3BhZ2UtPnNldE5ldHdvcmtBY2Nlc3NNYW5hZ2VyKHFuYW1UaHJlYWQubmV0d29ya0FjY2Vzc01h bmFnZXIoKSk7CisKKyAgICAvLyBUaGlzIGNhbGwgYWNjZXNzIHRoZSBjb29raWUgamFyLCB0aGUg Y29va2llIGphciBtdXN0IGJlIGluIHRoZSBzYW1lIHRocmVhZCBhcworICAgIC8vIHRoZSBuZXR3 b3JrIGFjY2VzcyBtYW5hZ2VyLgorICAgIFFWRVJJRlkobV9wYWdlLT5tYWluRnJhbWUoKS0+ZXZh bHVhdGVKYXZhU2NyaXB0KCJuYXZpZ2F0b3IuY29va2llRW5hYmxlZCIpLnRvQm9vbCgpKTsKKwor ICAgIFFDT01QQVJFKHFuYW1UaHJlYWQubmV0d29ya0FjY2Vzc01hbmFnZXIoKS0+Y29va2llSmFy KCktPnRocmVhZCgpLCAmcW5hbVRocmVhZCk7Cit9CisKICNpZmRlZiBRX09TX01BQwogdm9pZCB0 c3RfUVdlYlBhZ2U6Om1hY0NvcHlVbmljb2RlVG9DbGlwYm9hcmQoKQogewo=