52283 2011-01-12 02:15:35 -0800 Remove premature optimization from SchemeRegistry 2011-01-12 17:40:11 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue darin eric oldest_to_newest 332973 0 abarth 2011-01-12 02:15:35 -0800 Remove premature optimization from SchemeRegistry 332975 1 78666 abarth 2011-01-12 02:18:38 -0800 Created attachment 78666 Patch 332993 2 abarth 2011-01-12 02:59:52 -0800 This code looks to have been added in http://trac.webkit.org/changeset/19952, which doesn't explain why this optimization is necessary. 332995 3 abarth 2011-01-12 03:00:18 -0800 There might be more information in rdar://problem/4922454, but I can't see it. 333284 4 darin 2011-01-12 14:12:07 -0800 (In reply to comment #3) > There might be more information in rdar://problem/4922454, but I can't see it. That’s a security bug, so I can give some details here, but probably best to do so in a security-sensitive bug. 333343 5 abarth 2011-01-12 15:13:35 -0800 I'm marking this bug as security sensitive, not because this issue reflects a security issue but so we can discuss the original motivation for the code we're changing. 333400 6 darin 2011-01-12 16:21:49 -0800 Radar bug 4922454 was about http-protocol HTML files being able to load file-protocol scripts. The information in Radar does not any insight into why the fix included the optimized path. Sorry, didn’t mean to be a tease. I suppose this really isn’t all that security-sensitive. I was rushing and doing multiple things at once and really noticed only that the classification was security. 333407 7 abarth 2011-01-12 16:25:14 -0800 Thanks for looking in rdar. I'm going to move this back to non-sensitive so the commit-queue can land the patch. 333461 8 78666 commit-queue 2011-01-12 17:40:06 -0800 Comment on attachment 78666 Patch Clearing flags on attachment: 78666 Committed r75664: <http://trac.webkit.org/changeset/75664> 333462 9 commit-queue 2011-01-12 17:40:11 -0800 All reviewed patches have been landed. Closing bug. 78666 2011-01-12 02:18:38 -0800 2011-01-12 17:40:06 -0800 Patch bug-52283-20110112021833.patch text/plain 1790 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1NTk0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDEtMTIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgcHJlbWF0dXJlIG9wdGltaXphdGlvbiBmcm9tIFNjaGVt ZVJlZ2lzdHJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MjI4MworCisgICAgICAgIEFzIGZhciBhcyBJIGNhbiB0ZWxsLCB0aGlzIG9wdGltaXphdGlv biBpc24ndCBuZWNlc3NhcnkuICBJJ20gc2xpZ2h0bHkKKyAgICAgICAgdW5zdXJlIHdoaWNoIGJl bmNobWFya3MgdG8gcnVuIHRvIGRlbW9uc3RyYXRlIHRoaXMgbnVtZXJpY2FsbHksIGJ1dAorICAg ICAgICBub25lIG9mIHRoZSBiZW5jaG1hcmtzIENocm9taXVtIHRyYWNrcyB3ZXJlIGFmZmVjdGVk IGJ5IGFkZGluZyBhCisgICAgICAgIHNpbWlsYXIgY2hlY2sgZm9yICJkaXNwbGF5LWlzb2xhdGVk IiBzY2hlbWVzLgorCisgICAgICAgICogcGxhdGZvcm0vU2NoZW1lUmVnaXN0cnkuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U2NoZW1lUmVnaXN0cnk6OnNob3VsZFRyZWF0VVJMU2NoZW1lQXNMb2Nh bCk6CisKIDIwMTEtMDEtMTEgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vU2NoZW1lUmVnaXN0cnkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1NjaGVtZVJlZ2lzdHJ5LmNwcAkocmV2aXNpb24gNzU1ODgpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9TY2hlbWVSZWdpc3RyeS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEwOSwxOSArMTA5LDggQEAgY29uc3QgVVJMU2NoZW1lc01hcCYgU2NoZW1lUmVnaXN0cnk6Omxv YwogCiBib29sIFNjaGVtZVJlZ2lzdHJ5OjpzaG91bGRUcmVhdFVSTFNjaGVtZUFzTG9jYWwoY29u c3QgU3RyaW5nJiBzY2hlbWUpCiB7Ci0gICAgLy8gVGhpcyBhdm9pZHMgYW4gYWxsb2NhdGlvbiBv ZiBhbm90aGVyIFN0cmluZyBhbmQgdGhlIEhhc2hTZXQgY29udGFpbnMoKQotICAgIC8vIGNhbGwg Zm9yIHRoZSBmaWxlOiBhbmQgaHR0cDogc2NoZW1lcy4KLSAgICBpZiAoc2NoZW1lLmxlbmd0aCgp ID09IDQpIHsKLSAgICAgICAgY29uc3QgVUNoYXIqIHMgPSBzY2hlbWUuY2hhcmFjdGVycygpOwot ICAgICAgICBpZiAoc1swXSA9PSAnaCcgJiYgc1sxXSA9PSAndCcgJiYgc1syXSA9PSAndCcgJiYg c1szXSA9PSAncCcpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIGlmIChzWzBd ID09ICdmJyAmJiBzWzFdID09ICdpJyAmJiBzWzJdID09ICdsJyAmJiBzWzNdID09ICdlJykKLSAg ICAgICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KLQogICAgIGlmIChzY2hlbWUuaXNFbXB0eSgp KQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICByZXR1cm4gbG9jYWxVUkxTY2hlbWVzKCku Y29udGFpbnMoc2NoZW1lKTsKIH0KIAo=