52279 2011-01-12 00:14:33 -0800 WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks 2011-01-19 20:20:05 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yuzo yuzo commit-queue tkent oldest_to_newest 332943 0 yuzo 2011-01-12 00:14:33 -0800 See http://code.google.com/p/chromium/issues/detail?id=68268 Open 0.html attached to the bug report. 332954 1 78662 yuzo 2011-01-12 00:39:40 -0800 Created attachment 78662 Patch 333591 2 78662 tkent 2011-01-13 01:34:41 -0800 Comment on attachment 78662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78662&action=review > Source/WebCore/ChangeLog:11 > + weird position and a crash will result for documents containing Could you explain what is "weird position" concretely and why it causes a crash concretely please? 333602 3 78789 yuzo 2011-01-13 02:21:19 -0800 Created attachment 78789 Revised ChangeLog 333603 4 yuzo 2011-01-13 02:22:33 -0800 Thank you for the review. Updated the ChangeLog. Does it look better? (In reply to comment #2) > (From update of attachment 78662 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78662&action=review > > > Source/WebCore/ChangeLog:11 > > + weird position and a crash will result for documents containing > > Could you explain what is "weird position" concretely and why it causes a crash concretely please? 334091 5 tkent 2011-01-13 20:11:43 -0800 (In reply to comment #4) > Updated the ChangeLog. Does it look better? Does it mean nextObj can be NULL? 336943 6 yuzo 2011-01-19 16:52:04 -0800 Yes, it can be null and then the crash results. (In reply to comment #5) > (In reply to comment #4) > > Updated the ChangeLog. Does it look better? > > Does it mean nextObj can be NULL? 336966 7 78789 tkent 2011-01-19 17:24:06 -0800 Comment on attachment 78789 Revised ChangeLog ok, I understand. 336998 8 78789 yuzo 2011-01-19 17:58:42 -0800 Comment on attachment 78789 Revised ChangeLog Thank you for the review. 337074 9 yuzo 2011-01-19 20:20:05 -0800 Committed r76201: <http://trac.webkit.org/changeset/76201> 78662 2011-01-12 00:39:40 -0800 2011-01-13 02:21:19 -0800 Patch 52279.patch text/plain 3244 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiYjE2ODA0Li5iNTkzZmYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEt MTIgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgQnVnIDUyMjc5IC0gV2ViQ29y ZTo6UmVuZGVyQmxvY2s6OnVwZGF0ZUZpcnN0TGV0dGVyIGNyYXNoZXMgZm9yIGFub255bW91cyBi bG9ja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUy Mjc5CisKKyAgICAgICAgKiBmYXN0L2Nzcy9maXJzdC1sZXR0ZXItYW5vbnltb3VzLWJsb2NrLWNy YXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvZmlyc3QtbGV0dGVy LWFub255bW91cy1ibG9jay1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMS0wMS0xMSAgTmljbyBX ZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGVzdCBl eHBlY3RhdGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0 ZXItYW5vbnltb3VzLWJsb2NrLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL2ZpcnN0LWxldHRlci1hbm9ueW1vdXMtYmxvY2stY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjc2OTY0MjEKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXItYW5vbnltb3VzLWJsb2NrLWNyYXNo LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitObyBjcmFzaCBtZWFucyBQQVNTCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXItYW5vbnltb3VzLWJsb2NrLWNy YXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXItYW5vbnltb3VzLWJs b2NrLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uM2MyMTUw NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2ZpcnN0LWxldHRlci1h bm9ueW1vdXMtYmxvY2stY3Jhc2guaHRtbApAQCAtMCwwICsxLDE1IEBACis8aHRtbD4KKzxzdHls ZSB0eXBlPXRleHQvY3NzPgorZGQ6Zmlyc3QtbGV0dGVyIHsgY29udGVudDoiIjsgfQorZGlyOmZp cnN0LWxldHRlciB7IHRleHQtYWxpZ246IiI7IH0KKzwvc3R5bGU+Cis8ZGQ+Cis8ZGlyPgorPGZv bnQ+Cis8Zm9ybT4KK05vIGNyYXNoIG1lYW5zIFBBU1MKKzxzY3JpcHQ+CitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKKzwvc2NyaXB0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU0OGIwMjQuLjE3NzZkM2QgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMS0wMS0xMiAgWXV6byBGdWppc2hpbWEgIDx5 dXpvQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IGZvciBCdWcgNTIyNzkgLSBXZWJDb3JlOjpSZW5kZXJCbG9jazo6dXBkYXRl Rmlyc3RMZXR0ZXIgY3Jhc2hlcyBmb3IgYW5vbnltb3VzIGJsb2NrcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIyNzkKKworICAgICAgICBJbiBjb25z dHJ1Y3RpbmcgdGV4dCBmcmFnbWVudHMgdG8gaGFuZGxlIGZpcnN0LWxldHRlciBydWxlLCBmaXJz dCBhZGQKKyAgICAgICAgdGhlIHRleHQgZm9yIHRoZSBub24tZmlyc3QgbGV0dGVycyBhbmQgdGhl biByZW1vdmUgdGhlIG9yaWdpbmFsIHRleHQsCisgICAgICAgIHJhdGhlciB0aGFuIHRoZSBvdGhl ciB3YXkgYXJvdW5kLiBPdGhlcndpc2UsIHRoZSB0ZXh0IGNhbiBiZSBhZGRlZCB0byBhCisgICAg ICAgIHdlaXJkIHBvc2l0aW9uIGFuZCBhIGNyYXNoIHdpbGwgcmVzdWx0IGZvciBkb2N1bWVudHMg Y29udGFpbmluZworICAgICAgICBhbm9ueW1vdXMgYmxvY2tzLgorCisgICAgICAgIFRlc3Q6IGZh c3QvY3NzL2ZpcnN0LWxldHRlci1hbm9ueW1vdXMtYmxvY2stY3Jhc2guaHRtbAorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJs b2NrOjp1cGRhdGVGaXJzdExldHRlcik6CisKIDIwMTEtMDEtMTEgIEFuZHkgRXN0ZXMgIDxhZXN0 ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggZTM5MjIzYS4uZDcyMjY2MiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC01MjYwLDkgKzUy NjAsOCBAQCB2b2lkIFJlbmRlckJsb2NrOjp1cGRhdGVGaXJzdExldHRlcigpCiAgICAgICAgIGlm IChyZW1haW5pbmdUZXh0LT5ub2RlKCkpCiAgICAgICAgICAgICByZW1haW5pbmdUZXh0LT5ub2Rl KCktPnNldFJlbmRlcmVyKHJlbWFpbmluZ1RleHQpOwogCi0gICAgICAgIFJlbmRlck9iamVjdCog bmV4dE9iaiA9IHRleHRPYmotPm5leHRTaWJsaW5nKCk7CisgICAgICAgIGZpcnN0TGV0dGVyQ29u dGFpbmVyLT5hZGRDaGlsZChyZW1haW5pbmdUZXh0LCB0ZXh0T2JqKTsKICAgICAgICAgZmlyc3RM ZXR0ZXJDb250YWluZXItPnJlbW92ZUNoaWxkKHRleHRPYmopOwotICAgICAgICBmaXJzdExldHRl ckNvbnRhaW5lci0+YWRkQ2hpbGQocmVtYWluaW5nVGV4dCwgbmV4dE9iaik7CiAgICAgICAgIHJl bWFpbmluZ1RleHQtPnNldEZpcnN0TGV0dGVyKGZpcnN0TGV0dGVyKTsKICAgICAgICAgCiAgICAg ICAgIC8vIGNvbnN0cnVjdCB0ZXh0IGZyYWdtZW50IGZvciB0aGUgZmlyc3QgbGV0dGVyCg== 78789 2011-01-13 02:21:19 -0800 2011-01-19 17:58:42 -0800 Revised ChangeLog 52279.patch.2 text/plain 3358 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiYjE2ODA0Li5iNTkzZmYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEt MTIgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgQnVnIDUyMjc5IC0gV2ViQ29y ZTo6UmVuZGVyQmxvY2s6OnVwZGF0ZUZpcnN0TGV0dGVyIGNyYXNoZXMgZm9yIGFub255bW91cyBi bG9ja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUy Mjc5CisKKyAgICAgICAgKiBmYXN0L2Nzcy9maXJzdC1sZXR0ZXItYW5vbnltb3VzLWJsb2NrLWNy YXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvZmlyc3QtbGV0dGVy LWFub255bW91cy1ibG9jay1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMS0wMS0xMSAgTmljbyBX ZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGVzdCBl eHBlY3RhdGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0 ZXItYW5vbnltb3VzLWJsb2NrLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL2ZpcnN0LWxldHRlci1hbm9ueW1vdXMtYmxvY2stY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjc2OTY0MjEKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXItYW5vbnltb3VzLWJsb2NrLWNyYXNo LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitObyBjcmFzaCBtZWFucyBQQVNTCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXItYW5vbnltb3VzLWJsb2NrLWNy YXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXItYW5vbnltb3VzLWJs b2NrLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uM2MyMTUw NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2ZpcnN0LWxldHRlci1h bm9ueW1vdXMtYmxvY2stY3Jhc2guaHRtbApAQCAtMCwwICsxLDE1IEBACis8aHRtbD4KKzxzdHls ZSB0eXBlPXRleHQvY3NzPgorZGQ6Zmlyc3QtbGV0dGVyIHsgY29udGVudDoiIjsgfQorZGlyOmZp cnN0LWxldHRlciB7IHRleHQtYWxpZ246IiI7IH0KKzwvc3R5bGU+Cis8ZGQ+Cis8ZGlyPgorPGZv bnQ+Cis8Zm9ybT4KK05vIGNyYXNoIG1lYW5zIFBBU1MKKzxzY3JpcHQ+CitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKKzwvc2NyaXB0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU0OGIwMjQuLmU5Njc1NTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMS0wMS0xMiAgWXV6byBGdWppc2hpbWEgIDx5 dXpvQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IGZvciBCdWcgNTIyNzkgLSBXZWJDb3JlOjpSZW5kZXJCbG9jazo6dXBkYXRl Rmlyc3RMZXR0ZXIgY3Jhc2hlcyBmb3IgYW5vbnltb3VzIGJsb2NrcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIyNzkKKworICAgICAgICBJbiBjb25z dHJ1Y3RpbmcgdGV4dCBmcmFnbWVudHMgdG8gaGFuZGxlIGZpcnN0LWxldHRlciBydWxlLCBmaXJz dCBhZGQKKyAgICAgICAgdGhlIHRleHQgZm9yIHRoZSBub24tZmlyc3QgbGV0dGVycyBhbmQgdGhl biByZW1vdmUgdGhlIG9yaWdpbmFsIHRleHQsCisgICAgICAgIHJhdGhlciB0aGFuIHRoZSBvdGhl ciB3YXkgYXJvdW5kLiBPdGhlcndpc2UsIHRoZSB0ZXh0IGNhbiBiZSBhZGRlZCB0bworICAgICAg ICBhbiBhbm95bW91cyBibG9jayB0aGF0IGlzIGRpZmZlcmVudCBmcm9tIHRoZSBvcmlnaW5hbCBv bmUuIFRoaXMgYnJlYWtzCisgICAgICAgIHRoZSBhc3N1bXB0aW9uIHRoYXQgYSBmaXJzdCBsZXR0 ZXIgcmVuZGVyIG9iamVjdCBoYXMgYSBub24tbnVsbCBzaWJsaW5nCisgICAgICAgIGZvciB0aGUg bm9uLWZpcnN0IGxldHRlcnMgYW5kIGNhdXNlcyBhIGNyYXNoLgorCisgICAgICAgIFRlc3Q6IGZh c3QvY3NzL2ZpcnN0LWxldHRlci1hbm9ueW1vdXMtYmxvY2stY3Jhc2guaHRtbAorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJs b2NrOjp1cGRhdGVGaXJzdExldHRlcik6CisKIDIwMTEtMDEtMTEgIEFuZHkgRXN0ZXMgIDxhZXN0 ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggZTM5MjIzYS4uZDcyMjY2MiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC01MjYwLDkgKzUy NjAsOCBAQCB2b2lkIFJlbmRlckJsb2NrOjp1cGRhdGVGaXJzdExldHRlcigpCiAgICAgICAgIGlm IChyZW1haW5pbmdUZXh0LT5ub2RlKCkpCiAgICAgICAgICAgICByZW1haW5pbmdUZXh0LT5ub2Rl KCktPnNldFJlbmRlcmVyKHJlbWFpbmluZ1RleHQpOwogCi0gICAgICAgIFJlbmRlck9iamVjdCog bmV4dE9iaiA9IHRleHRPYmotPm5leHRTaWJsaW5nKCk7CisgICAgICAgIGZpcnN0TGV0dGVyQ29u dGFpbmVyLT5hZGRDaGlsZChyZW1haW5pbmdUZXh0LCB0ZXh0T2JqKTsKICAgICAgICAgZmlyc3RM ZXR0ZXJDb250YWluZXItPnJlbW92ZUNoaWxkKHRleHRPYmopOwotICAgICAgICBmaXJzdExldHRl ckNvbnRhaW5lci0+YWRkQ2hpbGQocmVtYWluaW5nVGV4dCwgbmV4dE9iaik7CiAgICAgICAgIHJl bWFpbmluZ1RleHQtPnNldEZpcnN0TGV0dGVyKGZpcnN0TGV0dGVyKTsKICAgICAgICAgCiAgICAg ICAgIC8vIGNvbnN0cnVjdCB0ZXh0IGZyYWdtZW50IGZvciB0aGUgZmlyc3QgbGV0dGVyCg==