52252 2011-01-11 14:14:09 -0800 [Qt] Use a black background color for the video element on Qt Mobile 2011-01-13 10:59:12 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other Other RESOLVED FIXED P3 Normal --- 1 max.hong.shen max.hong.shen ademar commit-queue eric hausmann kling nancy.piedra ossy oldest_to_newest 332646 0 max.hong.shen 2011-01-11 14:14:09 -0800 According to the UI specification for Html5 inline video on Symbian, if there is no poster defined or video frame data is available, the webpage should display a black box which fits the video element area. The easiest implementation is to use a black background color for the video element. I will add a patch for review soon. Comments & Suggestions are super welcome! :) 332812 1 78629 max.hong.shen 2011-01-11 17:12:29 -0800 Created attachment 78629 first try 333262 2 max.hong.shen 2011-01-12 13:52:08 -0800 Eric, could you also please take a look at this patch? Thx 333276 3 78629 eric 2011-01-12 14:02:58 -0800 Comment on attachment 78629 first try I mean, I know nothing about this. But I'm willing to rs=me this patch. 333279 4 eric 2011-01-12 14:06:39 -0800 In general the other eric knows a lot more about <video> and <audio> related stuff. I'm not sure he has much opinion on how <video> looks on symbian (i'm not sure any of us who don't work on symbian really care). 333292 5 max.hong.shen 2011-01-12 14:18:42 -0800 (In reply to comment #4) > In general the other eric knows a lot more about <video> and <audio> related stuff. I'm not sure he has much opinion on how <video> looks on symbian (i'm not sure any of us who don't work on symbian really care). Thanks Eric :) I am going to ask other qt/symbian guys for some comments. 333663 6 78629 kling 2011-01-13 06:49:08 -0800 Comment on attachment 78629 first try cq=me ;) 333678 7 78629 commit-queue 2011-01-13 07:29:36 -0800 Comment on attachment 78629 first try Clearing flags on attachment: 78629 Committed r75712: <http://trac.webkit.org/changeset/75712> 333679 8 commit-queue 2011-01-13 07:29:43 -0800 All reviewed patches have been landed. Closing bug. 333799 9 ademar 2011-01-13 10:57:56 -0800 Revision r75712 cherry-picked into qtwebkit-2.2 with commit b92afdd <http://gitorious.org/webkit/qtwebkit/commit/b92afdd> 78629 2011-01-11 17:12:29 -0800 2011-01-13 07:29:36 -0800 first try 52252.patch text/plain 1016 max.hong.shen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1NTc1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMTEgIFlpIFNoZW4g IDx5aS40LnNoZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtRdF0gVXNlIGEgYmxhY2sgYmFja2dyb3VuZCBjb2xvciBmb3IgdGhl IHZpZGVvIGVsZW1lbnQgb24gUXQgTW9iaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MjI1MgorCisgICAgICAgIFVzZSBibGFjayBhcyB0aGUgYmFj a2dyb3VuZCBjb2xvciBmb3IgdGhlIHZpZGVvIGVsZW1lbnQgb24gUXQgTW9iaWxlLgorCisgICAg ICAgICogY3NzL3RoZW1lUXRNb2JpbGUuY3NzOgorICAgICAgICAodmlkZW8pOgorCiAyMDExLTAx LTExICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy90aGVtZVF0TW9iaWxl LmNzcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvdGhlbWVRdE1vYmlsZS5jc3MJ KHJldmlzaW9uIDc1NTY0KQorKysgU291cmNlL1dlYkNvcmUvY3NzL3RoZW1lUXRNb2JpbGUuY3Nz CSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsMyArMTI4LDcgQEAgaW5wdXRbdHlwZT0idXJsIl06YWN0 aXZlLAogdGV4dGFyZWE6YWN0aXZlIHsKICAgICBiYWNrZ3JvdW5kOiBCdXR0b25TaGFkb3c7CiB9 CisKK3ZpZGVvIHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiAjMDAwMDAwOworfQo=