52240 2011-01-11 12:35:55 -0800 fix exception when adding a comment to a side-by-side diff 2011-01-11 12:56:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth eric mihaip oldest_to_newest 332563 0 ojan 2011-01-11 12:35:55 -0800 fix exception when adding a comment to a side-by-side diff 332564 1 78580 ojan 2011-01-11 12:36:54 -0800 Created attachment 78580 Patch 332584 2 ojan 2011-01-11 12:56:23 -0800 Committed r75539: <http://trac.webkit.org/changeset/75539> 78580 2011-01-11 12:36:54 -0800 2011-01-11 12:49:25 -0800 Patch bug-52240-20110111123653.patch text/plain 2421 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDEzOTNmYzE5N2FiNjdkNjAwNGRmNmRm NzJjYzlhZTE1OGM1ZGU1MzAuLjYzODdiYTc2MDYzZTU5YjYzZjhiMmNmYjVhODE5NGYzNWM0YzVh NjEgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEx LTAxLTExICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZml4IGV4Y2VwdGlvbiB3aGVuIGFkZGlu ZyBhIGNvbW1lbnQgdG8gYSBzaWRlLWJ5LXNpZGUgZGlmZgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIyNDAKKworICAgICAgICBwcmV2KCkgYW5kIG5l eHQoKSB3b24ndCBnZXQgdGhlIHByZXZpb3VzIGFuZCBuZXh0IGxpbmVzIGluCisgICAgICAgIHNp ZGUtYnktc2lkZSBtb2RlLiBJbnN0ZWFkIGRvIGEgcXVlcnkgdG8gZmluZCB0aGVtLgorCisgICAg ICAgICogY29kZS1yZXZpZXcuanM6CisKIDIwMTEtMDEtMTAgIE9qYW4gVmFmYWkgIDxvamFuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0 IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzIGIvV2Vic2l0ZXMvYnVn cy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzCmluZGV4IDBkYTFhMTRhODJjNDUzNmY5NTAyZDJh ZWUxZDc1NmRjNDRkNDRhMjIuLjU2NzA3ZmIyYzczNTMyY2YxMzBlODhiMWY1MzdlZTZjOGFlYjYz YjcgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcwor KysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKQEAgLTk3MCwxMCAr OTcwLDI1IEBACiAgICAgaW5fZHJhZ19zZWxlY3QgPSBmYWxzZTsKICAgfQogCisgIGZ1bmN0aW9u IGxpbmVPZmZzZXRGcm9tKGxpbmUsIG9mZnNldCkgeworICAgIHZhciBmaWxlX2RpZmYgPSBsaW5l LnBhcmVudHMoJy5GaWxlRGlmZicpOworICAgIHZhciBhbGxfbGluZXMgPSAkKCcuTGluZScsIGZp bGVfZGlmZik7CisgICAgdmFyIGluZGV4ID0gYWxsX2xpbmVzLmluZGV4KGxpbmUpOworICAgIHJl dHVybiAkKGFsbF9saW5lc1tpbmRleCArIG9mZnNldF0pOworICB9CisKKyAgZnVuY3Rpb24gcHJl dmlvdXNMaW5lRm9yKGxpbmUpIHsKKyAgICByZXR1cm4gbGluZU9mZnNldEZyb20obGluZSwgLTEp OworICB9CisKKyAgZnVuY3Rpb24gbmV4dExpbmVGb3IobGluZSkgeworICAgIHJldHVybiBsaW5l T2Zmc2V0RnJvbShsaW5lLCAxKTsKKyAgfQorCiAgICQoJy5saW5lTnVtYmVyJykubGl2ZSgnY2xp Y2snLCBmdW5jdGlvbigpIHsKICAgICB2YXIgbGluZSA9ICQodGhpcykucGFyZW50KCk7CiAgICAg aWYgKGxpbmUuaGFzQ2xhc3MoJ2NvbW1lbnRDb250ZXh0JykpCi0gICAgICB0cmltQ29tbWVudENv bnRleHRUb0JlZm9yZShsaW5lLnByZXYoKSk7CisgICAgICB0cmltQ29tbWVudENvbnRleHRUb0Jl Zm9yZShwcmV2aW91c0xpbmVGb3IobGluZSkpOwogICB9KS5saXZlKCdtb3VzZWRvd24nLCBmdW5j dGlvbigpIHsKICAgICBpbl9kcmFnX3NlbGVjdCA9IHRydWU7CiAgICAgJChsaW5lRnJvbUxpbmVE ZXNjZW5kYW50KHRoaXMpKS5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKQEAgLTk5MCw3ICsxMDA1LDcg QEAKICAgICBpZiAoIWluX2RyYWdfc2VsZWN0KQogICAgICAgcmV0dXJuOwogICAgIHZhciBzZWxl Y3RlZCA9ICQoJy5zZWxlY3RlZCcpOwotICAgIHZhciBzaG91bGRfYWRkX2NvbW1lbnQgPSAhc2Vs ZWN0ZWQubGFzdCgpLm5leHQoKS5oYXNDbGFzcygnY29tbWVudENvbnRleHQnKTsKKyAgICB2YXIg c2hvdWxkX2FkZF9jb21tZW50ID0gIW5leHRMaW5lRm9yKHNlbGVjdGVkLmxhc3QoKSkuaGFzQ2xh c3MoJ2NvbW1lbnRDb250ZXh0Jyk7CiAgICAgc2VsZWN0ZWQuYWRkQ2xhc3MoJ2NvbW1lbnRDb250 ZXh0Jyk7CiAKICAgICB2YXIgaWQ7CkBAIC05OTksNyArMTAxNCw3IEBACiAgICAgICBhZGRDb21t ZW50Rm9yKCQobGFzdCkpOwogICAgICAgaWQgPSBsYXN0LmlkOwogICAgIH0gZWxzZSB7Ci0gICAg ICBpZCA9IHNlbGVjdGVkLmxhc3QoKS5uZXh0KClbMF0uZ2V0QXR0cmlidXRlKCdkYXRhLWNvbW1l bnQtYmFzZS1saW5lJyk7CisgICAgICBpZCA9IG5leHRMaW5lRm9yKHNlbGVjdGVkLmxhc3QoKSlb MF0uZ2V0QXR0cmlidXRlKCdkYXRhLWNvbW1lbnQtYmFzZS1saW5lJyk7CiAgICAgfQogCiAgICAg c2VsZWN0ZWQuZWFjaChmdW5jdGlvbigpIHsK