<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>52233</bug_id>
          
          <creation_ts>2011-01-11 12:14:34 -0800</creation_ts>
          <short_desc>WebKitCSSMatrix constructor should accept &apos;none&apos;</short_desc>
          <delta_ts>2011-01-11 14:02:52 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dean Jackson">dino</reporter>
          <assigned_to name="Dean Jackson">dino</assigned_to>
          <cc>cmarrin</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>332533</commentid>
    <comment_count>0</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2011-01-11 12:14:34 -0800</bug_when>
    <thetext>Sometime recently-ish, an element without a transform started returning &apos;none&apos; as a computed style. This breaks existing code that simply pushes the computed style into the WebKitCSSMatrix constructor, since it does not accept the &apos;none&apos; string.

Update the constructor to accept &apos;none&apos;.

&lt;rdar://problem/8844355&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332549</commentid>
    <comment_count>1</comment_count>
      <attachid>78577</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2011-01-11 12:25:57 -0800</bug_when>
    <thetext>Created attachment 78577
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332555</commentid>
    <comment_count>2</comment_count>
      <attachid>78577</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-01-11 12:31:49 -0800</bug_when>
    <thetext>Comment on attachment 78577
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78577&amp;action=review

&gt; LayoutTests/transforms/cssmatrix-2d-interface.xhtml:19
&gt; +function testConstructor(desc, parameter) {
&gt; +  var m = null;
&gt; +  m = new WebKitCSSMatrix(parameter);
&gt; +  if (m)
&gt; +    testPassed(desc);
&gt; +  else
&gt; +    testFailed(desc);
&gt; +}

No need for this, since you can do 1-line tests:
shouldBeNull(&apos;&quot;new WebKitCSSMatrix(foopy)&quot;&apos;)
or similar (with some quoting magic).

&gt; LayoutTests/transforms/cssmatrix-2d-interface.xhtml:31
&gt; +var m = new WebKitCSSMatrix();
&gt;  if (m)
&gt;    testPassed(&quot;default constructor&quot;);
&gt;  else
&gt;    testFailed(&quot;default constructor&quot;);

These should be 1-liners using shouldBeNull() etc.

&gt; Source/WebCore/css/WebKitCSSMatrix.cpp:61
&gt; -        PassRefPtr&lt;CSSValue&gt; val =  styleDeclaration-&gt;getPropertyCSSValue(CSSPropertyWebkitTransform);
&gt; +        CSSValue* value =  styleDeclaration-&gt;getPropertyCSSValue(CSSPropertyWebkitTransform).get();

This should be a RefPtr&lt;CSSValue&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332582</commentid>
    <comment_count>3</comment_count>
      <attachid>78586</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2011-01-11 12:54:03 -0800</bug_when>
    <thetext>Created attachment 78586
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332632</commentid>
    <comment_count>4</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2011-01-11 14:02:52 -0800</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/75542</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78577</attachid>
            <date>2011-01-11 12:25:57 -0800</date>
            <delta_ts>2011-01-11 12:53:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-52233-20110112072555.patch</filename>
            <type>text/plain</type>
            <size>4942</size>
            <attacher name="Dean Jackson">dino</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBhM2VhMDJjYzNhNGM3MzZiMDMwOTAxZmQyMjAwOGJhYzVmM2Y3Y2NlLi45NDBmMTUz
OWRlYTM3MzEwNzM2MWIzNGE4MTNmYzhjNzNkZGJlMzgxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK
KzIwMTEtMDEtMTEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD01MjIzMworCisgICAgICAgIFVwZGF0ZSBXZWJLaXRDU1NNYXRy
aXggdGVzdCB0byBjb3ZlciBhIGNvbnN0cnVjdG9yCisgICAgICAgIHRoYXQgYWNjZXB0cyAnbm9u
ZScgYXMgaW5wdXQuCisKKyAgICAgICAgKiB0cmFuc2Zvcm1zL2Nzc21hdHJpeC0yZC1pbnRlcmZh
Y2UtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHRyYW5zZm9ybXMvY3NzbWF0cml4LTJkLWludGVy
ZmFjZS54aHRtbDoKKwogMjAxMS0wMS0xMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh
QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy9jc3NtYXRyaXgtMmQtaW50ZXJmYWNlLWV4
cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3RyYW5zZm9ybXMvY3NzbWF0cml4LTJkLWludGVyZmFj
ZS1leHBlY3RlZC50eHQKaW5kZXggOWNmMDNiMTc4ODJkZGVjYjY1NTcwZDcyMDY3M2FmZDU0YTE5
NWFmOC4uZWM3NTE3ZThkMjIxOWIxM2YyZGRmMmJjODI1NjNjZmIxYTQ2NThlZSAxMDA2NDQKLS0t
IGEvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy9jc3NtYXRyaXgtMmQtaW50ZXJmYWNlLWV4cGVjdGVk
LnR4dAorKysgYi9MYXlvdXRUZXN0cy90cmFuc2Zvcm1zL2Nzc21hdHJpeC0yZC1pbnRlcmZhY2Ut
ZXhwZWN0ZWQudHh0CkBAIC03LDYgKzcsOSBAQCBDU1NNYXRyaXggY29uc3RydWN0b3JzCiBQQVNT
IGRlZmF1bHQgY29uc3RydWN0b3IKIFBBU1Mgb2JqZWN0IGNvbnN0cnVjdG9yCiBQQVNTIHN0cmlu
ZyBjb25zdHJ1Y3RvcgorUEFTUyBlbXB0eSBzdHJpbmcgY29uc3RydWN0b3IKK1BBU1MgJ25vbmUn
IHN0cmluZyBjb25zdHJ1Y3RvcgorUEFTUyB0cmlja3kgJ25vbmUnIHN0cmluZyBjb25zdHJ1Y3Rv
cgogCiBUZXN0IHRvU3RyaW5nCiBQQVNTIGFbMF0gaXMgIm1hdHJpeCIKZGlmZiAtLWdpdCBhL0xh
eW91dFRlc3RzL3RyYW5zZm9ybXMvY3NzbWF0cml4LTJkLWludGVyZmFjZS54aHRtbCBiL0xheW91
dFRlc3RzL3RyYW5zZm9ybXMvY3NzbWF0cml4LTJkLWludGVyZmFjZS54aHRtbAppbmRleCA4MGVl
MmE4MjQ4Y2JiZjNlMDFhNzNmZDMzM2Y1ZDhkZDk0YzkwYjEzLi5lZjA3M2Y3YjY0NmU5NDE3ZWQx
YWNiMmFmZWE5YTc2YTc4NGJjNzFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy90cmFuc2Zvcm1z
L2Nzc21hdHJpeC0yZC1pbnRlcmZhY2UueGh0bWwKKysrIGIvTGF5b3V0VGVzdHMvdHJhbnNmb3Jt
cy9jc3NtYXRyaXgtMmQtaW50ZXJmYWNlLnhodG1sCkBAIC05LDI5ICs5LDMyIEBACiAKIDxzY3Jp
cHQ+CiAKK2Z1bmN0aW9uIHRlc3RDb25zdHJ1Y3RvcihkZXNjLCBwYXJhbWV0ZXIpIHsKKyAgdmFy
IG0gPSBudWxsOworICBtID0gbmV3IFdlYktpdENTU01hdHJpeChwYXJhbWV0ZXIpOworICBpZiAo
bSkKKyAgICB0ZXN0UGFzc2VkKGRlc2MpOworICBlbHNlCisgICAgdGVzdEZhaWxlZChkZXNjKTsK
K30KKwogZGVzY3JpcHRpb24oIlRoaXMgdGVzdCBleGVyY2lzZXMgdGhlIENTU01hdHJpeCBpbnRl
cmZhY2UiKTsKIAogZGVidWcoIiIpOwogZGVidWcoIkNTU01hdHJpeCBjb25zdHJ1Y3RvcnMiKTsK
IAotdmFyIG0gPSBudWxsOwotbSA9IG5ldyBXZWJLaXRDU1NNYXRyaXgoKTsKKwordmFyIG0gPSBu
ZXcgV2ViS2l0Q1NTTWF0cml4KCk7CiBpZiAobSkKICAgdGVzdFBhc3NlZCgiZGVmYXVsdCBjb25z
dHJ1Y3RvciIpOwogZWxzZQogICB0ZXN0RmFpbGVkKCJkZWZhdWx0IGNvbnN0cnVjdG9yIik7CiAK
LXZhciBtMiA9IG5ldyBXZWJLaXRDU1NNYXRyaXgobSk7Ci1pZiAobTIpCi0gIHRlc3RQYXNzZWQo
Im9iamVjdCBjb25zdHJ1Y3RvciIpOwotZWxzZQotICB0ZXN0RmFpbGVkKCJvYmplY3QgY29uc3Ry
dWN0b3IiKTsKLQotbSA9IG5ldyBXZWJLaXRDU1NNYXRyaXgoIm1hdHJpeCgxLCAwLCAwLCAxLCAw
LCAwKSIpOwotaWYgKG0pCi0gIHRlc3RQYXNzZWQoInN0cmluZyBjb25zdHJ1Y3RvciIpOwotZWxz
ZQotICB0ZXN0RmFpbGVkKCJzdHJpbmcgY29uc3RydWN0b3IiKTsKK3Rlc3RDb25zdHJ1Y3Rvcigi
b2JqZWN0IGNvbnN0cnVjdG9yIiwgbSk7Cit0ZXN0Q29uc3RydWN0b3IoInN0cmluZyBjb25zdHJ1
Y3RvciIsICJtYXRyaXgoMSwgMCwgMCwgMSwgMCwgMCkiKTsKK3Rlc3RDb25zdHJ1Y3RvcigiZW1w
dHkgc3RyaW5nIGNvbnN0cnVjdG9yIiwgIiIpOwordGVzdENvbnN0cnVjdG9yKCInbm9uZScgc3Ry
aW5nIGNvbnN0cnVjdG9yIiwgIm5vbmUiKTsKK3Rlc3RDb25zdHJ1Y3RvcigidHJpY2t5ICdub25l
JyBzdHJpbmcgY29uc3RydWN0b3IiLCAiICAgbm9uZSAgICAiKTsKIAogZGVidWcoIiIpOwogZGVi
dWcoIlRlc3QgdG9TdHJpbmciKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNTQ0MTVhMmM2YTQzYjZjYjY5MTVj
MWQzNDk0ZmMzODU4YTZmZGQ4Li5kZTNlZjQ5NDVlYWRmYWI3MWIxYzViNzBmZDdkZTM0MjJlYWEx
ZWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl
YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMTEgIERlYW4gSmFja3Nv
biAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjIz
MworCisgICAgICAgIFdlYktpdENTU01hdHJpeCBjb25zdHJ1Y3RvciBzaG91bGQgYWNjZXB0ICdu
b25lJworICAgICAgICBhcyBhIHZhbGlkIHN0cmluZyBwYXJhbWV0ZXIuCisKKyAgICAgICAgKiBj
c3MvV2ViS2l0Q1NTTWF0cml4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYktpdENTU01hdHJp
eDo6c2V0TWF0cml4VmFsdWUpOgorCiAyMDExLTAxLTExICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg
PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5z
b24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTTWF0cml4LmNwcCBi
L1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NNYXRyaXguY3BwCmluZGV4IGE0YWY3ZjhjYjYy
ZDZjNzE3OWZmZGNlMWUyMGQ2ODQyZWQ5MDdlZDYuLjEzZmYxYjA4OWIxY2RmNGM4Y2VmZGQyNmEw
NjRiOTA1ODBlY2QxYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NN
YXRyaXguY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NNYXRyaXguY3BwCkBA
IC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSAiQ1NTU3R5bGVTZWxlY3Rvci5oIgogI2luY2x1ZGUg
IkNTU011dGFibGVTdHlsZURlY2xhcmF0aW9uLmgiCiAjaW5jbHVkZSAiQ1NTUHJvcGVydHlOYW1l
cy5oIgorI2luY2x1ZGUgIkNTU1ZhbHVlS2V5d29yZHMuaCIKICNpbmNsdWRlICJFeGNlcHRpb25D
b2RlLmgiCiAjaW5jbHVkZSAiUmVuZGVyU3R5bGUuaCIKICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJh
cy5oPgpAQCAtNTcsOSArNTgsMTQgQEAgdm9pZCBXZWJLaXRDU1NNYXRyaXg6OnNldE1hdHJpeFZh
bHVlKGNvbnN0IFN0cmluZyYgc3RyaW5nLCBFeGNlcHRpb25Db2RlJiBlYykKICAgICBpZiAocC5w
YXJzZVZhbHVlKHN0eWxlRGVjbGFyYXRpb24uZ2V0KCksIENTU1Byb3BlcnR5V2Via2l0VHJhbnNm
b3JtLCBzdHJpbmcsIHRydWUpKSB7CiAgICAgICAgIC8vIENvbnZlcnQgdG8gVHJhbnNmb3JtT3Bl
cmF0aW9ucy4gVGhpcyBjYW4gZmFpbCBpZiBhIHByb3BlcnR5IAogICAgICAgICAvLyByZXF1aXJl
cyBzdHlsZSAoaS5lLiwgcGFyYW0gdXNlcyAnZW1zJyBvciAnZXhzJykKLSAgICAgICAgUGFzc1Jl
ZlB0cjxDU1NWYWx1ZT4gdmFsID0gIHN0eWxlRGVjbGFyYXRpb24tPmdldFByb3BlcnR5Q1NTVmFs
dWUoQ1NTUHJvcGVydHlXZWJraXRUcmFuc2Zvcm0pOworICAgICAgICBDU1NWYWx1ZSogdmFsdWUg
PSAgc3R5bGVEZWNsYXJhdGlvbi0+Z2V0UHJvcGVydHlDU1NWYWx1ZShDU1NQcm9wZXJ0eVdlYmtp
dFRyYW5zZm9ybSkuZ2V0KCk7CisKKyAgICAgICAgLy8gQ2hlY2sgZm9yIGEgIm5vbmUiIG9yIGVt
cHR5IHRyYW5zZm9ybS4gSW4gdGhlc2UgY2FzZXMgd2UgY2FuIHVzZSB0aGUgZGVmYXVsdCBpZGVu
dGl0eSBtYXRyaXguCisgICAgICAgIGlmICghdmFsdWUgfHwgKHZhbHVlLT5pc1ByaW1pdGl2ZVZh
bHVlKCkgJiYgKHN0YXRpY19jYXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4odmFsdWUpKS0+Z2V0SWRl
bnQoKSA9PSBDU1NWYWx1ZU5vbmUpKQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIFRy
YW5zZm9ybU9wZXJhdGlvbnMgb3BlcmF0aW9uczsKLSAgICAgICAgaWYgKCFDU1NTdHlsZVNlbGVj
dG9yOjpjcmVhdGVUcmFuc2Zvcm1PcGVyYXRpb25zKHZhbC5nZXQoKSwgMCwgMCwgb3BlcmF0aW9u
cykpIHsKKyAgICAgICAgaWYgKCFDU1NTdHlsZVNlbGVjdG9yOjpjcmVhdGVUcmFuc2Zvcm1PcGVy
YXRpb25zKHZhbHVlLCAwLCAwLCBvcGVyYXRpb25zKSkgewogICAgICAgICAgICAgZWMgPSBTWU5U
QVhfRVJSOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78586</attachid>
            <date>2011-01-11 12:54:03 -0800</date>
            <delta_ts>2011-01-11 12:55:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-52233-20110112075401.patch</filename>
            <type>text/plain</type>
            <size>5111</size>
            <attacher name="Dean Jackson">dino</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBhM2VhMDJjYzNhNGM3MzZiMDMwOTAxZmQyMjAwOGJhYzVmM2Y3Y2NlLi45NDBmMTUz
OWRlYTM3MzEwNzM2MWIzNGE4MTNmYzhjNzNkZGJlMzgxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK
KzIwMTEtMDEtMTEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD01MjIzMworCisgICAgICAgIFVwZGF0ZSBXZWJLaXRDU1NNYXRy
aXggdGVzdCB0byBjb3ZlciBhIGNvbnN0cnVjdG9yCisgICAgICAgIHRoYXQgYWNjZXB0cyAnbm9u
ZScgYXMgaW5wdXQuCisKKyAgICAgICAgKiB0cmFuc2Zvcm1zL2Nzc21hdHJpeC0yZC1pbnRlcmZh
Y2UtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHRyYW5zZm9ybXMvY3NzbWF0cml4LTJkLWludGVy
ZmFjZS54aHRtbDoKKwogMjAxMS0wMS0xMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh
QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy9jc3NtYXRyaXgtMmQtaW50ZXJmYWNlLWV4
cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3RyYW5zZm9ybXMvY3NzbWF0cml4LTJkLWludGVyZmFj
ZS1leHBlY3RlZC50eHQKaW5kZXggOWNmMDNiMTc4ODJkZGVjYjY1NTcwZDcyMDY3M2FmZDU0YTE5
NWFmOC4uZDQ1ZGY3MDgxMWQ3YmI5ZDRlNWY4MmVmYmFhNzAyOTc1MjdhNTc0MCAxMDA2NDQKLS0t
IGEvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy9jc3NtYXRyaXgtMmQtaW50ZXJmYWNlLWV4cGVjdGVk
LnR4dAorKysgYi9MYXlvdXRUZXN0cy90cmFuc2Zvcm1zL2Nzc21hdHJpeC0yZC1pbnRlcmZhY2Ut
ZXhwZWN0ZWQudHh0CkBAIC00LDkgKzQsMTMgQEAgT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg
c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUKIAog
CiBDU1NNYXRyaXggY29uc3RydWN0b3JzCi1QQVNTIGRlZmF1bHQgY29uc3RydWN0b3IKLVBBU1Mg
b2JqZWN0IGNvbnN0cnVjdG9yCi1QQVNTIHN0cmluZyBjb25zdHJ1Y3RvcgorUEFTUyBtIGlzIG5v
bi1udWxsLgorUEFTUyBuZXcgV2ViS2l0Q1NTTWF0cml4KCkgaXMgbm9uLW51bGwuCitQQVNTIG5l
dyBXZWJLaXRDU1NNYXRyaXgobSkgaXMgbm9uLW51bGwuCitQQVNTIG5ldyBXZWJLaXRDU1NNYXRy
aXgoIm1hdHJpeCgxLCAwLCAwLCAxLCAwLCAwKSIpIGlzIG5vbi1udWxsLgorUEFTUyBuZXcgV2Vi
S2l0Q1NTTWF0cml4KCIiKSBpcyBub24tbnVsbC4KK1BBU1MgbmV3IFdlYktpdENTU01hdHJpeCgi
bm9uZSIpIGlzIG5vbi1udWxsLgorUEFTUyBuZXcgV2ViS2l0Q1NTTWF0cml4KCIgICBub25lICAg
IikgaXMgbm9uLW51bGwuCiAKIFRlc3QgdG9TdHJpbmcKIFBBU1MgYVswXSBpcyAibWF0cml4Igpk
aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy9jc3NtYXRyaXgtMmQtaW50ZXJmYWNl
LnhodG1sIGIvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy9jc3NtYXRyaXgtMmQtaW50ZXJmYWNlLnho
dG1sCmluZGV4IDgwZWUyYTgyNDhjYmJmM2UwMWE3M2ZkMzMzZjVkOGRkOTRjOTBiMTMuLjhmMGQw
YjY2Zjg5MDBhY2RjOTFjYjBlMGU0YjcxYTZkOTlhZGFmZmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL3RyYW5zZm9ybXMvY3NzbWF0cml4LTJkLWludGVyZmFjZS54aHRtbAorKysgYi9MYXlvdXRU
ZXN0cy90cmFuc2Zvcm1zL2Nzc21hdHJpeC0yZC1pbnRlcmZhY2UueGh0bWwKQEAgLTE0LDI0ICsx
NCwxNSBAQCBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IGV4ZXJjaXNlcyB0aGUgQ1NTTWF0cml4IGlu
dGVyZmFjZSIpOwogZGVidWcoIiIpOwogZGVidWcoIkNTU01hdHJpeCBjb25zdHJ1Y3RvcnMiKTsK
IAotdmFyIG0gPSBudWxsOwotbSA9IG5ldyBXZWJLaXRDU1NNYXRyaXgoKTsKLWlmIChtKQotICB0
ZXN0UGFzc2VkKCJkZWZhdWx0IGNvbnN0cnVjdG9yIik7Ci1lbHNlCi0gIHRlc3RGYWlsZWQoImRl
ZmF1bHQgY29uc3RydWN0b3IiKTsKLQotdmFyIG0yID0gbmV3IFdlYktpdENTU01hdHJpeChtKTsK
LWlmIChtMikKLSAgdGVzdFBhc3NlZCgib2JqZWN0IGNvbnN0cnVjdG9yIik7Ci1lbHNlCi0gIHRl
c3RGYWlsZWQoIm9iamVjdCBjb25zdHJ1Y3RvciIpOwotCi1tID0gbmV3IFdlYktpdENTU01hdHJp
eCgibWF0cml4KDEsIDAsIDAsIDEsIDAsIDApIik7Ci1pZiAobSkKLSAgdGVzdFBhc3NlZCgic3Ry
aW5nIGNvbnN0cnVjdG9yIik7Ci1lbHNlCi0gIHRlc3RGYWlsZWQoInN0cmluZyBjb25zdHJ1Y3Rv
ciIpOworCit2YXIgbSA9IG5ldyBXZWJLaXRDU1NNYXRyaXgoKTsKK3Nob3VsZEJlTm9uTnVsbCgn
bScpOworc2hvdWxkQmVOb25OdWxsKCduZXcgV2ViS2l0Q1NTTWF0cml4KCknKTsKK3Nob3VsZEJl
Tm9uTnVsbCgnbmV3IFdlYktpdENTU01hdHJpeChtKScpOworc2hvdWxkQmVOb25OdWxsKCduZXcg
V2ViS2l0Q1NTTWF0cml4KCJtYXRyaXgoMSwgMCwgMCwgMSwgMCwgMCkiKScpOworc2hvdWxkQmVO
b25OdWxsKCduZXcgV2ViS2l0Q1NTTWF0cml4KCIiKScpOworc2hvdWxkQmVOb25OdWxsKCduZXcg
V2ViS2l0Q1NTTWF0cml4KCJub25lIiknKTsKK3Nob3VsZEJlTm9uTnVsbCgnbmV3IFdlYktpdENT
U01hdHJpeCgiICAgbm9uZSAgICIpJyk7CiAKIGRlYnVnKCIiKTsKIGRlYnVnKCJUZXN0IHRvU3Ry
aW5nIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cKaW5kZXggYTU0NDE1YTJjNmE0M2I2Y2I2OTE1YzFkMzQ5NGZjMzg1OGE2
ZmRkOC4uZGUzZWY0OTQ1ZWFkZmFiNzFiMWM1YjcwZmQ3ZGUzNDIyZWFhMWVkMCAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAxLTExICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl
LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIyMzMKKworICAgICAgICBX
ZWJLaXRDU1NNYXRyaXggY29uc3RydWN0b3Igc2hvdWxkIGFjY2VwdCAnbm9uZScKKyAgICAgICAg
YXMgYSB2YWxpZCBzdHJpbmcgcGFyYW1ldGVyLgorCisgICAgICAgICogY3NzL1dlYktpdENTU01h
dHJpeC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJLaXRDU1NNYXRyaXg6OnNldE1hdHJpeFZh
bHVlKToKKwogMjAxMS0wMS0xMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp
YS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU01hdHJpeC5jcHAgYi9Tb3VyY2UvV2ViQ29y
ZS9jc3MvV2ViS2l0Q1NTTWF0cml4LmNwcAppbmRleCBhNGFmN2Y4Y2I2MmQ2YzcxNzlmZmRjZTFl
MjBkNjg0MmVkOTA3ZWQ2Li43ZDYwZjhjZWExMWQzOGYyZmJiMTMwYjJhODA5NWIzNjgyODU2NzZk
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTTWF0cml4LmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTTWF0cml4LmNwcApAQCAtMzAsNiArMzAsNyBA
QAogI2luY2x1ZGUgIkNTU1N0eWxlU2VsZWN0b3IuaCIKICNpbmNsdWRlICJDU1NNdXRhYmxlU3R5
bGVEZWNsYXJhdGlvbi5oIgogI2luY2x1ZGUgIkNTU1Byb3BlcnR5TmFtZXMuaCIKKyNpbmNsdWRl
ICJDU1NWYWx1ZUtleXdvcmRzLmgiCiAjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgogI2luY2x1
ZGUgIlJlbmRlclN0eWxlLmgiCiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KQEAgLTU3LDkg
KzU4LDE0IEBAIHZvaWQgV2ViS2l0Q1NTTWF0cml4OjpzZXRNYXRyaXhWYWx1ZShjb25zdCBTdHJp
bmcmIHN0cmluZywgRXhjZXB0aW9uQ29kZSYgZWMpCiAgICAgaWYgKHAucGFyc2VWYWx1ZShzdHls
ZURlY2xhcmF0aW9uLmdldCgpLCBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybSwgc3RyaW5nLCB0
cnVlKSkgewogICAgICAgICAvLyBDb252ZXJ0IHRvIFRyYW5zZm9ybU9wZXJhdGlvbnMuIFRoaXMg
Y2FuIGZhaWwgaWYgYSBwcm9wZXJ0eSAKICAgICAgICAgLy8gcmVxdWlyZXMgc3R5bGUgKGkuZS4s
IHBhcmFtIHVzZXMgJ2Vtcycgb3IgJ2V4cycpCi0gICAgICAgIFBhc3NSZWZQdHI8Q1NTVmFsdWU+
IHZhbCA9ICBzdHlsZURlY2xhcmF0aW9uLT5nZXRQcm9wZXJ0eUNTU1ZhbHVlKENTU1Byb3BlcnR5
V2Via2l0VHJhbnNmb3JtKTsKKyAgICAgICAgUmVmUHRyPENTU1ZhbHVlPiB2YWx1ZSA9IHN0eWxl
RGVjbGFyYXRpb24tPmdldFByb3BlcnR5Q1NTVmFsdWUoQ1NTUHJvcGVydHlXZWJraXRUcmFuc2Zv
cm0pOworCisgICAgICAgIC8vIENoZWNrIGZvciBhICJub25lIiBvciBlbXB0eSB0cmFuc2Zvcm0u
IEluIHRoZXNlIGNhc2VzIHdlIGNhbiB1c2UgdGhlIGRlZmF1bHQgaWRlbnRpdHkgbWF0cml4Lgor
ICAgICAgICBpZiAoIXZhbHVlIHx8ICh2YWx1ZS0+aXNQcmltaXRpdmVWYWx1ZSgpICYmIChzdGF0
aWNfY2FzdDxDU1NQcmltaXRpdmVWYWx1ZSo+KHZhbHVlLmdldCgpKSktPmdldElkZW50KCkgPT0g
Q1NTVmFsdWVOb25lKSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBUcmFuc2Zvcm1P
cGVyYXRpb25zIG9wZXJhdGlvbnM7Ci0gICAgICAgIGlmICghQ1NTU3R5bGVTZWxlY3Rvcjo6Y3Jl
YXRlVHJhbnNmb3JtT3BlcmF0aW9ucyh2YWwuZ2V0KCksIDAsIDAsIG9wZXJhdGlvbnMpKSB7Cisg
ICAgICAgIGlmICghQ1NTU3R5bGVTZWxlY3Rvcjo6Y3JlYXRlVHJhbnNmb3JtT3BlcmF0aW9ucyh2
YWx1ZS5nZXQoKSwgMCwgMCwgb3BlcmF0aW9ucykpIHsKICAgICAgICAgICAgIGVjID0gU1lOVEFY
X0VSUjsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQo=
</data>
<flag name="review"
          id="69923"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
      

    </bug>

</bugzilla>