52231 2011-01-11 11:55:04 -0800 [WKView setFrameSize:] derefs _page->drawingArea() without null check 2011-01-11 12:35:30 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sullivan sullivan abarth eric webkit.review.bot oldest_to_newest 332509 0 sullivan 2011-01-11 11:55:04 -0800 [WKView setFrameSize:] dereferences _data->_page->drawingArea() without testing for null. But the drawing area can be null just after a WKView is created, due to a recent change. 332512 1 78572 sullivan 2011-01-11 11:56:22 -0800 Created attachment 78572 Patch that adds a null check. 332518 2 sullivan 2011-01-11 12:06:06 -0800 Fixed in r75525. 332550 3 webkit.review.bot 2011-01-11 12:27:05 -0800 http://trac.webkit.org/changeset/75525 might have broken Windows Release (Build) and Windows Debug (Build) 332561 4 sullivan 2011-01-11 12:35:30 -0800 I believe the WebKit Review Bot is oh so very wrong. This patch only affected the contents of one method in one Mac-specific file, so it could not have broken the Windows build. 78572 2011-01-11 11:56:22 -0800 2011-01-11 12:03:39 -0800 Patch that adds a null check. setFrameSizePatch.txt text/plain 1167 sullivan SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTUyMykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMTEgIEpvaG4gU3VsbGl2YW4gIDxzdWxsaXZhbkBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W1dLVmlldyBzZXRGcmFtZVNpemU6XSBkZXJlZnMgX3BhZ2UtPmRyYXdpbmdBcmVhKCkgd2l0aG91 dCBudWxsIGNoZWNrCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTIyMzE+CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06Cisg ICAgICAgICgtW1dLVmlldyBzZXRGcmFtZVNpemU6XSk6CisgICAgICAgIE51bGwgY2hlY2sgZHJh d2luZ0FyZWEoKS4gVGhpcyBpcyBPSyBiZWNhdXNlIGlmIGl0IGRvZXNuJ3QgZXhpc3QgdGhlbiBp dCB3aWxsIGJlCisgICAgICAgIGNyZWF0ZWQgbGF0ZXIgd2l0aCB0aGUgY29ycmVjdCBpbml0aWFs IHNpemUuCisKIDIwMTEtMDEtMDcgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpJbmRleDogV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDc1NTIzKQorKysgV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTI1Miw2ICsyNTIsOSBA QCAtICh2b2lkKXNldEZyYW1lU2l6ZTooTlNTaXplKXNpemUKIHsKICAgICBbc3VwZXIgc2V0RnJh bWVTaXplOnNpemVdOwogCisgICAgaWYgKCFfZGF0YS0+X3BhZ2UtPmRyYXdpbmdBcmVhKCkpCisg ICAgICAgIHJldHVybjsKKyAgICAKICAgICBfZGF0YS0+X3BhZ2UtPmRyYXdpbmdBcmVhKCktPnNl dFNpemUoSW50U2l6ZShzaXplKSk7CiB9CiAK