52208 2011-01-11 06:30:03 -0800 Align import/export directives in WebKit2 2011-01-14 11:51:12 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue eric sam s.mathur oldest_to_newest 332304 0 laszlo.gombos 2011-01-11 06:30:03 -0800 r75404 (http://trac.webkit.org/changeset/75404) introduced a set of fixes to WebKit2 import/export macros. These macros should be align across the entire project project. 332310 1 78523 laszlo.gombos 2011-01-11 06:40:05 -0800 Created attachment 78523 proposed patch Another option would be to have a shared header file under wtf to make sure these rules are aligned. 332497 2 eric 2011-01-11 11:47:29 -0800 I'm not sure your #define indent matches webkit style. 334299 3 78940 laszlo.gombos 2011-01-14 07:37:06 -0800 Created attachment 78940 Remove indentation 334365 4 78940 commit-queue 2011-01-14 09:46:59 -0800 Comment on attachment 78940 Remove indentation Rejecting attachment 78940 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-..." exit_code: 2 Last 500 characters of output: ................................ fast/images/load-img-with-empty-src.html -> timed out Sampling process 18778 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 18778 written to file /Users/chrome-bot/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 8872 tests run. 258.75s total testing time 8871 test cases (99%) succeeded 1 test case (<1%) timed out 6 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7557041 334373 5 commit-queue 2011-01-14 09:56:41 -0800 The commit-queue encountered the following flaky tests while processing attachment 78940: http/tests/media/video-load-twice.html bug 51304 (authors: eric.carlson@apple.com and hclam@google.com) The commit-queue is continuing to process your patch. 334425 6 78940 laszlo.gombos 2011-01-14 11:01:33 -0800 Comment on attachment 78940 Remove indentation Try again... 334468 7 78940 commit-queue 2011-01-14 11:51:04 -0800 Comment on attachment 78940 Remove indentation Clearing flags on attachment: 78940 Committed r75806: <http://trac.webkit.org/changeset/75806> 334469 8 commit-queue 2011-01-14 11:51:12 -0800 All reviewed patches have been landed. Closing bug. 78523 2011-01-11 06:40:05 -0800 2011-01-14 07:37:06 -0800 proposed patch 52208.patch text/plain 3397 laszlo.gombos SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzU0OTgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDEtMTEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsaWduIGlt cG9ydC9leHBvcnQgZGlyZWN0aXZlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTIyMDgKKworICAgICAgICAqIEFQSS9KU0Jhc2UuaDogQWxpZ24gaW1w b3J0L2V4cG9ydCBkaXJlY3RpdmVzIHdpdGggCisgICAgICAgIFdlYktpdDIvU2hhcmVkL0FQSS9j L1dLQmFzZS5oCisKIDIwMTEtMDEtMTAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9BUEkvSlNCYXNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS9KU0Jhc2UuaAkocmV2aXNpb24gNzU0MjgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvQVBJL0pTQmFzZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02MywxMyArNjMsMTQgQEAgdHlwZWRl ZiBjb25zdCBzdHJ1Y3QgT3BhcXVlSlNWYWx1ZSogSlNWYQogdHlwZWRlZiBzdHJ1Y3QgT3BhcXVl SlNWYWx1ZSogSlNPYmplY3RSZWY7CiAKIC8qIEphdmFTY3JpcHQgc3ltYm9sIGV4cG9ydHMgKi8K Ky8qIFRoZXNlIHJ1bGVzIHNob3VsZCBzdGF5IHRoZSBzYW1lIGFzIGluIFdlYktpdDIvU2hhcmVk L0FQSS9jL1dLQmFzZS5oICovCiAKICN1bmRlZiBKU19FWFBPUlQKICNpZiBkZWZpbmVkKEpTX05P X0VYUE9SVCkKICAgICAjZGVmaW5lIEpTX0VYUE9SVAogI2VsaWYgZGVmaW5lZChfX0dOVUNfXykg JiYgIWRlZmluZWQoX19DQ19BUk0pICYmICFkZWZpbmVkKF9fQVJNQ0NfXykKICAgICAjZGVmaW5l IEpTX0VYUE9SVCBfX2F0dHJpYnV0ZV9fKCh2aXNpYmlsaXR5KCJkZWZhdWx0IikpKQotI2VsaWYg ZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyX1dDRSkK KyNlbGlmIGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKSB8fCBkZWZpbmVkKF9XSU4z Ml9XQ0UpIHx8IGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKQogICAgICNp ZiBkZWZpbmVkKEJVSUxESU5HX0phdmFTY3JpcHRDb3JlKSB8fCBkZWZpbmVkKEJVSUxESU5HX1dU RikKICAgICAgICAgI2RlZmluZSBKU19FWFBPUlQgX19kZWNsc3BlYyhkbGxleHBvcnQpCiAgICAg I2Vsc2UKSW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hh bmdlTG9nCShyZXZpc2lvbiA3NTQ5OCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMTEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFsaWduIGltcG9ydC9leHBvcnQgZGlyZWN0aXZlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIyMDgKKworICAgICAgICAqIFNo YXJlZC9BUEkvYy9XS0Jhc2UuaDogQWxpZ24gaW1wb3J0L2V4cG9ydCBkaXJlY3RpdmVzIHdpdGgK KyAgICAgICAgSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oLgorCiAyMDExLTAxLTExICBBZGFt IFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYSB0eXBvIGluIGEgY29t bWVudApJbmRleDogV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tCYXNlLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tCYXNlLmgJKHJldmlzaW9uIDc1NDI4KQorKysgV2ViS2l0 Mi9TaGFyZWQvQVBJL2MvV0tCYXNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTk4LDE3ICs5OCwxOSBA QCB0eXBlZGVmIGNvbnN0IHN0cnVjdCBPcGFxdWVXS0J1bmRsZVBhZ2VPCiB0eXBlZGVmIGNvbnN0 IHN0cnVjdCBPcGFxdWVXS0J1bmRsZVJhbmdlSGFuZGxlKiBXS0J1bmRsZVJhbmdlSGFuZGxlUmVm OwogdHlwZWRlZiBjb25zdCBzdHJ1Y3QgT3BhcXVlV0tCdW5kbGVTY3JpcHRXb3JsZCogV0tCdW5k bGVTY3JpcHRXb3JsZFJlZjsKIAorLyogVGhlc2UgcnVsZXMgc2hvdWxkIHN0YXkgdGhlIHNhbWUg YXMgaW4gSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oICovCisKICN1bmRlZiBXS19FWFBPUlQK ICNpZiBkZWZpbmVkKFdLX05PX0VYUE9SVCkKLSNkZWZpbmUgV0tfRVhQT1JUCi0jZWxpZiBkZWZp bmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX0FSTUNDX18pCi0jZGVmaW5lIFdLX0VYUE9SVCBf X2F0dHJpYnV0ZV9fKCh2aXNpYmlsaXR5KCJkZWZhdWx0IikpKQotI2VsaWYgZGVmaW5lZChXSU4z MikgfHwgZGVmaW5lZChfV0lOMzIpIHx8IGRlZmluZWQoX19BUk1DQ19fKQotI2lmIEJVSUxESU5H X1dFQktJVAotI2RlZmluZSBXS19FWFBPUlQgX19kZWNsc3BlYyhkbGxleHBvcnQpCi0jZWxzZQot I2RlZmluZSBXS19FWFBPUlQgX19kZWNsc3BlYyhkbGxpbXBvcnQpCi0jZW5kaWYKKyAgICAjZGVm aW5lIFdLX0VYUE9SVAorI2VsaWYgZGVmaW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19DQ19B Uk0pICYmICFkZWZpbmVkKF9fQVJNQ0NfXykKKyAgICAjZGVmaW5lIFdLX0VYUE9SVCBfX2F0dHJp YnV0ZV9fKCh2aXNpYmlsaXR5KCJkZWZhdWx0IikpKQorI2VsaWYgZGVmaW5lZChXSU4zMikgfHwg ZGVmaW5lZChfV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyX1dDRSkgfHwgZGVmaW5lZChfX0NDX0FS TSkgfHwgZGVmaW5lZChfX0FSTUNDX18pCisgICAgI2lmIEJVSUxESU5HX1dFQktJVAorICAgICAg ICAjZGVmaW5lIFdLX0VYUE9SVCBfX2RlY2xzcGVjKGRsbGV4cG9ydCkKKyAgICAjZWxzZQorICAg ICAgICAjZGVmaW5lIFdLX0VYUE9SVCBfX2RlY2xzcGVjKGRsbGltcG9ydCkKKyAgICAjZW5kaWYK ICNlbHNlCiAjZGVmaW5lIFdLX0VYUE9SVAogI2VuZGlmCg== 78940 2011-01-14 07:37:06 -0800 2011-01-14 11:51:04 -0800 Remove indentation 52208.patch text/plain 3641 laszlo.gombos ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmggYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCmluZGV4IDJlMTY3MjAuLmQ5NjJiMDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0FQSS9KU0Jhc2UuaApAQCAtNjMsMjEgKzYzLDIyIEBAIHR5cGVkZWYgY29u c3Qgc3RydWN0IE9wYXF1ZUpTVmFsdWUqIEpTVmFsdWVSZWY7CiB0eXBlZGVmIHN0cnVjdCBPcGFx dWVKU1ZhbHVlKiBKU09iamVjdFJlZjsKIAogLyogSmF2YVNjcmlwdCBzeW1ib2wgZXhwb3J0cyAq LworLyogVGhlc2UgcnVsZXMgc2hvdWxkIHN0YXkgdGhlIHNhbWUgYXMgaW4gV2ViS2l0Mi9TaGFy ZWQvQVBJL2MvV0tCYXNlLmggKi8KIAogI3VuZGVmIEpTX0VYUE9SVAogI2lmIGRlZmluZWQoSlNf Tk9fRVhQT1JUKQotICAgICNkZWZpbmUgSlNfRVhQT1JUCisjZGVmaW5lIEpTX0VYUE9SVAogI2Vs aWYgZGVmaW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19DQ19BUk0pICYmICFkZWZpbmVkKF9f QVJNQ0NfXykKLSAgICAjZGVmaW5lIEpTX0VYUE9SVCBfX2F0dHJpYnV0ZV9fKCh2aXNpYmlsaXR5 KCJkZWZhdWx0IikpKQotI2VsaWYgZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIpIHx8 IGRlZmluZWQoX1dJTjMyX1dDRSkKLSAgICAjaWYgZGVmaW5lZChCVUlMRElOR19KYXZhU2NyaXB0 Q29yZSkgfHwgZGVmaW5lZChCVUlMRElOR19XVEYpCi0gICAgICAgICNkZWZpbmUgSlNfRVhQT1JU IF9fZGVjbHNwZWMoZGxsZXhwb3J0KQotICAgICNlbHNlCi0gICAgICAgICNkZWZpbmUgSlNfRVhQ T1JUIF9fZGVjbHNwZWMoZGxsaW1wb3J0KQotICAgICNlbmRpZgorI2RlZmluZSBKU19FWFBPUlQg X19hdHRyaWJ1dGVfXygodmlzaWJpbGl0eSgiZGVmYXVsdCIpKSkKKyNlbGlmIGRlZmluZWQoV0lO MzIpIHx8IGRlZmluZWQoX1dJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMl9XQ0UpIHx8IGRlZmluZWQo X19DQ19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKQorI2lmIGRlZmluZWQoQlVJTERJTkdfSmF2 YVNjcmlwdENvcmUpIHx8IGRlZmluZWQoQlVJTERJTkdfV1RGKQorI2RlZmluZSBKU19FWFBPUlQg X19kZWNsc3BlYyhkbGxleHBvcnQpCiAjZWxzZQotICAgICNkZWZpbmUgSlNfRVhQT1JUCisjZGVm aW5lIEpTX0VYUE9SVCBfX2RlY2xzcGVjKGRsbGltcG9ydCkKICNlbmRpZgorI2Vsc2UgLyogIWRl ZmluZWQoSlNfTk9fRVhQT1JUKSAqLworI2RlZmluZSBKU19FWFBPUlQKKyNlbmRpZiAvKiBkZWZp bmVkKEpTX05PX0VYUE9SVCkgKi8KIAogI2lmZGVmIF9fY3BsdXNwbHVzCiBleHRlcm4gIkMiIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDJlMDMxNzEuLmE3NGNlZDcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAxLTE0ICBMYXN6bG8gR29tYm9z ICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBbGlnbiBpbXBvcnQvZXhwb3J0IGRpcmVjdGl2ZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMjA4CisKKyAg ICAgICAgKiBBUEkvSlNCYXNlLmg6IEFsaWduIGltcG9ydC9leHBvcnQgZGlyZWN0aXZlcyB3aXRo CisgICAgICAgIFdlYktpdDIvU2hhcmVkL0FQSS9jL1dLQmFzZS5oCisKIDIwMTEtMDEtMTMgIERh cmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2Zm IEdhcmVuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9XZWJLaXQyL0NoYW5nZUxv ZwppbmRleCA4ZDYzY2UxLi5mOWYzNDJlIDEwMDY0NAotLS0gYS9XZWJLaXQyL0NoYW5nZUxvZwor KysgYi9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAxLTE0ICBMYXN6 bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGlnbiBpbXBvcnQvZXhwb3J0IGRpcmVj dGl2ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUy MjA4CisKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvV0tCYXNlLmg6IEFsaWduIGltcG9ydC9leHBv cnQgZGlyZWN0aXZlcyB3aXRoCisgICAgICAgIEphdmFTY3JpcHRDb3JlL0FQSS9KU0Jhc2UuaC4K KwogMjAxMS0wMS0xNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvV2ViS2l0 Mi9TaGFyZWQvQVBJL2MvV0tCYXNlLmggYi9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS0Jhc2UuaApp bmRleCA1YzI5ZGIwLi5mOTA2ZjlmIDEwMDY0NAotLS0gYS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9X S0Jhc2UuaAorKysgYi9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS0Jhc2UuaApAQCAtOTksMTkgKzk5 LDIxIEBAIHR5cGVkZWYgY29uc3Qgc3RydWN0IE9wYXF1ZVdLQnVuZGxlUGFnZU92ZXJsYXkqIFdL QnVuZGxlUGFnZU92ZXJsYXlSZWY7CiB0eXBlZGVmIGNvbnN0IHN0cnVjdCBPcGFxdWVXS0J1bmRs ZVJhbmdlSGFuZGxlKiBXS0J1bmRsZVJhbmdlSGFuZGxlUmVmOwogdHlwZWRlZiBjb25zdCBzdHJ1 Y3QgT3BhcXVlV0tCdW5kbGVTY3JpcHRXb3JsZCogV0tCdW5kbGVTY3JpcHRXb3JsZFJlZjsKIAor LyogVGhlc2UgcnVsZXMgc2hvdWxkIHN0YXkgdGhlIHNhbWUgYXMgaW4gSmF2YVNjcmlwdENvcmUv QVBJL0pTQmFzZS5oICovCisKICN1bmRlZiBXS19FWFBPUlQKICNpZiBkZWZpbmVkKFdLX05PX0VY UE9SVCkKICNkZWZpbmUgV0tfRVhQT1JUCi0jZWxpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVm aW5lZChfX0FSTUNDX18pCisjZWxpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX0ND X0FSTSkgJiYgIWRlZmluZWQoX19BUk1DQ19fKQogI2RlZmluZSBXS19FWFBPUlQgX19hdHRyaWJ1 dGVfXygodmlzaWJpbGl0eSgiZGVmYXVsdCIpKSkKLSNlbGlmIGRlZmluZWQoV0lOMzIpIHx8IGRl ZmluZWQoX1dJTjMyKSB8fCBkZWZpbmVkKF9fQVJNQ0NfXykKKyNlbGlmIGRlZmluZWQoV0lOMzIp IHx8IGRlZmluZWQoX1dJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMl9XQ0UpIHx8IGRlZmluZWQoX19D Q19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKQogI2lmIEJVSUxESU5HX1dFQktJVAogI2RlZmlu ZSBXS19FWFBPUlQgX19kZWNsc3BlYyhkbGxleHBvcnQpCiAjZWxzZQogI2RlZmluZSBXS19FWFBP UlQgX19kZWNsc3BlYyhkbGxpbXBvcnQpCiAjZW5kaWYKLSNlbHNlCisjZWxzZSAvKiAhZGVmaW5l ZChXS19OT19FWFBPUlQpICovCiAjZGVmaW5lIFdLX0VYUE9SVAotI2VuZGlmCisjZW5kaWYgLyog ZGVmaW5lZChXS19OT19FWFBPUlQpICovCiAKICNlbmRpZiAvKiBXS0Jhc2VfaCAqLwo=