52204 2011-01-11 05:34:08 -0800 Web Inspector: innerFirstChild has a side effect which should be done explicitly. 2011-01-11 06:14:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 332288 0 loislo 2011-01-11 05:34:08 -0800 if a node is a frame's owner then innerFirstChild method subscribes DOMAgent instance to the frame's doc's events. I think this should be done explicitly when we meet with the node for the first time. As I understand it happens in buildArrayForContainerChildren method. 332289 1 78520 loislo 2011-01-11 05:42:03 -0800 Created attachment 78520 [patch] initial version. 332290 2 78520 pfeldman 2011-01-11 05:59:07 -0800 Comment on attachment 78520 [patch] initial version. View in context: https://bugs.webkit.org/attachment.cgi?id=78520&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:271 > +void InspectorDOMAgent::startListeningFrameDoc(Node* frameOwnerNode) startListeningContentDocument? 332302 3 loislo 2011-01-11 06:14:13 -0800 Committed r75495 M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorDOMAgent.h M Source/WebCore/inspector/InspectorDOMAgent.cpp r75495 = 170e93b8362250788cc1a6e19e46e50d587729e8 (refs/remotes/trunk) 78520 2011-01-11 05:42:03 -0800 2011-01-11 06:14:28 -0800 [patch] initial version. patch text/plain 4130 loislo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiOTRkNmIyLi5iMTNjMzAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMDEtMTEgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IGlubmVyRmlyc3RDaGlsZCBoYXMgYSBzaWRlIGVmZmVjdCB3aGljaCBzaG91bGQgYmUg Y2FsbGVkIGV4cGxpY2l0bHkuCisKKyAgICAgICAgSWYgYSBub2RlIGlzIGEgZnJhbWUncyBvd25l ciB0aGVuIGlubmVyRmlyc3RDaGlsZCBtZXRob2QKKyAgICAgICAgc3Vic2NyaWJlcyBET01BZ2Vu dCBpbnN0YW5jZSB0byB0aGUgZnJhbWUncyBkb2MncyBldmVudHMuCisgICAgICAgIEkgdGhpbmsg dGhpcyBzaG91bGQgYmUgZG9uZSBleHBsaWNpdGx5IHdoZW4gd2UgbWVldCB3aXRoCisgICAgICAg IHRoZSBub2RlIGZvciB0aGUgZmlyc3QgdGltZS4gQXMgSSB1bmRlcnN0YW5kIGl0IGhhcHBlbnMK KyAgICAgICAgaW4gYnVpbGRBcnJheUZvckNvbnRhaW5lckNoaWxkcmVuIG1ldGhvZC4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIyMDQKKworICAg ICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpJbnNwZWN0b3JET01BZ2VudDo6c3RhcnRMaXN0ZW5pbmdGcmFtZURvYyk6CisgICAgICAgIChX ZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRBcnJheUZvckNvbnRhaW5lckNoaWxkcmVu KToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50Ojppbm5lckZpcnN0Q2hpbGQp OgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oOgorCiAyMDExLTAxLTEx ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckRPTUFnZW50LmNwcAppbmRleCBlNDJiZjJhLi5lMzRkOTc5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKQEAgLTI2OCw2ICsyNjgs MTUgQEAgdm9pZCBJbnNwZWN0b3JET01BZ2VudDo6cmVsZWFzZURhbmdsaW5nTm9kZXMoKQogICAg IG1fZGFuZ2xpbmdOb2RlVG9JZE1hcHMuY2xlYXIoKTsKIH0KIAordm9pZCBJbnNwZWN0b3JET01B Z2VudDo6c3RhcnRMaXN0ZW5pbmdGcmFtZURvYyhOb2RlKiBmcmFtZU93bmVyTm9kZSkKK3sKKyAg ICBBU1NFUlQoZnJhbWVPd25lck5vZGUtPmlzRnJhbWVPd25lckVsZW1lbnQoKSk7CisgICAgSFRN TEZyYW1lT3duZXJFbGVtZW50KiBmcmFtZU93bmVyID0gc3RhdGljX2Nhc3Q8SFRNTEZyYW1lT3du ZXJFbGVtZW50Kj4oZnJhbWVPd25lck5vZGUpOworICAgIERvY3VtZW50KiBkb2MgPSBmcmFtZU93 bmVyLT5jb250ZW50RG9jdW1lbnQoKTsKKyAgICBpZiAoZG9jKQorICAgICAgICBzdGFydExpc3Rl bmluZyhkb2MpOworfQorCiB2b2lkIEluc3BlY3RvckRPTUFnZW50OjpzdGFydExpc3RlbmluZyhE b2N1bWVudCogZG9jKQogewogICAgIGlmIChtX2RvY3VtZW50cy5jb250YWlucyhkb2MpKQpAQCAt OTQ3LDIwICs5NTYsMjQgQEAgUGFzc1JlZlB0cjxJbnNwZWN0b3JBcnJheT4gSW5zcGVjdG9yRE9N QWdlbnQ6OmJ1aWxkQXJyYXlGb3JFbGVtZW50QXR0cmlidXRlcyhFbGUKIFBhc3NSZWZQdHI8SW5z cGVjdG9yQXJyYXk+IEluc3BlY3RvckRPTUFnZW50OjpidWlsZEFycmF5Rm9yQ29udGFpbmVyQ2hp bGRyZW4oTm9kZSogY29udGFpbmVyLCBpbnQgZGVwdGgsIE5vZGVUb0lkTWFwKiBub2Rlc01hcCkK IHsKICAgICBSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IGNoaWxkcmVuID0gSW5zcGVjdG9yQXJyYXk6 OmNyZWF0ZSgpOworICAgIE5vZGUqIGNoaWxkID0gaW5uZXJGaXJzdENoaWxkKGNvbnRhaW5lcik7 CisKICAgICBpZiAoZGVwdGggPT0gMCkgewogICAgICAgICAvLyBTcGVjaWFsIGNhc2UgdGhlX29u bHkgdGV4dCBjaGlsZC4KLSAgICAgICAgaWYgKGlubmVyQ2hpbGROb2RlQ291bnQoY29udGFpbmVy KSA9PSAxKSB7Ci0gICAgICAgICAgICBOb2RlICpjaGlsZCA9IGlubmVyRmlyc3RDaGlsZChjb250 YWluZXIpOwotICAgICAgICAgICAgaWYgKGNoaWxkLT5ub2RlVHlwZSgpID09IE5vZGU6OlRFWFRf Tk9ERSkKLSAgICAgICAgICAgICAgICBjaGlsZHJlbi0+cHVzaE9iamVjdChidWlsZE9iamVjdEZv ck5vZGUoY2hpbGQsIDAsIG5vZGVzTWFwKSk7Ci0gICAgICAgIH0KKyAgICAgICAgaWYgKGNoaWxk ICYmIGNoaWxkLT5ub2RlVHlwZSgpID09IE5vZGU6OlRFWFRfTk9ERSAmJiAhaW5uZXJOZXh0U2li bGluZyhjaGlsZCkpCisgICAgICAgICAgICBjaGlsZHJlbi0+cHVzaE9iamVjdChidWlsZE9iamVj dEZvck5vZGUoY2hpbGQsIDAsIG5vZGVzTWFwKSk7CiAgICAgICAgIHJldHVybiBjaGlsZHJlbi5y ZWxlYXNlKCk7CiAgICAgfSBlbHNlIGlmIChkZXB0aCA+IDApIHsKICAgICAgICAgZGVwdGgtLTsK ICAgICB9CiAKLSAgICBmb3IgKE5vZGUgKmNoaWxkID0gaW5uZXJGaXJzdENoaWxkKGNvbnRhaW5l cik7IGNoaWxkOyBjaGlsZCA9IGlubmVyTmV4dFNpYmxpbmcoY2hpbGQpKQorICAgIGlmIChjb250 YWluZXItPmlzRnJhbWVPd25lckVsZW1lbnQoKSkKKyAgICAgICAgc3RhcnRMaXN0ZW5pbmdGcmFt ZURvYyhjb250YWluZXIpOworCisgICAgd2hpbGUgKGNoaWxkKSB7CiAgICAgICAgIGNoaWxkcmVu LT5wdXNoT2JqZWN0KGJ1aWxkT2JqZWN0Rm9yTm9kZShjaGlsZCwgZGVwdGgsIG5vZGVzTWFwKSk7 CisgICAgICAgIGNoaWxkID0gaW5uZXJOZXh0U2libGluZyhjaGlsZCk7CisgICAgfQogICAgIHJl dHVybiBjaGlsZHJlbi5yZWxlYXNlKCk7CiB9CiAKQEAgLTk4NywxMCArMTAwMCw4IEBAIE5vZGUq IEluc3BlY3RvckRPTUFnZW50Ojppbm5lckZpcnN0Q2hpbGQoTm9kZSogbm9kZSkKICAgICBpZiAo bm9kZS0+aXNGcmFtZU93bmVyRWxlbWVudCgpKSB7CiAgICAgICAgIEhUTUxGcmFtZU93bmVyRWxl bWVudCogZnJhbWVPd25lciA9IHN0YXRpY19jYXN0PEhUTUxGcmFtZU93bmVyRWxlbWVudCo+KG5v ZGUpOwogICAgICAgICBEb2N1bWVudCogZG9jID0gZnJhbWVPd25lci0+Y29udGVudERvY3VtZW50 KCk7Ci0gICAgICAgIGlmIChkb2MpIHsKLSAgICAgICAgICAgIHN0YXJ0TGlzdGVuaW5nKGRvYyk7 CisgICAgICAgIGlmIChkb2MpCiAgICAgICAgICAgICByZXR1cm4gZG9jLT5maXJzdENoaWxkKCk7 Ci0gICAgICAgIH0KICAgICB9CiAgICAgbm9kZSA9IG5vZGUtPmZpcnN0Q2hpbGQoKTsKICAgICB3 aGlsZSAoaXNXaGl0ZXNwYWNlKG5vZGUpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRE9NQWdlbnQuaAppbmRleCAxNjExYmFhLi4zMWFkZTY5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaApAQCAtMTQ4LDYgKzE0OCw3IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCByZW1vdmVET01CcmVha3BvaW50KGxvbmcg bm9kZUlkLCBsb25nIHR5cGUpOwogCiAgICAgcHJpdmF0ZToKKyAgICAgICAgdm9pZCBzdGFydExp c3RlbmluZ0ZyYW1lRG9jKE5vZGUqIGZyYW1lT3duZXJOb2RlKTsKICAgICAgICAgdm9pZCBzdGFy dExpc3RlbmluZyhEb2N1bWVudCogZG9jdW1lbnQpOwogICAgICAgICB2b2lkIHN0b3BMaXN0ZW5p bmcoRG9jdW1lbnQqIGRvY3VtZW50KTsKIAo=