52202 2011-01-11 03:10:16 -0800 [GTK] minimal build breaks in RenderThemeGtk3 2011-01-12 01:28:15 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned eric mrobinson oldest_to_newest 332218 0 pnormand 2011-01-11 03:10:16 -0800 missing if ENABLE(VIDEO) guards in RenderThemeGtk::initMediaColors() 332226 1 78508 pnormand 2011-01-11 03:14:32 -0800 Created attachment 78508 proposed patch 332504 2 78508 eric 2011-01-11 11:52:08 -0800 Comment on attachment 78508 proposed patch Does this need to check AUDIO as well? or is that part of VIDEO? 332960 3 pnormand 2011-01-12 01:26:13 -0800 (In reply to comment #2) > (From update of attachment 78508 [details]) > Does this need to check AUDIO as well? or is that part of VIDEO? You mean WEB_AUDIO? No, I think this is not directly related with the media elements. 332961 4 pnormand 2011-01-12 01:28:15 -0800 Committed r75591: <http://trac.webkit.org/changeset/75591> 78508 2011-01-11 03:14:32 -0800 2011-01-11 11:52:07 -0800 proposed patch proposed-patch.patch text/plain 1679 pnormand RnJvbSBmNzZiZjU2NzIzN2JkNWI5NWZiMzYxOWNiNTEwMzhkZmFmNGZiNWE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDExIEphbiAyMDExIDEyOjEzOjQwICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9SZW5kZXJUaGVtZUd0azMuY3BwIHwgICAgMiArKwogMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNl cnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYTQ2ZDlmLi4yYjAyM2Nm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTYgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KIAorICAgICAgICBbR1RLXSBtaW5pbWFsIGJ1aWxkIGJyZWFrcyBpbiBSZW5k ZXJUaGVtZUd0azMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUyMjAyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcDog QWRkZWQgVklERU8gZ3VhcmRzIGFyb3VuZAorICAgICAgICBpbml0TWVkaWFDb2xvcnMoKS4KKwor MjAxMS0wMS0xMSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgW0dUS10gbWluaW1h bCBidWlsZCB1bnJlY29nbml6ZWQgb3B0aW9ucwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA4OTAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcAppbmRleCAxYjJjYjM4Li5lZTJhMzdmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcApAQCAtMTA4 LDYgKzEwOCw3IEBAIFJlbmRlclRoZW1lR3RrOjp+UmVuZGVyVGhlbWVHdGsoKQogewogfQogCisj aWYgRU5BQkxFKFZJREVPKQogdm9pZCBSZW5kZXJUaGVtZUd0azo6aW5pdE1lZGlhQ29sb3JzKCkK IHsKICAgICBHZGtSR0JBIGNvbG9yOwpAQCAtMTIwLDYgKzEyMSw3IEBAIHZvaWQgUmVuZGVyVGhl bWVHdGs6OmluaXRNZWRpYUNvbG9ycygpCiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfZ2V0X2JhY2tn cm91bmRfY29sb3IoY29udGFpbmVyQ29udGV4dCwgR1RLX1NUQVRFX0ZMQUdfU0VMRUNURUQsICZj b2xvcik7CiAgICAgbV9zbGlkZXJUaHVtYkNvbG9yID0gY29sb3I7CiB9CisjZW5kaWYKIAogc3Rh dGljIHZvaWQgYWRqdXN0UmVjdEZvckZvY3VzKEd0a1N0eWxlQ29udGV4dCogY29udGV4dCwgSW50 UmVjdCYgcmVjdCkKIHsKLS0gCjEuNy4yLjM=