52197 2011-01-10 22:46:24 -0800 Use definition of PI from MathExtras.h 2013-10-09 15:13:08 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED DUPLICATE 93109 P2 Normal --- 0 carllobo webkit-unassigned berto oldest_to_newest 332168 0 carllobo 2011-01-10 22:46:24 -0800 Removed redefinition of M_PI and replaced it with piDouble or piFloat as appropriate. 332169 1 78497 carllobo 2011-01-10 22:47:37 -0800 Created attachment 78497 This patch uses the standard definitions of PI from MathExtras.h 332212 2 78497 eric 2011-01-11 03:03:06 -0800 Comment on attachment 78497 This patch uses the standard definitions of PI from MathExtras.h View in context: https://bugs.webkit.org/attachment.cgi?id=78497&action=review Looks great. But we need to fix the ChangeLog first or the commit-queue will fail to process it. > Source/WebCore/ChangeLog:7 > + Need a short description and bug URL (OOPS!) This will prevent the cq from being able to land this. the -b option to prepare-ChangeLog will fill this in automatically for you, or just using "webkit-patch upload" will fill it in too. 423047 3 78497 abarth 2011-06-17 23:01:49 -0700 Comment on attachment 78497 This patch uses the standard definitions of PI from MathExtras.h Please upload a new patch for the commit-queue. 938092 4 berto 2013-10-09 15:13:08 -0700 *** This bug has been marked as a duplicate of bug 93109 *** 78497 2011-01-10 22:47:37 -0800 2011-06-17 23:01:49 -0700 This patch uses the standard definitions of PI from MathExtras.h patch.txt text/plain 3567 carllobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNDkyMThiLi40ZmY5YTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDEtMTAgIENhcmwgTG9ibyAgPGNhcmxsb2JvQGdtYWlsLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ugc3RhbmRhcmQgTWF0 aEV4dHJhcy5oIGZvciB2YWx1ZSBvZiBwaQorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlw dGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBJdHMgYSBt aW5vciBjbGVhbnVwICsgYnVpbGRmaXguICAgIAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0OjpkcmF3RWxsaXBzZSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQ6OnN0cm9rZUFyYyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0 aENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhdGg6OmFkZEFyYyk6CisKIDIwMTEtMDEt MDQgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCmluZGV4IGNkYmZj NTcuLjY0NTYzNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKQEAgLTYyLDEwICs2 Miw2IEBACiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAKLSNpZm5kZWYgTV9QSQotI2RlZmluZSBN X1BJIDMuMTQxNTkyNjUzNTg5NzkzMjM4NDYKLSNlbmRpZgotCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIHN0YXRpYyBpbmxpbmUgdm9pZCBzZXRQbGF0Zm9ybUZpbGwoR3JhcGhpY3NDb250ZXh0KiBj b250ZXh0LCBjYWlyb190KiBjcikKQEAgLTM3MSw3ICszNjcsNyBAQCB2b2lkIEdyYXBoaWNzQ29u dGV4dDo6ZHJhd0VsbGlwc2UoY29uc3QgSW50UmVjdCYgcmVjdCkKICAgICBmbG9hdCB4UmFkaXVz ID0gLjUgKiByZWN0LndpZHRoKCk7CiAgICAgY2Fpcm9fdHJhbnNsYXRlKGNyLCByZWN0LngoKSAr IHhSYWRpdXMsIHJlY3QueSgpICsgeVJhZGl1cyk7CiAgICAgY2Fpcm9fc2NhbGUoY3IsIHhSYWRp dXMsIHlSYWRpdXMpOwotICAgIGNhaXJvX2FyYyhjciwgMC4sIDAuLCAxLiwgMC4sIDIgKiBNX1BJ KTsKKyAgICBjYWlyb19hcmMoY3IsIDAuLCAwLiwgMS4sIDAuLCAyICogcGlEb3VibGUpOwogICAg IGNhaXJvX3Jlc3RvcmUoY3IpOwogCiAgICAgaWYgKGZpbGxDb2xvcigpLmFscGhhKCkpIHsKQEAg LTQxMCw3ICs0MDYsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6c3Ryb2tlQXJjKGNvbnN0IElu dFJlY3QmIHJlY3QsIGludCBzdGFydEFuZ2xlLCBpbnQgYW5nbGVTcAogICAgIGlmICh3ICE9IGgp CiAgICAgICAgIGNhaXJvX3NjYWxlKGNyLCAxLiwgc2NhbGVGYWN0b3IpOwogCi0gICAgY2Fpcm9f YXJjX25lZ2F0aXZlKGNyLCB4ICsgaFJhZGl1cywgKHkgKyB2UmFkaXVzKSAqIHJldmVyc2VTY2Fs ZUZhY3RvciwgaFJhZGl1cywgLWZhICogTV9QSS8xODAsIC1mYWxlbiAqIE1fUEkvMTgwKTsKKyAg ICBjYWlyb19hcmNfbmVnYXRpdmUoY3IsIHggKyBoUmFkaXVzLCAoeSArIHZSYWRpdXMpICogcmV2 ZXJzZVNjYWxlRmFjdG9yLCBoUmFkaXVzLCAtZmEgKiBwaURvdWJsZSAvIDE4MCwgLWZhbGVuICog cGlEb3VibGUgLyAxODApOwogCiAgICAgaWYgKHcgIT0gaCkKICAgICAgICAgY2Fpcm9fc2NhbGUo Y3IsIDEuLCByZXZlcnNlU2NhbGVGYWN0b3IpOwpAQCAtNDM3LDkgKzQzMyw5IEBAIHZvaWQgR3Jh cGhpY3NDb250ZXh0OjpzdHJva2VBcmMoY29uc3QgSW50UmVjdCYgcmVjdCwgaW50IHN0YXJ0QW5n bGUsIGludCBhbmdsZVNwCiAgICAgICAgIC8vIHdpbGwgYmUgNTAgcGl4ZWxzLgogICAgICAgICBp bnQgZGlzdGFuY2U7CiAgICAgICAgIGlmIChoUmFkaXVzID09IHZSYWRpdXMpCi0gICAgICAgICAg ICBkaXN0YW5jZSA9IHN0YXRpY19jYXN0PGludD4oKE1fUEkgKiBoUmFkaXVzKSAvIDIuMCk7Cisg ICAgICAgICAgICBkaXN0YW5jZSA9IHN0YXRpY19jYXN0PGludD4oKHBpRmxvYXQgKiBoUmFkaXVz KSAvIDIuMCk7CiAgICAgICAgIGVsc2UgLy8gV2UgYXJlIGVsbGlwdGljYWwgYW5kIHdpbGwgaGF2 ZSB0byBlc3RpbWF0ZSB0aGUgZGlzdGFuY2UKLSAgICAgICAgICAgIGRpc3RhbmNlID0gc3RhdGlj X2Nhc3Q8aW50PigoTV9QSSAqIHNxcnRmKChoUmFkaXVzICogaFJhZGl1cyArIHZSYWRpdXMgKiB2 UmFkaXVzKSAvIDIuMCkpIC8gMi4wKTsKKyAgICAgICAgICAgIGRpc3RhbmNlID0gc3RhdGljX2Nh c3Q8aW50PigocGlGbG9hdCAqIHNxcnRmKChoUmFkaXVzICogaFJhZGl1cyArIHZSYWRpdXMgKiB2 UmFkaXVzKSAvIDIuMCkpIC8gMi4wKTsKIAogICAgICAgICBpbnQgcmVtYWluZGVyID0gZGlzdGFu Y2UgJSBwYXRXaWR0aDsKICAgICAgICAgaW50IGNvdmVyYWdlID0gZGlzdGFuY2UgLSByZW1haW5k ZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Q YXRoQ2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0 aENhaXJvLmNwcAppbmRleCA5ODFmZGNkLi4wMTEzNDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BhdGhDYWlyby5jcHAKQEAgLTE1Myw3ICsx NTMsNyBAQCB2b2lkIFBhdGg6OmFkZEFyYyhjb25zdCBGbG9hdFBvaW50JiBwLCBmbG9hdCByLCBm bG9hdCBzdGFydEFuZ2xlLCBmbG9hdCBlbmRBbmdsZQogCiAgICAgY2Fpcm9fdCogY3IgPSBwbGF0 Zm9ybVBhdGgoKS0+Y29udGV4dCgpOwogICAgIGZsb2F0IHN3ZWVwID0gZW5kQW5nbGUgLSBzdGFy dEFuZ2xlOwotICAgIGNvbnN0IGZsb2F0IHR3b1BJID0gMiAqIE1fUEk7CisgICAgY29uc3QgZmxv YXQgdHdvUEkgPSAyICogcGlGbG9hdDsKICAgICBpZiAoKHN3ZWVwIDw9IC10d29QSSB8fCBzd2Vl cCA+PSB0d29QSSkKICAgICAgICAgJiYgKChhbnRpY2xvY2t3aXNlICYmIChlbmRBbmdsZSA8IHN0 YXJ0QW5nbGUpKSB8fCAoIWFudGljbG9ja3dpc2UgJiYgKHN0YXJ0QW5nbGUgPCBlbmRBbmdsZSkp KSkgewogICAgICAgICBpZiAoYW50aWNsb2Nrd2lzZSkK